Re: knitr and Sweave security

2012-10-21 Thread Yihui Xie
I learned \write18 from a quick search: http://stackoverflow.com/questions/3252957/how-to-execute-shell-script-from-latex Security problems exist in most software packages. In this case (knitr/Sweave), a pure technical solution does not seem to be possible... Sometimes I do want to execute

Re: Press about LyX

2012-10-21 Thread Lars Gullik Bjønnes
Jürgen Spitzmüller sp...@lyx.org writes: | Jerry wrote: Who among the LyX developers has the power to edit the press page, http://www.lyx.org/PressAboutLyX? Daniel has written an article about LyX for the HowToAnswer web site and would like to get it linked from the LyX press page. Surely

Re: branch warnings

2012-10-21 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes lasgout...@lyx.org writes: | Le 09/10/2012 20:49, Lars Gullik Bjønnes a écrit : Jürgen Spitzmüller sp...@lyx.org writes: | Jean-Marc Lasgouttes wrote: ../boost/boost/config/stdlib/libstdcpp3.hpp:42:0: warning: BOOST_DISABLE_THREADS redefined [enabled by default] In file

Tests in cmake build

2012-10-21 Thread Kornel Benko
The target `test' should now emit output equivalent to the following: ... Running tests... /usr/bin/ctest --force-new-ctest-process Test project /usr/BUILD/BuildLyxGit Start 1: build_convert 1/11 Test #1: build_convert Passed0.49 sec Start 2:

Re: knitr and Sweave security

2012-10-21 Thread Scott Kostyshak
On Sun, Oct 21, 2012 at 3:08 AM, Yihui Xie x...@yihui.name wrote: I learned \write18 from a quick search: http://stackoverflow.com/questions/3252957/how-to-execute-shell-script-from-latex I didn't know about that. Then yes, if LyX allows security problems like that from LaTeX I should not be

Re: [LyX master] Fix bug #8379: LyX Archive fails to include BibTeX files

2012-10-21 Thread Richard Heck
On 10/20/2012 12:29 PM, Enrico Forestieri wrote: The branch, master, has been updated. - Log - commit f6fde4b55326c7fe3821c05d64fb00d2c36c4ef4 Author: Enrico Forestieri for...@lyx.org Date: Sat Oct 20 18:27:35 2012 +0200

[PATCH 01/13] Buffer.cpp: drop unused stack

2012-10-21 Thread Lars Gullik Bjønnes
--- src/Buffer.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Buffer.cpp b/src/Buffer.cpp index 8b052ad..ebc5d3a 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -113,7 +113,6 @@ #include map #include set #include sstream -#include stack #include vector using namespace std;

[PATCH 02/13] WS cleanup, remove extraeneous spaces

2012-10-21 Thread Lars Gullik Bjønnes
--- src/BufferParams.h | 2 +- src/CutAndPaste.cpp | 2 +- src/LyX.h | 3 +-- src/graphics/GraphicsLoader.cpp | 5 ++--- src/tex2lyx/tex2lyx.cpp | 4 ++-- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/BufferParams.h

[PATCH 06/13] src/graphics/GraphicsLoader: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsLoader.cpp | 1 - src/graphics/GraphicsLoader.h | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsLoader.cpp b/src/graphics/GraphicsLoader.cpp index bd81a50..8f3a4cf 100644 --- a/src/graphics/GraphicsLoader.cpp +++

[PATCH 04/13] src/graphics/GraphicsCache: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsCache.cpp | 1 - src/graphics/GraphicsCache.h | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsCache.cpp b/src/graphics/GraphicsCache.cpp index d508563..f9eee10 100644 --- a/src/graphics/GraphicsCache.cpp +++

Re: [PATCH 01/13] Buffer.cpp: drop unused stack

2012-10-21 Thread Jean-Marc Lasgouttes
This patch, and the others I saw, make sense. However, I only see numbers 1, 2, 4 and 6 (of supposedly 13 parts). JMarc

[PATCH 12/13] graphics/GraphicsImage.h: let newImage and Image::clone return a shared_ptr

2012-10-21 Thread Lars Gullik Bjønnes
--- src/frontends/qt4/GuiImage.cpp | 8 src/frontends/qt4/GuiImage.h | 2 +- src/graphics/GraphicsCacheItem.cpp | 2 +- src/graphics/GraphicsImage.h | 5 +++-- src/graphics/GraphicsLoader.cpp| 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git

[PATCH 11/13] Use make_shared to create shared_ptr

2012-10-21 Thread Lars Gullik Bjønnes
Using std::make_shared (and in our case for the time being boost::make_shared) is the preferred way of creating a std::shared_ptr. This is mainly due to two aspects: - half the number of allocations required - potential of using less space, and better locality Also a failed creation of

Re: [PATCH 01/13] Buffer.cpp: drop unused stack

2012-10-21 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes lasgout...@lyx.org writes: | This patch, and the others I saw, make sense. However, I only see | numbers 1, 2, 4 and 6 (of supposedly 13 parts). For some reason the seem to be trickling in. I'll resend the missing once if they do no show up. -- Lgb

[PATCH 13/13] boost: changes to make it compile cleanly with gcc 4.8

2012-10-21 Thread Lars Gullik Bjønnes
--- boost/boost/lexical_cast.hpp | 1 - boost/boost/math/special_functions/fpclassify.hpp | 4 boost/boost/math/special_functions/sign.hpp | 2 -- boost/boost/regex/v4/regex_format.hpp | 2 -- boost/boost/regex/v4/regex_split.hpp | 1 -

[PATCH 08/13] support/shared_ptr.h: drop support of TR1 smart pointers

2012-10-21 Thread Lars Gullik Bjønnes
--- src/support/shared_ptr.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h index 69e42da..792beb2 100644 --- a/src/support/shared_ptr.h +++ b/src/support/shared_ptr.h @@ -12,22 +12,6 @@ #ifndef LYX_SHARED_PTR_H

[PATCH 05/13] src/graphics/GraphicsCacheItem: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsCacheItem.cpp | 1 - src/graphics/GraphicsCacheItem.h | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsCacheItem.cpp b/src/graphics/GraphicsCacheItem.cpp index fafa78b..60477cc 100644 --- a/src/graphics/GraphicsCacheItem.cpp

[PATCH 09/13] support/shared_ptr.h: introduce boost::make_shared into ns lyx

2012-10-21 Thread Lars Gullik Bjønnes
--- src/support/shared_ptr.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h index 792beb2..3aa6492 100644 --- a/src/support/shared_ptr.h +++ b/src/support/shared_ptr.h @@ -12,12 +12,13 @@ #ifndef LYX_SHARED_PTR_H

[PATCH 10/13] More idiomatic way of checking if a shared_ptr has an associated managed object

2012-10-21 Thread Lars Gullik Bjønnes
--- src/KeyMap.cpp | 17 - src/frontends/qt4/LayoutBox.cpp| 4 ++-- src/graphics/GraphicsCacheItem.cpp | 2 +- src/graphics/GraphicsLoader.cpp| 22 +++--- src/support/ForkedCalls.cpp| 2 +- 5 files changed, 23 insertions(+),

[PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/LyX.cpp | 5 + src/LyX.h | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/LyX.cpp b/src/LyX.cpp index 722f040..03caff3 100644 --- a/src/LyX.cpp +++ b/src/LyX.cpp @@ -64,7 +64,6 @@ #include support/Systemcall.h #include support/bind.h -#include

[PATCH 07/13] graphics/GraphicsLoader.cpp: use !empty() to check for non-emptyness not size()

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsLoader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/graphics/GraphicsLoader.cpp b/src/graphics/GraphicsLoader.cpp index 8f3a4cf..04dd7bd 100644 --- a/src/graphics/GraphicsLoader.cpp +++ b/src/graphics/GraphicsLoader.cpp @@ -89,7 +89,7 @@

Re: [PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread André Pönitz
On Sun, Oct 21, 2012 at 08:49:06PM +0200, Lars Gullik Bjønnes wrote: diff --git a/src/LyX.h b/src/LyX.h index 70b8b7e..97c9b4a 100644 --- a/src/LyX.h +++ b/src/LyX.h @@ -16,6 +16,7 @@ #include support/strfwd.h +#include boost/scoped_ptr.hpp #include vector namespace lyx { @@

Re: [PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
André Pönitz andre.poen...@mathematik.tu-chemnitz.de writes: | On Sun, Oct 21, 2012 at 08:49:06PM +0200, Lars Gullik Bjønnes wrote: diff --git a/src/LyX.h b/src/LyX.h index 70b8b7e..97c9b4a 100644 --- a/src/LyX.h +++ b/src/LyX.h @@ -16,6 +16,7 @@ #include support/strfwd.h +#include

Ad. using namespace std - ref prob in c9b9748c

2012-10-21 Thread Lars Gullik Bjønnes
It is mentioned in c9b9748c that using namespace std on msvc10 also drags in std::tr1 stuff. IMHO the soltion is not to use boost::shared_ptr etc. But to stop using using namespace std. I look briefly as to what was discussed in 2007 when the using namespace std was introduced all over, and

Re: Commercial support for LyX?

2012-10-21 Thread Rob Oakes
On Mon, 2012-10-22 at 02:32 +0200, Lars Gullik Bjønnes wrote: Is that what this is? http://aprenderlyx.com/ Fascinating link. It looks like a course about how to use LyX for writing a thesis. They have five or six modules which covers creating a document, typesetting a document, and

Re: knitr and Sweave security

2012-10-21 Thread Yihui Xie
I learned \write18 from a quick search: http://stackoverflow.com/questions/3252957/how-to-execute-shell-script-from-latex Security problems exist in most software packages. In this case (knitr/Sweave), a pure technical solution does not seem to be possible... Sometimes I do want to execute

Re: Press about LyX

2012-10-21 Thread Lars Gullik Bjønnes
Jürgen Spitzmüller writes: | Jerry wrote: >> Who among the LyX developers has the power to edit the press page, >> http://www.lyx.org/PressAboutLyX? Daniel has written an article about LyX >> for the HowToAnswer web site and would like to get it linked from the LyX >> press page.

Re: branch warnings

2012-10-21 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 09/10/2012 20:49, Lars Gullik Bjønnes a écrit : >> Jürgen Spitzmüller writes: >> >> | Jean-Marc Lasgouttes wrote: > ../boost/boost/config/stdlib/libstdcpp3.hpp:42:0: warning: > "BOOST_DISABLE_THREADS" redefined

Tests in cmake build

2012-10-21 Thread Kornel Benko
The target `test' should now emit output equivalent to the following: ... Running tests... /usr/bin/ctest --force-new-ctest-process Test project /usr/BUILD/BuildLyxGit Start 1: build_convert 1/11 Test #1: build_convert Passed0.49 sec Start 2:

Re: knitr and Sweave security

2012-10-21 Thread Scott Kostyshak
On Sun, Oct 21, 2012 at 3:08 AM, Yihui Xie wrote: > I learned \write18 from a quick search: > http://stackoverflow.com/questions/3252957/how-to-execute-shell-script-from-latex I didn't know about that. Then yes, if LyX allows security problems like that from LaTeX I should not

Re: [LyX master] Fix bug #8379: LyX Archive fails to include BibTeX files

2012-10-21 Thread Richard Heck
On 10/20/2012 12:29 PM, Enrico Forestieri wrote: The branch, master, has been updated. - Log - commit f6fde4b55326c7fe3821c05d64fb00d2c36c4ef4 Author: Enrico Forestieri Date: Sat Oct 20 18:27:35 2012 +0200

[PATCH 01/13] Buffer.cpp: drop unused

2012-10-21 Thread Lars Gullik Bjønnes
--- src/Buffer.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Buffer.cpp b/src/Buffer.cpp index 8b052ad..ebc5d3a 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -113,7 +113,6 @@ #include #include #include -#include #include using namespace std; --

[PATCH 02/13] WS cleanup, remove extraeneous spaces

2012-10-21 Thread Lars Gullik Bjønnes
--- src/BufferParams.h | 2 +- src/CutAndPaste.cpp | 2 +- src/LyX.h | 3 +-- src/graphics/GraphicsLoader.cpp | 5 ++--- src/tex2lyx/tex2lyx.cpp | 4 ++-- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/BufferParams.h

[PATCH 06/13] src/graphics/GraphicsLoader: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsLoader.cpp | 1 - src/graphics/GraphicsLoader.h | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsLoader.cpp b/src/graphics/GraphicsLoader.cpp index bd81a50..8f3a4cf 100644 --- a/src/graphics/GraphicsLoader.cpp +++

[PATCH 04/13] src/graphics/GraphicsCache: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsCache.cpp | 1 - src/graphics/GraphicsCache.h | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsCache.cpp b/src/graphics/GraphicsCache.cpp index d508563..f9eee10 100644 --- a/src/graphics/GraphicsCache.cpp +++

Re: [PATCH 01/13] Buffer.cpp: drop unused

2012-10-21 Thread Jean-Marc Lasgouttes
This patch, and the others I saw, make sense. However, I only see numbers 1, 2, 4 and 6 (of supposedly 13 parts). JMarc

[PATCH 12/13] graphics/GraphicsImage.h: let newImage and Image::clone return a shared_ptr

2012-10-21 Thread Lars Gullik Bjønnes
--- src/frontends/qt4/GuiImage.cpp | 8 src/frontends/qt4/GuiImage.h | 2 +- src/graphics/GraphicsCacheItem.cpp | 2 +- src/graphics/GraphicsImage.h | 5 +++-- src/graphics/GraphicsLoader.cpp| 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git

[PATCH 11/13] Use make_shared to create shared_ptr

2012-10-21 Thread Lars Gullik Bjønnes
Using std::make_shared (and in our case for the time being boost::make_shared) is the preferred way of creating a std::shared_ptr. This is mainly due to two aspects: - half the number of allocations required - potential of using less space, and better locality Also a failed creation of

Re: [PATCH 01/13] Buffer.cpp: drop unused

2012-10-21 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | This patch, and the others I saw, make sense. However, I only see | numbers 1, 2, 4 and 6 (of supposedly 13 parts). For some reason the seem to be trickling in. I'll resend the missing once if they do no show up. -- Lgb

[PATCH 13/13] boost: changes to make it compile cleanly with gcc 4.8

2012-10-21 Thread Lars Gullik Bjønnes
--- boost/boost/lexical_cast.hpp | 1 - boost/boost/math/special_functions/fpclassify.hpp | 4 boost/boost/math/special_functions/sign.hpp | 2 -- boost/boost/regex/v4/regex_format.hpp | 2 -- boost/boost/regex/v4/regex_split.hpp | 1 -

[PATCH 08/13] support/shared_ptr.h: drop support of TR1 smart pointers

2012-10-21 Thread Lars Gullik Bjønnes
--- src/support/shared_ptr.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h index 69e42da..792beb2 100644 --- a/src/support/shared_ptr.h +++ b/src/support/shared_ptr.h @@ -12,22 +12,6 @@ #ifndef LYX_SHARED_PTR_H

[PATCH 05/13] src/graphics/GraphicsCacheItem: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsCacheItem.cpp | 1 - src/graphics/GraphicsCacheItem.h | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsCacheItem.cpp b/src/graphics/GraphicsCacheItem.cpp index fafa78b..60477cc 100644 --- a/src/graphics/GraphicsCacheItem.cpp

[PATCH 09/13] support/shared_ptr.h: introduce boost::make_shared into ns lyx

2012-10-21 Thread Lars Gullik Bjønnes
--- src/support/shared_ptr.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h index 792beb2..3aa6492 100644 --- a/src/support/shared_ptr.h +++ b/src/support/shared_ptr.h @@ -12,12 +12,13 @@ #ifndef LYX_SHARED_PTR_H

[PATCH 10/13] More idiomatic way of checking if a shared_ptr has an associated managed object

2012-10-21 Thread Lars Gullik Bjønnes
--- src/KeyMap.cpp | 17 - src/frontends/qt4/LayoutBox.cpp| 4 ++-- src/graphics/GraphicsCacheItem.cpp | 2 +- src/graphics/GraphicsLoader.cpp| 22 +++--- src/support/ForkedCalls.cpp| 2 +- 5 files changed, 23 insertions(+),

[PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/LyX.cpp | 5 + src/LyX.h | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/LyX.cpp b/src/LyX.cpp index 722f040..03caff3 100644 --- a/src/LyX.cpp +++ b/src/LyX.cpp @@ -64,7 +64,6 @@ #include "support/Systemcall.h" #include "support/bind.h" -#include

[PATCH 07/13] graphics/GraphicsLoader.cpp: use !empty() to check for non-emptyness not size()

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsLoader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/graphics/GraphicsLoader.cpp b/src/graphics/GraphicsLoader.cpp index 8f3a4cf..04dd7bd 100644 --- a/src/graphics/GraphicsLoader.cpp +++ b/src/graphics/GraphicsLoader.cpp @@ -89,7 +89,7 @@

Re: [PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread André Pönitz
On Sun, Oct 21, 2012 at 08:49:06PM +0200, Lars Gullik Bjønnes wrote: > diff --git a/src/LyX.h b/src/LyX.h > index 70b8b7e..97c9b4a 100644 > --- a/src/LyX.h > +++ b/src/LyX.h > @@ -16,6 +16,7 @@ > > #include "support/strfwd.h" > > +#include > #include > > namespace lyx { > @@ -126,7

Re: [PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Sun, Oct 21, 2012 at 08:49:06PM +0200, Lars Gullik Bjønnes wrote: >> diff --git a/src/LyX.h b/src/LyX.h >> index 70b8b7e..97c9b4a 100644 >> --- a/src/LyX.h >> +++ b/src/LyX.h >> @@ -16,6 +16,7 @@ >> >> #include

Ad. "using namespace std" - ref prob in c9b9748c

2012-10-21 Thread Lars Gullik Bjønnes
It is mentioned in c9b9748c that "using namespace std" on msvc10 also drags in std::tr1 stuff. IMHO the soltion is not to use boost::shared_ptr etc. But to stop using "using namespace std". I look briefly as to what was discussed in 2007 when the "using namespace std" was introduced all over,

Re: Commercial support for LyX?

2012-10-21 Thread Rob Oakes
On Mon, 2012-10-22 at 02:32 +0200, Lars Gullik Bjønnes wrote: > Is that what this is? > > http://aprenderlyx.com/ > Fascinating link. It looks like a course about how to use LyX for writing a thesis. They have five or six modules which covers creating a document, typesetting a document, and