Re: [patch] support to set box features in the box dialog

2015-05-09 Thread Scott Kostyshak
On Sat, May 9, 2015 at 9:04 PM, Uwe Stöhr uwesto...@web.de wrote: (I am aware that tex2lyx is still missing - I will do this before committing.) Please also check that the tex2lyx tests pass after your changes and before committing. For more information, see the section How to update the file

Re: Description of trac component 'frontend-qt4' ?

2015-05-09 Thread Scott Kostyshak
On Fri, May 8, 2015 at 2:35 AM, Jürgen Spitzmüller sp...@lyx.org wrote: 2015-05-07 21:55 GMT+02:00 Richard Heck rgh...@lyx.org: What would be nice is just to mothball dialog. But I don't see any way to disable it without just removing it. Though we could do that, and mass-move them to

[patch] support to set box features in the box dialog

2015-05-09 Thread Uwe Stöhr
Dear LyXers, attached is a patch that - redesigns the box dialog (better logic and necessary to expand it with features) - adds support to change the line thickness, box separation and shadow size (fixes bug #2598) - makes it possible to set a horizontal alignment for all box types (fixes

Re: Wrong enum as boolean usage in Text3.cpp

2015-05-09 Thread Scott Kostyshak
On Sat, May 9, 2015 at 12:26 AM, Stephan Witt st.w...@gmx.net wrote: Am 09.05.2015 um 05:12 schrieb Scott Kostyshak skost...@lyx.org: On Fri, May 8, 2015 at 10:29 PM, Stephan Witt st.w...@gmx.net wrote: Since change 02cb5fd3 one can see the clever code fragment in Text3.cpp line 2934..2943

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Abdelrazak Younes
On 08/05/2015 22:03, Jean-Marc Lasgouttes wrote: Le 08/05/2015 21:19, Georg Baum a écrit : commit 51cc8aa9f6b784f806b1d9cc97fe0749ffac29af Author: Georg Baum b...@lyx.org Date: Fri May 8 21:12:42 2015 +0200 Fix build with GNU libstdc++ C++11 ABI The GNU libstdc++ that ships witch

Re: C++ question about auto_ptr

2015-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2015 09:18, Abdelrazak Younes a écrit : On 08/05/2015 22:13, Jean-Marc Lasgouttes wrote: With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather avoid that. Why that? unique_ptr is supported since

Re: C++ question about auto_ptr

2015-05-09 Thread Abdelrazak Younes
On 09/05/2015 11:37, Jean-Marc Lasgouttes wrote: Le 09/05/2015 09:18, Abdelrazak Younes a écrit : On 08/05/2015 22:13, Jean-Marc Lasgouttes wrote: With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather

Re: C++ question about auto_ptr

2015-05-09 Thread Jean-Marc Lasgouttes
Le 08/05/2015 23:10, Georg Baum a écrit : I have many places like in the patch below. Is there a reason why I should keep the auto_ptr instead of a naked pointer? What is it good for? Usually it is used for exception safety: If you use a raw pointer, you need to delete it in the catch clause,

Re: C++ question about auto_ptr

2015-05-09 Thread Abdelrazak Younes
On 08/05/2015 22:13, Jean-Marc Lasgouttes wrote: With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather avoid that. Why that? unique_ptr is supported since gcc 4.4 released in 2009:

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread Abdelrazak Younes
On 08/05/2015 21:24, Georg Baum wrote: José Matos wrote: While testing what packages failed with the new ABI one of the cases is LyX (2.1.3), the first builder to fail was the x86_64 one and this is why this message refers to it:

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Kornel Benko
Am Freitag, 8. Mai 2015 um 21:19:24, schrieb Georg Baum b...@lyx.org commit 51cc8aa9f6b784f806b1d9cc97fe0749ffac29af Author: Georg Baum b...@lyx.org Date: Fri May 8 21:12:42 2015 +0200 Fix build with GNU libstdc++ C++11 ABI The GNU libstdc++ that ships witch gcc 5 can be

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread Abdelrazak Younes
On 09/05/2015 11:39, Jean-Marc Lasgouttes wrote: Le 09/05/2015 09:30, Abdelrazak Younes a écrit : Now with modern compilers and STL, string is much cheaper... Do you have a reference for that? My own experience + just some article that I read about gcc's and clang's STL minimizing the

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2015 09:30, Abdelrazak Younes a écrit : Now with modern compilers and STL, string is much cheaper... Do you have a reference for that? JMarc

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2015 09:37, Abdelrazak Younes a écrit : Good job :) BTW, we have a problem with clang in Ubuntu 15.04. THe boost 1.55 that ships with ubuntu crashes with clang 3.6. There is not much we can do about it, except maybe upgrading our local copy of boost. Or removing boost ;-) We are not

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Richard Heck
On 05/08/2015 03:19 PM, Georg Baum wrote: commit 51cc8aa9f6b784f806b1d9cc97fe0749ffac29af Author: Georg Baum b...@lyx.org Date: Fri May 8 21:12:42 2015 +0200 Fix build with GNU libstdc++ C++11 ABI The GNU libstdc++ that ships witch gcc 5 can be used with the same ABI as

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Kornel Benko
Am Samstag, 9. Mai 2015 um 11:14:20, schrieb Juergen Spitzmueller sp...@lyx.org commit ded1b4f6c897dab24ef470b3645dadeb1c0f39f6 Author: Juergen Spitzmueller sp...@lyx.org Date: Sat May 9 11:13:28 2015 +0200 Adapt enumii counter display to KOMA default as suggested in #3311.

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Jürgen Spitzmüller
2015-05-09 16:45 GMT+02:00 Kornel Benko: Because of missing '('? It looks weird. Well, that's the whole point of the commit. KOMA typesets enumii as a) instead of (a). Jürgen Kornel

Re: Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread José Matos
On Friday 08 May 2015 21:24:27 Georg Baum wrote: The forward declarations in src/support/strfwd.h were wrong. I fixed this by not using the forward declarations in C++11 mode and including string instead. Feel free to adapt the forward declarations if you prefer that, the configure

Re: Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread José Matos
On Saturday 09 May 2015 11:38:46 Jean-Marc Lasgouttes wrote: We are not there yet unfortunately. Up to gcc 4.8 (4.9?), std::regex just does not work. JMarc IIRC you are right, 4.9 is the first version where it works properly:

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Jürgen Spitzmüller
2015-05-09 16:07 GMT+02:00 Kornel Benko kor...@lyx.org: Am Samstag, 9. Mai 2015 um 11:14:20, schrieb Juergen Spitzmueller sp...@lyx.org commit ded1b4f6c897dab24ef470b3645dadeb1c0f39f6 Author: Juergen Spitzmueller sp...@lyx.org Date: Sat May 9 11:13:28 2015 +0200 Adapt enumii

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Kornel Benko
Am Samstag, 9. Mai 2015 um 16:51:23, schrieb Jürgen Spitzmüller sp...@lyx.org 2015-05-09 16:45 GMT+02:00 Kornel Benko: Because of missing '('? It looks weird. Well, that's the whole point of the commit. KOMA typesets enumii as a) instead of (a). Jürgen Ah, OK.

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Kornel Benko
Am Samstag, 9. Mai 2015 um 16:42:36, schrieb Jürgen Spitzmüller sp...@lyx.org 2015-05-09 16:07 GMT+02:00 Kornel Benko kor...@lyx.org: Am Samstag, 9. Mai 2015 um 11:14:20, schrieb Juergen Spitzmueller sp...@lyx.org commit ded1b4f6c897dab24ef470b3645dadeb1c0f39f6 Author: Juergen

Re: C++ question about auto_ptr

2015-05-09 Thread Abdelrazak Younes
On 08/05/2015 22:13, Jean-Marc Lasgouttes wrote: With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather avoid that. Why that? unique_ptr is supported since gcc 4.4 released in 2009:

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread Abdelrazak Younes
On 08/05/2015 21:24, Georg Baum wrote: José Matos wrote: While testing what packages failed with the new ABI one of the cases is LyX (2.1.3), the first builder to fail was the x86_64 one and this is why this message refers to it:

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Abdelrazak Younes
On 08/05/2015 22:03, Jean-Marc Lasgouttes wrote: Le 08/05/2015 21:19, Georg Baum a écrit : commit 51cc8aa9f6b784f806b1d9cc97fe0749ffac29af Author: Georg Baum Date: Fri May 8 21:12:42 2015 +0200 Fix build with GNU libstdc++ C++11 ABI The GNU libstdc++ that ships

Re: C++ question about auto_ptr

2015-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2015 09:18, Abdelrazak Younes a écrit : On 08/05/2015 22:13, Jean-Marc Lasgouttes wrote: With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather avoid that. Why that? unique_ptr is supported since

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2015 09:37, Abdelrazak Younes a écrit : Good job :) BTW, we have a problem with clang in Ubuntu 15.04. THe boost 1.55 that ships with ubuntu crashes with clang 3.6. There is not much we can do about it, except maybe upgrading our local copy of boost. Or removing boost ;-) We are not

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2015 09:30, Abdelrazak Younes a écrit : Now with modern compilers and STL, is much cheaper... Do you have a reference for that? JMarc

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Kornel Benko
Am Freitag, 8. Mai 2015 um 21:19:24, schrieb Georg Baum > commit 51cc8aa9f6b784f806b1d9cc97fe0749ffac29af > Author: Georg Baum > Date: Fri May 8 21:12:42 2015 +0200 > > Fix build with GNU libstdc++ C++11 ABI > > The GNU libstdc++ that ships witch gcc 5

Re: C++ question about auto_ptr

2015-05-09 Thread Abdelrazak Younes
On 09/05/2015 11:37, Jean-Marc Lasgouttes wrote: Le 09/05/2015 09:18, Abdelrazak Younes a écrit : On 08/05/2015 22:13, Jean-Marc Lasgouttes wrote: With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread Abdelrazak Younes
On 09/05/2015 11:39, Jean-Marc Lasgouttes wrote: Le 09/05/2015 09:30, Abdelrazak Younes a écrit : Now with modern compilers and STL, is much cheaper... Do you have a reference for that? My own experience + just some article that I read about gcc's and clang's STL minimizing the

Re: C++ question about auto_ptr

2015-05-09 Thread Jean-Marc Lasgouttes
Le 08/05/2015 23:10, Georg Baum a écrit : I have many places like in the patch below. Is there a reason why I should keep the auto_ptr instead of a naked pointer? What is it good for? Usually it is used for exception safety: If you use a raw pointer, you need to delete it in the catch clause,

Re: Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-09 Thread José Matos
On Friday 08 May 2015 21:24:27 Georg Baum wrote: > The forward declarations in src/support/strfwd.h were wrong. I fixed this by > not using the forward declarations in C++11 mode and including > instead. Feel free to adapt the forward declarations if you prefer that, the > configure machinery

Re: Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread José Matos
On Saturday 09 May 2015 11:38:46 Jean-Marc Lasgouttes wrote: > We are not there yet unfortunately. Up to gcc 4.8 (4.9?), std::regex > just does not work. > > JMarc IIRC you are right, 4.9 is the first version where it works properly:

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Kornel Benko
Am Samstag, 9. Mai 2015 um 11:14:20, schrieb Juergen Spitzmueller > commit ded1b4f6c897dab24ef470b3645dadeb1c0f39f6 > Author: Juergen Spitzmueller > Date: Sat May 9 11:13:28 2015 +0200 > > Adapt enumii counter display to KOMA default as suggested in #3311. >

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Jürgen Spitzmüller
2015-05-09 16:07 GMT+02:00 Kornel Benko : > Am Samstag, 9. Mai 2015 um 11:14:20, schrieb Juergen Spitzmueller < > sp...@lyx.org> > > commit ded1b4f6c897dab24ef470b3645dadeb1c0f39f6 > > Author: Juergen Spitzmueller > > Date: Sat May 9 11:13:28 2015 +0200 > > > >

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Kornel Benko
Am Samstag, 9. Mai 2015 um 16:42:36, schrieb Jürgen Spitzmüller > 2015-05-09 16:07 GMT+02:00 Kornel Benko : > > > Am Samstag, 9. Mai 2015 um 11:14:20, schrieb Juergen Spitzmueller < > > sp...@lyx.org> > > > commit ded1b4f6c897dab24ef470b3645dadeb1c0f39f6 > > >

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Jürgen Spitzmüller
2015-05-09 16:45 GMT+02:00 Kornel Benko: > > Because of missing '('? > It looks weird. > Well, that's the whole point of the commit. KOMA typesets enumii as a) instead of (a). Jürgen > > Kornel

Re: [LyX/master] Adapt enumii counter display to KOMA default as suggested in #3311.

2015-05-09 Thread Kornel Benko
Am Samstag, 9. Mai 2015 um 16:51:23, schrieb Jürgen Spitzmüller > 2015-05-09 16:45 GMT+02:00 Kornel Benko: > > > > > Because of missing '('? > > It looks weird. > > > > Well, that's the whole point of the commit. > KOMA typesets enumii as a) instead of (a). > > Jürgen > > Ah,

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-09 Thread Richard Heck
On 05/08/2015 03:19 PM, Georg Baum wrote: commit 51cc8aa9f6b784f806b1d9cc97fe0749ffac29af Author: Georg Baum Date: Fri May 8 21:12:42 2015 +0200 Fix build with GNU libstdc++ C++11 ABI The GNU libstdc++ that ships witch gcc 5 can be used with the same ABI as

Re: Wrong enum as boolean usage in Text3.cpp

2015-05-09 Thread Scott Kostyshak
On Sat, May 9, 2015 at 12:26 AM, Stephan Witt wrote: > Am 09.05.2015 um 05:12 schrieb Scott Kostyshak : > >> On Fri, May 8, 2015 at 10:29 PM, Stephan Witt wrote: >>> Since change 02cb5fd3 one can see the clever code fragment in Text3.cpp >>>

[patch] support to set box features in the box dialog

2015-05-09 Thread Uwe Stöhr
Dear LyXers, attached is a patch that - redesigns the box dialog (better logic and necessary to expand it with features) - adds support to change the line thickness, box separation and shadow size (fixes bug #2598) - makes it possible to set a horizontal alignment for all box types (fixes

Re: Description of trac component 'frontend-qt4' ?

2015-05-09 Thread Scott Kostyshak
On Fri, May 8, 2015 at 2:35 AM, Jürgen Spitzmüller wrote: > 2015-05-07 21:55 GMT+02:00 Richard Heck : >> >> What would be nice is just to mothball "dialog". But I don't see any way >> to disable it without just removing it. Though we could do that, and >> mass-move

Re: [patch] support to set box features in the box dialog

2015-05-09 Thread Scott Kostyshak
On Sat, May 9, 2015 at 9:04 PM, Uwe Stöhr wrote: > (I am aware that tex2lyx is still missing - I will do this before > committing.) Please also check that the tex2lyx tests pass after your changes and before committing. For more information, see the section "How to update the