Re: master is no longer compilable because of required polib library

Am Dienstag, 26. Juli 2016 um 21:50:42, schrieb Pavel Sanda > Kornel Benko wrote: > > > What I mean is that if someone wants to create layouttranslations, he > > > should > > > explicitly write something like "cmake layouttranslations" or whatever > > > the cmake > > > syntax is.

Re: master is no longer compilable because of required polib library

Kornel Benko wrote: > > What I mean is that if someone wants to create layouttranslations, he should > > explicitly write something like "cmake layouttranslations" or whatever the > > cmake > > syntax is. It should never be called/created as a dependency for targets > > like > >

Re: master is no longer compilable because of required polib library

Am Dienstag, 26. Juli 2016 um 23:50:15, schrieb Uwe Stöhr > Am 26.07.2016 um 11:57 schrieb Kornel Benko: > > >> I don't think that one needs to have polib installed to be able to > >> compile LyX. > > > > This is a consequence of your previous mail > > Hi Kornel, > > then you

Re: master is no longer compilable because of required polib library

Am Dienstag, 26. Juli 2016 um 17:46:30, schrieb Pavel Sanda > Kornel Benko wrote: > > > Kornel, polib should not be ever needed by Uwe, in fact if it's > > > silently called to rebuild translations, it violates format freeze > > > for the branch. If released with installer, windows

Re: C++ "good practices" regarding constifying a function parameter?

On Tue, Jul 26, 2016 at 11:40:17PM -0400, Richard Heck wrote: > On 07/26/2016 08:54 PM, Scott Kostyshak wrote: > > The attached patch constifies a function parameter. My question is > > whether this patch causes more pain to other developers than it does > > good to the code. > > So the change

Re: C++ "good practices" regarding constifying a function parameter?

On 07/26/2016 08:54 PM, Scott Kostyshak wrote: > The attached patch constifies a function parameter. My question is > whether this patch causes more pain to other developers than it does > good to the code. So the change is: -bool BufferView::scrollToCursor(DocIterator const & dit, bool

Re: master is no longer compilable because of required polib library

On 07/26/2016 08:37 PM, Pavel Sanda wrote: > Georg Baum wrote: >>> Kornel, polib should not be ever needed by Uwe, >> This is not true, Uwe remerges strings from time to time, and then this is >> needed. > Somewhat I was under the impression that polib is needed only for > layouttranslations

C++ "good practices" regarding constifying a function parameter?

The attached patch constifies a function parameter. My question is whether this patch causes more pain to other developers than it does good to the code. The patch modifies a header that is included in many of our .cpp files, so will cause a significant amount of recompilation. I think I will

Re: master is no longer compilable because of required polib library

Kornel Benko wrote: > > Kornel, polib should not be ever needed by Uwe, in fact if it's > > silently called to rebuild translations, it violates format freeze > > for the branch. If released with installer, windows version will > > produce different pdfs than other archs. > > > > Can you please

Re: master is no longer compilable because of required polib library

Georg Baum wrote: > > Kornel, polib should not be ever needed by Uwe, > > This is not true, Uwe remerges strings from time to time, and then this is > needed. Somewhat I was under the impression that polib is needed only for layouttranslations generation not for remerging strings. If it's not

Re: master is no longer compilable because of required polib library

Am 26.07.2016 um 11:57 schrieb Kornel Benko: I don't think that one needs to have polib installed to be able to compile LyX. This is a consequence of your previous mail Hi Kornel, then you misunderstood me. If I explicitly execute the Cmake target "layouttranslations1" i expect to get the

Re: master is no longer compilable because of required polib library

Am Dienstag, 26. Juli 2016 um 10:27:56, schrieb Pavel Sanda > Kornel Benko wrote: > > This is a consequence of your previous mail stating > > 1> ImportError: No module named polib > > > > Surprisingly I get this error also in the 2.2.x branch. (I will open a > > bug

Re: master is no longer compilable because of required polib library

Pavel Sanda wrote: > Kornel Benko wrote: >> This is a consequence of your previous mail stating >> 1> ImportError: No module named polib >> >> Surprisingly I get this error also in the 2.2.x branch. (I will open a >> bug report for this.) >> The wrong part was that cmake didn't care about the

Re: master is no longer compilable because of required polib library

Uwe Stöhr wrote: > I don't think that one needs to have polib installed to be able to > compile LyX. It is not required for compiling LyX. It is only required if you remerge translation strings. > Moreover, I still don't know from where I can install this > library. This info should be added

Re: new compilation warning in 2.2.x branch

On 07/25/2016 09:58 PM, Guillaume Munch wrote: > Le 26/07/2016 à 00:15, Uwe Stöhr a écrit : >> I found time to compile today's 2.2.x branch. I get this warning that >> could and should be avoided: >> >> TextMetrics.cpp >> D:\LyXGit\2.2.x\src\RowPainter.cpp(590): warning C4244: 'initializing': >>

Re: master is no longer compilable because of required polib library

Kornel Benko wrote: > This is a consequence of your previous mail stating > 1> ImportError: No module named polib > > Surprisingly I get this error also in the 2.2.x branch. (I will open a > bug report for this.) > The wrong part was that cmake didn't care about the failed

Re: [LyX/master] Try to fix #4889 in the right way

On Tue, Jul 26, 2016 at 01:10:03PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/07/2016 à 04:22, Scott Kostyshak a écrit : > > Also, I'm curious why there is a difference if painting is done with > > mouse versus with keyboard. e.g. I cannot reproduce the issue when > > selecting with keyboard. Why

Re: [LyX/master] Use a proper test for detecting usable std::regex

Le 24/07/2016 à 00:14, Guillaume Munch a écrit : Le 18/07/2016 à 10:55, Jean-Marc Lasgouttes a écrit : Le 08/07/2016 à 22:18, Guillaume Munch a écrit : It takes several seconds each time... Is it better now? Not sure. It went down from 6 seconds to 2 seconds after running autogen. But I

Re: [LyX/master] Try to fix #4889 in the right way

Le 25/07/2016 à 04:22, Scott Kostyshak a écrit : Also, I'm curious why there is a difference if painting is done with mouse versus with keyboard. e.g. I cannot reproduce the issue when selecting with keyboard. Why does this asymmetry exist? One case is a full painting where the background has

Re: master is no longer compilable because of required polib library

Am Dienstag, 26. Juli 2016 um 01:20:44, schrieb Uwe Stöhr > Hi Kornel, > > after your today's changes I can no longer compile LyX's master. I get > this error: > > Building with USE_HUNSPELL > CMake Error at C:/Program >

Re: [LyX/2.2.x] Start preparations for 2.2.1.

On 2016-07-25, Guillaume Munch wrote: > Le 24/07/2016 à 16:48, Jean-Pierre Chrétien a écrit : >> Le 22/07/2016 16:21, Guillaume Munch a écrit : >>> Le 22/07/2016 à 14:31, Jean-Pierre Chrétien a écrit : ... What about "Export" rather than "Format"? This covers all three items in the