Re: [LyX/master] Try to fix #4889 in the right way

2016-08-06 Thread Scott Kostyshak
On Thu, Aug 04, 2016 at 06:27:29PM -0400, Scott Kostyshak wrote: > On Thu, Aug 04, 2016 at 11:22:46PM +0200, Jean-Marc Lasgouttes wrote: > > Le 24/07/2016 à 23:49, Scott Kostyshak a écrit : > > > This commit appears to have changed behavior for me (says git bisect). > > > With the attached

Re: middle-click to open child documents?

2016-08-06 Thread Scott Kostyshak
On Sat, Aug 06, 2016 at 09:02:25PM +0100, José Abílio Matos wrote: > Yet for me a browser is a read-only process where I am a consumer > while with > lyx is a write process where I am a producer/maker. That is to say > that > mentally that analogy is not obvious. I would not expect for lyx to >

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Scott Kostyshak
On Sat, Aug 06, 2016 at 06:51:54PM +0100, Guillaume Munch wrote: > Thanks for the explanations. After a few tries and turning off the > MERGE_FILES flag, I got: > ...master/src/frontends/qt4/GuiApplication.cpp:128:21: fatal error: > xcb/xcb.h: No such file or directory > and I do not know where

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Enrico Forestieri
On Sat, Aug 06, 2016 at 03:39:19PM +0100, Guillaume Munch wrote: > > call_once.cpp: > > #include > static std::once_flag flag; > int main() { > std::call_once(flag, [](){ return; }); > return 0; > } Thanks for the test case. I used it to fix this issue at 41e409f8. -- Enrico

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Enrico Forestieri
On Sat, Aug 06, 2016 at 06:51:54PM +0100, Guillaume Munch wrote: > > For Enrico's suggestion of using the --target flag with autotools, the > problem is that I do not know where to find and install the windows headers > for the external libraries (which I think this script automatises). Please,

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Enrico Forestieri
On Sat, Aug 06, 2016 at 03:39:19PM +0100, Guillaume Munch wrote: > Le 06/08/2016 à 03:44, Enrico Forestieri a écrit : > > > > Unfortunately, this does not work. Although the manual states that the > > -pthread option sets flags for both the preprocessor and linker, this > > is not the case for

Re: middle-click to open child documents?

2016-08-06 Thread José Abílio Matos
On Friday, August 5, 2016 10:56:31 PM WEST Scott Kostyshak wrote: > Dear LyX devs, > > The following behavior is shared by Firefox and Chromium: > > ctrl+left-click opens a tab but does not switch to it > middle-click is the same as ctrl+left click > shift+middle-click opens the tab and switches

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 16:45, Abdelrazak Younes a écrit : On 06/08/2016 17:04, Guillaume Munch wrote: Le 06/08/2016 à 10:16, Abdelrazak Younes a écrit : (1) Do not commit any part of the patch because it is so minor. This is my preference because it doesn't bring anything and it can create

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Kornel Benko
Am Samstag, 6. August 2016 um 18:51:54, schrieb Guillaume Munch > Le 06/08/2016 à 02:26, Scott Kostyshak a écrit : > > On Sat, Aug 06, 2016 at 02:01:00AM +0100, Guillaume Munch wrote: > >> Le 05/08/2016 à 02:35, Enrico Forestieri a écrit : > >>> > >>> I am simply cross-compiling

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 02:26, Scott Kostyshak a écrit : On Sat, Aug 06, 2016 at 02:01:00AM +0100, Guillaume Munch wrote: Le 05/08/2016 à 02:35, Enrico Forestieri a écrit : I am simply cross-compiling from cygwin following the usual way: Good to know. configure --host=i686-w64-mingw32

Protected hyphenInert->Special Character requires amsmath package

2016-08-06 Thread Jean-Pierre Chrétien
Hello, I happened to check that splash.lyx compiled correctly in French. As I found a wrongly justified line, I tried to correct this by inserting a Insert->Spacial Character->Protected Hyphen, which is not the correct solution of course as I should have inserted a

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Abdelrazak Younes
On 06/08/2016 17:04, Guillaume Munch wrote: Le 06/08/2016 à 10:16, Abdelrazak Younes a écrit : (1) Do not commit any part of the patch because it is so minor. This is my preference because it doesn't bring anything and it can create confusion for the beginner when compared with const

QFile::remove: Empty or null file name

2016-08-06 Thread Scott Kostyshak
To reproduce, open the Embedded Objects manual and compile to PDF. I get the following warnings in the terminal: QFile::remove: Empty or null file name QFile::remove: Empty or null file name QFile::remove: Empty or null file name They come from InsetExternal.cpp:103. I think they are

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Kornel Benko
Am Samstag, 6. August 2016 um 15:39:19, schrieb Guillaume Munch > Le 06/08/2016 à 03:44, Enrico Forestieri a écrit : > > > > As already said, it should be the same, provided you have the necessary > > tools and libraries. These can be found in the cygwin distribution with > >

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Guillaume Munch
(For some reason the message did not get through, retrying. That's the second time this happens in the recent days. Anyone else experiences issues with gmane?) Le 06/08/2016 à 10:16, Abdelrazak Younes a écrit : (1) Do not commit any part of the patch because it is so minor. This is my

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 03:44, Enrico Forestieri a écrit : As already said, it should be the same, provided you have the necessary tools and libraries. These can be found in the cygwin distribution with package names such as mingw64-i686-hunspell, mingw64-i686-pkg-config, mingw64-i686-qt5-base,

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread José Abílio Matos
On Saturday, August 6, 2016 4:17:01 PM WEST Abdelrazak Younes wrote: > Exactly! > > Cheers, > Abdel. Can I use a 4K screen as the standard? ;-) FWIW I agree with the rational of having short/not too long functions, I am just saying that half a screen is an ambiguous measure. :-) -- José

tex2lyx fails with \subfloat without optional arguments

2016-08-06 Thread José Abílio Matos
Hi, recently I had a colleague that asked to convert some tex document to lyx because it was failing for him. After some work, involving bissections :-) , I dound out that the culprit was a subfloat. Basically a call like \subfloat{somegraphics} fails to produce a legal lyx

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Abdelrazak Younes
On 06/08/2016 14:41, Vincent van Ravesteijn wrote: But, I guess the coding standard says that functions shouldn't be longer than something like half a screen. Exactly! Cheers, Abdel.

Re: Pandora's box

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 10:31, Abdelrazak Younes a écrit : Hi Guillaume, Just my 2 cents about those recent commits: 1) Switching to C++11 thread is a good thing 2) All these #if (gcc 4.6) are uglyfying the code considerably, you should enter C++11 with 2 steps or just leave it. Thanks, Abdel Hi

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Vincent van Ravesteijn
Op 6 aug. 2016 11:26 schreef "Abdelrazak Younes" : > > Hi Scott, > > Too late already but my 2 cents below :-) > > > On 27/07/2016 02:54, Scott Kostyshak wrote: >> >> The attached patch constifies a function parameter. My question is >> whether this patch causes more pain to other

Hide insets

2016-08-06 Thread racoon
Dear LyX devs, I find it very convenient in LyX that one can easily insert notes into the text while editing a document. I make heavy usage of this feature. However, at some stages in working on my documents seeing those notes and certain other insets seems distracting to me. Then I

Re: Pandora's box

2016-08-06 Thread Abdelrazak Younes
Hi Guillaume, Just my 2 cents about those recent commits: 1) Switching to C++11 thread is a good thing 2) All these #if (gcc 4.6) are uglyfying the code considerably, you should enter C++11 with 2 steps or just leave it. Thanks, Abdel On 31/07/2016 19:38, Guillaume Munch wrote: Hi list,

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Abdelrazak Younes
Hi Scott, Too late already but my 2 cents below :-) On 27/07/2016 02:54, Scott Kostyshak wrote: The attached patch constifies a function parameter. My question is whether this patch causes more pain to other developers than it does good to the code. The patch modifies a header that is