Re: Continuous Spellchecker Default Behavior (and Voting?)

Am 02.11.2020 um 19:10 schrieb Joel Kulesza : > > On Sun, Nov 1, 2020 at 4:19 PM Richard Kimberly Heck wrote: > On 11/1/20 4:54 PM, Richard Kimberly Heck wrote: > > Attached is the patch. > > Riki > > I seem to never be able to successfully apply patches. This is no exception > (I'm on maste

Re: Patches

Le 02/11/2020 à 22:56, Richard Kimberly Heck a écrit : I have been thinking just a bit about this and wonder how plausible it is to separate out those elements of the Counter class that are per-Buffer (or, at least, document set) and those that are not. Basically: ALL of the members of Counter

Re: [LyX/master] Remove 'slave' terminology from Counters.cpp.

Le 02/11/2020 à 23:46, Richard Kimberly Heck a écrit : This seems to have been the only use of 'slave' in our code. Best to get rid of it. The general view seems to be that 'master' on its own is not problematic, so I don't propose to change 'master document', etc. But, as I say in the comm

Re: [LyX/master] Remove 'slave' terminology from Counters.cpp.

This seems to have been the only use of 'slave' in our code. Best to get rid of it. The general view seems to be that 'master' on its own is not problematic, so I don't propose to change 'master document', etc. But, as I say in the commit message below, 'child' seemed the best way to go he

Re: Patches

On 11/2/20 2:33 PM, Jean-Marc Lasgouttes wrote: Le 02/11/2020 à 19:50, Yuriy Skalko a écrit : I'll check this stuff. By the way, is it related to numbered layouts that Daniel is now implementing on the bugtracker (https://www.lyx.org/trac/ticket/12010)? I don't inadvertently want to break his

Re: Patches

On Monday, November 2, 2020 7:33:41 PM WET Jean-Marc Lasgouttes wrote: > Yes, updateMacros is a pain, it is actually a O(n^2) algorithm which > kills performance for big documents. But it is a bit scary and I never > dared changing it I had a PhD student last year showing a lyx document full of m

Re: Patches

Le 02/11/2020 à 19:50, Yuriy Skalko a écrit : I'll check this stuff. By the way, is it related to numbered layouts that Daniel is now implementing on the bugtracker (https://www.lyx.org/trac/ticket/12010)? I don't inadvertently want to break his results. Yes it is related, but it should not

Re: Continuous Spellchecker Default Behavior (and Voting?)

On Mon, Nov 2, 2020 at 11:46 AM Richard Kimberly Heck wrote: > On 11/2/20 1:10 PM, Joel Kulesza wrote: > > On Sun, Nov 1, 2020 at 4:19 PM Richard Kimberly Heck > wrote: > >> On 11/1/20 4:54 PM, Richard Kimberly Heck wrote: >> >> Attached is the patch. >> >> Riki >> > > I seem to never be able to

Re: OutputParams

On 11/2/20 1:36 PM, Yuriy Skalko wrote: That is fine. I do prefer this initialization syntax. Committed. Good luck with the rest! It's a minefield. Riki Riki, have you seen my last patch? I hope this minefield is walked through without significant losses :) Yes, I looked at it but didn'

Re: Patches

I am very impressed :) If you feel like factoring more, you could have a look at splitting Counters/Counter into 3 classes: 1/2) the definitions, which belong to the textclass, and which should basically be accessed as const 3) the values of the counters, which can be a much more compact objec

Re: Continuous Spellchecker Default Behavior (and Voting?)

On 11/2/20 1:10 PM, Joel Kulesza wrote: On Sun, Nov 1, 2020 at 4:19 PM Richard Kimberly Heck > wrote: On 11/1/20 4:54 PM, Richard Kimberly Heck wrote: Attached is the patch. Riki I seem to never be able to successfully apply patches.  This is no exceptio

Re: ...

That is fine. I do prefer this initialization syntax. Committed. Good luck with the rest! It's a minefield. Riki Riki, have you seen my last patch? I hope this minefield is walked through without significant losses :) Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.l

Re: Continuous Spellchecker Default Behavior (and Voting?)

On Sun, Nov 1, 2020 at 4:19 PM Richard Kimberly Heck wrote: > On 11/1/20 4:54 PM, Richard Kimberly Heck wrote: > > Attached is the patch. > > Riki > I seem to never be able to successfully apply patches. This is no exception (I'm on master at e8a28c33c), so I cannot test it (complaints follow m

Re: ...

On 11/2/20 5:02 AM, Yuriy Skalko wrote: The place I find mutable members most problematic is in OutputParams. I once tried to sort that out but gave up after a while. Riki I'll try to handle this. Are there any mutables to leave here? The first refactoring step is in attached patch. That i

Re: Patches

Le 01/11/2020 à 17:08, Yuriy Skalko a écrit : And the last 10 refactoring patches from me. I am very impressed :) If you feel like factoring more, you could have a look at splitting Counters/Counter into 3 classes: 1/2) the definitions, which belong to the textclass, and which should basica

Re: Warnings while compiling branch

Le 02/11/2020 à 15:39, Jean-Pierre Chrétien a écrit : Dear developers While compiling the latest branch with this config I see this : ../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx: In member function ‘bool HunspellImpl::spell(const string&, int*, std::__cxx11::string*)’:

Warnings while compiling branch

Dear developers While compiling the latest branch with this config Configuration Host type: x86_64-pc-linux-gnu Special build flags: build=development std-regex warnings assertions stdlib-debug use-hunspell Bundled libraries:boost hunspell mythes C++ Compiler

Re: ...

The place I find mutable members most problematic is in OutputParams. I once tried to sort that out but gave up after a while. Riki I'll try to handle this. Are there any mutables to leave here? The first refactoring step is in attached patch. Yuriy And here is the second step.

Re: ...

I'm never entirely sure about mutable members, but it does make sense to me for used_ to be mutable. It's really just a kind of convenient flag used when writing the LyX file. It could be replaced by a list of used authors or something. So it's exactly that kind of thing that it's safe to update i