Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 11:56, Jean-Marc Lasgouttes a écrit : Le 21/11/2016 à 11:49, Guillaume Munch a écrit : Le 21/11/2016 à 11:45, Jean-Marc Lasgouttes a écrit : I agree, but I could not figure it out. Do you have a MWE? That's the point, I don't. I can add a terminal error message to help find

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2016 à 11:49, Guillaume Munch a écrit : Le 21/11/2016 à 11:45, Jean-Marc Lasgouttes a écrit : I agree, but I could not figure it out. Do you have a MWE? That's the point, I don't. I can add a terminal error message to help find one in the future if you think it is going to help.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 11:45, Jean-Marc Lasgouttes a écrit : I agree, but I could not figure it out. Do you have a MWE? That's the point, I don't. I can add a terminal error message to help find one in the future if you think it is going to help.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2016 à 11:40, Guillaume Munch a écrit : Le 21/11/2016 à 10:02, Jean-Marc Lasgouttes a écrit : Can you expand on when w<0 happens? I think that fixing problems (other than with an explicit workaround) is often a better idea in the long run. I agree, but I could not figure it out. D

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 09:06, Scott Kostyshak a écrit : On Mon, Nov 21, 2016 at 01:04:10AM +0100, Guillaume Munch wrote: But with your recipe I got the attached (unrelated) segfault when closing LyX. A bisect led me to fb264663. Thank you for doing that.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 10:02, Jean-Marc Lasgouttes a écrit : Can you expand on when w<0 happens? I think that fixing problems (other than with an explicit workaround) is often a better idea in the long run. I agree, but I could not figure it out.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2016 à 00:51, Guillaume Munch a écrit : Backtrace is attached. Thank you for the trace. Does the attached patch help? - if (w < 0) - // this is not expected to happen (but it does) + if (w <= 0) + // w < 0 is not expected to happen (but it does

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Scott Kostyshak
On Mon, Nov 21, 2016 at 01:04:10AM +0100, Guillaume Munch wrote: > > But with your recipe I got the attached (unrelated) segfault when > > closing LyX. A bisect led me to fb264663. I posted on that thread. Scott signature.asc Description: PGP signature

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-20 Thread Scott Kostyshak
On Mon, Nov 21, 2016 at 01:04:10AM +0100, Guillaume Munch wrote: > > Unfortunately I cannot reproduce. > > > > But with your recipe I got the attached (unrelated) segfault when > > closing LyX. > > Sorry for the mix-up, only the last trace is relevant. (short answer: your patch does fix the ass

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-20 Thread Guillaume Munch
Le 21/11/2016 à 00:51, Guillaume Munch a écrit : Le 20/11/2016 à 22:47, Scott Kostyshak a écrit : After this commit I get an assertion. To reproduce: 1. Open lib/doc/Math.lyx 2. ctrl+a to select all. 3. Insert > Branch > Insert New Branch. Call it "hello" and press OK. Hi Scott, Unfortuna

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-20 Thread Guillaume Munch
Le 20/11/2016 à 22:47, Scott Kostyshak a écrit : After this commit I get an assertion. To reproduce: 1. Open lib/doc/Math.lyx 2. ctrl+a to select all. 3. Insert > Branch > Insert New Branch. Call it "hello" and press OK. Hi Scott, Unfortunately I cannot reproduce. But with your recipe I g

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-20 Thread Scott Kostyshak
On Sun, Nov 06, 2016 at 02:45:03PM +0100, Guillaume Munch wrote: > commit b30f8d3c4bffd04bbef16adfc0a5e59e32b160e0 > Author: Guillaume Munch > Date: Sat Aug 13 19:03:02 2016 +0100 > > On-screen justification: stretch in proportion with the em, up to a limit > > 1) Distinguish expan