Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Am Mittwoch, 3. Mai 2017 um 18:57:57, schrieb Tommaso Cucinotta > On 03/05/2017 17:42, Tommaso Cucinotta wrote: > > On 03/05/2017 17:37, Tommaso Cucinotta wrote: > >> Kornel, would you mind to re-run the tests ? > > > > I have this one consistently failing: > > > >

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

On 03/05/2017 17:42, Tommaso Cucinotta wrote: On 03/05/2017 17:37, Tommaso Cucinotta wrote: Kornel, would you mind to re-run the tests ? I have this one consistently failing: findadv-02-in.txt: FAILED will dig shortly (I'm going off-line a few hours). this is what

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

On 03/05/2017 17:42, Tommaso Cucinotta wrote: On 03/05/2017 17:37, Tommaso Cucinotta wrote: Kornel, would you mind to re-run the tests ? I have this one consistently failing: findadv-02-in.txt: FAILED will dig shortly (I'm going off-line a few hours). this is what

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Am Mittwoch, 3. Mai 2017 um 17:42:25, schrieb Tommaso Cucinotta > On 03/05/2017 17:37, Tommaso Cucinotta wrote: > > Kornel, would you mind to re-run the tests ? > > I have this one consistently failing: > > findadv-02-in.txt: FAILED This one passes

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

On 03/05/2017 17:37, Tommaso Cucinotta wrote: Kornel, would you mind to re-run the tests ? I have this one consistently failing: findadv-02-in.txt: FAILED will dig shortly (I'm going off-line a few hours). T.

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Le 03/05/2017 à 17:37, Tommaso Cucinotta a écrit : As for the "word-findadv" verb, I don't have strong opinions about hiding that, and I don't know for sure what these "Edit" vs "Hidden" etc. flags are for :(... It is to know in what group the function appears when one tries to customize the

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

On 03/05/2017 11:26, Jean-Marc Lasgouttes wrote: 3610cdf66944dc790e2e3df666e99f33c45b1ede Yes, this is much less surprising than to two other commits. this is now (correctly) fixed in commit cf6bbe21 Author: Tommaso Cucinotta Date: Wed May 3 17:32:31 2017 +0200

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

my bad, quite blind commits without testing, I just reverted the suppression of the "word-findadv" lfun name, but, as you just pointed out, it was actually the crash fix to break all tests :-)! (just confirmed that reverting that as well recovers a working findadv pane) T. On

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Le 03/05/2017 à 10:44, Kornel Benko a écrit : Testing manually, I see, that replace is not working. (E.g. findadv does not find anything) Hm, test passes after reverting also 3610cdf66944dc790e2e3df666e99f33c45b1ede Yes, this is much less surprising than to two other commits. JMarc

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Am Mittwoch, 3. Mai 2017 um 10:08:40, schrieb Jean-Marc Lasgouttes > Le 03/05/2017 à 10:05, Kornel Benko a écrit : > > Am Mittwoch, 3. Mai 2017 um 09:41:08, schrieb Jean-Marc Lasgouttes > > > >> Le 03/05/2017 à 07:48, Stephan Witt a écrit : > >>>

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Le 03/05/2017 à 10:05, Kornel Benko a écrit : Am Mittwoch, 3. Mai 2017 um 09:41:08, schrieb Jean-Marc Lasgouttes Le 03/05/2017 à 07:48, Stephan Witt a écrit : Something like the attached patch is needed!? Yes, I just did that. JMarc You did, but without test.

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Am Mittwoch, 3. Mai 2017 um 09:41:08, schrieb Jean-Marc Lasgouttes > Le 03/05/2017 à 07:48, Stephan Witt a écrit : > > Something like the attached patch is needed!? > > Yes, I just did that. > > JMarc You did, but without test. # ctest -R findadv ...

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Le 03/05/2017 à 07:48, Stephan Witt a écrit : Something like the attached patch is needed!? Yes, I just did that. JMarc

Re: [LyX/master] findadv: hide word-findadv verb from the mini-buffer

Am 03.05.2017 um 01:34 schrieb Tommaso Cucinotta : > > commit 8c10182962efa643edfcfbe64fc830b5fc0d9a65 > Author: Tommaso Cucinotta > Date: Wed May 3 01:29:36 2017 +0200 > >findadv: hide word-findadv verb from the mini-buffer > >The current set of