Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Juergen Vigna
Lars Gullik Bjønnes wrote: Juergen Vigna [EMAIL PROTECTED] writes: | Alfredo Braunstein wrote: | It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). | Then you have also a lyxtext in every children insettext... I'm talking | about these, mostly. Or else I am confusing

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Lars Gullik Bjønnes
Juergen Vigna [EMAIL PROTECTED] writes: | Lars Gullik Bjønnes wrote: | Juergen Vigna [EMAIL PROTECTED] writes: | | Alfredo Braunstein wrote: | | It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). | | Then you have also a lyxtext in every children insettext... I'm

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Juergen Vigna
Lars Gullik Bjønnes wrote: Keep the enclosed LyXText somehwere else, so that parts of the paragraph structure could be modified at will, without having to thing about anything else. I don't really understand how you would do that and how that would facilitate the process, I understand however that

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Lars Gullik Bjønnes
Juergen Vigna [EMAIL PROTECTED] writes: | Lars Gullik Bjønnes wrote: | Keep the enclosed LyXText somehwere else, so that parts of the | paragraph structure could be modified at will, without having to thing | about anything else. | | I don't really understand how you would do that and how

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Juergen Vigna
Lars Gullik Bjønnes wrote: Who are we? the inset? The inset should know nothing about any lyxtext at all, the same way a Paragraph today knows nothing about any lyxtext. Well we is the inset. And yes this is a good idea and quite easy IMO we just have to remove the DRAW functionality from the

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Juergen Vigna
Lars Gullik Bjønnes wrote: Juergen Vigna <[EMAIL PROTECTED]> writes: | Alfredo Braunstein wrote: | > It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). | > Then you have also a lyxtext in every children insettext... I'm talking | > about these, mostly. Or else I am

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Juergen Vigna <[EMAIL PROTECTED]> writes: | > | Alfredo Braunstein wrote: | > | > It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). | > | > Then you have also a lyxtext in every children

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Juergen Vigna
Lars Gullik Bjønnes wrote: Keep the enclosed LyXText somehwere else, so that parts of the paragraph structure could be modified at will, without having to thing about anything else. I don't really understand how you would do that and how that would facilitate the process, I understand however that

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Keep the enclosed LyXText somehwere else, so that parts of the | > paragraph structure could be modified at will, without having to thing | > about anything else. | | I don't really understand how you would do that and

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-18 Thread Juergen Vigna
Lars Gullik Bjønnes wrote: Who are "we"? the inset? The inset should know nothing about any lyxtext at all, the same way a Paragraph today knows nothing about any lyxtext. Well "we" is the inset. And yes this is a good idea and quite easy IMO we just have to remove the "DRAW" functionality from

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
John Levon [EMAIL PROTECTED] writes: | On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bj?nnes wrote: | | Please comment. | | If bv_owner is always != 0, what is the isTopLevel() test all about ? Just to be explicit. It seems that either isTopLevel or isInInset can be removed. | This

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: I have a patch ready (that seems to work) that does 99.9% of these changes. How the multiple bv will be adressed (or is it already in the patch?) - by having a cont bv member in lyxtext (i.e different bv for different buffers) - by resetting the bv * member in all

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Juergen Vigna
Alfredo Braunstein wrote: Lars Gullik Bjønnes wrote: I have a patch ready (that seems to work) that does 99.9% of these changes. How the multiple bv will be adressed (or is it already in the patch?) - by having a cont bv member in lyxtext (i.e different bv for different buffers) - by

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Alfredo Braunstein
Juergen Vigna wrote: We will need 1 LyXText for every BufferView! Hope that answers all your questions above ;) Jürgen It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). Then you have also a lyxtext in every children insettext... I'm talking about these,

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
Alfredo Braunstein [EMAIL PROTECTED] writes: | Lars Gullik Bjønnes wrote: | | I have a patch ready (that seems to work) that does 99.9% of these | changes. | | How the multiple bv will be adressed (or is it already in the patch?) No. This patch completely punt on that issue. (So copy paste

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
Juergen Vigna [EMAIL PROTECTED] writes: | Alfredo Braunstein wrote: | Lars Gullik Bjønnes wrote: | | I have a patch ready (that seems to work) that does 99.9% of these | changes. | How the multiple bv will be adressed (or is it already in the patch?) | - by having a cont bv member in lyxtext

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Andre Poenitz
On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bjønnes wrote: I am not sure that it cleans up a lot, but I guess it is a bit saner anyway. I'd guess so, too. At least it looks nicer. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread John Levon
On Mon, Mar 17, 2003 at 09:52:37AM +0100, Lars Gullik Bj?nnes wrote: It seems that either isTopLevel or isInInset can be removed. OK, I think isTopLevel should go then regards john

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
John Levon [EMAIL PROTECTED] writes: | On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bj?nnes wrote: | | Please comment. | | If bv_owner is always != 0, what is the isTopLevel() test all about ? | | This seems dubious to me, look at RowPainter::paintFirst() - if bv_owner | was always

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Juergen Vigna
Alfredo Braunstein wrote: It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). Then you have also a lyxtext in every children insettext... I'm talking about these, mostly. Or else I am confusing something ;) InsetText already has support for multiple BufferViews (while other

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
Juergen Vigna [EMAIL PROTECTED] writes: | Alfredo Braunstein wrote: | It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). | Then you have also a lyxtext in every children insettext... I'm talking | about these, mostly. Or else I am confusing something ;) | | InsetText

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bj?nnes wrote: | | > Please comment. | | If bv_owner is always != 0, what is the isTopLevel() test all about ? Just to be explicit. It seems that either isTopLevel or isInInset can be removed. |

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Alfredo Braunstein
Lars Gullik Bjønnes wrote: > I have a patch ready (that seems to work) that does 99.9% of these > changes. How the multiple bv will be adressed (or is it already in the patch?) - by having a cont bv member in lyxtext (i.e different bv for different buffers) - by resetting the bv * member in all

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Juergen Vigna
Alfredo Braunstein wrote: Lars Gullik Bjønnes wrote: I have a patch ready (that seems to work) that does 99.9% of these changes. How the multiple bv will be adressed (or is it already in the patch?) - by having a cont bv member in lyxtext (i.e different bv for different buffers) - by

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Alfredo Braunstein
Juergen Vigna wrote: > We will need 1 LyXText for every BufferView! Hope that answers all > your questions above ;) > >Jürgen > It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). Then you have also a lyxtext in every children insettext... I'm talking about these,

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | | > I have a patch ready (that seems to work) that does 99.9% of these | > changes. | | How the multiple bv will be adressed (or is it already in the patch?) No. This patch completely punt on that issue. (So copy

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | Alfredo Braunstein wrote: | > Lars Gullik Bjønnes wrote: | > | >>I have a patch ready (that seems to work) that does 99.9% of these | >>changes. | > How the multiple bv will be adressed (or is it already in the patch?) | > - by having a cont bv member

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Andre Poenitz
On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bjønnes wrote: > I am not sure that it cleans up a lot, but I guess it is a bit saner > anyway. I'd guess so, too. At least it looks nicer. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread John Levon
On Mon, Mar 17, 2003 at 09:52:37AM +0100, Lars Gullik Bj?nnes wrote: > It seems that either isTopLevel or isInInset can be removed. OK, I think isTopLevel should go then regards john

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bj?nnes wrote: | | > Please comment. | | If bv_owner is always != 0, what is the isTopLevel() test all about ? | | This seems dubious to me, look at RowPainter::paintFirst() - if bv_owner | was

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Juergen Vigna
Alfredo Braunstein wrote: It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). Then you have also a lyxtext in every children insettext... I'm talking about these, mostly. Or else I am confusing something ;) InsetText already has support for multiple BufferViews (while other

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-17 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | Alfredo Braunstein wrote: | > It doesn't. You need 1 _top_ lyxtext for every bv (and there is already). | > Then you have also a lyxtext in every children insettext... I'm talking | > about these, mostly. Or else I am confusing something ;) | |

[PATCH] dump all the BufferView args from LyXText methods

2003-03-16 Thread Lars Gullik Bjønnes
I have a patch ready (that seems to work) that does 99.9% of these changes. I am not sure that it cleans up a lot, but I guess it is a bit saner anyway. There shouldn't bee too many ws only chunks in this patch, but there might be some. Please comment. (I had to zip this... size unzipped

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-16 Thread John Levon
On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bj?nnes wrote: Please comment. If bv_owner is always != 0, what is the isTopLevel() test all about ? This seems dubious to me, look at RowPainter::paintFirst() - if bv_owner was always set, then we'd get the top margin at the top of every

[PATCH] dump all the BufferView args from LyXText methods

2003-03-16 Thread Lars Gullik Bjønnes
I have a patch ready (that seems to work) that does 99.9% of these changes. I am not sure that it cleans up a lot, but I guess it is a bit saner anyway. There shouldn't bee too many "ws only" chunks in this patch, but there might be some. Please comment. (I had to zip this... size unzipped

Re: [PATCH] dump all the BufferView args from LyXText methods

2003-03-16 Thread John Levon
On Mon, Mar 17, 2003 at 12:54:40AM +0100, Lars Gullik Bj?nnes wrote: > Please comment. If bv_owner is always != 0, what is the isTopLevel() test all about ? This seems dubious to me, look at RowPainter::paintFirst() - if bv_owner was always set, then we'd get the top margin at the top of every