Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-27 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: Very nice! So, you propose that we Angus> do not compile the ispell code at all if using aspell or Angus> pspell. >> Yes. Actually, instead of the conditional, we could have a >> variable SPELL which con

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-26 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Very nice! So, you propose that we do not compile the ispell > Angus> code at all if using aspell or pspell. > > Yes. Actually, instead of the conditional, we could have a variable > SPELL which contains the one of [pai]spell source/header pair of > files. The

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-26 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> The code for lyxserver, lyxsocket. Angus> This isn't a sentence. I take it that you mean you like the Angus> code for lyxserver and lyxsocket? Yes. >> Finally, for the configure code, I think I'd prefer something like >> the attache

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-26 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Well, see how you like this, which extends the previous patch > Angus> as you suggest. It leads to the following variables being > Angus> defined in config.h > > The code for lyxserver, lyxsocket. This isn't a sentence. I take it that you mean you like the co

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-26 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Well, see how you like this, which extends the previous patch Angus> as you suggest. It leads to the following variables being Angus> defined in config.h The code for lyxserver, lyxsocket. Concerning socktools, I do not understand

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Mmmm, but the ISpell class encapsulates our interaction with > Angus> the external ispell process. Not being able to interact with > Angus> this external process (no select(), different API to open > Angus> pipes) is conceptually the same to the rest of LyX as b

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Mmmm, but the ISpell class encapsulates our interaction with Angus> the external ispell process. Not being able to interact with Angus> this external process (no select(), different API to open Angus> pipes) is conceptually the same

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> I've come round to the opinion that ISpell.C should have a stub > Angus> implementation for the case when HAVE_SELECT is not defined. > Angus> The existing ISpell interface is sufficient to enable the rest > Angus> of LyX to know that communication with the ispe

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I've come round to the opinion that ISpell.C should have a stub Angus> implementation for the case when HAVE_SELECT is not defined. Angus> The existing ISpell interface is sufficient to enable the rest Angus> of LyX to know that com

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Jean-Marc Lasgouttes wrote: I need this patch to compile the > Angus> 1.4.x tree with mingw. It results in support/globbing.C being > Angus> compiled only if we're building the XForms frontend. >>> Why don't you just move globbing.* to frontends/xforms? > > An

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: I need this patch to compile the Angus> 1.4.x tree with mingw. It results in support/globbing.C being Angus> compiled only if we're building the XForms frontend. >> Why don't you just move globbing.* to

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> I need this patch to compile the 1.4.x tree with mingw. It > Angus> results in support/globbing.C being compiled only if we're > Angus> building the XForms frontend. > > Why don't you just move globbing.* to frontends/xforms? Good idea, actually. But the clien

Re: [PATCH 14x] build support/globbing.C only for XForms

2005-04-25 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I need this patch to compile the 1.4.x tree with mingw. It Angus> results in support/globbing.C being compiled only if we're Angus> building the XForms frontend. Why don't you just move globbing.* to frontends/xforms? JMarc

[PATCH 14x] build support/globbing.C only for XForms

2005-04-24 Thread Angus Leeming
I need this patch to compile the 1.4.x tree with mingw. It results in support/globbing.C being compiled only if we're building the XForms frontend. configure --with-frontend='qt' leads to this in src/support/Makefile: #GLOBBING = globbing.C globbing.h $(GLOBBING) $(COMPRESSION) kill.C \