Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Michael == Michael Schmitt [EMAIL PROTECTED] writes:
| Michael Sigh... I really don't understand why simple things can get
| Michael that complicated. Sometimes it seems easier to introduce a
| Michael new feature than to fix a few spaces.
|
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:
>
| Michael> Sigh... I really don't understand why simple things can get
| Michael> that complicated. Sometimes it seems easier to introduce a
| Michael> new feature than to fix a few
Michael == Michael Schmitt [EMAIL PROTECTED] writes:
Michael Sigh... I really don't understand why simple things can get
Michael that complicated. Sometimes it seems easier to introduce a
Michael new feature than to fix a few spaces.
Indeed :)
JMarc
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:
Michael> Sigh... I really don't understand why simple things can get
Michael> that complicated. Sometimes it seems easier to introduce a
Michael> new feature than to fix a few spaces.
Indeed :)
JMarc
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: |
Lars What Michael did is purely cosmetic (no code change). It does
Lars not | change anything about behaviour.
Lars I realize that, but am still a bit queasy about it.
My take on it is
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| Lars Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: |
| Lars What Michael did is purely cosmetic (no code change). It does
| Lars not | change anything about behaviour.
| Lars I realize that,
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars A user having a similar .layout must now edit it to work with a
Lars newer version of lyx 1.3.x.
No.
The code in LyxTextClass::Read reads:
case TC_STYLE:
if (lexrc.next()) {
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
| case TC_STYLE:
| if (lexrc.next()) {
| string const name = subst(lexrc.getString(),
| '_', ' ');
| This means that the _ syntax is
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars Did we ever really have a space based syntax, or is just an
Lars artifact (bug) brought in since we use lyxlex for reading?
Well, in 0.10.7 (I just checked) we read the name and immediately
transform the _ to a space. I really think
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| Lars Did we ever really have a space based syntax, or is just an
| Lars artifact (bug) brought in since we use lyxlex for reading?
| Well, in 0.10.7 (I just checked) we read the name and
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars And a solution localized to the gettext machinery, so that
Lars sounds very correct to me.
So this is what you want for 1.3.6cvs?
JMarc
Index: po/ChangeLog
===
RCS file:
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| Lars And a solution localized to the gettext machinery, so that
| Lars sounds very correct to me.
| So this is what you want for 1.3.6cvs?
Yes. This looks good.
| Index: po/Makefile.in.in
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars And pretty simple it was too.
What remains to see is whether this change will prove helpful when we
actually need proper identifiers...
Lars Sorry for being such a drag about this, but I thought it
Lars important.
Lars btw. This is ok
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
| What remains to see is whether this change will prove helpful when we
| actually need proper identifiers...
Yes. The worst part might be the style names used in the .lyx files.
| Lars Sorry for being such a drag about this, but I thought it
|
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| You mean I'm supposed to do it? Bummer.
Lars Yes please :-)
OK, first it seems that there was a reason why we used the quote
syntax in CopyStyle. And I forgot one entry.
Committing shortly.
JMarc
Index: lib/layouts/llncs.layout
Lars Gullik Bjønnes wrote:
| Lars IMHO this patch should not be in 1.3 nor in 1.4.
| So, your thinking is that you want to be able to use the Style name as
| an identifier later and therefore would like to promote the use of
| underscore instead of space in names.
yes. (or close enough)
| In
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: |
Lars> What Michael did is purely cosmetic (no code change). It does
Lars> not | change anything about behaviour.
Lars> I realize that, but am still a bit "queasy" about it.
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: |
| Lars> What Michael did is purely cosmetic (no code change). It does
| Lars> not | change anything about behaviour.
>
|
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> A user having a similar .layout must now edit it to work with a
Lars> newer version of lyx 1.3.x.
No.
The code in LyxTextClass::Read reads:
case TC_STYLE:
if (lexrc.next()) {
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
| case TC_STYLE:
| if (lexrc.next()) {
| string const name = subst(lexrc.getString(),
| '_', ' ');
>
| This means that the _ syntax
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> Did we ever really have a "space based" syntax, or is just an
Lars> artifact (bug) brought in since we use lyxlex for reading?
Well, in 0.10.7 (I just checked) we read the name and immediately
transform the _ to a space. I
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> Did we ever really have a "space based" syntax, or is just an
| Lars> artifact (bug) brought in since we use lyxlex for reading?
>
| Well, in 0.10.7 (I just checked) we read
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> And a solution localized to the gettext machinery, so that
Lars> sounds very correct to me.
So this is what you want for 1.3.6cvs?
JMarc
Index: po/ChangeLog
===
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> And a solution localized to the gettext machinery, so that
| Lars> sounds very correct to me.
>
| So this is what you want for 1.3.6cvs?
Yes. This looks good.
| Index:
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> And pretty simple it was too.
What remains to see is whether this change will prove helpful when we
actually need proper identifiers...
Lars> Sorry for being such a drag about this, but I thought it
Lars> important.
Lars>
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
| What remains to see is whether this change will prove helpful when we
| actually need proper identifiers...
Yes. The worst part might be the style names used in the .lyx files.
| Lars> Sorry for being such a drag about this, but I thought it
|
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| You mean I'm supposed to do it? Bummer.
Lars> Yes please :-)
OK, first it seems that there was a reason why we used the quote
syntax in CopyStyle. And I forgot one entry.
Committing shortly.
JMarc
Index:
Lars Gullik Bjønnes wrote:
| Lars> IMHO this patch should not be in 1.3 nor in 1.4.
| So, your thinking is that you want to be able to use the Style name as
| an identifier later and therefore would like to promote the use of
| underscore instead of space in names.
yes. (or close enough)
| In
Michael == Michael Schmitt [EMAIL PROTECTED] writes:
Michael This patch should be side-effect-free and allows us to
Michael translate about 25 additional messages. I have loaded some of
Michael LyX's examples file for the corresponding layouts -
Michael everythings seems to work just as before.
Michael Schmitt [EMAIL PROTECTED] writes:
| Dear Jean-Marc,
| several styles defined in the *.layout files are not translatable,
| because their names contain underscores which are replaced by spaces
| at run-time.
I do not quite agree with this change. If are going to change this, we
should
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Michael == Michael Schmitt [EMAIL PROTECTED] writes:
| Michael This patch should be side-effect-free and allows us to
| Michael translate about 25 additional messages. I have loaded some of
| Michael LyX's examples file for the corresponding
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars Michael Schmitt [EMAIL PROTECTED] writes: | Dear
Lars Jean-Marc,
Lars | several styles defined in the *.layout files are not
Lars translatable, | because their names contain underscores which
Lars are replaced by spaces | at run-time.
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
| What Michael did is purely cosmetic (no code change). It does not
| change anything about behaviour.
I realize that, but am still a bit queasy about it.
--
Lgb
Jean-Marc Lasgouttes wrote:
Could you elaborate on why this is a problem? The _ are changed to
spaces internally when reading the layout file, so currently it does
not make _any_ difference.
What about user defined styles that include the system styles? I am not sure
wether they would need to
Lars Gullik Bjønnes wrote:
| If you don't have any objections, please commit the patch to the 1.3
| branch. I will produce a similar patch for 1.4 next time I find some
| time.
IMHO this should not go into 1.3, and I am very reluctant about 1.4
for this. IMHO let's fix it properly in 1.5.
I can
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:
Michael> This patch should be side-effect-free and allows us to
Michael> translate about 25 additional messages. I have loaded some of
Michael> LyX's examples file for the corresponding layouts -
Michael> everythings seems to work
Michael Schmitt <[EMAIL PROTECTED]> writes:
| Dear Jean-Marc,
>
| several styles defined in the *.layout files are not translatable,
| because their names contain underscores which are replaced by spaces
| at run-time.
I do not quite agree with this change. If are going to change this, we
should
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:
>
| Michael> This patch should be side-effect-free and allows us to
| Michael> translate about 25 additional messages. I have loaded some of
| Michael> LyX's examples file for the
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> Michael Schmitt <[EMAIL PROTECTED]> writes: | Dear
Lars> Jean-Marc,
>>
Lars> | several styles defined in the *.layout files are not
Lars> translatable, | because their names contain underscores which
Lars> are replaced by
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
| What Michael did is purely cosmetic (no code change). It does not
| change anything about behaviour.
I realize that, but am still a bit "queasy" about it.
--
Lgb
Jean-Marc Lasgouttes wrote:
> Could you elaborate on why this is a problem? The _ are changed to
> spaces internally when reading the layout file, so currently it does
> not make _any_ difference.
What about user defined styles that include the system styles? I am not sure
wether they would need
Lars Gullik Bjønnes wrote:
| If you don't have any objections, please commit the patch to the 1.3
| branch. I will produce a similar patch for 1.4 next time I find some
| time.
IMHO this should not go into 1.3, and I am very reluctant about 1.4
for this. IMHO let's fix it properly in 1.5.
I can
Dear Jean-Marc,
several styles defined in the *.layout files are not translatable,
because their names contain underscores which are replaced by spaces at
run-time.
I have modified the corresponding layout files. Moreover, I have
adjusted the po files for the 16 currently supported languages.
Dear Jean-Marc,
several styles defined in the *.layout files are not translatable,
because their names contain underscores which are replaced by spaces at
run-time.
I have modified the corresponding layout files. Moreover, I have
adjusted the po files for the 16 currently supported languages.
44 matches
Mail list logo
