Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread José Matos
On Sunday 03 June 2007 08:42:23 Stefan Schimanski wrote: José, what is your opinion about all that. I guess you don't follow   the thread anymore. Stefan Yes, I do. In cases like this I expect a clear conclusion from the thread. An as it seems the exchange of arguments is still going. --

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Stefan Schimanski
Am 04.06.2007 um 14:33 schrieb José Matos: On Sunday 03 June 2007 08:42:23 Stefan Schimanski wrote: José, what is your opinion about all that. I guess you don't follow the thread anymore. Stefan Yes, I do. In cases like this I expect a clear conclusion from the thread. An as it seems

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread José Matos
On Monday 04 June 2007 14:06:59 Stefan Schimanski wrote: There are several patches we were discussing. Those posted are the   ones both me and Dov agreed on. And are those present in the new thread you have opened today? -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Stefan Schimanski
Am 04.06.2007 um 16:54 schrieb José Matos: On Monday 04 June 2007 14:06:59 Stefan Schimanski wrote: There are several patches we were discussing. Those posted are the ones both me and Dov agreed on. And are those present in the new thread you have opened today? The patches in the new

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Dov Feldstern
Stefan Schimanski wrote: Am 04.06.2007 um 16:54 schrieb José Matos: On Monday 04 June 2007 14:06:59 Stefan Schimanski wrote: There are several patches we were discussing. Those posted are the ones both me and Dov agreed on. And are those present in the new thread you have opened today?

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread José Matos
On Monday 04 June 2007 17:19:07 Dov Feldstern wrote: Hi! Yes, the patches in the new thread from this morning (http://permalink.gmane.org/gmane.editors.lyx.devel/86583) are all OKed by me. Stefan, you can proceed with those. -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Stefan Schimanski
Am 04.06.2007 um 20:07 schrieb José Matos: On Monday 04 June 2007 17:19:07 Dov Feldstern wrote: Hi! Yes, the patches in the new thread from this morning (http://permalink.gmane.org/gmane.editors.lyx.devel/86583) are all OKed by me. Stefan, you can proceed with those. Thanks! Stefan

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread José Matos
On Sunday 03 June 2007 08:42:23 Stefan Schimanski wrote: > José, what is your opinion about all that. I guess you don't follow   > the thread anymore. > > Stefan Yes, I do. In cases like this I expect a clear conclusion from the thread. An as it seems the exchange of arguments is still going.

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Stefan Schimanski
Am 04.06.2007 um 14:33 schrieb José Matos: On Sunday 03 June 2007 08:42:23 Stefan Schimanski wrote: José, what is your opinion about all that. I guess you don't follow the thread anymore. Stefan Yes, I do. In cases like this I expect a clear conclusion from the thread. An as it seems

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread José Matos
On Monday 04 June 2007 14:06:59 Stefan Schimanski wrote: > There are several patches we were discussing. Those posted are the   > ones both me and Dov agreed on. And are those present in the new thread you have opened today? -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Stefan Schimanski
Am 04.06.2007 um 16:54 schrieb José Matos: On Monday 04 June 2007 14:06:59 Stefan Schimanski wrote: There are several patches we were discussing. Those posted are the ones both me and Dov agreed on. And are those present in the new thread you have opened today? The patches in the new

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Dov Feldstern
Stefan Schimanski wrote: Am 04.06.2007 um 16:54 schrieb José Matos: On Monday 04 June 2007 14:06:59 Stefan Schimanski wrote: There are several patches we were discussing. Those posted are the ones both me and Dov agreed on. And are those present in the new thread you have opened today?

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread José Matos
On Monday 04 June 2007 17:19:07 Dov Feldstern wrote: > Hi! > > Yes, the patches in the new thread from this morning > (http://permalink.gmane.org/gmane.editors.lyx.devel/86583) are all OKed > by me. Stefan, you can proceed with those. -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-06-04 Thread Stefan Schimanski
Am 04.06.2007 um 20:07 schrieb José Matos: On Monday 04 June 2007 17:19:07 Dov Feldstern wrote: Hi! Yes, the patches in the new thread from this morning (http://permalink.gmane.org/gmane.editors.lyx.devel/86583) are all OKed by me. Stefan, you can proceed with those. Thanks! Stefan

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
1) In Text2.cpp, in the condition if (cur.boundary() ! bidi.isBoundary..., it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return setCursor(cur, cur.pit(), cur.pos() + 1, true, false); (the + 1 is wrong; see what happens at the end of

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
José, what is your opinion about all that. I guess you don't follow the thread anymore. Stefan Am 03.06.2007 um 09:36 schrieb Stefan Schimanski: 1) In Text2.cpp, in the condition if (cur.boundary() ! bidi.isBoundary..., it should be: return setCursor(cur, cur.pit(), cur.pos(), true,

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
* rtlspaces.patch: There is a inconsistency between the font of spaces at RTL-LTR boundaries. The whole space problem is discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/ 80783. An illustration of the current situation and the one after this patch are visible at

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Slight correction of the EPM patch: there are these exceptions of the logic to avoid double spaces: abc [WERBEH|] def abc [ WERBEH]|def abc|[WERBEH ]def abc[|WERBEH] def All 4 should be possible, i.e. a space should be inserted. The last two don't fulfill the condition that the previous

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Michael Gerz
Stefan Schimanski schrieb: Slight correction of the EPM patch: there are these exceptions of the logic to avoid double spaces: abc [WERBEH|] def abc [ WERBEH]|def abc|[WERBEH ]def abc[|WERBEH] def All 4 should be possible, i.e. a space should be inserted. The last two don't fulfill the

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Am 03.06.2007 um 15:29 schrieb Michael Gerz: Stefan Schimanski schrieb: Slight correction of the EPM patch: there are these exceptions of the logic to avoid double spaces: abc [WERBEH|] def abc [ WERBEH]|def abc|[WERBEH ]def abc[|WERBEH] def All 4 should be possible, i.e. a space should

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Dov Feldstern
Stefan Schimanski wrote: 1) In Text2.cpp, in the condition if (cur.boundary() !bidi.isBoundary..., it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return setCursor(cur, cur.pit(), cur.pos() + 1, true, false); (the + 1 is wrong; see

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Am 03.06.2007 um 21:28 schrieb Dov Feldstern: Stefan Schimanski wrote: 1) In Text2.cpp, in the condition if (cur.boundary() ! bidi.isBoundary..., it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return setCursor(cur, cur.pit(),

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Dov Feldstern
Stefan Schimanski wrote: Am 03.06.2007 um 21:28 schrieb Dov Feldstern: Stefan Schimanski wrote: 1) In Text2.cpp, in the condition if (cur.boundary() !bidi.isBoundary..., it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Dov Feldstern
Stefan Schimanski wrote: * rtlspaces.patch: There is a inconsistency between the font of spaces at RTL-LTR boundaries. The whole space problem is discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/80783. An illustration of the current situation and the one after this patch are

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Am 03.06.2007 um 23:12 schrieb Dov Feldstern: Stefan Schimanski wrote: * rtlspaces.patch: There is a inconsistency between the font of spaces at RTL-LTR boundaries. The whole space problem is discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/ 80783. An illustration of the

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov But then you have a somewhat weird situation, where you're at the Dov end of a line, and pressing delete deletes from the beginning of Dov the next line, where the cursor isn't. That does not seem Dov natural to me... (Of course it's the

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
1) In Text2.cpp, in the condition "if (cur.boundary() && ! bidi.isBoundary...", it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return setCursor(cur, cur.pit(), cur.pos() + 1, true, false); (the + 1 is wrong; see what happens at the end

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
José, what is your opinion about all that. I guess you don't follow the thread anymore. Stefan Am 03.06.2007 um 09:36 schrieb Stefan Schimanski: 1) In Text2.cpp, in the condition "if (cur.boundary() && ! bidi.isBoundary...", it should be: return setCursor(cur, cur.pit(), cur.pos(),

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
* rtlspaces.patch: There is a inconsistency between the font of spaces at RTL<->LTR boundaries. The whole space problem is discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/ 80783. An illustration of the current situation and the one after this patch are visible at

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Slight correction of the EPM patch: there are these exceptions of the logic to avoid double spaces: abc [WERBEH|] def" abc [ WERBEH]|def" abc|[WERBEH ]def" abc[|WERBEH] def" All 4 should be possible, i.e. a space should be inserted. The last two don't fulfill the condition that the previous

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Michael Gerz
Stefan Schimanski schrieb: Slight correction of the EPM patch: there are these exceptions of the logic to avoid double spaces: abc [WERBEH|] def" abc [ WERBEH]|def" abc|[WERBEH ]def" abc[|WERBEH] def" All 4 should be possible, i.e. a space should be inserted. The last two don't fulfill the

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Am 03.06.2007 um 15:29 schrieb Michael Gerz: Stefan Schimanski schrieb: Slight correction of the EPM patch: there are these exceptions of the logic to avoid double spaces: abc [WERBEH|] def" abc [ WERBEH]|def" abc|[WERBEH ]def" abc[|WERBEH] def" All 4 should be possible, i.e. a space

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Dov Feldstern
Stefan Schimanski wrote: 1) In Text2.cpp, in the condition "if (cur.boundary() && !bidi.isBoundary...", it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return setCursor(cur, cur.pit(), cur.pos() + 1, true, false); (the + 1 is wrong;

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Am 03.06.2007 um 21:28 schrieb Dov Feldstern: Stefan Schimanski wrote: 1) In Text2.cpp, in the condition "if (cur.boundary() && ! bidi.isBoundary...", it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return setCursor(cur, cur.pit(),

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Dov Feldstern
Stefan Schimanski wrote: Am 03.06.2007 um 21:28 schrieb Dov Feldstern: Stefan Schimanski wrote: 1) In Text2.cpp, in the condition "if (cur.boundary() && !bidi.isBoundary...", it should be: return setCursor(cur, cur.pit(), cur.pos(), true, false); and not, as you have: return

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Dov Feldstern
Stefan Schimanski wrote: * rtlspaces.patch: There is a inconsistency between the font of spaces at RTL<->LTR boundaries. The whole space problem is discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/80783. An illustration of the current situation and the one after this patch are

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Stefan Schimanski
Am 03.06.2007 um 23:12 schrieb Dov Feldstern: Stefan Schimanski wrote: * rtlspaces.patch: There is a inconsistency between the font of spaces at RTL<->LTR boundaries. The whole space problem is discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/ 80783. An illustration of the

Re: [patch] RTL cursor display on inset edges

2007-06-03 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> But then you have a somewhat weird situation, where you're at the Dov> end of a line, and pressing delete deletes from the beginning of Dov> the next line, where the cursor "isn't". That does not seem Dov> natural to me... (Of course

Re: [patch] RTL cursor display on inset edges

2007-06-02 Thread Dov Feldstern
Stefan Schimanski wrote: Hi! I cleaned up the patches to prepare them for committing: Again there are three, which are half depending on each other. Together the RTL behavior is correct (a lyx2lyx patch is still missing to convert LyX 1.3's wrong encoding of RTL paragraphs into the new one).

Re: [patch] RTL cursor display on inset edges

2007-06-02 Thread Dov Feldstern
Stefan Schimanski wrote: Hi! I cleaned up the patches to prepare them for committing: Again there are three, which are half depending on each other. Together the RTL behavior is correct (a lyx2lyx patch is still missing to convert LyX 1.3's "wrong" encoding of RTL paragraphs into the new

Re: [patch] RTL cursor display on inset edges

2007-06-01 Thread Stefan Schimanski
Hi! I cleaned up the patches to prepare them for committing: Again there are three, which are half depending on each other. Together the RTL behavior is correct (a lyx2lyx patch is still missing to convert LyX 1.3's wrong encoding of RTL paragraphs into the new one). * rtlboundary.patch:

Re: [patch] RTL cursor display on inset edges

2007-06-01 Thread Stefan Schimanski
Hi! I cleaned up the patches to prepare them for committing: Again there are three, which are half depending on each other. Together the RTL behavior is correct (a lyx2lyx patch is still missing to convert LyX 1.3's "wrong" encoding of RTL paragraphs into the new one). *

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Jean-Marc Lasgouttes
Stefan == Stefan Schimanski [EMAIL PROTECTED] writes: Stefan I will make a clean patch tomorrow morning. It adds another Stefan return value to cursorPos which tell whether insets in deeper Stefan slices will be put to the left or right of the returned Stefan position. This is indeed one of

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
As promised, here it is. This is the way to do it. It includes our former patch for cursorLeft/Right to avoid boundary magic on RTL- boundaries. @Dov: For the example where your patch was wrong, make a selection, starting in an RTL paragraph, ending in a LTR paragraph. One of the two

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Martin Vermeer
On Wed, May 30, 2007 at 11:36:13PM +0200, Stefan Schimanski wrote: Am 30.05.2007 um 23:29 schrieb Jean-Marc Lasgouttes: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Please, could someone respond regarding this patch from Elazar? Dov It fixes issue (3) of Dov

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Jean-Marc Lasgouttes
Stefan == Stefan Schimanski [EMAIL PROTECTED] writes: Stefan As promised, here it is. This is the way to do it. It includes Stefan our former patch for cursorLeft/Right to avoid boundary magic Stefan on RTL- boundaries. A few comments: first, I am not sure I like +bool Text::isRTL(Buffer const

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: As promised, here it is. This is the way to do it. It includes our former patch for cursorLeft/Right to avoid boundary magic on RTL-boundaries. I don't understand what I'm supposed to apply this patch against. @Dov: For the example where your patch was wrong, make

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the patch file, or at line 279(?) of

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the patch file, or at line

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 21:57 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile

[patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Anyhow, to reproduce: 1) type a long long string with no space, until it breaks to the next line. 2) from the last position in the paragraph (it only works from there) start backspacing. When you try to delete the last

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:10 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Anyhow, to reproduce: 1) type a long long string with no space, until it breaks to the next line. 2) from the last position in the paragraph (it only works from there) start

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@ checkBufferStructure(cur.buffer(), cur); } - if (cur.pos() ==

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, makes sense. The character then entered should be with the font of the character at that position. Stefan --- once you're at it, should Text2.cpp:768 (in setCurrentFont) be changed: - if ((pos 0 cur.boundary()) || pos == cur.lastpos()) --pos; + if

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:54 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie)

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
For those who want to try it out (for reference please look at the single patches), here is everything together in one patch. Stefan rtl.patch Description: Binary data As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:54 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
We're redrawing the whole thing, too? Is *that* necessary after every backspace?! Everything = the paragraph. That are the rules of the games currently. I and others have ideas to speed up the drawing considerable for 1.6. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: As promised, here it is. This is the way to do it. It includes our former patch for cursorLeft/Right to avoid boundary magic on RTL-boundaries. I don't understand what I'm supposed to apply this patch against. @Dov: For the example where your patch was wrong, make

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the patch file, or at line 279(?) of

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the patch file, or at line

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile --- there's a semicolon missing on line 347 of the

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 21:57 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including another patch --- which BTW, I would still commit separately). Then it didn't compile

[patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Anyhow, to reproduce: 1) type a long long string with no space, until it breaks to the next line. 2) from the last position in the paragraph (it only works from there) start backspacing. When you try to delete the last

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:10 schrieb Dov Feldstern: Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Anyhow, to reproduce: 1) type a long long string with no space, until it breaks to the next line. 2) from the last position in the paragraph (it only works from there) start

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@ checkBufferStructure(cur.buffer(), cur); } - if (cur.pos() ==

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, makes sense. The character then entered should be with the font of the character at that position. Stefan --- once you're at it, should Text2.cpp:768 (in setCurrentFont) be changed: - if ((pos > 0 && cur.boundary()) || pos == cur.lastpos()) --pos; +

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
Am 31.05.2007 um 22:54 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie)

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
For those who want to try it out (for reference please look at the single patches), here is everything together in one patch. Stefan rtl.patch Description: Binary data As always, Stefan, you are right :) . I applied your patch (what threw me off was what you said about including

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Stefan Schimanski wrote: Am 31.05.2007 um 22:54 schrieb Dov Feldstern: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Dov Feldstern
Dov Feldstern wrote: Stefan Schimanski wrote: Am 31.05.2007 um 22:27 schrieb Stefan Schimanski: The patch: Index: src/Text.cpp === --- src/Text.cpp(Revision 18599) +++ src/Text.cpp(Arbeitskopie) @@ -1330,8 +1331,10 @@

Re: [patch] crash fix [was: Re: [patch] RTL cursor display on inset edges]

2007-05-31 Thread Stefan Schimanski
We're redrawing the whole thing, too? Is *that* necessary after every backspace?! Everything = the paragraph. That are the rules of the games currently. I and others have ideas to speed up the drawing considerable for 1.6. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> I will make a clean patch tomorrow morning. It adds another Stefan> return value to cursorPos which tell whether insets in deeper Stefan> slices will be put to the left or right of the returned Stefan> position. This is

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Stefan Schimanski
As promised, here it is. This is the way to do it. It includes our former patch for cursorLeft/Right to avoid boundary magic on RTL- boundaries. @Dov: For the example where your patch was wrong, make a selection, starting in an RTL paragraph, ending in a LTR paragraph. One of the two

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Martin Vermeer
On Wed, May 30, 2007 at 11:36:13PM +0200, Stefan Schimanski wrote: > > Am 30.05.2007 um 23:29 schrieb Jean-Marc Lasgouttes: > > >>"Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: > > > >Dov> Please, could someone respond regarding this patch from Elazar? > >Dov> It fixes issue (3) of >

Re: [patch] RTL cursor display on inset edges

2007-05-31 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> As promised, here it is. This is the way to do it. It includes Stefan> our former patch for cursorLeft/Right to avoid boundary magic Stefan> on RTL- boundaries. A few comments: first, I am not sure I like +bool

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Dov Feldstern
Please, could someone respond regarding this patch from Elazar? It fixes issue (3) of http://bugzilla.lyx.org/show_bug.cgi?id=3551, which is a regression. It works. The concept makes sense. The implementation -- well, we don't love it, but we haven't gotten any better suggestions. (The

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Please, could someone respond regarding this patch from Elazar? Dov It fixes issue (3) of Dov http://bugzilla.lyx.org/show_bug.cgi?id=3551, which is a Dov regression. Dov It works. The concept makes sense. The implementation -- well, we Dov

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread José Matos
On Wednesday 30 May 2007 22:29:12 Jean-Marc Lasgouttes wrote: Dov So please, can we have it okayed and committed? José? JMarc OK. -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Stefan Schimanski
Am 30.05.2007 um 23:29 schrieb Jean-Marc Lasgouttes: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Please, could someone respond regarding this patch from Elazar? Dov It fixes issue (3) of Dov http://bugzilla.lyx.org/show_bug.cgi?id=3551, which is a Dov regression. Dov It works. The

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Stefan Schimanski
Am 30.05.2007 um 23:32 schrieb José Matos: On Wednesday 30 May 2007 22:29:12 Jean-Marc Lasgouttes wrote: Dov So please, can we have it okayed and committed? José? JMarc OK. See my comment please. I think I have a case where the proposed solution is wrong. But I cannot implement it

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Dov Feldstern
Stefan Schimanski wrote: Am 30.05.2007 um 23:32 schrieb José Matos: On Wednesday 30 May 2007 22:29:12 Jean-Marc Lasgouttes wrote: Dov So please, can we have it okayed and committed? José? JMarc OK. See my comment please. I think I have a case where the proposed solution is wrong. But

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Dov Feldstern
Please, could someone respond regarding this patch from Elazar? It fixes issue (3) of http://bugzilla.lyx.org/show_bug.cgi?id=3551, which is a regression. It works. The concept makes sense. The implementation -- well, we don't love it, but we haven't gotten any better suggestions. (The

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Please, could someone respond regarding this patch from Elazar? Dov> It fixes issue (3) of Dov> http://bugzilla.lyx.org/show_bug.cgi?id=3551, which is a Dov> regression. Dov> It works. The concept makes sense. The implementation --

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread José Matos
On Wednesday 30 May 2007 22:29:12 Jean-Marc Lasgouttes wrote: > Dov> So please, can we have it okayed and committed? > > José? > > JMarc OK. -- José Abílio

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Stefan Schimanski
Am 30.05.2007 um 23:29 schrieb Jean-Marc Lasgouttes: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Please, could someone respond regarding this patch from Elazar? Dov> It fixes issue (3) of Dov> http://bugzilla.lyx.org/show_bug.cgi?id=3551, which is a Dov> regression. Dov> It

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Stefan Schimanski
Am 30.05.2007 um 23:32 schrieb José Matos: On Wednesday 30 May 2007 22:29:12 Jean-Marc Lasgouttes wrote: Dov> So please, can we have it okayed and committed? José? JMarc OK. See my comment please. I think I have a case where the proposed solution is wrong. But I cannot implement it

Re: [patch] RTL cursor display on inset edges

2007-05-30 Thread Dov Feldstern
Stefan Schimanski wrote: Am 30.05.2007 um 23:32 schrieb José Matos: On Wednesday 30 May 2007 22:29:12 Jean-Marc Lasgouttes wrote: Dov> So please, can we have it okayed and committed? José? JMarc OK. See my comment please. I think I have a case where the proposed solution is wrong. But

Re: [patch] RTL cursor display on inset edges

2007-05-29 Thread Dov Feldstern
Dov Feldstern wrote: Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov So, if we move Martin's test out of cursorX, we're going to have Dov to add it in 4 or 5 new places. Very good argument. Thanks for checking. Dov Finally, (a) Martin's test has been in for a

Re: [patch] RTL cursor display on inset edges

2007-05-29 Thread Dov Feldstern
Dov Feldstern wrote: Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> So, if we move Martin's test out of cursorX, we're going to have Dov> to add it in 4 or 5 new places. Very good argument. Thanks for checking. Dov> Finally, (a) Martin's test has been in

Re: [patch] RTL cursor display on inset edges

2007-05-27 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov So, if we move Martin's test out of cursorX, we're going to have Dov to add it in 4 or 5 new places. Very good argument. Thanks for checking. Dov Finally, (a) Martin's test has been in for a while (since r10513, Dov 10/2005), I don't know why

Re: [patch] RTL cursor display on inset edges

2007-05-27 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov So, if we move Martin's test out of cursorX, we're going to have Dov to add it in 4 or 5 new places. Very good argument. Thanks for checking. Dov Finally, (a) Martin's test has been in for a while (since r10513,

  1   2   >