José == José Matos [EMAIL PROTECTED] writes:
All of this make perfectly sense to me. Although Jean-Marc has left
us with some FUD (but without a given proof), I would like to
commit his patch. Could someone please give another OK?
José I would like to wait for Jean-Marc on this. Not that I
Jean-Marc Lasgouttes schrieb:
I did not manage to reproduce the problem I saw and anyway I do not
think they are introduced by the patch. Please go ahead.
Committed as
http://www.lyx.org/trac/changeset/19019
Michael
Michael == Michael Gerz [EMAIL PROTECTED] writes:
Michael Jean-Marc Lasgouttes schrieb:
I did not manage to reproduce the problem I saw and anyway I do not
think they are introduced by the patch. Please go ahead.
Committed as
Michael http://www.lyx.org/trac/changeset/19019
Thanks.
JMarc
> "José" == José Matos <[EMAIL PROTECTED]> writes:
>> All of this make perfectly sense to me. Although Jean-Marc has left
>> us with some FUD (but without a given proof), I would like to
>> commit his patch. Could someone please give another OK?
José> I would like to wait for Jean-Marc on
Jean-Marc Lasgouttes schrieb:
I did not manage to reproduce the problem I saw and anyway I do not
think they are introduced by the patch. Please go ahead.
Committed as
http://www.lyx.org/trac/changeset/19019
Michael
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> Jean-Marc Lasgouttes schrieb:
>> I did not manage to reproduce the problem I saw and anyway I do not
>> think they are introduced by the patch. Please go ahead.
>>
Committed as
Michael> http://www.lyx.org/trac/changeset/19019
Jean-Marc Lasgouttes schrieb:
Jean-Marc Something like that. I tested briefly with 3 different
Jean-Marc authors, and I think something is wrong (I think it was
Jean-Marc already wrong before, actually). I do not see how current
Jean-Marc author could always be index 0 (which is written in the
On Saturday 07 July 2007 12:34:35 Michael Gerz wrote:
Accept all changes by Mike and MG:
\tracking_changes true
\output_changes false
\author
\author
\author Michael Gerz [EMAIL PROTECTED]
Is there any reason to leave the empty authors field there?
All of this make
José Matos schrieb:
On Saturday 07 July 2007 12:34:35 Michael Gerz wrote:
Accept all changes by Mike and MG:
\tracking_changes true
\output_changes false
\author
\author
\author Michael Gerz [EMAIL PROTECTED]
Is there any reason to leave the empty authors field there?
Jean-Marc Lasgouttes schrieb:
Jean-Marc> Something like that. I tested briefly with 3 different
Jean-Marc> authors, and I think something is wrong (I think it was
Jean-Marc> already wrong before, actually). I do not see how current
Jean-Marc> author could always be index 0 (which is written in
On Saturday 07 July 2007 12:34:35 Michael Gerz wrote:
> Accept all changes by "Mike" and "MG":
>
> \tracking_changes true
> \output_changes false
> \author ""
> \author ""
> \author "Michael Gerz" [EMAIL PROTECTED]
Is there any reason to leave the empty authors field there?
> All of
José Matos schrieb:
On Saturday 07 July 2007 12:34:35 Michael Gerz wrote:
Accept all changes by "Mike" and "MG":
\tracking_changes true
\output_changes false
\author ""
\author ""
\author "Michael Gerz" [EMAIL PROTECTED]
Is there any reason to leave the empty authors
Jean-Marc,
Jean-Marc Something like that.
Great. Very compact and non-intrusive patch!
Jean-Marc I tested briefly with 3 different
Jean-Marc authors, and I think something is wrong (I think it was
Jean-Marc already wrong before, actually). I do not see how current
Jean-Marc author could
Jean-Marc,
Jean-Marc> Something like that.
Great. Very compact and non-intrusive patch!
Jean-Marc> I tested briefly with 3 different
Jean-Marc> authors, and I think something is wrong (I think it was
Jean-Marc> already wrong before, actually). I do not see how current
Jean-Marc> author could
Michael == Michael Gerz [EMAIL PROTECTED] writes:
Michael Jean-Marc Lasgouttes schrieb:
http://bugzilla.lyx.org/show_bug.cgi?id=3764
I do not like this patch very much, actually %-| The name
AuthorActive is ugly, the class definition in Author.h is weird
(but better IMO than including map
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Jean-Marc A const method should return a const object. If you want to
Jean-Marc go this route, the best may be to declare 'used_' as
Jean-Marc mutable.
Something like that. I tested briefly with 3 different authors, and I
think
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Jean-Marc A const method should return a const object. If you want to
Jean-Marc go this route, the best may be to declare 'used_' as
Jean-Marc mutable.
Jean-Marc Something
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> Jean-Marc Lasgouttes schrieb:
>> http://bugzilla.lyx.org/show_bug.cgi?id=3764
>>
>> I do not like this patch very much, actually %-| The name
>> AuthorActive is ugly, the class definition in Author.h is weird
>> (but better IMO
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> A const method should return a const object. If you want to
Jean-Marc> go this route, the best may be to declare 'used_' as
Jean-Marc> mutable.
Something like that. I tested briefly with 3 different authors, and I
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> A const method should return a const object. If you want to
Jean-Marc> go this route, the best may be to declare 'used_' as
Jean-Marc> mutable.
http://bugzilla.lyx.org/show_bug.cgi?id=3764
This is an important privacy bug, that should be fixed before 1..50
IMO. In the following patch, I tried to be as unintrusive as possible.
The idea is that before writing the buffer params, the whole document
is scanned to determine what are the
Jean-Marc Lasgouttes schrieb:
http://bugzilla.lyx.org/show_bug.cgi?id=3764
This is an important privacy bug, that should be fixed before 1..50
IMO. In the following patch, I tried to be as unintrusive as possible.
Jean-Marc, thank you very much for stepping forward!
The
other authors of
Michael == Michael Gerz [EMAIL PROTECTED] writes:
Michael Jean-Marc, thank you very much for stepping forward!
I had the impression that nobody was going to do it :)
Michael A consequence of this patch is that the list of authors grows
Michael with every load-buffer-save-buffer cycle. Luckily,
Jean-Marc Lasgouttes schrieb:
What do you mean? That it is saved in the file with id 0 for all his
changes? Then I do not understand what happens when somebody else
edits the file... This is precisely an area I do not understand.
The active user (i.e. the one running LyX) always has author id
http://bugzilla.lyx.org/show_bug.cgi?id=3764
This is an important privacy bug, that should be fixed before 1..50
IMO. In the following patch, I tried to be as unintrusive as possible.
The idea is that before writing the buffer params, the whole document
is scanned to determine what are the
Jean-Marc Lasgouttes schrieb:
http://bugzilla.lyx.org/show_bug.cgi?id=3764
This is an important privacy bug, that should be fixed before 1..50
IMO. In the following patch, I tried to be as unintrusive as possible.
Jean-Marc, thank you very much for stepping forward!
The
other authors of
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> Jean-Marc, thank you very much for stepping forward!
I had the impression that nobody was going to do it :)
Michael> A consequence of this patch is that the list of authors grows
Michael> with every load-buffer-save-buffer
Jean-Marc Lasgouttes schrieb:
What do you mean? That it is saved in the file with id 0 for all his
changes? Then I do not understand what happens when somebody else
edits the file... This is precisely an area I do not understand.
The active user (i.e. the one running LyX) always has author id
Michael Gerz wrote:
Pavel Sanda schrieb:
In contrary, my resources are limited at the moment.
the quick fix is below.
I think this is a good work-around for the time being (i.e. 1.5rc2).
I don't think so, IMHO this hack causes more harm than good:
It affects only new users, not
Michael Gerz wrote:
> Pavel Sanda schrieb:
>>> In contrary, my resources are limited at the moment.
>>>
>>
>> the quick fix is below.
>>
> I think this is a good work-around for the time being (i.e. 1.5rc2).
I don't think so, IMHO this hack causes more harm than good:
It affects only new
In contrary, my resources are limited at the moment.
the quick fix is below.
Setting the user name to anonymous may be a good solution for the time being
(at least for 1.5rc2) provided that we can change back to the old settings at
no cost later.
afaik the current situation is :
1. user
Pavel Sanda schrieb:
In contrary, my resources are limited at the moment.
the quick fix is below.
I think this is a good work-around for the time being (i.e. 1.5rc2).
If I get another OK, I will commit. As soon as we have a better
solution, I am going to revert the quick fix.
On Tuesday 19 June 2007 21:58:16 Michael Gerz wrote:
If I get another OK, I will commit. As soon as we have a better
solution, I am going to revert the quick fix.
Michael
OK.
--
José Abílio
> In contrary, my resources are limited at the moment.
the quick fix is below.
> Setting the user name to anonymous may be a good solution for the time being
> (at least for 1.5rc2) provided that we can change back to the old settings at
> no cost later.
afaik the current situation is :
1.
Pavel Sanda schrieb:
In contrary, my resources are limited at the moment.
the quick fix is below.
I think this is a good work-around for the time being (i.e. 1.5rc2).
If I get another OK, I will commit. As soon as we have a better
solution, I am going to revert the quick fix.
On Tuesday 19 June 2007 21:58:16 Michael Gerz wrote:
> If I get another OK, I will commit. As soon as we have a better
> solution, I am going to revert the quick fix.
>
> Michael
OK.
--
José Abílio
Any comments or suggestions for a better solution?
Michael, what if we just change the code inside userinfo.cpp instead of
intricating CT code ?
the solution could be that the user_name/mail() will return eg Anonymous by
default. later (1.5.1 or so) - lyx initialization could be supplied by
Michael, what if we just change the code inside userinfo.cpp instead of
intricating CT code ?
the solution could be that the user_name/mail() will return eg
Anonymous by default.
I have some ideas on how to fix the problem without changing the file format.
In any case (with or without
> > Any comments or suggestions for a better solution?
Michael, what if we just change the code inside userinfo.cpp instead of
intricating CT code ?
the solution could be that the user_name/mail() will return eg "Anonymous" by
default. later (1.5.1 or so) - lyx initialization could be supplied
> Michael, what if we just change the code inside userinfo.cpp instead of
> intricating CT code ?
> the solution could be that the user_name/mail() will return eg
> "Anonymous" by default.
I have some ideas on how to fix the problem without changing the file format.
In any case (with or
Jean-Marc Lasgouttes schrieb:
Michael In the LyX document header, we have to list all authors for
Michael which a change is tracked in the document. That means that we
Michael have to iterate through the complete document and check
Michael whether there is any change for a given author whenever
Michael Gerz schrieb:
Jean-Marc Lasgouttes schrieb:
Michael In the LyX document header, we have to list all authors for
Michael which a change is tracked in the document. That means that we
Michael have to iterate through the complete document and check
Michael whether there is any change for a
Question: Would it be possible to change the file format at this stage
of development? E.g., to
i remember jose has written somewhere that yes. fileformat cant be changed
only after 1.5.0 is out to maintain 1.5.x series stable.
Any comments or suggestions for a better solution?
just two
Jean-Marc Lasgouttes schrieb:
Michael> In the LyX document header, we have to list all authors for
Michael> which a change is tracked in the document. That means that we
Michael> have to iterate through the complete document and check
Michael> whether there is any change for a given author
Michael Gerz schrieb:
Jean-Marc Lasgouttes schrieb:
Michael> In the LyX document header, we have to list all authors for
Michael> which a change is tracked in the document. That means that we
Michael> have to iterate through the complete document and check
Michael> whether there is any change
> Question: Would it be possible to change the file format at this stage
> of development? E.g., to
i remember jose has written somewhere that yes. fileformat cant be changed
only after 1.5.0 is out to maintain 1.5.x series stable.
> Any comments or suggestions for a better solution?
just two
Michael Gerz schrieb:
Juergen Spitzmueller schrieb:
Michael Gerz wrote:
You can have changes in a document even if change tracking is
deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
But the possibility to hide author information is a must. This is a
Michael == Michael Gerz [EMAIL PROTECTED] writes:
Michael In the LyX document header, we have to list all authors for
Michael which a change is tracked in the document. That means that we
Michael have to iterate through the complete document and check
Michael whether there is any change for a
Michael Gerz schrieb:
Juergen Spitzmueller schrieb:
Michael Gerz wrote:
You can have changes in a document even if change tracking is
deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
But the possibility to hide author information is a must. This is a
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:
Michael> In the LyX document header, we have to list all authors for
Michael> which a change is tracked in the document. That means that we
Michael> have to iterate through the complete document and check
Michael> whether there is any
Veto!
You can have changes in a document even if change tracking is deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
Michael
Pavel Sanda schrieb:
Hi,
the following patch add author info to .lyx file only if change tracking is
enabled
(
Michael Gerz wrote:
You can have changes in a document even if change tracking is deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
But the possibility to hide author information is a must. This is a serious
security hole.
Jürgen
Juergen Spitzmueller schrieb:
Michael Gerz wrote:
You can have changes in a document even if change tracking is deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
But the possibility to hide author information is a must. This is a serious
security hole.
Michael Gerz [EMAIL PROTECTED] writes:
| Juergen Spitzmueller schrieb:
| Michael Gerz wrote:
|
|
| You can have changes in a document even if change tracking is deactivated!
|
| (We no longer have the enervating restriction of the 1.4.X series)
|
|
| But the possibility to hide author
Veto!
You can have changes in a document even if change tracking is deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
Michael
Pavel Sanda schrieb:
Hi,
the following patch add author info to .lyx file only if change tracking is
enabled
(
Michael Gerz wrote:
> You can have changes in a document even if change tracking is deactivated!
>
> (We no longer have the enervating restriction of the 1.4.X series)
But the possibility to hide author information is a must. This is a serious
security hole.
Jürgen
Juergen Spitzmueller schrieb:
Michael Gerz wrote:
You can have changes in a document even if change tracking is deactivated!
(We no longer have the enervating restriction of the 1.4.X series)
But the possibility to hide author information is a must. This is a serious
security hole.
Michael Gerz <[EMAIL PROTECTED]> writes:
| Juergen Spitzmueller schrieb:
| > Michael Gerz wrote:
| >
| >
| >> You can have changes in a document even if change tracking is deactivated!
| >>
| >> (We no longer have the enervating restriction of the 1.4.X series)
| >>
| >
| > But the possibility to
Hi,
the following patch add author info to .lyx file only if change tracking is
enabled
( http://bugzilla.lyx.org/show_bug.cgi?id=3764 ).
Pavel
--- work/lyx-1.5.0beta3/src/BufferParams.cpp2007-05-12 02:22:37.0
+0200
+++ /trash/lyx-1.5.0beta3/src/BufferParams.cpp 2007-05-30
Hi,
the following patch add author info to .lyx file only if change tracking is
enabled
( http://bugzilla.lyx.org/show_bug.cgi?id=3764 ).
Pavel
--- work/lyx-1.5.0beta3/src/BufferParams.cpp2007-05-12 02:22:37.0
+0200
+++ /trash/lyx-1.5.0beta3/src/BufferParams.cpp 2007-05-30
60 matches
Mail list logo
