Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-10-04 Thread Jürgen Spitzmüller
Am Dienstag, dem 03.10.2023 um 14:13 +0200 schrieb Jean-Marc Lasgouttes: > I implemented the color change for local math selections. I notice > right now that I missed the case of multiple cell selection. I'll > have a look. Thanks. > > So I would have to put your patch on top of that, and

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-10-03 Thread Jean-Marc Lasgouttes
Le 30/09/2023 à 15:23, Jürgen Spitzmüller a écrit : Am Freitag, dem 29.09.2023 um 15:53 +0200 schrieb Jürgen Spitzmüller: And it only works for fully selected math insets, not for parts of it. Don't know where to set the latter. The issue here is, probably, that Math is missing something like

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-30 Thread Jürgen Spitzmüller
Am Freitag, dem 29.09.2023 um 15:53 +0200 schrieb Jürgen Spitzmüller: > And it only works for fully selected math insets, not for parts of > it. Don't know where to set the latter. The issue here is, probably, that Math is missing something like RowPainter::paintStringAndSel() which accounts for,

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-30 Thread Jürgen Spitzmüller
Am Freitag, dem 29.09.2023 um 20:30 +0200 schrieb Jean-Marc Lasgouttes: > How can I switch to dark mode. Switching Ubuntu to dark mode does not > seem to be enough and I did not find the switch in our prefs. Don't know Ubuntu's adaptations, but in stock GNOME, LyX responds to the mode switch in

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-30 Thread Jürgen Spitzmüller
Am Freitag, dem 29.09.2023 um 18:15 +0200 schrieb Jean-Marc Lasgouttes: > What makes you think that it is safer to introduce a new color ?  Because it only touches dark mode math selection, This is where the new color applies. Also, I don't think math and text should be forced to have the same

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Richard Kimberly Heck
On 9/29/23 15:22, Scott Kostyshak wrote: On Fri, Sep 29, 2023 at 08:30:14PM +0200, Jean-Marc Lasgouttes wrote: Le 29/09/2023 à 15:53, Jürgen Spitzmüller a écrit : Am Freitag, dem 29.09.2023 um 15:11 +0200 schrieb Jürgen Spitzmüller: Or maybe introduce a Color_selectionmath. I think this could

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Scott Kostyshak
On Fri, Sep 29, 2023 at 08:30:14PM +0200, Jean-Marc Lasgouttes wrote: > Le 29/09/2023 à 15:53, Jürgen Spitzmüller a écrit : > > Am Freitag, dem 29.09.2023 um 15:11 +0200 schrieb Jürgen Spitzmüller: > > > Or maybe introduce a Color_selectionmath. I think this could be > > > easily implemented for

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Jean-Marc Lasgouttes
Le 29/09/2023 à 15:53, Jürgen Spitzmüller a écrit : Am Freitag, dem 29.09.2023 um 15:11 +0200 schrieb Jürgen Spitzmüller: Or maybe introduce a Color_selectionmath. I think this could be easily implemented for 2.4 without having to fear collateral effects. Like this. Involves a new string,

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Daniel
On 2023-09-29 15:53, Jürgen Spitzmüller wrote: Am Freitag, dem 29.09.2023 um 15:11 +0200 schrieb Jürgen Spitzmüller: Or maybe introduce a Color_selectionmath. I think this could be easily implemented for 2.4 without having to fear collateral effects. Like this. Involves a new string, tough.

Re: [RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Jean-Marc Lasgouttes
Le 29/09/2023 à 15:53, Jürgen Spitzmüller a écrit : Am Freitag, dem 29.09.2023 um 15:11 +0200 schrieb Jürgen Spitzmüller: Or maybe introduce a Color_selectionmath. I think this could be easily implemented for 2.4 without having to fear collateral effects. Like this. Involves a new string,

[RFC Riki!] Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Jürgen Spitzmüller
Am Freitag, dem 29.09.2023 um 15:11 +0200 schrieb Jürgen Spitzmüller: > Or maybe introduce a Color_selectionmath. I think this could be > easily implemented for 2.4 without having to fear collateral effects. Like this. Involves a new string, tough. And it only works for fully selected math

Re: Highlighted math in dark mode is hard to see

2023-09-29 Thread Jürgen Spitzmüller
Am Samstag, dem 23.09.2023 um 21:21 +0200 schrieb Daniel: > Is there a reason why the "selected text" color is not applied to > maths? > Changing that would solve the problem since this color is visible on > a > "selection" background. (I guess that is its point.) Or maybe introduce a

Re: Highlighted math in dark mode is hard to see

2023-09-23 Thread Jean-Marc Lasgouttes
Le 23/09/2023 à 21:21, Daniel a écrit : On 2023-09-23 20:09, Scott Kostyshak wrote: Is there a reason why the "selected text" color is not applied to maths? Changing that would solve the problem since this color is visible on a "selection" background. (I guess that is its point.) No, it

Re: Highlighted math in dark mode is hard to see

2023-09-23 Thread Daniel
On 2023-09-23 20:09, Scott Kostyshak wrote: On Sat, Sep 23, 2023 at 07:34:29PM +0200, Dan wrote: You mean to change the math color without selection also? Perhaps. I'm new to dark theme, so I don't know. I do really like the current math color; it's just the selection issues. Scott

Re: Highlighted math in dark mode is hard to see

2023-09-23 Thread Scott Kostyshak
On Sat, Sep 23, 2023 at 07:34:29PM +0200, Dan wrote: > > > > You mean to change the math color without selection also? Perhaps. I'm new > > to dark theme, so I don't know. I do really like the current math color; > > it's just the selection issues. > > > > Scott > > > Definitely the "math

Re: Highlighted math in dark mode is hard to see

2023-09-23 Thread Dan
> You mean to change the math color without selection also? Perhaps. I'm new to > dark theme, so I don't know. I do really like the current math color; it's > just the selection issues. > > Scott > Definitely the "math text" colour is pretty nice, but I think it is easier (and less prone to

Re: Highlighted math in dark mode is hard to see

2023-09-23 Thread Scott Kostyshak
On Sat, Sep 23, 2023 at 06:30:51PM +0200, Dan wrote: > > > > See attached screenshot, taken from the Math manual. Any highlighted > > math is hard to see. Is it the same for others on dark mode? > > > > Scott > > > Yes, I have the same problem, but only if I use the default palette of >

Re: Highlighted math in dark mode is hard to see

2023-09-23 Thread Dan
> See attached screenshot, taken from the Math manual. Any highlighted > math is hard to see. Is it the same for others on dark mode? > > Scott > Yes, I have the same problem, but only if I use the default palette of colours. When using the colours from the system's theme (LinuxMint 21.2 with