Re: [LyX/master] InsetGraphics: use totalheight for height output

On Wed, Aug 28, 2019 at 07:28:43AM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, den 27.08.2019, 21:34 -0400 schrieb Scott Kostyshak: > > A git bisect led me here. I think this commit broke the lyx2lyx > > convergence tests for ja/Intro.lyx. To reproduce manually, do the > > following for the

Re: [LyX/master] InsetGraphics: use totalheight for height output

Am Dienstag, den 27.08.2019, 21:34 -0400 schrieb Scott Kostyshak: > A git bisect led me here. I think this commit broke the lyx2lyx > convergence tests for ja/Intro.lyx. To reproduce manually, do the > following for the Japanese Intro.lyx file: Should be fixed. Jürgen signature.asc

Re: [LyX/master] InsetGraphics: use totalheight for height output

On Wed, Aug 14, 2019 at 04:48:58PM +0200, Juergen Spitzmueller wrote: > commit 4b0069860c4ac54aff09627582c6f5da7aa9020c > Author: Juergen Spitzmueller > Date: Wed Aug 14 16:55:43 2019 +0200 > > InsetGraphics: use totalheight for height output > > Grap

Re: Remove InsetGraphics noUnzip

Jean-Marc Lasgouttes wrote: Le 17/07/2015 18:57, Pavel Sanda a écrit : Scott Kostyshak wrote: On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda sa...@lyx.org wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What

Re: Remove InsetGraphics noUnzip

Jean-Marc Lasgouttes wrote: > Le 17/07/2015 18:57, Pavel Sanda a écrit : >> Scott Kostyshak wrote: >>> On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: Jean-Marc Lasgouttes wrote: > I think you should remove it. Are people really still using EPS files > anyway?

Re: Remove InsetGraphics noUnzip

Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What vector format do you use for submitting papers? P

Re: Remove InsetGraphics noUnzip

Scott Kostyshak wrote: On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda sa...@lyx.org wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What vector format do you use for submitting papers? PDF. Funny, couple

Re: Remove InsetGraphics noUnzip

On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda sa...@lyx.org wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What vector format do you use for submitting papers? PDF. Scott

Re: Remove InsetGraphics noUnzip

On Fri, Jul 17, 2015 at 12:57 PM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda sa...@lyx.org wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What

Re: Remove InsetGraphics noUnzip

Le 17/07/2015 18:57, Pavel Sanda a écrit : Scott Kostyshak wrote: On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda sa...@lyx.org wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What vector format do you use for

Re: Remove InsetGraphics noUnzip

Jean-Marc Lasgouttes wrote: > I think you should remove it. Are people really still using EPS files > anyway? Major for me. What vector format do you use for submitting papers? P

Re: Remove InsetGraphics noUnzip

On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: >> I think you should remove it. Are people really still using EPS files >> anyway? > > Major for me. What vector format do you use for submitting papers? PDF. Scott

Re: Remove InsetGraphics noUnzip

Scott Kostyshak wrote: > On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: > > Jean-Marc Lasgouttes wrote: > >> I think you should remove it. Are people really still using EPS files > >> anyway? > > > > Major for me. What vector format do you use for submitting papers? > > PDF.

Re: Remove InsetGraphics noUnzip

On Fri, Jul 17, 2015 at 12:57 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: >> > Jean-Marc Lasgouttes wrote: >> >> I think you should remove it. Are people really still using EPS files >> >> anyway? >> > >> >

Re: Remove InsetGraphics noUnzip

Le 17/07/2015 18:57, Pavel Sanda a écrit : Scott Kostyshak wrote: On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What vector format do you use for

Re: Remove InsetGraphics noUnzip

Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? I do occasionally (but these are really special cases, they are hand programmed). Fortunately after the removal of noUnzip EPS is just one of many supported formats, we do not need to

Re: Remove InsetGraphics noUnzip

Jean-Marc Lasgouttes wrote: > I think you should remove it. Are people really still using EPS files > anyway? I do occasionally (but these are really special cases, they are hand programmed). Fortunately after the removal of noUnzip EPS is just one of many supported formats, we do not need to

Remove InsetGraphics noUnzip

Hi, InsetGraphics has a parameter noUnzip. If this is set, and the included image is a compressed eps, then LyX does not unzip it when producing a DVI. Instead, the LaTeX compiler gets the bounding box information, and the .eps file stays compresssed. Only when the DVi is viewed, the viewer

Re: Remove InsetGraphics noUnzip

Le 15/07/2015 22:04, Georg Baum a écrit : InsetGraphics has a parameter noUnzip. If this is set, and the included image is a compressed eps, then LyX does not unzip it when producing a DVI. Instead, the LaTeX compiler gets the bounding box information, and the .eps file stays compresssed. Only

Remove InsetGraphics noUnzip

Hi, InsetGraphics has a parameter noUnzip. If this is set, and the included image is a compressed eps, then LyX does not unzip it when producing a DVI. Instead, the LaTeX compiler gets the bounding box information, and the .eps file stays compresssed. Only when the DVi is viewed, the viewer

Re: Remove InsetGraphics noUnzip

Le 15/07/2015 22:04, Georg Baum a écrit : InsetGraphics has a parameter noUnzip. If this is set, and the included image is a compressed eps, then LyX does not unzip it when producing a DVI. Instead, the LaTeX compiler gets the bounding box information, and the .eps file stays compresssed. Only

Re: [PATCH] InsetGraphics: add a layoutName method

Le 25/03/2013 22:19, Richard Heck a écrit : Actually, I should figure this out, because it would make it possible to put the CSS for InsetTOC into an InsetLayout for TOC, which would then be included only when it was needed. As it is now, it has to be included no matter what. Yes, it would be

Re: [PATCH] InsetGraphics: add a layoutName method

Le 25/03/2013 22:19, Richard Heck a écrit : Actually, I should figure this out, because it would make it possible to put the CSS for InsetTOC into an InsetLayout for TOC, which would then be included only when it was needed. As it is now, it has to be included no matter what. Yes, it would be

Re: [PATCH] InsetGraphics: add a layoutName method

Le 23/03/2013 07:04, Pavel Sanda a écrit : Scott Kostyshak wrote: Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :) I do not know what InsetLayout parameters would make sense to change, and whether InsetGraphics honor them. What trick

Re: [PATCH] InsetGraphics: add a layoutName method

, and whether InsetGraphics honor them. What trick would you like? I think InsetGraphics could honor such settings, though I am not absolutely sure. At one point, only Text insets would recognize anything in InsetLayout, but I seem to remember we fixed this. Actually, I should figure this out

Re: [PATCH] InsetGraphics: add a layoutName method

Jean-Marc Lasgouttes wrote: I do not know what InsetLayout parameters would make sense to change, and whether InsetGraphics honor them. What trick would you like? I was just curious, no particular need. Pavel

Re: [PATCH] InsetGraphics: add a layoutName method

Le 23/03/2013 07:04, Pavel Sanda a écrit : Scott Kostyshak wrote: Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :) I do not know what InsetLayout parameters would make sense to change, and whether InsetGraphics honor them. What trick

Re: [PATCH] InsetGraphics: add a layoutName method

, and whether InsetGraphics honor them. What trick would you like? I think InsetGraphics could honor such settings, though I am not absolutely sure. At one point, only Text insets would recognize anything in InsetLayout, but I seem to remember we fixed this. Actually, I should figure this out

Re: [PATCH] InsetGraphics: add a layoutName method

Jean-Marc Lasgouttes wrote: > I do not know what InsetLayout parameters would make sense to change, and > whether InsetGraphics honor them. What trick would you like? I was just curious, no particular need. Pavel

Re: [PATCH] InsetGraphics: add a layoutName method

Scott Kostyshak wrote: Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :) Pavel

Re: [PATCH] InsetGraphics: add a layoutName method

On Sat, Mar 23, 2013 at 2:04 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :) It's in at 8831e4a1. I don't know much about layout files. What kind of magic do you have in mind?

Re: [PATCH] InsetGraphics: add a layoutName method

Scott Kostyshak wrote: On Sat, Mar 23, 2013 at 2:04 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :) It's in at 8831e4a1. I don't know much about layout files. What kind

Re: [PATCH] InsetGraphics: add a layoutName method

On Sat, Mar 23, 2013 at 6:47 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: On Sat, Mar 23, 2013 at 2:04 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :)

Re: [PATCH] InsetGraphics: add a layoutName method

Scott Kostyshak wrote: > Can this go in? Looks reasonable. Can we do some new magic with graphic inset via layout files now? :) Pavel

Re: [PATCH] InsetGraphics: add a layoutName method

On Sat, Mar 23, 2013 at 2:04 AM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> Can this go in? > > Looks reasonable. Can we do some new magic with graphic inset via layout > files now? :) It's in at 8831e4a1. I don't know much about layout files. What kind of magic do you have

Re: [PATCH] InsetGraphics: add a layoutName method

Scott Kostyshak wrote: > On Sat, Mar 23, 2013 at 2:04 AM, Pavel Sanda wrote: > > Scott Kostyshak wrote: > >> Can this go in? > > > > Looks reasonable. Can we do some new magic with graphic inset via layout > > files now? :) > > It's in at 8831e4a1. I don't know much about layout

Re: [PATCH] InsetGraphics: add a layoutName method

On Sat, Mar 23, 2013 at 6:47 AM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> On Sat, Mar 23, 2013 at 2:04 AM, Pavel Sanda wrote: >> > Scott Kostyshak wrote: >> >> Can this go in? >> > >> > Looks reasonable. Can we do some new magic with graphic inset via layout

[PATCH] InsetGraphics: add a layoutName method

Now when using inset-forall, Graphics can be used to refer to all Graphics insets. --- src/insets/InsetGraphics.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/insets/InsetGraphics.h b/src/insets/InsetGraphics.h index a6e6ce3..d29194a 100644 --- a/src/insets/InsetGraphics.h +++

Re: [PATCH] InsetGraphics: add a layoutName method

On Fri, Mar 22, 2013 at 3:14 PM, Scott Kostyshak skost...@lyx.org wrote: Now when using inset-forall, Graphics can be used to refer to all Graphics insets. --- src/insets/InsetGraphics.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/insets/InsetGraphics.h

Re: [PATCH] InsetGraphics: add a layoutName method

Scott Kostyshak wrote: +++ b/src/insets/InsetGraphics.h @@ -87,6 +87,8 @@ private: /// returns LyX code associated with the inset. Used for TOC, ...) InsetCode lyxCode() const { return GRAPHICS_CODE; } /// Get the inset parameters, used by the GUIndependent

[PATCH] InsetGraphics: add a layoutName method

Now when using inset-forall, Graphics can be used to refer to all Graphics insets. --- src/insets/InsetGraphics.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/insets/InsetGraphics.h b/src/insets/InsetGraphics.h index a6e6ce3..d6ccfe2 100644 --- a/src/insets/InsetGraphics.h +++

Re: [PATCH] InsetGraphics: add a layoutName method

On Fri, Mar 22, 2013 at 8:54 PM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: +++ b/src/insets/InsetGraphics.h @@ -87,6 +87,8 @@ private: /// returns LyX code associated with the inset. Used for TOC, ...) InsetCode lyxCode() const { return GRAPHICS_CODE; }

[PATCH] InsetGraphics: add a layoutName method

Now when using inset-forall, "Graphics" can be used to refer to all Graphics insets. --- src/insets/InsetGraphics.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/insets/InsetGraphics.h b/src/insets/InsetGraphics.h index a6e6ce3..d29194a 100644 --- a/src/insets/InsetGraphics.h +++

Re: [PATCH] InsetGraphics: add a layoutName method

On Fri, Mar 22, 2013 at 3:14 PM, Scott Kostyshak wrote: > Now when using inset-forall, "Graphics" can be used > to refer to all Graphics insets. > --- > src/insets/InsetGraphics.h |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/insets/InsetGraphics.h

Re: [PATCH] InsetGraphics: add a layoutName method

Scott Kostyshak wrote: > > +++ b/src/insets/InsetGraphics.h > > @@ -87,6 +87,8 @@ private: > > /// returns LyX code associated with the inset. Used for TOC, ...) > > InsetCode lyxCode() const { return GRAPHICS_CODE; } > > /// Get the inset parameters, used by the

[PATCH] InsetGraphics: add a layoutName method

Now when using inset-forall, "Graphics" can be used to refer to all Graphics insets. --- src/insets/InsetGraphics.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/insets/InsetGraphics.h b/src/insets/InsetGraphics.h index a6e6ce3..d6ccfe2 100644 --- a/src/insets/InsetGraphics.h +++

Re: [PATCH] InsetGraphics: add a layoutName method

On Fri, Mar 22, 2013 at 8:54 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> > +++ b/src/insets/InsetGraphics.h >> > @@ -87,6 +87,8 @@ private: >> > /// returns LyX code associated with the inset. Used for TOC, ...) >> > InsetCode lyxCode() const { return

[HELP] XHTML for InsetGraphics

What needs doing here is pretty simple: If necessary, we convert the image to a format acceptable for HTML (png, I guess) and deposit it wherever it needs to be; then we write an image tag. I see more or less how the conversion can be done, but I'm wondering if anyone has any helpful ideas

[HELP] XHTML for InsetGraphics

What needs doing here is pretty simple: If necessary, we convert the image to a format acceptable for HTML (png, I guess) and deposit it wherever it needs to be; then we write an image tag. I see more or less how the conversion can be done, but I'm wondering if anyone has any helpful ideas

Re: InsetGraphics groups #3

LFUN_GRAPHICS_GROUPS_UNIFY: { + LASSERT(lyx_view_, /**/); + if (argument.empty()) break; + + view()-cursor().recordUndoFullDocument(); + + InsetGraphicsParams params; + InsetGraphics::string2params

Re: InsetGraphics groups #3

Pavel Sanda wrote: now we need somehow to allow the user to assign picture to the existing group and i'm not sure how to proceed here. i see two possibilities: 1. modify how the context menu works, so we have dynamically created and shown list of groups for each call of context menu.

Re: InsetGraphics groups #3

2. i have problem with update flags - setting updateFlags = Update::Force | Update::FitCursor; is not enough to render properly scrollbar and begining of a document in case graphics is resized (it may be bug, see http://bugzilla.lyx.org/show_bug.cgi?id=4829 ). what should i

Re: InsetGraphics groups #3

: case LFUN_BUFFER_LANGUAGE: case LFUN_TEXTCLASS_APPLY: case LFUN_TEXTCLASS_LOAD: @@ -1462,6 +1463,33 @@ void LyXFunc::dispatch(FuncRequest const & cmd) break; } + case LFUN_GRAPHICS_GROUPS_UNIFY: { +

Re: InsetGraphics groups #3

Pavel Sanda wrote: now we need somehow to allow the user to assign picture to the existing group and i'm not sure how to proceed here. i see two possibilities: 1. modify how the context menu works, so we have dynamically created and shown list of groups for each call of context menu.

Re: InsetGraphics groups #3

>> 2. i have problem with update flags - setting updateFlags = Update::Force >> | Update::FitCursor; >>is not enough to render properly scrollbar and begining of a document >> in case graphics >>is resized (it may be bug, see >> http://bugzilla.lyx.org/show_bug.cgi?id=4829 ). >>what

InsetGraphics groups #2

; + InsetGraphics::string2params(argument, *lyx_view_-buffer(), params); + //InsetGraphics::unifyGraphicsGroups(*lyx_view_-buffer(), argument); + + Inset inset = lyx_view_-buffer()-inset(); + InsetIterator

InsetGraphics groups #2

InsetGraphicsParams params; + InsetGraphics::string2params(argument, *lyx_view_->buffer(), params); + //InsetGraphics::unifyGraphicsGroups(*lyx_view_->buffer(), argument); + + Inset & inset = lyx_view_->buffer()->

Re: [patch] InsetGraphics Safety

On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: This patch prevents InsetGraphics from being created without a Buffer. Comments? General direction is ok. Note that a private (class) static function could as well be a freestanding (anonymous/static) function in the cpp

Re: [patch] InsetGraphics Safety

Andre Poenitz wrote: On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: This patch prevents InsetGraphics from being created without a Buffer. Comments? General direction is ok. It seems like doing this across the board would solve a lot of these buffer pointer crashes

Re: [patch] InsetGraphics Safety

On Tue, Mar 25, 2008 at 12:15:12PM -0400, rgheck wrote: Andre Poenitz wrote: On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: This patch prevents InsetGraphics from being created without a Buffer. Comments? General direction is ok. It seems like doing this across

Re: [patch] InsetGraphics Safety

On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: > > This patch prevents InsetGraphics from being created without a Buffer. > Comments? General direction is ok. Note that a private (class) static function could as well be a freestanding (anonymous/static) function i

Re: [patch] InsetGraphics Safety

Andre Poenitz wrote: On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: This patch prevents InsetGraphics from being created without a Buffer. Comments? General direction is ok. It seems like doing this across the board would solve a lot of these buffer pointer crashes

Re: [patch] InsetGraphics Safety

On Tue, Mar 25, 2008 at 12:15:12PM -0400, rgheck wrote: > Andre Poenitz wrote: >> On Tue, Mar 25, 2008 at 01:38:06AM -0400, rgheck wrote: >> >>> This patch prevents InsetGraphics from being created without a Buffer. >>> Comments? >>> >> >

[patch] InsetGraphics Safety

This patch prevents InsetGraphics from being created without a Buffer. Comments? rh Index: src/CutAndPaste.cpp === --- src/CutAndPaste.cpp (revision 23930) +++ src/CutAndPaste.cpp (working copy) @@ -859,7 +859,7 @@ return

[patch] InsetGraphics Safety

This patch prevents InsetGraphics from being created without a Buffer. Comments? rh Index: src/CutAndPaste.cpp === --- src/CutAndPaste.cpp (revision 23930) +++ src/CutAndPaste.cpp (working copy) @@ -859,7 +859,7 @@ return

Problems in InsetGraphics linked to Embedded file support (was Re: trunk doesn't load the user manual)

Stefan Schimanski wrote: The paths are still absolute in \includegraphics. I have a path for the lyx file with a dot: ~/Arbeit/thesis.lyx. The . shows up as \lyxdot in the \includegraphics output. But \lyxdot is not defined. Shouldn't those paths be relative? I believe you are right yes.

Problems in InsetGraphics linked to Embedded file support (was Re: trunk doesn't load the user manual)

Stefan Schimanski wrote: The paths are still absolute in \includegraphics. I have a path for the lyx file with a dot: ~/Arbeit/thesis.lyx. The . shows up as \lyxdot in the \includegraphics output. But \lyxdot is not defined. Shouldn't those paths be relative? I believe you are right yes.

[Emdedding patch 5]: Allow InsetGraphics and InsetExternal to handle embedded file.

. When InsetGraphics (or InsetExternal) is loaded, a filename is read, which is the external filename. This patch then checks with embeddedFiles() and get the 'available file', which is determined by embedding status and the availability of embedded and external files. For example, if the embedding

[Emdedding patch 5]: Allow InsetGraphics and InsetExternal to handle embedded file.

. When InsetGraphics (or InsetExternal) is loaded, a filename is read, which is the external filename. This patch then checks with embeddedFiles() and get the 'available file', which is determined by embedding status and the availability of embedded and external files. For example, if the embedding

Re: [PATCH 13x] insetgraphics

On Fri, Jul 08, 2005 at 05:50:50PM +0100, Angus Leeming wrote: This new version backports the name mangling scheme from LyX 1.4 Why don't you simply mangle ':' unconditionally? Andre'

Re: [PATCH 13x] insetgraphics

Andre Poenitz wrote: On Fri, Jul 08, 2005 at 05:50:50PM +0100, Angus Leeming wrote: This new version backports the name mangling scheme from LyX 1.4 Why don't you simply mangle ':' unconditionally? Good question. I'll do that. Angus

Re: [PATCH 13x] insetgraphics

On Fri, Jul 08, 2005 at 05:50:50PM +0100, Angus Leeming wrote: > This new version backports the name mangling scheme from LyX 1.4 Why don't you simply mangle ':' unconditionally? Andre'

Re: [PATCH 13x] insetgraphics

Andre Poenitz wrote: On Fri, Jul 08, 2005 at 05:50:50PM +0100, Angus Leeming wrote: This new version backports the name mangling scheme from LyX 1.4 Why don't you simply mangle ':' unconditionally? Good question. I'll do that. Angus

[PATCH 13x] insetgraphics

The attached patch simply refactors the name mangling code in insetgraphics into a separate function. OK to commit? If we're unable to resolve this long file name causes gs to die problem, then I'd suggest reworking the function to use the file name only and a unique counter ID. -- AngusIndex

Re: [PATCH 13x] insetgraphics

Angus Leeming wrote: The attached patch simply refactors the name mangling code in insetgraphics into a separate function. OK to commit? If we're unable to resolve this long file name causes gs to die problem, then I'd suggest reworking the function to use the file name only and a unique

[PATCH 13x] insetgraphics

The attached patch simply refactors the name mangling code in insetgraphics into a separate function. OK to commit? If we're unable to resolve this "long file name causes gs to die" problem, then I'd suggest reworking the function to use the file name only and a unique counter ID. --

Re: [PATCH 13x] insetgraphics

Angus Leeming wrote: > The attached patch simply refactors the name mangling code in > insetgraphics into a separate function. OK to commit? > > If we're unable to resolve this "long file name causes gs to die" > problem, then I'd suggest reworking the function to

Re: [patch] fixes for insetgraphics and insetexternal

::support::GetExtension; using lyx::support::IsFileReadable; -using lyx::support::LibFileSearch; using lyx::support::OnlyFilename; using lyx::support::rtrim; using lyx::support::strToDbl; @@ -672,34 +670,11 @@ string const InsetGraphics::prepareFile( \tfile to convert = temp_file '\n' \t

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: Yes. I knew that, but did not remember that _this_ could be your problem. I don't know why it is like that, but if desired it would not be difficult to call convertDefault.sh. Angus, do we want that? Sure. I must have forgotten it. This patch implements that. Jürgen,

Re: [patch] fixes for insetgraphics and insetexternal

/usr/local/lyx/cvsroot/lyx-devel/src/insets/insetgraphics.C,v retrieving revision 1.270 diff -u -p -r1.270 insetgraphics.C --- src/insets/insetgraphics.C 14 Jan 2005 08:52:35 - 1.270 +++ src/insets/insetgraphics.C 14 Jan 2005 15:25:47 - @@ -97,7 +97,6 @@ using lyx::support::FileName; using lyx::

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: >>> Yes. I knew that, but did not remember that _this_ could be your >>> problem. I don't know why it is like that, but if desired it would not >>> be difficult to call convertDefault.sh. Angus, do we want that? >> >> Sure. I must have forgotten it. > > This patch implements

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: Jürgen, can you check wether this fixes your problems? Unfortunately not. \includegraphics{0_home_juergen_lyx-error} I could not locate the file with any of these extensions: .eps,.ps,.eps.gz,.ps.gz,.eps.Z Try typing return to

Re: [patch] fixes for insetgraphics and insetexternal

Juergen Spitzmueller wrote: Georg Baum wrote: Jürgen, can you check wether this fixes your problems? Unfortunately not. \includegraphics{0_home_juergen_lyx-error} Does the file 0_home_juergen_lyx-error.png exist in the temp dir? Any other files with the same basename? And what is your

Re: [patch] fixes for insetgraphics and insetexternal

should have been used). However, if I define a specific converter in prefs (e.g. convert), then the problem disappears. So it seems that InsetExternal does not call convertDefault.sh, like InsetGraphics. (I don't have the standard imagemagick one, I use the netpbm family of converters

Re: [patch] fixes for insetgraphics and insetexternal

Juergen Spitzmueller wrote: So it seems that InsetExternal does not call convertDefault.sh, like InsetGraphics. Yes. I knew that, but did not remember that _this_ could be your problem. I don't know why it is like that, but if desired it would not be difficult to call convertDefault.sh. Angus

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: Juergen Spitzmueller wrote: So it seems that InsetExternal does not call convertDefault.sh, like InsetGraphics. Yes. I knew that, but did not remember that _this_ could be your problem. I don't know why it is like that, but if desired it would not be difficult to call

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: > Jürgen, can you check wether this fixes your problems? Unfortunately not. \includegraphics{0_home_juergen_lyx-error} I could not locate the file with any of these extensions: .eps,.ps,.eps.gz,.ps.gz,.eps.Z Try typingto

Re: [patch] fixes for insetgraphics and insetexternal

Juergen Spitzmueller wrote: > Georg Baum wrote: >> Jürgen, can you check wether this fixes your problems? > > Unfortunately not. > > \includegraphics{0_home_juergen_lyx-error} Does the file 0_home_juergen_lyx-error.png exist in the temp dir? Any other files with the same basename? And what is

Re: [patch] fixes for insetgraphics and insetexternal

efined any (i.e. convertDefault.sh should have been used). However, if I define a specific converter in prefs (e.g. convert), then the problem disappears. So it seems that InsetExternal does not call convertDefault.sh, like InsetGraphics. > (I don't have the standard imagemagick one, I use the netpbm fami

Re: [patch] fixes for insetgraphics and insetexternal

Juergen Spitzmueller wrote: > So it seems that InsetExternal does not call convertDefault.sh, like > InsetGraphics. Yes. I knew that, but did not remember that _this_ could be your problem. I don't know why it is like that, but if desired it would not be difficult to call convertDefa

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: > Juergen Spitzmueller wrote: > >> So it seems that InsetExternal does not call convertDefault.sh, like >> InsetGraphics. > > Yes. I knew that, but did not remember that _this_ could be your problem. > I don't know why it is like th

[patch] fixes for insetgraphics and insetexternal

-clean/src/insets/insetgraphics.C 2005-01-12 21:05:54.0 +0100 +++ lyx-1.4-cvs/src/insets/insetgraphics.C 2005-01-10 22:32:51.0 +0100 @@ -674,7 +673,12 @@ string const InsetGraphics::prepareFile( // if no special converter defined, then we take the default one // from ImageMagic

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: 2. (insetexternal) The lines ReferencedFile latex $$AbsPath$$Basename.eps ReferencedFile dvi $$AbsPath$$Basename.eps in the template definition tell LyX that the file $$AbsPath$$Basename.eps will be created by the conversion process and will be needed by the exported

[patch] fixes for insetgraphics and insetexternal

bool external_in_tmpdir = false, + Substitute what = ALL); /** Write the output for a specific file format and generate any external data files. -If \param external_in_tmpdir == true, then the generated file is + If \p exte

Re: [patch] fixes for insetgraphics and insetexternal

Georg Baum wrote: > 2. (insetexternal) The lines > > ReferencedFile latex "$$AbsPath$$Basename.eps" > ReferencedFile dvi "$$AbsPath$$Basename.eps" > > in the template definition tell LyX that the file > "$$AbsPath$$Basename.eps" will be created by the conversion process and > will be needed by

Re: [PATCH] fix another insetgraphics bug

Georg Baum wrote: The following does not work: - open a doc with a figure in .eps format - View-Postscript - View-PDF(pdflatex) Reason: The .eps file gets copied to the temp dir to produce the postscript version of the document. When the pdf version is produced, the .eps file is already

Re: [PATCH] fix another insetgraphics bug

Angus Leeming wrote: Georg Baum wrote: The following does not work: - open a doc with a figure in .eps format - View-Postscript - View-PDF(pdflatex) Reason: The .eps file gets copied to the temp dir to produce the postscript version of the document. When the pdf version is produced,

Re: [PATCH] fix another insetgraphics bug

Georg Baum wrote: > The following does not work: > - open a doc with a figure in .eps format > - View->Postscript > - View->PDF(pdflatex) > > Reason: The .eps file gets copied to the temp dir to produce the > postscript version of the document. When the pdf version is produced, > the .eps file

Re: [PATCH] fix another insetgraphics bug

Angus Leeming wrote: > Georg Baum wrote: > >> The following does not work: >> - open a doc with a figure in .eps format >> - View->Postscript >> - View->PDF(pdflatex) >> >> Reason: The .eps file gets copied to the temp dir to produce the >> postscript version of the document. When the pdf

[PATCH] fix another insetgraphics bug

:15.0 +0200 @@ -455,16 +455,12 @@ string const InsetGraphics::prepareFile( // This is necessary for DVI export. string const temp_path = m_buffer-temppath(); - bool conversion_needed = true; - CopyStatus status; boost::tie(status, temp_file) = copyToDirIfNeeded(orig_file, temp_path

  1   2   3   4   5   >