Re: OutputParams refactoring

2020-11-07 Thread Jean-Marc Lasgouttes
Le 07/11/2020 à 16:52, Yuriy Skalko a écrit : I never understood how it works, but I always assumed it was C++ for grown ups, jut without the lambda function mess. All I can say is that it works :) JMarc That's the most important thing, the rest are implementation details :) Now I've found

Re: OutputParams refactoring

2020-11-07 Thread Yuriy Skalko
I never understood how it works, but I always assumed it was C++ for grown ups, jut without the lambda function mess. All I can say is that it works :) JMarc That's the most important thing, the rest are implementation details :) Now I've found that Changer is just no-op variant of

Re: OutputParams refactoring

2020-11-06 Thread Jean-Marc Lasgouttes
Le 06/11/2020 à 23:53, Yuriy Skalko a écrit : Yes, RefChanger is an interesting approach, it will be better than stack. This NewOutputParams class looks like variation of the RefChanger. Right? I understand how RefChanger works, but Changer is a strange thing. How can it work with empty

Re: OutputParams refactoring

2020-11-06 Thread Scott Kostyshak
On Sat, Nov 07, 2020 at 12:53:33AM +0200, Yuriy Skalko wrote: > P.S. I've tried to search for some docs on Changers in LyX repository and > found this useful document: development/coding/CodingRulesAndAdvice.lyx. > Maybe it will be reasonable to merge it into lib/doc/Development.lyx so that >

Re: OutputParams refactoring

2020-11-06 Thread Yuriy Skalko
I started a patch some time ago trying something like that method for OutputParams generally. The destuctor for the new instance copied relevant changes back to the one one. Basically something like: class NewOutputParams : public OutputParams { explicit NewOutputParams(OutputParams

Re: OutputParams refactoring

2020-11-06 Thread Richard Kimberly Heck
be propagated on the higher level. Or use Changers. I started a patch some time ago trying something like that method for OutputParams generally. The destuctor for the new instance copied relevant changes back to the one one. Basically something like: class NewOutputParams : public

Re: OutputParams refactoring

2020-11-06 Thread Jean-Marc Lasgouttes
Le 06/11/2020 à 10:57, Yuriy Skalko a écrit : And to implement for OutputContext the push/pop operations (with internal stack) to save/restore parent context (when needed to do local changes) or directly modify parent context if changes should be propagated on the higher level. Or use

OutputParams refactoring

2020-11-06 Thread Yuriy Skalko
Yes, I looked at it but didn't have time then to comment. It's fine as far as it goes, but I was thinking something somewhat different. Others can chime in, perhaps, but I think there's a reason that OutputParams was always supposed to be passed as const. At least, it began life as precisely

Re: OutputParams

2020-11-02 Thread Richard Kimberly Heck
at it but didn't have time then to comment. It's fine as far as it goes, but I was thinking something somewhat different. Others can chime in, perhaps, but I think there's a reason that OutputParams was always supposed to be passed as const. At least, it began life as precisely what it sounds like: A bunch

Compile Errors in OutputParams

2011-12-08 Thread Rob Oakes
Dear LyX Developers, I'm trying to add a simple list objet to the OutputParams header file, but I keep getting strange errors and I can't figure out what's causing them. Here's what I would like to do: #include list #include insets/InsetFoot.h ... std::listInsetFoot const * footlist; However

Compile Errors in OutputParams

2011-12-08 Thread Rob Oakes
Dear LyX Developers, I'm trying to add a simple list objet to the OutputParams header file, but I keep getting strange errors and I can't figure out what's causing them. Here's what I would like to do: #include #include ... std::list footlist; However, I can't get that far. When I include

Re: OutputParams

2011-04-22 Thread Enrico Forestieri
On Thu, Apr 21, 2011 at 08:22:05PM -0400, Richard Heck wrote: Not that I'm intending to commit this soon, but I thought I'd post this patch now for comment and commit shortly after 2.0. This patch un-mutables most of the mutable members of OutputParams. A couple remain: encoding, which maybe

Re: OutputParams

2011-04-22 Thread Richard Heck
of OutputParams. A couple remain: encoding, which maybe should be mutable, and inulemcmd, which I'm less sure about, though maybe it should be too. Anyway, comments welcome. You don't explain the logic of your patch. A quick glance (I have no time right now to go deeply into it) seems to suggest that you

Re: OutputParams

2011-04-22 Thread Enrico Forestieri
On Thu, Apr 21, 2011 at 08:22:05PM -0400, Richard Heck wrote: > Not that I'm intending to commit this soon, but I thought I'd post > this patch now for comment and commit shortly after 2.0. This patch > un-mutables most of the mutable members of OutputParams. A couple > remain: enc

Re: OutputParams

2011-04-22 Thread Richard Heck
of OutputParams. A couple remain: encoding, which maybe should be mutable, and inulemcmd, which I'm less sure about, though maybe it should be too. Anyway, comments welcome. You don't explain the logic of your patch. A quick glance (I have no time right now to go deeply into it) seems to suggest that you

OutputParams

2011-04-21 Thread Richard Heck
Not that I'm intending to commit this soon, but I thought I'd post this patch now for comment and commit shortly after 2.0. This patch un-mutables most of the mutable members of OutputParams. A couple remain: encoding, which maybe should be mutable, and inulemcmd, which I'm less sure about

OutputParams

2011-04-21 Thread Richard Heck
Not that I'm intending to commit this soon, but I thought I'd post this patch now for comment and commit shortly after 2.0. This patch un-mutables most of the mutable members of OutputParams. A couple remain: encoding, which maybe should be mutable, and inulemcmd, which I'm less sure about