Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-28 Thread Scott Kostyshak
On Thu, May 28, 2020 at 08:44:18PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/05/2020 à 16:37, Jean-Marc Lasgouttes a écrit : > > Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : > > > > Rereading your mail ... if we use another character (e.g. > > > > \alpha), the box is OK. > > > > Checking all G

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-28 Thread Jean-Marc Lasgouttes
Le 25/05/2020 à 16:37, Jean-Marc Lasgouttes a écrit : Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : Rereading your mail ... if we use another character (e.g. \alpha), the box is OK. Checking all Greek chars, only epsilon box looks bad. (and \omicron 'ο' is missing, while \textomicron exists

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
On Mon, May 25, 2020 at 04:37:01PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : > > > Rereading your mail ... if we use another character (e.g. \alpha), the > > > box is OK. > > > Checking all Greek chars, only epsilon box looks bad. (and \omicron 'ο' > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
On Mon, May 25, 2020 at 05:40:32PM +0200, Enrico Forestieri wrote: > On Sun, May 24, 2020 at 09:43:55PM -0400, Scott Kostyshak wrote: > > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > > Author: Jean-Marc Lasgouttes >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Enrico Forestieri
On Sun, May 24, 2020 at 09:43:55PM -0400, Scott Kostyshak wrote: > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > Improve metrics of e

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Jean-Marc Lasgouttes
Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : Rereading your mail ... if we use another character (e.g. \alpha), the box is OK. Checking all Greek chars, only epsilon box looks bad. (and \omicron 'ο' is missing, while \textomicron exists) It also seems not to depend on the zoom level. So

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
On Mon, May 25, 2020 at 04:05:04PM +0200, Kornel Benko wrote: > Am Mon, 25 May 2020 09:39:24 -0400 > schrieb Scott Kostyshak : > > > On Mon, May 25, 2020 at 09:28:31AM +0200, Kornel Benko wrote: > > > Am Sun, 24 May 2020 21:43:55 -0400 > > > schrieb Scott Kostyshak : > > > > > > > On Mon, Feb 1

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Kornel Benko
Am Mon, 25 May 2020 09:39:24 -0400 schrieb Scott Kostyshak : > On Mon, May 25, 2020 at 09:28:31AM +0200, Kornel Benko wrote: > > Am Sun, 24 May 2020 21:43:55 -0400 > > schrieb Scott Kostyshak : > > > > > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > > > commit 56e0

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
On Mon, May 25, 2020 at 09:28:31AM +0200, Kornel Benko wrote: > Am Sun, 24 May 2020 21:43:55 -0400 > schrieb Scott Kostyshak : > > > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > > Author: Jean-Marc Lasgouttes > > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Kornel Benko
Am Sun, 24 May 2020 21:43:55 -0400 schrieb Scott Kostyshak : > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > Improve metrics of equa

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-24 Thread Scott Kostyshak
On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > Author: Jean-Marc Lasgouttes > Date: Mon Feb 19 18:24:29 2018 +0100 > > Improve metrics of equations. More work remains to be done. > > Use proper value for abo

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-04 Thread Jean-Marc Lasgouttes
Le 04/04/2018 à 16:50, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: I pushed it to master. Please try it out and let me know whether it is ready for 2.3.x, especially with small font size. I am working with it. The most striking of small cursor is if you type operator first, e.g. hit minu

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-04 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I pushed it to master. Please try it out and let me know whether it is > ready for 2.3.x, especially with small font size. I am working with it. The most striking of small cursor is if you type operator first, e.g. hit minus ("-") in mathed first and see the cursor s

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-04 Thread Jean-Marc Lasgouttes
Le 03/04/2018 à 17:41, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Can you confirm that these go away when preview are disabled? No, I get the assertion even with preview off. I also found recipy to reproduce: 1. open math manual, go to section 3.1 2. enter with cursor the large math inse

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-03 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: >>> Can you confirm that these go away when preview are disabled? >> No, I get the assertion even with preview off. >> I also found recipy to reproduce: >> 1. open math manual, go to section 3.1 >> 2. enter with cursor the large math inset showing nested fractions with

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-03 Thread Jean-Marc Lasgouttes
Le 21/03/2018 à 13:09, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : Unf I also am getting assertion when navigating through complex fractions and scrolling with mouse wheel at the same time. Not sure whether your patch is involved. Can you co

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Pavel Sanda
Kornel Benko wrote: > > No, I get the assertion even with preview off. > > > > I also found recipy to reproduce: > > 1. open math manual, go to section 3.1 > > You mean 3.2 here? Yes, sorry. > > 2. enter with cursor the large math inset showing nested fractions with > > cfrac 3. scroll down via

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Kornel Benko
Am Mittwoch, 21. März 2018 13:09:02 CET schrieb Pavel Sanda : > Jean-Marc Lasgouttes wrote: > > Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : > >> Unf I also am getting assertion when navigating through complex fractions > >> and scrolling with mouse wheel at the same time. > >> Not sure whether yo

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Pavel Sanda
Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: > > Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : > >> Unf I also am getting assertion when navigating through complex fractions > >> and scrolling with mouse wheel at the same time. > >> Not sure whether your patch is involved. > > > > Can you confi

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : >> Unf I also am getting assertion when navigating through complex fractions >> and scrolling with mouse wheel at the same time. >> Not sure whether your patch is involved. > > Can you confirm that these go away when previe

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 17:39, Pavel Sanda a écrit : Unf I also am getting assertion when navigating through complex fractions and scrolling with mouse wheel at the same time. Not sure whether your patch is involved. Can you confirm that these go away when preview are disabled? JMarc

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20 mars 2018 17:49:44 GMT+01:00, Pavel Sanda a écrit : >Pavel Sanda wrote: >> Unf I also am getting assertion when navigating through complex >fractions >> and scrolling with mouse wheel at the same time. >> Not sure whether your patch is involved. > >limited testing indicates it's part of the

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Pavel Sanda wrote: > Unf I also am getting assertion when navigating through complex fractions > and scrolling with mouse wheel at the same time. > Not sure whether your patch is involved. limited testing indicates it's part of the second patch.p

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 20/03/2018 ?? 16:57, Pavel Sanda a écrit : >> This is already huge improvement to the current situation. >> It might still make sense to decrease little bit, I can try >> different patch if you have another variant at hand. > > This, for example. I am not sure how r

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 16:57, Pavel Sanda a écrit : This is already huge improvement to the current situation. It might still make sense to decrease little bit, I can try different patch if you have another variant at hand. This, for example. I am not sure how robust it is, but it seems to work. JMar

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 15:37, Scott Kostyshak a écrit : It is probably a good time to have this discussion: do we want the UI element size/thickness to depend from dpi/zoom? My first thought is that it makes sense to zoom. What do other applications do in similar situations? Is the symbol indicating

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 20/03/2018 ?? 16:23, Jean-Marc Lasgouttes a écrit : >> I have the same issue with the cursor. The problem I have for fixing this >> is that the font is not known outside of the metrics or draw calls. It >> could be possible to set Cursor::real_current_font inside

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 16:23, Jean-Marc Lasgouttes a écrit : I have the same issue with the cursor. The problem I have for fixing this is that the font is not known outside of the metrics or draw calls. It could be possible to set Cursor::real_current_font inside some metrics call, though. I'll think

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Montag, 19. März 2018 21:46:05 CET schrieb Scott Kostyshak : > On Mon, Feb 19, 2018 at 05:36:36PM +, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > Improve metrics of e

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 13:10, Pavel Sanda a écrit : I have been using mathed very intensively past few weeks and the main glitch which is continuously frustrating me is that often I can't visually distinguish whether I am in subscript or no. In larger equations involving fractions the cursor moves verti

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Scott Kostyshak
On Tue, Mar 20, 2018 at 11:38:12AM +, Jean-Marc Lasgouttes wrote: > Le 20/03/2018 à 02:46, Scott Kostyshak a écrit : > > Starting with this commit, when I view lib/fonts/test/stmary10.lyx and > > turn preview on, I see several previews marked with red. Attached is a > > screenshot. Is this chan

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Dienstag, 20. März 2018 13:34:53 CET schrieb Pavel Sanda : > Be my guest and don't touch the rest :) OK. Done. Kornel signature.asc Description: This is a digitally signed message part.

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Kornel Benko wrote: > > > Why can't you use it if it is at other place? > > > Copying would mean, that I had to copy (and commit) every time a change is > > > done. > > > Adding this directory to the tests is a possibility, but complicates even > > > more the tests IMHO. > > > > I do not think you

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Dienstag, 20. März 2018 12:58:34 CET schrieb Pavel Sanda : > Kornel Benko wrote: > > > > I propose to move it to > > > > > > > > autotests/export/fonts/stmary10.lyx > > > > > > > > instead, and leave a readme in lib/fonts/test showing the new path. > > > > > > No, please don't move it

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Similarly, I have a work in progress that changes the length and width of > mathed corners depending on zoom. > > It is probably a good time to have this discussion: do we want the UI > element size/thickness to depend from dpi/zoom? This is hard to say until one se

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Kornel Benko wrote: > > > I propose to move it to > > > > > > autotests/export/fonts/stmary10.lyx > > > > > > instead, and leave a readme in lib/fonts/test showing the new path. > > > > No, please don't move it. But feel free to copy it to whatever test you have > > in mind. I'm working on the

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 02:46, Scott Kostyshak a écrit : Starting with this commit, when I view lib/fonts/test/stmary10.lyx and turn preview on, I see several previews marked with red. Attached is a screenshot. Is this change expected? Here is the part that causes the issue, if I understand well: +boo

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Dienstag, 20. März 2018 11:42:18 CET schrieb Pavel Sanda : > Kornel Benko wrote: > > Don't see it after latest commit from Riki. > > > > Apropo, why is this test-file not part of the test suite? > > What do you want to test there? If it compiles of course. > > I propose to move it to > > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Kornel Benko wrote: > Don't see it after latest commit from Riki. > > Apropo, why is this test-file not part of the test suite? What do you want to test there? > I propose to move it to > autotests/export/fonts/stmary10.lyx > instead, and leave a readme in lib/fonts/test showing the new pa

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Montag, 19. März 2018 21:46:05 CET schrieb Scott Kostyshak : > On Mon, Feb 19, 2018 at 05:36:36PM +, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > Improve metrics of e