Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-13 Thread Yuriy Skalko
Frankly, I am not at ease at all with the way things get updated. I do not understand the Qt mechanisms well enough. If you feel like trying to understand it, please do. Be warn though that we are in a working but fragile situation now, changes will lead to a rough ride but it is probably

Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-09 Thread Jean-Marc Lasgouttes
Le 09/01/2021 à 22:13, Yuriy Skalko a écrit : Yes, only these 3. Seems like this is caused by `getIcon` calls in DynamicMenuButton::updateTriggered (called on every toolbar update, that happens on every key press). And `getIcon` doesn't just return icon from some cache, but directly checks

Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-09 Thread Yuriy Skalko
Also I noticed that these files are accessed on every keypress (even on navigating document with arrows): lib/images/undo.svgz lib/images/textstyle-apply.svgz lib/images/paste.svgz Is it *really* necessary? It would be because of getStatus, I suspect, though I'm not sure why the files would

Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-09 Thread Jean-Marc Lasgouttes
Le 09/01/2021 à 10:41, Yuriy Skalko a écrit : Also I noticed that these files are accessed on every keypress (even on navigating document with arrows): lib/images/undo.svgz lib/images/textstyle-apply.svgz lib/images/paste.svgz Is it *really* necessary? Only these files? JMarc -- lyx-devel

Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-09 Thread Richard Kimberly Heck
On 1/9/21 4:41 AM, Yuriy Skalko wrote: >> I don't know enough about this stuff to say much. I think this would be >> worth doing for 2.4.0, as it will probably provide for some speed as >> well. >> >> Riki > > Committed at 854c9de. > > Also I noticed that these files are accessed on every keypress

Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-09 Thread Yuriy Skalko
I don't know enough about this stuff to say much. I think this would be worth doing for 2.4.0, as it will probably provide for some speed as well. Riki Committed at 854c9de. Also I noticed that these files are accessed on every keypress (even on navigating document with arrows):

Re: [PATCH] Add move constructor and move assignment operator for FileName class

2021-01-08 Thread Richard Kimberly Heck
On 1/6/21 7:33 PM, Yuriy Skalko wrote: > This should reduce memory allocations for this heavily used class. I don't know enough about this stuff to say much. I think this would be worth doing for 2.4.0, as it will probably provide for some speed as well. Riki -- lyx-devel mailing list