Re: Combo Box for Custom Insets

On 06/26/2016 07:33 AM, Jean-Marc Lasgouttes wrote: Le 25/06/2016 23:41, Richard Heck a écrit : But then it doesn't work with non-LyX-provided insets, i.e., ones you make yourself. If you had a lot of such insets, this would get very messy, too. I'd be happy if it were done as an icon-based

Re: Combo Box for Custom Insets

Le 25/06/2016 23:41, Richard Heck a écrit : But then it doesn't work with non-LyX-provided insets, i.e., ones you make yourself. If you had a lot of such insets, this would get very messy, too. I'd be happy if it were done as an icon-based menu. As I've said, I just don't know how to do that.

Re: Combo Box for Custom Insets

On Sat, Jun 25, 2016 at 8:05 PM, Richard Heck wrote: > On 06/25/2016 12:23 PM, Liviu Andronic wrote: >> On Sat, Jun 25, 2016 at 6:00 PM, Richard Heck wrote: >>> I've fixed both these issues with the attached. >>> >> I have trouble applying this patch. I've tried

Re: Combo Box for Custom Insets

On Sat, Jun 25, 2016 at 11:41 PM, Richard Heck wrote: > On 06/25/2016 04:55 PM, Jean-Marc Lasgouttes wrote: >> Le 25/06/2016 22:37, Guillaume Munch a écrit : >>> Le 25/06/2016 19:15, Richard Heck a écrit : For now, the branch is here:

Re: Combo Box for Custom Insets

On Sat, Jun 25, 2016 at 7:30 PM, Pavel Sanda wrote: > Liviu Andronic wrote: >> The next patch would create the file src/frontends/qt4/InsetCombo.cpp, >> which already exists! Assume -R? [n] >> Apply anyway? [n] > > Delete new files (InsetCombo*). P That was it, thanks. Liviu

Re: Combo Box for Custom Insets

On 06/25/2016 04:55 PM, Jean-Marc Lasgouttes wrote: > Le 25/06/2016 22:37, Guillaume Munch a écrit : >> Le 25/06/2016 19:15, Richard Heck a écrit : >>> >>> For now, the branch is here: >>> http://git.lyx.org/?p=developers/rgheck/lyx.git;a=shortlog;h=refs/heads/features/CustomInsets >>> >>> >>> >>

Re: Combo Box for Custom Insets

Le 25/06/2016 22:37, Guillaume Munch a écrit : Le 25/06/2016 19:15, Richard Heck a écrit : For now, the branch is here: http://git.lyx.org/?p=developers/rgheck/lyx.git;a=shortlog;h=refs/heads/features/CustomInsets If you are satisfied with it then you could commit it, I think. What is your

Re: Combo Box for Custom Insets

Le 25/06/2016 19:15, Richard Heck a écrit : For now, the branch is here: http://git.lyx.org/?p=developers/rgheck/lyx.git;a=shortlog;h=refs/heads/features/CustomInsets If you are satisfied with it then you could commit it, I think. What is your plan?

Re: Combo Box for Custom Insets

On 06/25/2016 01:36 PM, Guillaume Munch wrote: > Le 25/06/2016 17:00, Richard Heck a écrit : >> On 06/25/2016 02:58 AM, Liviu Andronic wrote: >>> On Sat, Jun 25, 2016 at 12:23 AM, Richard Heck wrote: Attached please find a patch that implements a combo box for custom

Re: Combo Box for Custom Insets

On 06/25/2016 12:23 PM, Liviu Andronic wrote: > On Sat, Jun 25, 2016 at 6:00 PM, Richard Heck wrote: >> I've fixed both these issues with the attached. >> > I have trouble applying this patch. I've tried everything from patch > -p1 < filename.patch to git apply filename.patch on a

Re: Combo Box for Custom Insets

Le 25/06/2016 18:36, Guillaume Munch a écrit : > @@ -328,6 +329,7 @@ public: > delete splitter_; > delete bg_widget_; > delete stack_widget_; > +delete insets_; > } This is incorrect. The pointer is not owned by GuiView::GuiViewPrivate but by

Re: Combo Box for Custom Insets

Le 25/06/2016 17:01, Richard Heck a écrit : I'd be happy for someone else to make it into a menu, but I do not know enough about Qt to do it myself. I mostly stole this from LayoutBox. Yes, looks like it is not immediate.

Re: Combo Box for Custom Insets

Le 25/06/2016 17:00, Richard Heck a écrit : On 06/25/2016 02:58 AM, Liviu Andronic wrote: On Sat, Jun 25, 2016 at 12:23 AM, Richard Heck wrote: Attached please find a patch that implements a combo box for custom insets, much like the layout box. This is a very simple version.

Re: Combo Box for Custom Insets

Liviu Andronic wrote: > The next patch would create the file src/frontends/qt4/InsetCombo.cpp, > which already exists! Assume -R? [n] > Apply anyway? [n] Delete new files (InsetCombo*). P

Re: Combo Box for Custom Insets

Am Samstag, 25. Juni 2016 um 18:34:14, schrieb Liviu Andronic > On Sat, Jun 25, 2016 at 6:29 PM, Kornel Benko wrote: > > Am Samstag, 25. Juni 2016 um 18:23:03, schrieb Liviu Andronic > > > >> On Sat, Jun 25, 2016 at 6:00 PM, Richard Heck

Re: Combo Box for Custom Insets

On Sat, Jun 25, 2016 at 6:29 PM, Kornel Benko wrote: > Am Samstag, 25. Juni 2016 um 18:23:03, schrieb Liviu Andronic > >> On Sat, Jun 25, 2016 at 6:00 PM, Richard Heck wrote: >> > I've fixed both these issues with the attached. >> > >> I have

Re: Combo Box for Custom Insets

Am Samstag, 25. Juni 2016 um 18:23:03, schrieb Liviu Andronic > On Sat, Jun 25, 2016 at 6:00 PM, Richard Heck wrote: > > I've fixed both these issues with the attached. > > > I have trouble applying this patch. I've tried everything from patch > -p1 <

Re: Combo Box for Custom Insets

On Sat, Jun 25, 2016 at 6:00 PM, Richard Heck wrote: > I've fixed both these issues with the attached. > I have trouble applying this patch. I've tried everything from patch -p1 < filename.patch to git apply filename.patch on a clean tree and it fails. >git apply

Re: Combo Box for Custom Insets

On 06/25/2016 05:29 AM, Jean-Marc Lasgouttes wrote: > That means that we probably shouldn't use a x but a kind of menu, maybe > attached to an icon Try the latest version. I'd be happy for someone else to make it into a menu, but I do not know enough about Qt to do it myself. I mostly stole

Re: Combo Box for Custom Insets

On 06/25/2016 02:58 AM, Liviu Andronic wrote: > On Sat, Jun 25, 2016 at 12:23 AM, Richard Heck wrote: >> Attached please find a patch that implements a combo box for custom >> insets, much like the layout box. This is a very simple version. More >> complicated ones might also have

Re: Combo Box for Custom Insets

That means that we probably shouldn't use a x but a kind of menu, maybe attached to an icon JMarc Le 25 juin 2016 08:58:57 GMT+02:00, Liviu Andronic a écrit : >On Sat, Jun 25, 2016 at 12:23 AM, Richard Heck wrote: >Looks good. Couple of comments: >- since

Re: Combo Box for Custom Insets

On Sat, Jun 25, 2016 at 12:23 AM, Richard Heck wrote: > > Attached please find a patch that implements a combo box for custom > insets, much like the layout box. This is a very simple version. More > complicated ones might also have an InsetLayout tag that governed > whether an