Re: compilation for coverity fails

2016-06-12 Thread Guillaume Munch
Le 12/06/2016 19:59, Jean-Marc Lasgouttes a écrit : Le 12/06/2016 20:53, Richard Heck a écrit : I don't think we have a definite policy, but it would be a good sort of comment to have. Coverity seems to want the comment right before the code it complains about, though, so I'm not sure this can

Re: compilation for coverity fails

2016-06-12 Thread Richard Heck
On 06/12/2016 02:59 PM, Jean-Marc Lasgouttes wrote: > Le 12/06/2016 20:53, Richard Heck a écrit : >> I don't think we have a definite policy, but it would be a good sort of >> comment to have. >> >> Coverity seems to want the comment right before the code it complains >> about, though, so I'm not

Re: compilation for coverity fails

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 20:53, Richard Heck a écrit : I don't think we have a definite policy, but it would be a good sort of comment to have. Coverity seems to want the comment right before the code it complains about, though, so I'm not sure this can be done ahead of time. We can also provide models

Re: compilation for coverity fails

2016-06-12 Thread Richard Heck
On 06/12/2016 02:45 PM, Guillaume Munch wrote: > Le 12/06/2016 19:39, Richard Heck a écrit : >> On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: >>> Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero

Re: compilation for coverity fails

2016-06-12 Thread Guillaume Munch
Le 12/06/2016 19:39, Richard Heck a écrit : On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero coverity errors, but to fix dangerous code. So if you do not

Re: compilation for coverity fails

2016-06-12 Thread Richard Heck
On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: > Le 12/06/2016 15:05, Georg Baum a écrit : >> If others want to join the effort please keep in mind that the goal >> is not >> to get zero coverity errors, but to fix dangerous code. So if you do not >> understand an issue 100%, or understand it

Re: compilation for coverity fails

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero coverity errors, but to fix dangerous code. So if you do not understand an issue 100%, or understand it but do not know how to fix it, please keep it open. I did that

Re: compilation for coverity fails

2016-06-12 Thread Liviu Andronic
On Thu, Jun 9, 2016 at 4:14 PM, Jean-Marc Lasgouttes wrote: > Le 09/06/2016 à 12:22, Liviu Andronic a écrit : >>> >>> Are you currently updating the analysis on coverity site? >>> >> Yes, uploading build now. Should be up within an hour or so. > > > They are there indeed,

Re: compilation for coverity fails

2016-06-09 Thread Jean-Marc Lasgouttes
Le 09/06/2016 à 12:22, Liviu Andronic a écrit : Are you currently updating the analysis on coverity site? Yes, uploading build now. Should be up within an hour or so. They are there indeed, thanks. There two new defects, but these are false positive. I have changed to code to avoid them.

Re: compilation for coverity fails

2016-06-09 Thread Liviu Andronic
On Thu, Jun 9, 2016 at 12:20 PM, Jean-Marc Lasgouttes wrote: > Le 09/06/2016 à 11:49, Liviu Andronic a écrit : >> >> On Thu, Jun 9, 2016 at 10:19 AM, Jean-Marc Lasgouttes >> wrote: >>> >>> >>> Le 08/06/2016 à 23:39, Liviu Andronic a écrit :

Re: compilation for coverity fails

2016-06-09 Thread Jean-Marc Lasgouttes
Le 09/06/2016 à 11:49, Liviu Andronic a écrit : On Thu, Jun 9, 2016 at 10:19 AM, Jean-Marc Lasgouttes wrote: Le 08/06/2016 à 23:39, Liviu Andronic a écrit : Does anyone know if these error messages point to a problem in our code? Is this a clean build? Thank you,

Re: compilation for coverity fails

2016-06-09 Thread Liviu Andronic
On Thu, Jun 9, 2016 at 10:19 AM, Jean-Marc Lasgouttes wrote: > > Le 08/06/2016 à 23:39, Liviu Andronic a écrit : >> >> Does anyone know if these error messages point to a problem in our code? > > > Is this a clean build? > Thank you, that must have been it. After a make

Re: compilation for coverity fails

2016-06-09 Thread Jean-Marc Lasgouttes
Le 08/06/2016 à 23:39, Liviu Andronic a écrit : Does anyone know if these error messages point to a problem in our code? Is this a clean build? JMarc

Re: compilation for coverity fails

2016-06-09 Thread Kornel Benko
Am Mittwoch, 8. Juni 2016 um 23:39:34, schrieb Liviu Andronic > On Tue, Jun 7, 2016 at 8:08 PM, Liviu Andronic wrote: > > > > > AR liblyxinsets.a > > CXXLD lyx > > liblyxinsets.a(InsetERT.o):(.rodata._ZTVN3lyx8InsetERTE[_ZTVN3lyx8InsetERTE]+0x230): > >

Re: compilation for coverity fails

2016-06-08 Thread Liviu Andronic
On Tue, Jun 7, 2016 at 8:08 PM, Liviu Andronic wrote: > > AR liblyxinsets.a > CXXLD lyx > liblyxinsets.a(InsetERT.o):(.rodata._ZTVN3lyx8InsetERTE[_ZTVN3lyx8InsetERTE]+0x230): > undefined reference to `lyx::InsetCollapsable::clickable(int, int) const' >