Kayvan == Kayvan A Sylvan [EMAIL PROTECTED] writes:
Kayvan Here's the fixed patch. ;-)
Applied.
JMarc
> "Kayvan" == Kayvan A Sylvan <[EMAIL PROTECTED]> writes:
Kayvan> Here's the fixed patch. ;-)
Applied.
JMarc
Kayvan A. Sylvan [EMAIL PROTECTED] writes:
| On Sat, May 05, 2001 at 01:50:20PM +1000, Allan Rae wrote:
| On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
|
| Here's the patch.
|
| Somebody correct me if I'm wrong but can't the static bool be placed
| at a minimal scope (just before the
On Mon, May 07, 2001 at 01:56:42PM +0200, Lars Gullik Bjønnes wrote:
Can't you move it here?
Yes, I could.
One more time... ;-)
Index: src/ChangeLog
===
RCS file: /cvs/lyx/lyx-devel/src/ChangeLog,v
retrieving revision 1.157
On Mon, May 07, 2001 at 08:14:01AM -0700, Kayvan A. Sylvan wrote:
+ static bool sent_space_message = false;
+ if (cursor.pos() == 0) {
+ if (!sent_space_message)
bview-owner()-message(_(You cannot insert a space at the
Dekel Tsur [EMAIL PROTECTED] writes:
| On Mon, May 07, 2001 at 08:14:01AM -0700, Kayvan A. Sylvan wrote:
| + static bool sent_space_message = false;
| + if (cursor.pos() == 0) {
| + if (!sent_space_message)
static bool sent_space_message = false;
if (!sent_space_message)
if (cursor.pos() == 0)
bview-owner()-message(...)
else
bview-owner()-message(...)
sent_space_message = true
(and the inner if can be repalced by '? :')
This is just wrong. The
Kayvan A. Sylvan [EMAIL PROTECTED] writes:
|
| static bool sent_space_message = false;
| if (!sent_space_message)
|if (cursor.pos() == 0)
| bview-owner()-message(...)
|else
| bview-owner()-message(...)
| sent_space_message = true
|
| (and the
On Mon, May 07, 2001 at 07:14:42PM +0200, Lars Gullik Bjønnes wrote:
Kayvan A. Sylvan [EMAIL PROTECTED] writes:
| This is just wrong. The first time through this part of the InsertChar function,
| sent_space_message is set to true (regardless of whether the space message
| is actually sent.
"Kayvan A. Sylvan" <[EMAIL PROTECTED]> writes:
| On Sat, May 05, 2001 at 01:50:20PM +1000, Allan Rae wrote:
| > On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
| >
| > > Here's the patch.
| >
| > Somebody correct me if I'm wrong but can't the static bool be placed
| > at a minimal scope (just
On Mon, May 07, 2001 at 01:56:42PM +0200, Lars Gullik Bjønnes wrote:
> Can't you move it here?
Yes, I could.
One more time... ;-)
Index: src/ChangeLog
===
RCS file: /cvs/lyx/lyx-devel/src/ChangeLog,v
retrieving revision 1.157
On Mon, May 07, 2001 at 08:14:01AM -0700, Kayvan A. Sylvan wrote:
> + static bool sent_space_message = false;
> + if (cursor.pos() == 0) {
> + if (!sent_space_message)
>bview->owner()->message(_("You cannot insert a space at the
Dekel Tsur <[EMAIL PROTECTED]> writes:
| On Mon, May 07, 2001 at 08:14:01AM -0700, Kayvan A. Sylvan wrote:
| > + static bool sent_space_message = false;
| > + if (cursor.pos() == 0) {
| > + if (!sent_space_message)
>
>static bool sent_space_message = false;
>if (!sent_space_message)
> if (cursor.pos() == 0)
> bview->owner()->message(...)
> else
> bview->owner()->message(...)
>sent_space_message = true
>
> (and the inner if can be repalced by '? :')
This is just
"Kayvan A. Sylvan" <[EMAIL PROTECTED]> writes:
| >
| >static bool sent_space_message = false;
| >if (!sent_space_message)
| > if (cursor.pos() == 0)
| > bview->owner()->message(...)
| > else
| > bview->owner()->message(...)
| >sent_space_message = true
On Mon, May 07, 2001 at 07:14:42PM +0200, Lars Gullik Bjønnes wrote:
> "Kayvan A. Sylvan" <[EMAIL PROTECTED]> writes:
> | This is just wrong. The first time through this part of the InsertChar function,
> | sent_space_message is set to true (regardless of whether the space message
> | is actually
On Sat, May 05, 2001 at 01:50:20PM +1000, Allan Rae wrote:
On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
Here's the patch.
Somebody correct me if I'm wrong but can't the static bool be placed
at a minimal scope (just before the inner conditional). That would keep
the variable next to
On Sat, May 05, 2001 at 01:50:20PM +1000, Allan Rae wrote:
> On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
>
> > Here's the patch.
>
> Somebody correct me if I'm wrong but can't the static bool be placed
> at a minimal scope (just before the inner conditional). That would keep
> the variable
Jean-Marc Lasgouttes wrote:
George == George De Bruin [EMAIL PROTECTED] writes:
George What does form at least a minor irritant is the message about
George not being about to insert two spaces. I just wish there was a
George way to turn this one message off. It really does tend to break
On Sat, 5 May 2001, Allan Rae wrote:
On Fri, 4 May 2001, John Levon wrote:
On Fri, 4 May 2001, Allan Rae wrote:
It's also a good chance for John to fix his implementation.
implementation of what ? Or do you mean John Weiss ?
Maybe it's my fading memory but I thought it was you
On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
Here's the patch. Though it is obscured by the presence of an unrelated bug
that exists in the current CVS: When you type space at the beginning of a
paragraph or after another space, the message flashes across but is
immediately replaced by the
On Fri, May 04, 2001 at 09:01:54PM +1000, Allan Rae wrote:
On 4 May 2001, Lars Gullik [iso-8859-1] Bjønnes wrote:
Allan Rae [EMAIL PROTECTED] writes:
| Why not output the message only once per session?
|
| I already suggested that! You can either say I agree. or suggest
|
On 4 May 2001, Lars Gullik [iso-8859-1] Bjønnes wrote:
Allan Rae [EMAIL PROTECTED] writes:
[...]
| I think we should sit back a moment and ask ourselves if there really is
| any point in showing this message at all. I find it a distraction and
| while it'd be easy to add YAP (Yet Another
Allan Rae [EMAIL PROTECTED] writes:
| Why not output the message only once per session?
|
| I already suggested that! You can either say I agree. or suggest
| something different. Rewording an existing suggestion isn't a valid
| option!
so where's the patch then?
prttbbttr!
--
On Fri, 4 May 2001, Allan Rae wrote:
If we just keep saying:
Such-and-such is annoying. Let's add a preference to disable it.
then maybe such-and-such shouldn't exist at all or is at least not well
thought out. Otherwise we get preference bloat and you'll either end up
with so
On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
Here's the patch.
Somebody correct me if I'm wrong but can't the static bool be placed
at a minimal scope (just before the inner conditional). That would keep
the variable next to where it's used and it minimize its scope. Since
it's static it'll
On Sat, May 05, 2001 at 01:50:20PM +1000, Allan Rae wrote:
On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
Here's the patch.
Somebody correct me if I'm wrong but can't the static bool be placed
at a minimal scope (just before the inner conditional). That would keep
the variable next to
Allan Rae [EMAIL PROTECTED] writes:
| On Fri, 4 May 2001, Michael Koziarski wrote:
|
| On Thu, May 03, 2001 at 05:15:27PM +0200 or thereabouts, Jean-Marc Lasgouttes
|wrote:
| This message was added because somebody felt it was irritant to be
| unable to add double space without reason :)
On Fri, 4 May 2001, Michael Koziarski wrote:
On Thu, May 03, 2001 at 05:15:27PM +0200 or thereabouts, Jean-Marc Lasgouttes wrote:
This message was added because somebody felt it was irritant to be
unable to add double space without reason :) I do not know whether we
are supposed to add a
On 4 May 2001, Lars Gullik [iso-8859-1] Bjønnes wrote:
Allan Rae [EMAIL PROTECTED] writes:
| Why not output the message only once per session?
|
| I already suggested that! You can either say I agree. or suggest
| something different. Rewording an existing suggestion isn't a valid
|
On Fri, 4 May 2001, Allan Rae wrote:
It's also a good chance for John to fix his implementation.
implementation of what ? Or do you mean John Weiss ?
john
--
Brodie, he's a reasonable man, but he's *insane* !
- Kramer
Jean-Marc Lasgouttes wrote:
>
> > "George" == George De Bruin <[EMAIL PROTECTED]> writes:
>
> George> What does form at least a minor irritant is the message about
> George> not being about to insert two spaces. I just wish there was a
> George> way to turn this one message off. It really
On Sat, 5 May 2001, Allan Rae wrote:
> On Fri, 4 May 2001, John Levon wrote:
>
> > On Fri, 4 May 2001, Allan Rae wrote:
> >
> > > It's also a good chance for John to fix his implementation.
> >
> > implementation of what ? Or do you mean John Weiss ?
>
> Maybe it's my fading memory but I
On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
> Here's the patch. Though it is obscured by the presence of an unrelated bug
> that exists in the current CVS: When you type space at the beginning of a
> paragraph or after another space, the message flashes across but is
> immediately replaced by
On Fri, May 04, 2001 at 09:01:54PM +1000, Allan Rae wrote:
> On 4 May 2001, Lars Gullik [iso-8859-1] Bjønnes wrote:
>
> > Allan Rae <[EMAIL PROTECTED]> writes:
> >
> > | > Why not output the message only once per session?
> > |
> > | I already suggested that! You can either say "I agree." or
On 4 May 2001, Lars Gullik [iso-8859-1] Bjønnes wrote:
> Allan Rae <[EMAIL PROTECTED]> writes:
[...]
> | I think we should sit back a moment and ask ourselves if there really is
> | any point in showing this message at all. I find it a distraction and
> | while it'd be easy to add YAP (Yet
Allan Rae <[EMAIL PROTECTED]> writes:
| > Why not output the message only once per session?
|
| I already suggested that! You can either say "I agree." or suggest
| something different. Rewording an existing suggestion isn't a valid
| option!
so where's the patch then?
prttbbttr!
--
On Fri, 4 May 2001, Allan Rae wrote:
> If we just keep saying:
> "Such-and-such is annoying. Let's add a preference to disable it."
>
> then maybe such-and-such shouldn't exist at all or is at least not well
> thought out. Otherwise we get preference bloat and you'll either end up
>
On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
> Here's the patch.
Somebody correct me if I'm wrong but can't the static bool be placed
at a minimal scope (just before the inner conditional). That would keep
the variable next to where it's used and it minimize its scope. Since
it's static it'll
On Sat, May 05, 2001 at 01:50:20PM +1000, Allan Rae wrote:
> On Fri, 4 May 2001, Kayvan A. Sylvan wrote:
>
> > Here's the patch.
>
> Somebody correct me if I'm wrong but can't the static bool be placed
> at a minimal scope (just before the inner conditional). That would keep
> the variable
Allan Rae <[EMAIL PROTECTED]> writes:
| On Fri, 4 May 2001, Michael Koziarski wrote:
|
| > On Thu, May 03, 2001 at 05:15:27PM +0200 or thereabouts, Jean-Marc Lasgouttes
|wrote:
| > > This message was added because somebody felt it was irritant to be
| > > unable to add double space without
On Fri, 4 May 2001, Michael Koziarski wrote:
> On Thu, May 03, 2001 at 05:15:27PM +0200 or thereabouts, Jean-Marc Lasgouttes wrote:
> > This message was added because somebody felt it was irritant to be
> > unable to add double space without reason :) I do not know whether we
> > are supposed to
On 4 May 2001, Lars Gullik [iso-8859-1] Bjønnes wrote:
> Allan Rae <[EMAIL PROTECTED]> writes:
>
> | > Why not output the message only once per session?
> |
> | I already suggested that! You can either say "I agree." or suggest
> | something different. Rewording an existing suggestion isn't a
On Fri, 4 May 2001, Allan Rae wrote:
> It's also a good chance for John to fix his implementation.
implementation of what ? Or do you mean John Weiss ?
john
--
"Brodie, he's a reasonable man, but he's *insane* !"
- Kramer
George == George De Bruin [EMAIL PROTECTED] writes:
George What does form at least a minor irritant is the message about
George not being about to insert two spaces. I just wish there was a
George way to turn this one message off. It really does tend to break
George one's concentration when
On Thu, May 03, 2001 at 05:15:27PM +0200 or thereabouts, Jean-Marc Lasgouttes wrote:
This message was added because somebody felt it was irritant to be
unable to add double space without reason :) I do not know whether we
are supposed to add a configure option for each and every LyX feature,
> "George" == George De Bruin <[EMAIL PROTECTED]> writes:
George> What does form at least a minor irritant is the message about
George> not being about to insert two spaces. I just wish there was a
George> way to turn this one message off. It really does tend to break
George> one's
On Thu, May 03, 2001 at 05:15:27PM +0200 or thereabouts, Jean-Marc Lasgouttes wrote:
> This message was added because somebody felt it was irritant to be
> unable to add double space without reason :) I do not know whether we
> are supposed to add a configure option for each and every LyX
Moving this comment over here (if it hasn't already been moved here) since it
has been suggested this is a more appropriate location:
On Tuesday 01 May 2001 14:44, Laura Jackson wrote:
Why couldn't LyX allow the user to type 2 spaces between sentences and 1
space between words? It's
Moving this comment over here (if it hasn't already been moved here) since it
has been suggested this is a more appropriate location:
On Tuesday 01 May 2001 14:44, Laura Jackson wrote:
> Why couldn't LyX allow the user to type 2 spaces between sentences and 1
> space between words? It's
50 matches
Mail list logo
