Am Sonntag, dem 31.10.2021 um 11:33 +0100 schrieb Juergen Spitzmueller:
> commit f0126b9fdff2118f3e9566387bed0cb5da2df9d4
> Author: Juergen Spitzmueller
> Date: Sun Oct 31 11:56:53 2021 +0100
>
> \\noindent in a paragraph that starts with \\vspace is possible
>
>
.7 on Windows 7 and 1.6.6 on Ubuntu.
In debug mode, it crashes. I'm seeing an infinite loop in this code:
int VSpace::inPixels(BufferView const & bv) const
{
// Height of a normal line in pixels (zoom factor considered)
int const default_height = defaultRowHeight();
> Thanks, it works now. I committed some small tweaks.
Thanks.
regards Uwe
Uwe Stöhr wrote:
> The bug was again that I only did the "-" -> "minus" conversion only when
> the length contained a percent unit. This is now fixed.
Thanks, it works now. I committed some small tweaks.
Jürgen
> Thanks, but the result is not correct. Lyx2lyx reverts to
> \hspace*{1cm+1mm-2mm}
The bug was again that I only did the "-" -> "minus" conversion only when the length contained a
percent unit. This is now fixed.
regards Uwe
BTW I think that this code
o = document.body[i+1].find("\\length")
if o == -1:
document.warning("Error: Cannot find lenght for \\hspace!")
break
# search for the beginning of the value via the space
k = document.body[i+1].find(" ")
length = documen
Uwe Stöhr wrote:
> > I was talking about negative *non*-glue lengths such as "-2cm", which do
> > not
>
> > need to be reverted at all.
>
> This already works correctly.
Good.
> > Nothing in the test case, BTW, does revert correctly to 1.6.
>
> Because I only reverted when the glue lengths cont
> I was talking about negative *non*-glue lengths such as "-2cm", which do not
> need to be reverted at all.
This already works correctly.
> Nothing in the test case, BTW, does revert correctly to 1.6.
Because I only reverted when the glue lengths contain at least a percent
length. This is now
Uwe Stöhr wrote:
> > Just one question to the lyx2lyx code: did you exclude minus at the first
>
> > position? "-2cm" is a valid non-glue length that doesn't need to be
> reverted.
>
> minus is never at the first position when there is also a plus. Lengths
> like 5col%-2text% are converted correct
Vincent van Ravesteijn - TNW schrieb:
Besides the awful duplication of code,
I haven't figured out a simpler solution. But anyway, it works.
the following looks suspicious:
sstring = value + "\\paperwidth" + end
^
Fixed.
And is this warning necessary, or a relic of the debugging phase ?
>> Attached a patch that implements the glue length
>> for texted. Maybe you can do the file format/lyx2lyx
>> stuff.
>
> The lyx2lyx part was more complicated than I thought.
> However, attached is the patch to go in.
Besides the awful duplication of code, the following looks suspicious:
sstri
Uwe Stöhr wrote:
> The lyx2lyx part was more complicated than I thought. However, attached is
> the patch to go in.
Just one question to the lyx2lyx code: did you exclude minus at the first
position? "-2cm" is a valid non-glue length that doesn't need to be reverted.
Apart from that, it looks go
[365, []],
[366, []],
- [367, []]
+ [367, []],
+ [368, []]
]
-revert = [[366, [revert_percent_vspace_lengths, revert_percent_hspace_lengths]],
+revert = [[367, [revert_hspace_
Jürgen Spitzmüller wrote:
> > I won't have time to work further on this the next weeks, so please take
> > over as you are deep enough in this business as well as I am.
>
> I don't have time either.
I couldn't resist.
Attached a patch that implements the glue length for texted. Maybe you can do
t
r texted first.
> Moreover VSpace.cpp contains many routines to handle glue lengths in the
> lineEdit field. These are missing for GlueLengths and should be implemented
> to HSpace.cpp. The HSpace dialog should then use the HSpace class instead
> of the Length class.
The dialog is independ
> Looks good.
The patch is in.
>> The HSpace dialog lacks in general support for glue lengths, see
>> http://www.lyx.org/trac/ticket/6099 but this is independent from support
>> for percent lengths.)
>
> Should be easy to implement as well, while you're at it. Just replace the
> Length in InsetS
Uwe Stöhr wrote:
> The attached simple patch allows to use percent lengths in the HSpace and
> VSpace dialog. (In the VSpace dialog you can with this patch also insert
> things like this: 5col%+-1mm
Looks good.
> The HSpace dialog lacks in general support for glue lengths
The attached simple patch allows to use percent lengths in the HSpace and
VSpace dialog.
(In the VSpace dialog you can with this patch also insert things like this:
5col%+-1mm
The HSpace dialog lacks in general support for glue lengths, see http://www.lyx.org/trac/ticket/6099
but this is
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Bernhard Roider <[EMAIL PROTECTED]> writes:
| > | Hello Lars,
| > | | as Abdel suggested i would like to ask you for SVN commit
| > access, to
| > | be able to commit my contributions by myself.
| > I am a bit reluctant
Lars Gullik Bjønnes wrote:
Bernhard Roider <[EMAIL PROTECTED]> writes:
| Hello Lars,
|
| as Abdel suggested i would like to ask you for SVN commit access, to
| be able to commit my contributions by myself.
I am a bit reluctant, especially since (pardon me if wrong) you havent
contributed much
token != "\\end_inset") {
+ if (!lex) {
lex.printError("Missing \\end_inset at this point. "
"Read: `$$Token'");
}
Index: src/insets/insetvspace.C
===========
Georg Baum wrote:
Am Freitag, 2. März 2007 23:40 schrieb Bernhard Roider:
The rule for using the lexer:
if you want to know if the lexer still has data to read (either from the
stream or from the pushed
token) then use "lex.isOK()".
If you want to test if the last reading operation was succ
Am Freitag, 2. März 2007 23:40 schrieb Bernhard Roider:
> The rule for using the lexer:
>
> if you want to know if the lexer still has data to read (either from the
stream or from the pushed
> token) then use "lex.isOK()".
> If you want to test if the last reading operation was successful then
Bernhard Roider <[EMAIL PROTECTED]> writes:
| Ok, then here's the patch with const methods and mutable member
| variable. It fixes bug #3293.
The patch does a lot of small code shuffling that might change
behavior, so it porbably needs some testing. I'll leave it up to RM if
this should be applie
Lars Gullik Bjønnes wrote:
Bernhard Roider <[EMAIL PROTECTED]> writes:
| Hello Lars,
|
| as Abdel suggested i would like to ask you for SVN commit access, to
| be able to commit my contributions by myself.
I am a bit reluctant, especially since (pardon me if wrong) you havent
contributed much
"\\end_inset") {
+ if (!lex) {
lex.printError("Missing \\end_inset at this point. "
"Read: `$$Token'");
}
Index: src/insets/insetvspace.C
=========
Bernhard Roider <[EMAIL PROTECTED]> writes:
| Hello Lars,
|
| as Abdel suggested i would like to ask you for SVN commit access, to
| be able to commit my contributions by myself.
I am a bit reluctant, especially since (pardon me if wrong) you havent
contributed much yet, and I have not seen/revi
Andre Poenitz wrote:
On Fri, Mar 02, 2007 at 11:41:45PM +0100, Bernhard Roider wrote:
The rule for using the lexer:
if you want to know if the lexer still has data to read (either from the
stream or from the pushed token) then use "lex.isOK()".
Why not lex.dataAvailable() or something simila
On Fri, Mar 02, 2007 at 11:41:45PM +0100, Bernhard Roider wrote:
> >The rule for using the lexer:
> >
> >if you want to know if the lexer still has data to read (either from the
> >stream or from the pushed token) then use "lex.isOK()".
Why not lex.dataAvailable() or something similar?
Andre'
Lars Gullik Bjønnes wrote:
Bernhard Roider <[EMAIL PROTECTED]> writes:
| the patch...
I think the var "lastReadOk" should be mutable, and you should not
remove const from the functions.
i already thought about that. i will do it.
Bernhard Roider <[EMAIL PROTECTED]> writes:
| the patch...
I think the var "lastReadOk" should be mutable, and you should not
remove const from the functions.
| Index: src/lyxlex.h
| ===
| --- src/lyxlex.h (revision 17394)
| ++
Bernhard Roider wrote:
Hello all,
[...]
I tested lyx with the attached patch and found no problems, but who
knows...
i think this should go in.
comments?
Only a tiny one from me:
Instead of remove the constness of getXXX() methods I suggest that you
make lastReadOk_ mutable..
Bernh
Bernhard Roider wrote:
today i searched for the reason why the vspace dialog is completely
broken as Michael Gerz wrote in his mail from 27.02.2007.
bug #3293 (http://bugzilla.lyx.org/show_bug.cgi?id=3293)
the patch...
Bernhard Roider wrote:
Hello all,
today i searched for the reason why the vspace dialog is completely
broken as Michael Gerz wrote in his mail from 27.02.2007. It turned out
that the bug was introduced by the patch that fixed the bug that crashed
lyx when "inset-inser
Hello all,
today i searched for the reason why the vspace dialog is completely broken as Michael Gerz wrote in
his mail from 27.02.2007. It turned out that the bug was introduced by the patch that fixed the bug
that crashed lyx when "inset-insert ert" was executed from the command bu
Michael Gerz wrote:
if you place the cursor in front of a vspace inset, it is displayed
way too high.
I had a look at method "metrics" in insetvspace.C which IMHO is a bit
confusing (and partially wrong - Why is size set to 10 initially? Why
do we decrease the font size twice b
Georg Baum wrote:
if you place the cursor in front of a vspace inset, it is displayed way
too high.
Did you try different vspace values (very large, very small)? I am not sure
whether this behaviour is on purpose or not.
Yes, I did. The LyX cursor is determined by the font size of the
Michael Gerz wrote:
> Hello,
>
> if you place the cursor in front of a vspace inset, it is displayed way
> too high.
Did you try different vspace values (very large, very small)? I am not sure
whether this behaviour is on purpose or not.
> I had a look at method "metri
Hello,
if you place the cursor in front of a vspace inset, it is displayed way
too high.
I had a look at method "metrics" in insetvspace.C which IMHO is a bit
confusing (and partially wrong - Why is size set to 10 initially? Why do
we decrease the font size twice but compute some
This patch adds a gtk VSpace dialog, as well as a function in ghelpers
to get a list of units excluding the percentage units.
John
? tmp
Index: ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/gtk/ChangeLog,v
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Hm, I noticed that LyXGlueLength::asLaTexString does not
Juergen> transform the %-values correctly (as
Juergen> LyXLength::asLaTeXString). This would require some more
Juergen> coding, and I think I'd rather postpone this
Am Montag, 15. November 2004 12:00 schrieb Jean-Marc Lasgouttes:
> Juergen> I think that screen representation will be just o.k. as is.
> Juergen> We'd just need to delete the deletion of %-units in the
> Juergen> frontends.
>
> In any case, avoiding to remove %-units will simplify the code, so it
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>> You should be careful though about the screen representation of
>> such a length.
Juergen> I think that screen representation will be just o.k. as is.
Juergen> We'd just need to delete the deletion of %-units in the
Juergen> f
Jean-Marc Lasgouttes wrote:
> I guess \textheight is the only sensible one.
Why shouldn't someone find \textwidth sensible? E.g., if he wants produce a
blank square (for whatever reason). But textheight is certainly the most
important one.
> You should be careful
> though about the screen rep
>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> What were again the reasons why we have excluded the
Juergen> %-lengths from VSpace? They certainly work, and IMO at least
Juergen> \textheight is highly sensible.
I guess \
What were again the reasons why we have excluded the %-lengths from VSpace?
They certainly work, and IMO at least \textheight is highly sensible.
Jürgen
angeLog 2003/11/19 10:35:50 1.42
+++ src/tex2lyx/ChangeLog 2003/12/09 19:47:26
@@ -1,3 +1,9 @@
+2003-12-08 Georg Baum <[EMAIL PROTECTED]>
+
+ * text.C: Use the new VSpace inset (fixes a bug with added_space top)
+ * text.C: Fix \= in tabbing env again
+ * text.C: Fix invocation of parse_co
On Sat, Dec 06, 2003 at 10:16:01PM +0100, Georg Baum wrote:
> Comments?
Looks good.
Andre'
The attached patch makes tex2lyx output an Inset VSpace where possible for
vertical spaces. Unfortunately it needed more code than I thought to handle
corner cases correctly. There are some overlaps with lyxlength.C
(translate_len() could vanish), but lyxlength.C needs some bufferview
stuff
Juergen Spitzmueller wrote:
> The patch removes VSPACE::NONE from both the qt and the xforms
> dialog. I haven't touched the inset (and won't).
This is half of Michael Schmitt's patch, right? Why not just apply it
all?
> One problem left (in both frontends): what do I
On Mon, Dec 01, 2003 at 01:41:39PM +0100, Juergen Spitzmueller wrote:
> Michael Schmitt wrote:
> > NONE is a pretty pointless option with a true VSpace inset.
> >
> > Please check and apply the attached patch.
>
> Cool. I merge it with my changes and commit, o.k.? (I
On Mon, Dec 01, 2003 at 01:42:39PM +0100, Juergen Spitzmueller wrote:
> > Change the policy in the controller.
>
> Where? To what?
in qt2/Dialogs.C:
263 dialog->setController(new ControlVSpace(*dialog));
264 dialog->setView(new QVSpace(*dialog));
265
Michael Schmitt wrote:
> NONE is a pretty pointless option with a true VSpace inset.
>
> Please check and apply the attached patch.
Cool. I merge it with my changes and commit, o.k.? (I have a few other changes
concerning the VSpace gui).
Thanks,
Jürgen.
John Levon wrote:
> > One problem left (in both frontends): what do I have to do to let the
> > ok/apply buttons be enabled if I insert a *new* inset? Currently I have
> > to change sth
>
> Change the policy in the controller.
Where? To what?
(sorry, but I really can't see it).
Jürgen.
On Mon, Dec 01, 2003 at 11:16:06AM +0100, Juergen Spitzmueller wrote:
> The patch removes VSPACE::NONE from both the qt and the xforms dialog. I
> haven't touched the inset (and won't).
Whoops, duplicated effort ! I'll let you deal with merging with
Michael's if it m
On Mon, Dec 01, 2003 at 10:30:27AM +0100, Michael Schmitt wrote:
> NONE is a pretty pointless option with a true VSpace inset.
>
> Please check and apply the attached patch.
Looks good
regards
john
On Mon, Dec 01, 2003 at 08:35:08AM +0100, Juergen Spitzmueller wrote:
> > There are missing tooltips it seems ... (qt)
>
> Where?
Sorry, there wasn't ... but I don't like the tooltip for protect,
"reset" is the wrong word here
john
--
Khendon's Law:
If the same point is made twice by the sam
The patch removes VSPACE::NONE from both the qt and the xforms dialog. I
haven't touched the inset (and won't).
One problem left (in both frontends): what do I have to do to let the ok/apply
buttons be enabled if I insert a *new* inset? Currently I have to change sth
in the dialog to
Hello,
NONE is a pretty pointless option with a true VSpace inset.
Please check and apply the attached patch.
Thanks, Michael
Index: src/ChangeLog
===
RCS file: /cvs/lyx/lyx-devel/src/ChangeLog,v
retrieving revision 1.1732
diff -u
On Mon, Dec 01, 2003 at 12:20:36AM +, John Levon wrote:
>
> What on earth is a vspace of "none" ? Why is it the default ?
Because we used to have two vspace members in the paragraph parameters
(that skip above/below) which were unused almost all the time and
therefore d
John Levon wrote:
> What on earth is a vspace of "none" ? Why is it the default ?
Don't know. But it does not make any sense to me either.
> There are missing tooltips it seems ... (qt)
Where?
Jürgen.
What on earth is a vspace of "none" ? Why is it the default ?
There are missing tooltips it seems ... (qt)
regards
john
--
Khendon's Law:
If the same point is made twice by the same person, the thread is over.
Just look at this:
<>
(or table draws outside bounds)
--
Lgb
>>>>> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes:
Herbert> try this in int LyXText::getLengthMarkerHeight(BufferView *
Herbert> bv, VSpace const & vsp) const
I'll commit something like that soon.
JMarc
> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes:
>> Is your dpi setting correct? Do you have a zoom factor?
Herbert> don't know? Changed only the zoom to 150. dpi is 90. is it
Herbert> not correct?
Assuming the dpi of you monitor in indeed 90, then everything will be
1.5 times larger
Jean-Marc Lasgouttes wrote:
>>"Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes:
>>
>
> Herbert> where is the sense, that I get a long vertical line when I
> Herbert> choose for example "-3cm" as vertical length? It should be
> Herbert> better to a) draw negative values as is, or b) d
length? It should be
> Herbert> better to a) draw negative values as is, or b) draw them with
> Herbert> the minimum of positive length
>
> Yes, b) is probably the best option. I'll try to do it tonight.
try this in
int LyXText::getLengthMarkerHeight(BufferView * bv, VS
> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes:
Herbert> where is the sense, that I get a long vertical line when I
Herbert> choose for example "-3cm" as vertical length? It should be
Herbert> better to a) draw negative values as is, or b) draw them with
Herbert> the minimum of positi
where is the sense, that I get a long vertical line when I choose
for example "-3cm" as vertical length? It should be better to
a) draw negative values as is, or
b) draw them with the minimum of positive length
btw: my lines are about 1cm too long on my 1200x1024 monitor
HErbert
--
http://www
>>>>> "Herbert" == Herbert Voss <[EMAIL PROTECTED]> writes:
Herbert> the new vspace marker on the left side is a good thing but
Herbert> not in tables! It's very difficult to handle a large table
Herbert> when a vspace of 2cm is marked with such a lon
the new vspace marker on the left side is a good thing but
not in tables! It's very difficult to handle a large table
when a vspace of 2cm is marked with such a long vertical
line. Should be better to mark it generally with a standard
height, because you always write explizit the value o
John Levon wrote:
>
> btw, Herbert, if you have any 1.1.6 or other files that 1.2.0cvs isn't
> happy with in whatever way, it would be great if you could email
> me them with a short note
I'll have a look at weekend. Only one thing which is not a real problem
but for the users annoying and al
On Thu, Dec 06, 2001 at 10:22:43PM +0100, Herbert Voss wrote:
> A new situation:
>
> I suppose it's no more a problem, because it happens only
>
> for 1.1.6 files which I read with 1.2.0 some time (weeks) ago.
> With latest cvs I can't reproduce.
good - I suspect
> John Levon wrote:
>
>> On Thu, Dec 06, 2001 at 07:11:57AM +0100, Herbert Voss wrote:
>>
>>
>>> looks cool ... I have only one problem:
>>> why should I see, that I don't have any space where
>>> by default is no additional space ... ;-)
>>>
>>> the floatingfigure is converted from 1.1.6 to 1.2
On Thu, Dec 06, 2001 at 10:11:59PM +0100, Herbert Voss wrote:
> sure, but this was written by lyx into the file:
>
> \layout Standard
> \added_space_top 0cm \added_space_bottom 0cm \align center
OK, so for compatibility we should convert these to VSpace::NONE
> >Did you ad
dded_space_bottom 0cm \align center
> Did you add the space of 0cm in the old lyx file, or does the 1.2.0
> import introduce it ?
this is the same which Lars reported with the two red dashed
lines, now the two vspace marker.
The appear at all tables and floats.
I'll have a look for a 1.1.6 file.
Herbert
--
http://www.lyx.org/help/
On Thu, Dec 06, 2001 at 07:11:57AM +0100, Herbert Voss wrote:
> looks cool ... I have only one problem:
> why should I see, that I don't have any space where
> by default is no additional space ... ;-)
>
> the floatingfigure is converted from 1.1.6 to 1.2
> by lyx.
Can I have the original 1.1.
looks cool ... I have only one problem:
why should I see, that I don't have any space where
by default is no additional space ... ;-)
the floatingfigure is converted from 1.1.6 to 1.2
by lyx.
Herbert
--
http://www.lyx.org/help/
On Sun, Dec 02, 2001 at 03:32:38PM +0100, Lars Gullik Bjønnes wrote:
> I like it, but can you take the cstddef and types part our of it?
Aehm.. sure...
Andre'
--
André Pönitz .. [EMAIL PROTECTED]
On Fri, Nov 30, 2001 at 06:10:51PM +0100, Herbert Voss wrote:
> why is this method in vspace?
Not my doing. Has been there all the time...
Andre'
--
André Pönitz .. [EMAIL PROTECTED]
Andre Poenitz wrote:
> A bit of the interface cleanup.
> Removes the inheritance etc,
>
> +LyXLength::UNIT unitFromString(string const & data)
> +{
> + int i = 0;
> + while (i < num_units && data != unit_name[i])
[...]
why is this method in v
_view->text->setLayout(current_view, 0);
- current_view->text->
- setParagraph(current_view, 0, 0,
-0, 0,
- VSpace (0.3 * buffer->par
On Fri, Nov 30, 2001 at 11:04:36AM +0100, Juergen Vigna wrote:
^^
> On 29-Nov-2001 Juergen Spitzmueller wrote:
^^
> > BTW: the patch is missing ;-)
> ^ Aaaarggg!
^^^
Passing arg failed.
Andre'
--
André Pönit
On Fri, Nov 30, 2001 at 11:03:58AM +0100, Juergen Vigna wrote:
>
> Which patch?
See the Urmpf message that André posted later.
>Jug
--
José Abílio Matos
LyX and docbook a perfect match.
On 29-Nov-2001 Andre Poenitz wrote:
>
> This patch is cosmetical. It basically moves stuff from the .h to the .C,
Which patch?
Jug
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel
On 29-Nov-2001 Juergen Spitzmueller wrote:
> BTW: the patch is missing ;-)
^ Aaaarggg!
Jug
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-047
Andre Poenitz wrote:
> This patch is cosmetical. It basically moves stuff from the .h to the
> .C, changes 'float' to 'double' and changes whitespaces and variable
> names to something more similar to the rest of LyX.
>
> I'll have a look at the interface later.
Cool! Please tell me when you're d
This patch is cosmetical. It basically moves stuff from the .h to the .C,
changes 'float' to 'double' and changes whitespaces and variable names to
something more similar to the rest of LyX.
I'll have a look at the interface later.
Andre'
--
André Pönitz ..
88 matches
Mail list logo
