[patch] record undo for LFUN_NEXT_INSET_MODIFY

Currently, this lfun does not touch the undo stack. The attached patch works for me. Correct approach? Jürgen Index: src/BufferView.cpp === --- src/BufferView.cpp (Revision 27887) +++ src/BufferView.cpp (Arbeitskopie) @@ -1358,11

Re: [patch] record undo for LFUN_NEXT_INSET_MODIFY

Jürgen Spitzmüller juer...@spitzmueller.org writes: Currently, this lfun does not touch the undo stack. The attached patch works for me. Correct approach? If the lfun can change other parts of the document, and dispatch is not called from top-level as should be, you may have to create an undo

Re: [patch] record undo for LFUN_NEXT_INSET_MODIFY

Jean-Marc Lasgouttes wrote: If the lfun can change other parts of the document, and dispatch is not called from top-level as should be, you may have to create an undo group. I don't think this is the case (but I don't know how to verify this either). But for now it looks good. OK, I'll put

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

sp...@lyx.org writes: // if there is an inset at cursor, see whether it // can be modified. Inset * inset = cur.nextInset(); - if (inset) + if (inset) { + cur.recordUndo();

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes jean-marc.lasgout...@inria.fr writes: I'd it is think actually where it belongs... Try that instead: I'd think it is actually where it belongs...

Re: [ANNOUNCE] LyX 1.6.1 is released

On Tue, Dec 16, 2008 at 08:06:43AM +0100, Jürgen Spitzmüller wrote: Enrico Forestieri wrote: J�rgen, you can find a cygwin binary here: http://www.lyx.org/~forenr/lyx-1.6.1-cygwin.tar.gz Thanks, Enrico. It's on the server. BTW I noticed that the cygwin binary is not mentioned on our

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes wrote: Try that instead: I'd think it is actually where it belongs... Or maybe not ;-) Jürgen

Re: signing releases

Per Olofsson wrote: Of course, there are all sorts of security issues here involving key distribution and the like, but the point is that it would still be much more secure than the present situation. Establishing a trust-path by getting your key signed would be an improvement, but it is not

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jürgen Spitzmüller juer...@spitzmueller.org writes: Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: Try that instead: I'd think it is actually where it belongs... Or maybe not ;-) Missing attachment, in case you did not understand the pun. There was no attachment, I just was

Re: [patch] fix wrap float layout

Jean-Marc Lasgouttes wrote: Yes. Note BTW that the Float and Wrap insets, which used to be almost identical structure-wise, have subtly diverge with time. I guess there are bugs to find there. In the long run, wrap should be merged into float. Jürgen

Re: [patch] fix wrap float layout

Jürgen Spitzmüller juer...@spitzmueller.org writes: In the long run, wrap should be merged into float. Yep. JMarc

Re: [patch] fix wrap float layout

Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: Yes. Note BTW that the Float and Wrap insets, which used to be almost identical structure-wise, have subtly diverge with time. I guess there are bugs to find there. In the long run, wrap should be merged into float. I remember

Re: External material problems, xfig, dia support

Pavel Sanda wrote: problem #5: colors are inversed (which at the end means i'm not able to see anything on my default black background). i was wrong here. colors are not inverse, just the background of preview gets black according to the color settings of guiview background, so

Re: signing releases

Hi, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: I guess we would need one key for you and one for Jose (we cannot share a LyX key). I have a key. But I guess it is not very authorative (due to missing counter- signs). Well, even if your keys are not signed by anyone, it still

Re: External material problems, xfig, dia support

Pavel Sanda wrote: Pavel Sanda wrote: hi, while trying to add support for dia i encountered more strange problems. after some investigation i found that these problems haven't been introduced by my changes, but are already part of lyx. can anybody confirm those problems on independent

Re: [Cvslog] r27897 - /lyx-devel/trunk/src/TextClass.cpp

rgheck wrote: OK for branch, Jurgen? This is actually a lot less than it looks: Just moving a later test to earlier, per JMarc's suggestion. OK. Jürgen

Re: Fix InsetLayout Problem

Jean-Marc Lasgouttes wrote: rgheck rgh...@bobjweil.com writes: + case TC_INSETLAYOUT: { if (lexrc.next()) { [long stuff snipped] + } else { + lexrc.printError(No name given for InsetLayout:

Re: [Cvslog] r27900 - in /lyx-devel/trunk/src: TextClass.cpp TextClass...

rgh...@lyx.org wrote: Author: rgheck Date: Tue Dec 16 17:11:15 2008 New Revision: 27900 This is the real patch, Jurgen...this one and 27901. Also needed in branch. OK? rh URL: http://www.lyx.org/trac/changeset/27900 Log: Currently, a second InsetLayout declaration of a given inset

Re: [Cvslog] r27900 - in /lyx-devel/trunk/src: TextClass.cpp TextClass...

rgheck wrote: This is the real patch, Jurgen...this one and 27901. Also needed in branch. OK? Yes, go ahead. Jürgen

Re: [ANNOUNCE] LyX 1.6.1 is released

Enrico Forestieri wrote: I think that it will suffice changing Some alternative installers can be found here: to Some alternative installers and a Cygwin binary can be found here: on that page. done. Jürgen

Re: [Cvslog] r27899 - in /lyx-devel/trunk/lib: configure.py external_t...

sa...@lyx.org wrote: Author: sanda Date: Tue Dec 16 17:07:07 2008 New Revision: 27899 URL: http://www.lyx.org/trac/changeset/27899 Log: Allow Dia diagrams as external insets. what about the branch? pavel

Re: [Cvslog] r27899 - in /lyx-devel/trunk/lib: configure.py external_t...

Pavel Sanda wrote: Allow Dia diagrams as external insets. what about the branch? I think our policy was to not introduce new External insets in branch, since this is de facto a file format change, but I'm not absolutely sure (since the same would apply to new layouts and modules). What do

Re: [patch] fix wrap float layout

rgheck rgh...@bobjweil.com writes: Jürgen Spitzmüller wrote: This one fixes the layout of wrap floats, which currently do not find their InsetLayout (and thus have this ugly red background). Looks right. Yes. Note BTW that the Float and Wrap insets, which used to be almost identical

Re: Fix InsetLayout Problem

rgheck rgh...@bobjweil.com writes: Currently, if you repeat an InsetLayout declaration, it completely over-writes the original, rather than updating it, as ordinary Style declarations do. The attached patch, for trunk, aims to fix that problem. Comments welcome. Very good. A few points: +

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: Try that instead: I'd think it is actually where it belongs... Or maybe not ;-) Missing attachment, in case you did not understand the pun. Jürgen

Re: External material problems, xfig, dia support

Pavel Sanda wrote: hi, while trying to add support for dia i encountered more strange problems. after some investigation i found that these problems haven't been introduced by my changes, but are already part of lyx. can anybody confirm those problems on independent latex setup? (0.

Re: External material problems, xfig, dia support

Pavel Sanda wrote: hi, while trying to add support for dia i encountered more strange problems. after some investigation i found that these problems haven't been introduced by my changes, but are already part of lyx. can anybody confirm those problems on independent latex setup? (0.

[patch] fix wrap float layout

This one fixes the layout of wrap floats, which currently do not find their InsetLayout (and thus have this ugly red background). Jürgen Index: src/insets/InsetWrap.cpp === --- src/insets/InsetWrap.cpp (Revision 27887) +++

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes wrote: I looked it up again, and it seems that you code is fine after all... Sorry for the fuss. No problem, I'm very happy to have you review this stuff sceptically. Jürgen

Re: [patch] fix wrap float layout

Jürgen Spitzmüller wrote: This one fixes the layout of wrap floats, which currently do not find their InsetLayout (and thus have this ugly red background). Looks right. rh

Re: [Cvslog] r27897 - /lyx-devel/trunk/src/TextClass.cpp

rgh...@lyx.org wrote: Author: rgheck Date: Tue Dec 16 17:01:32 2008 New Revision: 27897 URL: http://www.lyx.org/trac/changeset/27897 Log: Exit early to avoid indentation. OK for branch, Jurgen? This is actually a lot less than it looks: Just moving a later test to earlier, per JMarc's

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes lasgout...@lyx.org writes: There was no attachment, I just was painfully trying to express the idea that the undo should be handled in INSET_MODIFY. I'll have to check the code. I looked it up again, and it seems that you code is fine after all... Sorry for the fuss.

[patch] fix two geometry-related bugs

This attachment addresses the following two bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3838 (Compilation errors with custom margins) If the paper size options are not passed as optional argument to the geometry package, but as \geometry arguments (as we do now), some classes (such as

Fix InsetLayout Problem

Currently, if you repeat an InsetLayout declaration, it completely over-writes the original, rather than updating it, as ordinary Style declarations do. The attached patch, for trunk, aims to fix that problem. Comments welcome. Richard Index: src/insets/InsetLayout.cpp

Re: [ANNOUNCE] LyX 1.6.1 is released

Jürgen Spitzmüller wrote: Prebuilt binaries (rpms for Linux distributions, Mac OS X and Windows installers) should soon be available at ftp://ftp.lyx.org/pub/lyx/bin/1.6.1/ I've uploaded Windows installers to http://www.lyx.org/~joost/ Regards, Joost

Bug in new find and replace code

When compiling LyX 2.0svn I get: ..\..\lyx-windows-deps-msvc2008\qt-4\bin\uic -tr lyx::qt_ -o release\src\frontends\qt4\ui\ui_FindAndReplaceUi.h D:\LyXSVN\lyx-devel\src\frontends\qt4\ui\FindAndReplaceUi.ui 'layoutWidget' isn't a valid widget regards Uwe

change tracking quite unusable in LyX 1.6.x

Today me was sent a larger file created with LyX 1.5.x with change tracking enabled. When opening that file with LyX 1.6.1 every change is highlighted in blue, no matter if it was a deletion or addition. This make change tracking rather unusable. In LyX 1.5.7 deletions are correctly highlighted

Re: change tracking quite unusable in LyX 1.6.x

Uwe Stöhr schreef: Today me was sent a larger file created with LyX 1.5.x with change tracking enabled. When opening that file with LyX 1.6.1 every change is highlighted in blue, no matter if it was a deletion or addition. This make change tracking rather unusable. In LyX 1.5.7 deletions are

[patch] record undo for LFUN_NEXT_INSET_MODIFY

Currently, this lfun does not touch the undo stack. The attached patch works for me. Correct approach? Jürgen Index: src/BufferView.cpp === --- src/BufferView.cpp (Revision 27887) +++ src/BufferView.cpp (Arbeitskopie) @@ -1358,11

Re: [patch] record undo for LFUN_NEXT_INSET_MODIFY

Jürgen Spitzmüller writes: > Currently, this lfun does not touch the undo stack. > The attached patch works for me. Correct approach? If the lfun can change other parts of the document, and dispatch is not called from top-level as should be, you may have to create an

Re: [patch] record undo for LFUN_NEXT_INSET_MODIFY

Jean-Marc Lasgouttes wrote: > If the lfun can change other parts of the document, and dispatch is not > called from top-level as should be, you may have to create an undo > group. I don't think this is the case (but I don't know how to verify this either). > But for now it looks good. OK, I'll

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

sp...@lyx.org writes: > // if there is an inset at cursor, see whether it > // can be modified. > Inset * inset = cur.nextInset(); > - if (inset) > + if (inset) { > + cur.recordUndo(); >

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes writes: > I'd it is think actually where it belongs... Try that instead: I'd think it is actually where it belongs...

Re: [ANNOUNCE] LyX 1.6.1 is released

On Tue, Dec 16, 2008 at 08:06:43AM +0100, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > J�rgen, you can find a cygwin binary here: > > http://www.lyx.org/~forenr/lyx-1.6.1-cygwin.tar.gz > > Thanks, Enrico. It's on the server. > > BTW I noticed that the cygwin binary is not mentioned

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes wrote: > Try that instead: > I'd think it is actually where it belongs... Or maybe not ;-) Jürgen

Re: signing releases

Per Olofsson wrote: > Of course, there are all sorts of security issues here involving key > distribution and the like, but the point is that it would still be > much more secure than the present situation. Establishing a trust-path > by getting your key signed would be an improvement, but it is

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jürgen Spitzmüller writes: > Jürgen Spitzmüller wrote: >> Jean-Marc Lasgouttes wrote: >> > Try that instead: >> > I'd think it is actually where it belongs... >> >> Or maybe not ;-) > > Missing attachment, in case you did not understand the pun. There was no

Re: [patch] fix wrap float layout

Jean-Marc Lasgouttes wrote: > Yes. Note BTW that the Float and Wrap insets, which used to be almost > identical structure-wise, have subtly diverge with time. I guess there > are bugs to find there. In the long run, wrap should be merged into float. Jürgen

Re: [patch] fix wrap float layout

Jürgen Spitzmüller writes: > In the long run, wrap should be merged into float. Yep. JMarc

Re: [patch] fix wrap float layout

Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: Yes. Note BTW that the Float and Wrap insets, which used to be almost identical structure-wise, have subtly diverge with time. I guess there are bugs to find there. In the long run, wrap should be merged into float. I remember

Re: External material problems, xfig, dia support

Pavel Sanda wrote: > problem #5: colors are inversed (which at the end means i'm not able to see > anything > on my default black background). i was wrong here. colors are not inverse, just the background of preview gets black according to the color settings of guiview background,

Re: signing releases

Hi, Jürgen Spitzmüller wrote: > Jean-Marc Lasgouttes wrote: >> I guess we would need one key for you and one for Jose (we cannot share >> a LyX key). > > I have a key. But I guess it is not very authorative (due to missing counter- > signs). Well, even if your keys are not signed by anyone, it

Re: External material problems, xfig, dia support

Pavel Sanda wrote: Pavel Sanda wrote: hi, while trying to add support for dia i encountered more strange problems. after some investigation i found that these problems haven't been introduced by my changes, but are already part of lyx. can anybody confirm those problems on independent

Re: [Cvslog] r27897 - /lyx-devel/trunk/src/TextClass.cpp

rgheck wrote: > OK for branch, Jurgen? This is actually a lot less than it looks: Just > moving a later test to earlier, per JMarc's suggestion. OK. Jürgen

Re: Fix InsetLayout Problem

Jean-Marc Lasgouttes wrote: rgheck writes: + case TC_INSETLAYOUT: { if (lexrc.next()) { [long stuff snipped] + } else { + lexrc.printError("No name given for InsetLayout:

Re: [Cvslog] r27900 - in /lyx-devel/trunk/src: TextClass.cpp TextClass...

rgh...@lyx.org wrote: Author: rgheck Date: Tue Dec 16 17:11:15 2008 New Revision: 27900 This is the real patch, Jurgen...this one and 27901. Also needed in branch. OK? rh URL: http://www.lyx.org/trac/changeset/27900 Log: Currently, a second InsetLayout declaration of a given inset

Re: [Cvslog] r27900 - in /lyx-devel/trunk/src: TextClass.cpp TextClass...

rgheck wrote: > This is the real patch, Jurgen...this one and 27901. Also needed in > branch. OK? Yes, go ahead. Jürgen

Re: [ANNOUNCE] LyX 1.6.1 is released

Enrico Forestieri wrote: > I think that it will suffice changing "Some alternative installers can be > found here:" to "Some alternative installers and a Cygwin binary can be > found here:" on that page. done. Jürgen

Re: [Cvslog] r27899 - in /lyx-devel/trunk/lib: configure.py external_t...

sa...@lyx.org wrote: > Author: sanda > Date: Tue Dec 16 17:07:07 2008 > New Revision: 27899 > > URL: http://www.lyx.org/trac/changeset/27899 > Log: > Allow Dia diagrams as external insets. what about the branch? pavel

Re: [Cvslog] r27899 - in /lyx-devel/trunk/lib: configure.py external_t...

Pavel Sanda wrote: > > Allow Dia diagrams as external insets. > > what about the branch? I think our policy was to not introduce new External insets in branch, since this is de facto a file format change, but I'm not absolutely sure (since the same would apply to new layouts and modules). What

Re: [patch] fix wrap float layout

rgheck writes: > Jürgen Spitzmüller wrote: >> This one fixes the layout of wrap floats, which currently do not >> find their InsetLayout (and thus have this ugly red background). >> >> > Looks right. Yes. Note BTW that the Float and Wrap insets, which used to be almost

Re: Fix InsetLayout Problem

rgheck writes: > Currently, if you repeat an InsetLayout declaration, it completely > over-writes the original, rather than updating it, as ordinary Style > declarations do. The attached patch, for trunk, aims to fix that > problem. Comments welcome. Very good. A few

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jürgen Spitzmüller wrote: > Jean-Marc Lasgouttes wrote: > > Try that instead: > > I'd think it is actually where it belongs... > > Or maybe not ;-) Missing attachment, in case you did not understand the pun. Jürgen

Re: External material problems, xfig, dia support

Pavel Sanda wrote: > hi, > > while trying to add support for dia i encountered more strange problems. > after some investigation i found that these problems haven't been introduced > by my changes, but are already part of lyx. > > can anybody confirm those problems on independent latex setup? >

Re: External material problems, xfig, dia support

Pavel Sanda wrote: > hi, > > while trying to add support for dia i encountered more strange problems. > after some investigation i found that these problems haven't been introduced > by my changes, but are already part of lyx. > > can anybody confirm those problems on independent latex setup? >

[patch] fix wrap float layout

This one fixes the layout of wrap floats, which currently do not find their InsetLayout (and thus have this ugly red background). Jürgen Index: src/insets/InsetWrap.cpp === --- src/insets/InsetWrap.cpp (Revision 27887) +++

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes wrote: > I looked it up again, and it seems that you code is fine after all... > > Sorry for the fuss. No problem, I'm very happy to have you review this stuff sceptically. Jürgen

Re: [patch] fix wrap float layout

Jürgen Spitzmüller wrote: This one fixes the layout of wrap floats, which currently do not find their InsetLayout (and thus have this ugly red background). Looks right. rh

Re: [Cvslog] r27897 - /lyx-devel/trunk/src/TextClass.cpp

rgh...@lyx.org wrote: Author: rgheck Date: Tue Dec 16 17:01:32 2008 New Revision: 27897 URL: http://www.lyx.org/trac/changeset/27897 Log: Exit early to avoid indentation. OK for branch, Jurgen? This is actually a lot less than it looks: Just moving a later test to earlier, per JMarc's

Re: [Cvslog] r27890 - in /lyx-devel/branches/BRANCH_1_6_X: src/BufferV...

Jean-Marc Lasgouttes writes: > There was no attachment, I just was painfully trying to express the idea > that the undo should be handled in INSET_MODIFY. I'll have to check the > code. I looked it up again, and it seems that you code is fine after all... Sorry for the fuss.

[patch] fix two geometry-related bugs

This attachment addresses the following two bugs: http://bugzilla.lyx.org/show_bug.cgi?id=3838 (Compilation errors with custom margins) If the paper size options are not passed as optional argument to the geometry package, but as \geometry arguments (as we do now), some classes (such as

Fix InsetLayout Problem

Currently, if you repeat an InsetLayout declaration, it completely over-writes the original, rather than updating it, as ordinary Style declarations do. The attached patch, for trunk, aims to fix that problem. Comments welcome. Richard Index: src/insets/InsetLayout.cpp

Re: [ANNOUNCE] LyX 1.6.1 is released

Jürgen Spitzmüller wrote: Prebuilt binaries (rpms for Linux distributions, Mac OS X and Windows installers) should soon be available at ftp://ftp.lyx.org/pub/lyx/bin/1.6.1/ I've uploaded Windows installers to http://www.lyx.org/~joost/ Regards, Joost

Bug in new find and replace code

When compiling LyX 2.0svn I get: ..\..\lyx-windows-deps-msvc2008\qt-4\bin\uic -tr lyx::qt_ -o release\src\frontends\qt4\ui\ui_FindAndReplaceUi.h D:\LyXSVN\lyx-devel\src\frontends\qt4\ui\FindAndReplaceUi.ui 'layoutWidget' isn't a valid widget regards Uwe

change tracking quite unusable in LyX 1.6.x

Today me was sent a larger file created with LyX 1.5.x with change tracking enabled. When opening that file with LyX 1.6.1 every change is highlighted in blue, no matter if it was a deletion or addition. This make change tracking rather unusable. In LyX 1.5.7 deletions are correctly highlighted

Re: change tracking quite unusable in LyX 1.6.x

Uwe Stöhr schreef: Today me was sent a larger file created with LyX 1.5.x with change tracking enabled. When opening that file with LyX 1.6.1 every change is highlighted in blue, no matter if it was a deletion or addition. This make change tracking rather unusable. In LyX 1.5.7 deletions are