Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/15 06:16, Uwe Stöhr a écrit : Dear LyXers, the attached patch makes it possible to choose a frame color and a background color for boxes. I see that this does not replace boxes with shaded background. Do we really need to have all these types of boxes now? OK to go in? A few

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Jean-Marc Lasgouttes
Le 14/05/15 22:31, Guillaume M-M a écrit : My typical use case is to change the macro while keeping the same arguments. In the absolute, it is easy to see that this can be useful occasionally at least. Indeed, in the absence of macro-unfolding, the alternative is to copy and paste the arguments

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 12:04:50, schrieb Stephan Witt st.w...@gmx.net Am 14.05.2015 um 22:08 schrieb Stephan Witt st.w...@gmx.net: Am 14.05.2015 um 20:07 schrieb Jean-Marc Lasgouttes lasgout...@lyx.org: Le 13/05/2015 22:52, Stephan Witt a écrit : Am 13.05.2015 um 10:42 schrieb

Re: [LyX/master] Shut up compiler warning

2015-05-15 Thread Stephan Witt
Am 14.05.2015 um 20:22 schrieb Georg Baum georg.b...@post.rwth-aachen.de: Stephan Witt wrote: Please, what's the compiler switch to enable these warnings? I don't see them. Neither with the settings of automake nor with the settings of cmake builds. autoconf with --enable-warnings and

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/15 13:58, Uwe Stöhr a écrit : This has nothing to do with the announcement of a soon feature freeze. As you saw I had now some more time for LyX and used it to work on my ToAdd list. Nevertheless I like to have more frequent major releases. So fine with me if you say feature freeze

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/15 12:42, Stephan Witt a écrit : Thank you. The current splash has a size of 400x250. I'll attach the 1600x1000 splash banner to test. It would be great if this is ok too. If not I have to get it right myself. Why is there a need to set a size for the splash? Since it is

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 06:16 schrieb Uwe Stöhr: the attached patch makes it possible to choose a frame color and a background color for boxes. Attached is a better patch. (I forgot to register xcolor and now also take care that a box with a frame color black cannot have no background color)

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 10:50 schrieb Jean-Marc Lasgouttes: A few comments on the patch follow. Many thanks JMarc, +static QListColorPair colorData() +{ Please use anonymous namespace rather than static in this case (no, I cannot tell you why; but anways I think it is in our code

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 14.05.2015 um 22:08 schrieb Stephan Witt st.w...@gmx.net: Am 14.05.2015 um 20:07 schrieb Jean-Marc Lasgouttes lasgout...@lyx.org: Le 13/05/2015 22:52, Stephan Witt a écrit : Am 13.05.2015 um 10:42 schrieb Jean-Marc Lasgouttes lasgout...@lyx.org: Hi there, The ritual question: what

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 12:42:01, schrieb Stephan Witt st.w...@gmx.net Am 15.05.2015 um 12:33 schrieb Kornel Benko kor...@lyx.org: Am Freitag, 15. Mai 2015 um 12:04:50, schrieb Stephan Witt st.w...@gmx.net Am 14.05.2015 um 22:08 schrieb Stephan Witt st.w...@gmx.net: Am 14.05.2015 um

Re: 2.2

2015-05-15 Thread Uwe Stöhr
Am 14.05.2015 um 20:10 schrieb Jean-Marc Lasgouttes: Since a long time I have some time for LyX and ant to use is to enrich it with some more features if possible. So if it is not urgent I would be happy not to start the feature freeze before June. I am not sure that the point when we discuss

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 14:32 schrieb Jean-Marc Lasgouttes lasgout...@lyx.org: Le 15/05/15 12:42, Stephan Witt a écrit : Thank you. The current splash has a size of 400x250. I'll attach the 1600x1000 splash banner to test. It would be great if this is ok too. If not I have to get it right myself.

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 12:42:01PM +0200, Stephan Witt wrote: Thank you. The current splash has a size of 400x250. I'll attach the 1600x1000 splash banner to test. It would be great if this is ok too. If not I have to get it right myself. Why is this (compressed) svg image so big? Are you

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 15:14 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 02:53:22PM +0200, Enrico Forestieri wrote: On Fri, May 15, 2015 at 12:42:01PM +0200, Stephan Witt wrote: Thank you. The current splash has a size of 400x250. I'll attach the 1600x1000 splash banner to

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: I'll try to get it running on Linux to see how it works there. Meanwhile, I'm interested in comments. Please, don't pass back and forth QPixmap objects on the stack. These are big objects, potentially. Instead, use bool

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 14:49 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: I'll try to get it running on Linux to see how it works there. Meanwhile, I'm interested in comments. Please, don't pass back and forth QPixmap objects on the

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2015 16:58, Stephan Witt a écrit : Yes, I think that it is better passing big objects by reference rather than by value. But this is not a good property of C++ compilers than. 1. It's not a constant fact if an object is big. 2. The compiler should generate fast code for this scenario

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 16:53:51, schrieb Stephan Witt st.w...@gmx.net Compile error with this patch. That's no surprise. The method I've changed is used in conditionally compiled code. Attached is an updated patch. Still problems ... [ 30%] Building CXX object

Re: about our lyx2lyx reversion policy

2015-05-15 Thread Uwe Stöhr
Am 14.05.2015 um 14:34 schrieb Jürgen Spitzmüller: I disagree with this proposal and opt for going with our current policy. But why? What are your arguments? What are your experiences with collaborations? regards Uwe

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 03:45:28PM +0200, Stephan Witt wrote: Am 15.05.2015 um 15:14 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 02:53:22PM +0200, Enrico Forestieri wrote: On Fri, May 15, 2015 at 12:42:01PM +0200, Stephan Witt wrote: Thank you. The current splash

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 04:58:24PM +0200, Stephan Witt wrote: Am 15.05.2015 um 16:48 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 04:31:05PM +0200, Stephan Witt wrote: This results in the following patch - if you had something like that in mind I'll split it in

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 21:41 schrieb Georg Baum: 1) It is impossible to manually verify in this huge diff whether the new references are really correct. I wondered about that too. Thanks for taking care and adding the note. However, the huge diff shows that tex2lyx is not yet producing the same

Re: 2.2

2015-05-15 Thread Jürgen Spitzmüller
2015-05-15 15:14 GMT+02:00 Enrico Forestieri: Indeed, I found the attached 4 (base64 encoded) bitmaps embedded in the svg. That's bad. I just hacked this svg splash together quite quickly for testing pruposes. It is _not_ intended to be published. I agree, of course, that the final splash

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 16:48 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 04:31:05PM +0200, Stephan Witt wrote: This results in the following patch - if you had something like that in mind I'll split it in two patches. The other getPixmap method with QPixmap result was

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 15:46 schrieb Stephan Witt st.w...@gmx.net: Am 15.05.2015 um 14:49 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: I'll try to get it running on Linux to see how it works there. Meanwhile, I'm interested in comments.

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 04:31:05PM +0200, Stephan Witt wrote: This results in the following patch - if you had something like that in mind I'll split it in two patches. The other getPixmap method with QPixmap result was already there. Yes, I think that it is better passing big objects by

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 16:31:05, schrieb Stephan Witt st.w...@gmx.net Am 15.05.2015 um 15:46 schrieb Stephan Witt st.w...@gmx.net: Am 15.05.2015 um 14:49 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: I'll try to get it

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 16:40 schrieb Kornel Benko kor...@lyx.org: Am Freitag, 15. Mai 2015 um 16:31:05, schrieb Stephan Witt st.w...@gmx.net Am 15.05.2015 um 15:46 schrieb Stephan Witt st.w...@gmx.net: Am 15.05.2015 um 14:49 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Guillaume M-M
On 05/15/15 10:04, Jean-Marc Lasgouttes wrote: Le 14/05/15 22:31, Guillaume M-M a écrit : My typical use case is to change the macro while keeping the same arguments. In the absolute, it is easy to see that this can be useful occasionally at least. Indeed, in the absence of macro-unfolding, the

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 18:34 schrieb Jean-Marc Lasgouttes: Actually I see now that static is still used more often than anonymous namespaces in current code. So you can probably leave it as it is. OK. I have put the patch in with static. regards Uwe

Re: [LyX/master] support for all default colors of the package xcolor

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 05:14 schrieb Scott Kostyshak: Is there a reason why White is the only one that is not alphabetized? Note that it was like this before your patch but this just seems a convenient place to bring this up. You are right, there is no reason to treat white differently. I am aware

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 16.05.2015 um 00:48 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 03:45:28PM +0200, Stephan Witt wrote: Am 15.05.2015 um 15:14 schrieb Enrico Forestieri for...@lyx.org: On Fri, May 15, 2015 at 02:53:22PM +0200, Enrico Forestieri wrote: On Fri, May 15, 2015 at

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 09:06:34PM +0200, Georg Baum wrote: Can you try again pelase? c_str() was not instantiated explicitly (because on linux it is automatically instantiated). Yes, it now compiles on both solaris and cygwin. However, on solaris, a spurious warning is printed after each

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Georg Baum
Am 14.05.2015 um 23:13 schrieb Uwe Stöhr: commit afdfc3cf43501a0728cef79385b31afe6f4cf877 Author: Uwe Stöhr uwesto...@lyx.org Date: Thu May 14 23:13:14 2015 +0200 tex2lyx testfiles: update to latest fileformat Uwe, I appreciate your effort to update the tests, but unfortunately it

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Georg Baum
Kornel Benko wrote: Am Donnerstag, 14. Mai 2015 um 21:05:23, schrieb Georg Baum georg.b...@post.rwth-aachen.de Kornel Benko wrote: This does not cover all tex2lyx tests used under cmake. IMHO calling these tests tex2lyx tests is confusing. They test nothing in tex2lyx which the

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 21:41:37, schrieb Georg Baum georg.b...@post.rwth-aachen.de Am 14.05.2015 um 23:13 schrieb Uwe Stöhr: commit afdfc3cf43501a0728cef79385b31afe6f4cf877 Author: Uwe Stöhr uwesto...@lyx.org Date: Thu May 14 23:13:14 2015 +0200 tex2lyx testfiles: update to

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Le 14/05/15 22:31, Guillaume M-M a écrit : My typical use case is to change the macro while keeping the same arguments. In the absolute, it is easy to see that this can be useful occasionally at least. Indeed, in the absence of macro-unfolding, the alternative is

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Le 14/05/2015 21:00, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: It is a dummy inset that can be used like a MathInset from outside, but forwards every work to the math macro cell that it represents. This allows to store the expanded cells in a standard

Re: [LyX/master] Shut up compiler warning

2015-05-15 Thread Georg Baum
Stephan Witt wrote: Thanks. I'm using clang and the only way to get this warning is -Wconversion, AFAIK. With these warnings enabled I'm getting tons of warnings for boost and Qt headers. So, I'll let it disabled then. With -Wfloat-conversion you'll also get some in qt and boost, but not as

Re: layout tests are failing

2015-05-15 Thread Georg Baum
Enrico Forestieri wrote: Sorry, I cannot run the tests so I could not see this but I know why it happens. Now addLocalLayout() returns a full path if a local layout file is found. Hence, it has to be stripped before being used as an index. Should be fixed now. Thanks, works fine now. Georg

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Georg Baum
Enrico Forestieri wrote: Sure. This is on Solaris: g++ -fPIC -O2-L/usr/local/lib -Wl,-R/usr/local/lib -L/opt/lib -Wl,-R/opt/lib -L/usr/X11/lib -Wl,-R/usr/X11/lib -o check_trivstring check_trivstring.o dummy_functions.o boost.o liblyxsupport.a -liconv ../../boost/liblyxboost.a

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 17:51 schrieb Jean-Marc Lasgouttes lasgout...@lyx.org: Le 15/05/2015 16:58, Stephan Witt a écrit : Yes, I think that it is better passing big objects by reference rather than by value. But this is not a good property of C++ compilers than. 1. It's not a constant fact if an

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2015 18:47, Stephan Witt a écrit : C++ rvalue references fix this problem, and they re implemented in Qt5 (and partly in Qt4.8 AFAICS). Can you give an example, please? And what's with return value optimization? I'm not sure I understood it completely, but it sounds like returning

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2015 13:48, Uwe Stöhr a écrit : Am 15.05.2015 um 10:50 schrieb Jean-Marc Lasgouttes: A few comments on the patch follow. Many thanks JMarc, +static QListColorPair colorData() +{ Please use anonymous namespace rather than static in this case (no, I cannot tell you why;

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 21:45:51, schrieb Georg Baum georg.b...@post.rwth-aachen.de Kornel Benko wrote: Am Donnerstag, 14. Mai 2015 um 21:05:23, schrieb Georg Baum georg.b...@post.rwth-aachen.de Kornel Benko wrote: This does not cover all tex2lyx tests used under cmake.

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/15 06:16, Uwe Stöhr a écrit : Dear LyXers, the attached patch makes it possible to choose a frame color and a background color for boxes. I see that this does not replace boxes with shaded background. Do we really need to have all these types of boxes now? OK to go in? A few

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Jean-Marc Lasgouttes
Le 14/05/15 22:31, Guillaume M-M a écrit : My typical use case is to change the macro while keeping the same arguments. In the absolute, it is easy to see that this can be useful occasionally at least. Indeed, in the absence of macro-unfolding, the alternative is to copy and paste the arguments

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 14.05.2015 um 22:08 schrieb Stephan Witt : > Am 14.05.2015 um 20:07 schrieb Jean-Marc Lasgouttes : > >> Le 13/05/2015 22:52, Stephan Witt a écrit : >>> Am 13.05.2015 um 10:42 schrieb Jean-Marc Lasgouttes : >>> Hi there,

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 12:04:50, schrieb Stephan Witt > Am 14.05.2015 um 22:08 schrieb Stephan Witt : > > > Am 14.05.2015 um 20:07 schrieb Jean-Marc Lasgouttes : > > > >> Le 13/05/2015 22:52, Stephan Witt a écrit : > >>> Am 13.05.2015

Re: [LyX/master] Shut up compiler warning

2015-05-15 Thread Stephan Witt
Am 14.05.2015 um 20:22 schrieb Georg Baum : > Stephan Witt wrote: > >> Please, what's the compiler switch to enable these warnings? >> I don't see them. Neither with the settings of automake nor >> with the settings of cmake builds. > > autoconf with

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 12:42:01, schrieb Stephan Witt > Am 15.05.2015 um 12:33 schrieb Kornel Benko : > > > Am Freitag, 15. Mai 2015 um 12:04:50, schrieb Stephan Witt > >> Am 14.05.2015 um 22:08 schrieb Stephan Witt : > >> >

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 06:16 schrieb Uwe Stöhr: > the attached patch makes it possible to choose a frame color and a background color for boxes. Attached is a better patch. (I forgot to register xcolor and now also take care that a box with a frame color <> black cannot have no background color)

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 10:50 schrieb Jean-Marc Lasgouttes: > A few comments on the patch follow. Many thanks JMarc, +static QList colorData() +{ Please use anonymous namespace rather than static in this case (no, I cannot tell you why; but anways I think it is in our code rules).

Re: 2.2

2015-05-15 Thread Uwe Stöhr
Am 14.05.2015 um 20:10 schrieb Jean-Marc Lasgouttes: Since a long time I have some time for LyX and ant to use is to enrich it with some more features if possible. So if it is not urgent I would be happy not to start the feature freeze before June. I am not sure that the point when we discuss

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/15 13:58, Uwe Stöhr a écrit : This has nothing to do with the announcement of a soon feature freeze. As you saw I had now some more time for LyX and used it to work on my ToAdd list. Nevertheless I like to have more frequent major releases. So fine with me if you say feature freeze

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/15 12:42, Stephan Witt a écrit : Thank you. The current splash has a size of 400x250. I'll attach the 1600x1000 splash banner to test. It would be great if this is ok too. If not I have to get it right myself. Why is there a need to set a size for the splash? Since it is

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: > > I'll try to get it running on Linux to see how it works there. Meanwhile, > I'm interested in comments. Please, don't pass back and forth QPixmap objects on the stack. These are big objects, potentially. Instead, use bool

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 12:42:01PM +0200, Stephan Witt wrote: > > Thank you. The current splash has a size of 400x250. I'll attach the > 1600x1000 splash banner to test. > It would be great if this is ok too. If not I have to get it right myself. Why is this (compressed) svg image so big? Are

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 15:14 schrieb Enrico Forestieri : > On Fri, May 15, 2015 at 02:53:22PM +0200, Enrico Forestieri wrote: >> On Fri, May 15, 2015 at 12:42:01PM +0200, Stephan Witt wrote: >>> >>> Thank you. The current splash has a size of 400x250. I'll attach the >>> 1600x1000

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 14:49 schrieb Enrico Forestieri : > On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: >> >> I'll try to get it running on Linux to see how it works there. Meanwhile, >> I'm interested in comments. > > Please, don't pass back and forth QPixmap objects

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 14:32 schrieb Jean-Marc Lasgouttes : > Le 15/05/15 12:42, Stephan Witt a écrit : >> Thank you. The current splash has a size of 400x250. I'll attach the >> 1600x1000 splash banner to test. >> It would be great if this is ok too. If not I have to get it right

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 15:46 schrieb Stephan Witt : > Am 15.05.2015 um 14:49 schrieb Enrico Forestieri : > >> On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: >>> >>> I'll try to get it running on Linux to see how it works there. Meanwhile, >>> I'm

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 16:31:05, schrieb Stephan Witt > Am 15.05.2015 um 15:46 schrieb Stephan Witt : > > > Am 15.05.2015 um 14:49 schrieb Enrico Forestieri : > > > >> On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote: > >>> >

Re: 2.2

2015-05-15 Thread Jürgen Spitzmüller
2015-05-15 15:14 GMT+02:00 Enrico Forestieri: > Indeed, I found the attached 4 (base64 encoded) bitmaps embedded in the > svg. > That's bad. > I just hacked this svg splash together quite quickly for testing pruposes. It is _not_ intended to be published. I agree, of course, that the final

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 04:31:05PM +0200, Stephan Witt wrote: > > This results in the following patch - if you had something like that in > mind I'll split it in two patches. The other getPixmap method with > QPixmap result was already there. Yes, I think that it is better passing big objects by

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 16:40 schrieb Kornel Benko : > Am Freitag, 15. Mai 2015 um 16:31:05, schrieb Stephan Witt >> Am 15.05.2015 um 15:46 schrieb Stephan Witt : >> >>> Am 15.05.2015 um 14:49 schrieb Enrico Forestieri : >>> On

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 16:48 schrieb Enrico Forestieri : > On Fri, May 15, 2015 at 04:31:05PM +0200, Stephan Witt wrote: >> >> This results in the following patch - if you had something like that in >> mind I'll split it in two patches. The other getPixmap method with >> QPixmap result

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Guillaume M-M
On 05/15/15 10:04, Jean-Marc Lasgouttes wrote: Le 14/05/15 22:31, Guillaume M-M a écrit : My typical use case is to change the macro while keeping the same arguments. In the absolute, it is easy to see that this can be useful occasionally at least. Indeed, in the absence of macro-unfolding, the

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2015 16:58, Stephan Witt a écrit : Yes, I think that it is better passing big objects by reference rather than by value. But this is not a good property of C++ compilers than. 1. It's not a constant fact if an object is big. 2. The compiler should generate fast code for this scenario

Re: 2.2

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 16:53:51, schrieb Stephan Witt > > > > Compile error with this patch. > > That's no surprise. The method I've changed is used in conditionally compiled > code. > Attached is an updated patch. > Still problems ... [ 30%] Building CXX object

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2015 13:48, Uwe Stöhr a écrit : Am 15.05.2015 um 10:50 schrieb Jean-Marc Lasgouttes: > A few comments on the patch follow. Many thanks JMarc, +static QList colorData() +{ Please use anonymous namespace rather than static in this case (no, I cannot tell you why; but

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 15.05.2015 um 17:51 schrieb Jean-Marc Lasgouttes : > Le 15/05/2015 16:58, Stephan Witt a écrit : >>> Yes, I think that it is better passing big objects by reference rather >>> than by value. >> >> But this is not a good property of C++ compilers than. >> 1. It's not a

Re: 2.2

2015-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2015 18:47, Stephan Witt a écrit : C++ rvalue references fix this problem, and they re implemented in Qt5 (and partly in Qt4.8 AFAICS). Can you give an example, please? And what's with return value optimization? I'm not sure I understood it completely, but it sounds like returning

Re: [LyX/master] Shut up compiler warning

2015-05-15 Thread Georg Baum
Stephan Witt wrote: > Thanks. I'm using clang and the only way to get this warning is > -Wconversion, AFAIK. With these warnings enabled I'm getting tons of > warnings for boost and Qt headers. So, I'll let it disabled then. With -Wfloat-conversion you'll also get some in qt and boost, but not

Re: layout tests are failing

2015-05-15 Thread Georg Baum
Enrico Forestieri wrote: > Sorry, I cannot run the tests so I could not see this but I know why it > happens. Now addLocalLayout() returns a full path if a local layout file > is found. Hence, it has to be stripped before being used as an index. > Should be fixed now. Thanks, works fine now.

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Georg Baum
Enrico Forestieri wrote: > Sure. This is on Solaris: > > g++ -fPIC -O2-L/usr/local/lib -Wl,-R/usr/local/lib -L/opt/lib > -Wl,-R/opt/lib -L/usr/X11/lib -Wl,-R/usr/X11/lib -o check_trivstring > check_trivstring.o dummy_functions.o boost.o liblyxsupport.a -liconv > ../../boost/liblyxboost.a

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Georg Baum
Am 14.05.2015 um 23:13 schrieb Uwe Stöhr: commit afdfc3cf43501a0728cef79385b31afe6f4cf877 Author: Uwe Stöhr Date: Thu May 14 23:13:14 2015 +0200 tex2lyx testfiles: update to latest fileformat Uwe, I appreciate your effort to update the tests, but unfortunately it

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Georg Baum
Kornel Benko wrote: > Am Donnerstag, 14. Mai 2015 um 21:05:23, schrieb Georg Baum > >> Kornel Benko wrote: >> >> > This does not cover all tex2lyx tests used under cmake. >> >> IMHO calling these tests tex2lyx tests is confusing. They test nothing in >> tex2lyx

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 14/05/15 22:31, Guillaume M-M a écrit : >> My typical use case is to change the macro while keeping the same >> arguments. In the absolute, it is easy to see that this can be useful >> occasionally at least. Indeed, in the absence of macro-unfolding, the >>

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 14/05/2015 21:00, Georg Baum a écrit : >> Jean-Marc Lasgouttes wrote: >> >> It is a dummy inset that can be used like a MathInset from outside, but >> forwards every work to the math macro cell that it represents. This >> allows to store the expanded cells in a

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 21:41:37, schrieb Georg Baum > Am 14.05.2015 um 23:13 schrieb Uwe Stöhr: > > commit afdfc3cf43501a0728cef79385b31afe6f4cf877 > > Author: Uwe Stöhr > > Date: Thu May 14 23:13:14 2015 +0200 > > > > tex2lyx

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Kornel Benko
Am Freitag, 15. Mai 2015 um 21:45:51, schrieb Georg Baum > Kornel Benko wrote: > > > Am Donnerstag, 14. Mai 2015 um 21:05:23, schrieb Georg Baum > > > >> Kornel Benko wrote: > >> > >> > This does not cover all tex2lyx tests used

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 04:58:24PM +0200, Stephan Witt wrote: > Am 15.05.2015 um 16:48 schrieb Enrico Forestieri : > > > On Fri, May 15, 2015 at 04:31:05PM +0200, Stephan Witt wrote: > >> > >> This results in the following patch - if you had something like that in > >> mind I'll

Re: 2.2

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 03:45:28PM +0200, Stephan Witt wrote: > Am 15.05.2015 um 15:14 schrieb Enrico Forestieri : > > > On Fri, May 15, 2015 at 02:53:22PM +0200, Enrico Forestieri wrote: > >> On Fri, May 15, 2015 at 12:42:01PM +0200, Stephan Witt wrote: > >>> > >>> Thank you.

Re: about our lyx2lyx reversion policy

2015-05-15 Thread Uwe Stöhr
Am 14.05.2015 um 14:34 schrieb Jürgen Spitzmüller: I disagree with this proposal and opt for going with our current policy. But why? What are your arguments? What are your experiences with collaborations? regards Uwe

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 21:41 schrieb Georg Baum: 1) It is impossible to manually verify in this huge diff whether the new references are really correct. I wondered about that too. Thanks for taking care and adding the note. However, the huge diff shows that tex2lyx is not yet producing the same

Re: [patch] support for \fcolorbox and \colorbox

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 18:34 schrieb Jean-Marc Lasgouttes: Actually I see now that "static" is still used more often than anonymous namespaces in current code. So you can probably leave it as it is. OK. I have put the patch in with static. regards Uwe

Re: [LyX/master] support for all default colors of the package xcolor

2015-05-15 Thread Uwe Stöhr
Am 15.05.2015 um 05:14 schrieb Scott Kostyshak: Is there a reason why "White" is the only one that is not alphabetized? Note that it was like this before your patch but this just seems a convenient place to bring this up. You are right, there is no reason to treat white differently. I am

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Enrico Forestieri
On Fri, May 15, 2015 at 09:06:34PM +0200, Georg Baum wrote: > > Can you try again pelase? c_str() was not instantiated explicitly (because > on linux it is automatically instantiated). Yes, it now compiles on both solaris and cygwin. However, on solaris, a spurious warning is printed after each

Re: 2.2

2015-05-15 Thread Stephan Witt
Am 16.05.2015 um 00:48 schrieb Enrico Forestieri : > On Fri, May 15, 2015 at 03:45:28PM +0200, Stephan Witt wrote: > >> Am 15.05.2015 um 15:14 schrieb Enrico Forestieri : >> >>> On Fri, May 15, 2015 at 02:53:22PM +0200, Enrico Forestieri wrote: On Fri, May