Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

2016-06-12 Thread Scott Kostyshak
On Sun, Jun 12, 2016 at 03:27:24PM +0200, Georg Baum wrote: > Scott Kostyshak wrote: > > > I tried xmingw-script on current master but it does not succeed for me. > > > > I get the following: > > > > error: > > In file included from > > >

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

2016-06-12 Thread Scott Kostyshak
On Sun, Jun 12, 2016 at 10:15:53AM +0200, Kornel Benko wrote: > Am Samstag, 11. Juni 2016 um 20:50:43, schrieb Scott Kostyshak > > > On Sat, Jun 11, 2016 at 07:30:55PM -0400, Scott Kostyshak wrote: > > > On Sun, Jun 12, 2016 at 12:23:18AM +0200, Kornel Benko wrote: > > > > Am

Re: [LyX/2.2.x] * Math.lyx : add few maxima examples to ch. 23.1.

2016-06-12 Thread Pavel Sanda
Uwe Stöhr wrote: >> commit 8a1578e40543edfa5a23b22058753298e58bdfbb >> Author: Pavel Sanda >> Date: Sat Jun 11 11:23:39 2016 -0700 >> >> * Math.lyx : add few maxima examples to ch. 23.1. > > Pavel, > > please don't commit things to the branch doc files without discussion.

Re: compilation for coverity fails

2016-06-12 Thread Guillaume Munch
Le 12/06/2016 19:59, Jean-Marc Lasgouttes a écrit : Le 12/06/2016 20:53, Richard Heck a écrit : I don't think we have a definite policy, but it would be a good sort of comment to have. Coverity seems to want the comment right before the code it complains about, though, so I'm not sure this can

Re: [LyX/2.2.x] * Math.lyx : add few maxima examples to ch. 23.1.

2016-06-12 Thread Uwe Stöhr
commit 8a1578e40543edfa5a23b22058753298e58bdfbb Author: Pavel Sanda Date: Sat Jun 11 11:23:39 2016 -0700 * Math.lyx : add few maxima examples to ch. 23.1. Pavel, please don't commit things to the branch doc files without discussion. In general, please use change

Re: [LyX/2.2.x] Fix compilation with Qt < 4.7

2016-06-12 Thread Guillaume Munch
Le 12/06/2016 23:23, Richard Heck a écrit : On 06/12/2016 06:13 PM, Guillaume Munch wrote: commit e6d28aad0a6f267c5ce51c5205fdb60343a7fc90 Author: Guillaume Munch Date: Sat Jun 11 05:41:48 2016 +0100 Fix compilation with Qt < 4.7 Probably this should go to 2.2.x, as

Re: [LyX/2.2.x] Fix compilation with Qt < 4.7

2016-06-12 Thread Richard Heck
On 06/12/2016 06:13 PM, Guillaume Munch wrote: > commit e6d28aad0a6f267c5ce51c5205fdb60343a7fc90 > Author: Guillaume Munch > Date: Sat Jun 11 05:41:48 2016 +0100 > > Fix compilation with Qt < 4.7 Probably this should go to 2.2.x, as well. Richard

Re: compilation for coverity fails

2016-06-12 Thread Richard Heck
On 06/12/2016 02:59 PM, Jean-Marc Lasgouttes wrote: > Le 12/06/2016 20:53, Richard Heck a écrit : >> I don't think we have a definite policy, but it would be a good sort of >> comment to have. >> >> Coverity seems to want the comment right before the code it complains >> about, though, so I'm not

Re: Why is the filesystemencoding needed for \origin lyx2lyx?

2016-06-12 Thread Enrico Forestieri
On Sun, Jun 12, 2016 at 07:21:48PM +0200, Georg Baum wrote: > Hi Enrico, > > you added an encoding conversion in lyx2lyx here: > http://www.lyx.org/trac/changeset/a0afd345/lyxgit > > Can you please explain why this is needed, but not on windows? According to my recollection, because on windows

Re: [LyX/master] Make lyx2lyx infrastructure python3 ready

2016-06-12 Thread Georg Baum
Georg Baum wrote: > commit 166420d02ccb073dc32ab5cd0bc466de54aa36bb > Author: Georg Baum > Date: Sun Jun 12 21:21:15 2016 +0200 > > Make lyx2lyx infrastructure python3 ready > > The LyX class works now with python 3. Certain file format conversions > may still

Re: compilation for coverity fails

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 20:53, Richard Heck a écrit : I don't think we have a definite policy, but it would be a good sort of comment to have. Coverity seems to want the comment right before the code it complains about, though, so I'm not sure this can be done ahead of time. We can also provide models

Re: compilation for coverity fails

2016-06-12 Thread Richard Heck
On 06/12/2016 02:45 PM, Guillaume Munch wrote: > Le 12/06/2016 19:39, Richard Heck a écrit : >> On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: >>> Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero

Re: compilation for coverity fails

2016-06-12 Thread Guillaume Munch
Le 12/06/2016 19:39, Richard Heck a écrit : On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero coverity errors, but to fix dangerous code. So if you do not

Re: compilation for coverity fails

2016-06-12 Thread Richard Heck
On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: > Le 12/06/2016 15:05, Georg Baum a écrit : >> If others want to join the effort please keep in mind that the goal >> is not >> to get zero coverity errors, but to fix dangerous code. So if you do not >> understand an issue 100%, or understand it

Re: [LyX/master] Make the non-drawing cases faster in TextMetrics::drawParagraph

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 19:05, Guillaume Munch a écrit : In some situations, LyX does not recognize that an inset is hovered with the mouse: does not change cursor icon, does not paint the label in a different color, and does not show tooltip. Bisect leads to the commit above. If you would like to have a

Re: [LyX/master] unique_ptr and make_unique

2016-06-12 Thread Kornel Benko
Am Sonntag, 12. Juni 2016 um 18:35:56, schrieb Guillaume Munch > Le 12/06/2016 10:23, Kornel Benko a écrit : > > Am Sonntag, 12. Juni 2016 um 10:25:30, schrieb Kornel Benko > >> Am Sonntag, 12. Juni 2016 um 03:25:38, schrieb Guillaume Munch > >> >

Re: [LyX/master] unique_ptr and make_unique

2016-06-12 Thread Guillaume Munch
Le 12/06/2016 10:23, Kornel Benko a écrit : Am Sonntag, 12. Juni 2016 um 10:25:30, schrieb Kornel Benko Am Sonntag, 12. Juni 2016 um 03:25:38, schrieb Guillaume Munch Le 09/06/2016 15:23, Guillaume Munch a écrit : diff --git a/configure.ac b/configure.ac index

Why is the filesystemencoding needed for \origin lyx2lyx?

2016-06-12 Thread Georg Baum
Hi Enrico, you added an encoding conversion in lyx2lyx here: http://www.lyx.org/trac/changeset/a0afd345/lyxgit Can you please explain why this is needed, but not on windows? I ask because this conversion does not work with python 3: All strings, also the ones returned by os.path, are

Re: [LyX/master] Make the non-drawing cases faster in TextMetrics::drawParagraph

2016-06-12 Thread Guillaume Munch
Le 30/05/2016 13:56, Jean-Marc Lasgouttes a écrit : commit fc73ebc16c4f0aca76360415a94eca57f283e44e Author: Jean-Marc Lasgouttes Date: Mon Feb 29 16:07:35 2016 +0100 Make the non-drawing cases faster in TextMetrics::drawParagraph There are two main cases:

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

2016-06-12 Thread Georg Baum
Scott Kostyshak wrote: > I tried xmingw-script on current master but it does not succeed for me. > > I get the following: > > error: > In file included from > /home/scott/lyxbuilds/master/CMakeBuild/src/support/_allinone_const.C:118:0: >

Re: compilation for coverity fails

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero coverity errors, but to fix dangerous code. So if you do not understand an issue 100%, or understand it but do not know how to fix it, please keep it open. I did that

Re: "Reconfigure" gives an error

2016-06-12 Thread Georg Baum
Andrew Parsloe wrote: > What puzzled (& puzzles) me is that the warning doesn't arise with > 2.1.4, nor when 2.2.0 is installed. This is strange. If you want you could try out whether the error happens as well if you start platex.exe manually. If yes, then it is definitely a MikTeX problwem,

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 12/06/2016 12:14, Stephan Witt a écrit : >>> Different structure of headers, just switching between different gcc >>> versions and their accompanied libs is enough to trigger such errors on >>> the same system. >> >> I’m not used to this behavior with other

Re: Errors in lib/lyx2lyx/LyX.py with python3

2016-06-12 Thread Georg Baum
Kornel Benko wrote: > All tests with lyx2lyx fail with: > -- Executing /usr/bin/python3 /usr2/src/lyx/lyx-git/lib/lyx2lyx/lyx2lyx -e > qwbwf -o 8dqNDg /usr2/src/lyx/lyx-git/lib/doc/Math.lyx Traceback (most > recent call last): > File "/usr2/src/lyx/lyx-git/lib/lyx2lyx/lyx2lyx", line 88, in >

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Jean-Marc Lasgouttes
Le 12/06/2016 12:14, Stephan Witt a écrit : Different structure of headers, just switching between different gcc versions and their accompanied libs is enough to trigger such errors on the same system. I’m not used to this behavior with other development environment. For example, the docs

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Stephan Witt
Am 12.06.2016 um 10:39 schrieb Pavel Sanda : > > Stephan Witt wrote: >> sstream or iostream (as JMarc wrote) because of std::endl. > > But where in the _header_ do you need that? Ok, I misunderstood then. It should go to Server.cpp of course. Stephan > >> I have to admit that

Re: [LyX/master] unique_ptr and make_unique

2016-06-12 Thread Kornel Benko
Am Sonntag, 12. Juni 2016 um 10:25:30, schrieb Kornel Benko > Am Sonntag, 12. Juni 2016 um 03:25:38, schrieb Guillaume Munch > > Le 09/06/2016 15:23, Guillaume Munch a écrit : > > > diff --git a/configure.ac b/configure.ac > > > index 3353df4..52da6ce 100644 > > >

Re: compilation for coverity fails

2016-06-12 Thread Liviu Andronic
On Thu, Jun 9, 2016 at 4:14 PM, Jean-Marc Lasgouttes wrote: > Le 09/06/2016 à 12:22, Liviu Andronic a écrit : >>> >>> Are you currently updating the analysis on coverity site? >>> >> Yes, uploading build now. Should be up within an hour or so. > > > They are there indeed,

Re: [LyX/master] Add missing includes after change to boost signals2

2016-06-12 Thread Pavel Sanda
Stephan Witt wrote: > sstream or iostream (as JMarc wrote) because of std::endl. But where in the _header_ do you need that? > I have to admit that I start to mistrust the GCC-compilers. > I don???t understand why our sources compile on some systems > and not on some other systems. Why do I need

Re: [PATCH] unique_ptr and some clean-up

2016-06-12 Thread Pavel Sanda
Guillaume Munch wrote: >>> I do not clearly see the situation wrt gcc 4.6. Which are the >>> distributions that currently lack gcc > 4.6 ? >> >> this is ubuntu 12.04.p >> > > I see. I has assumed g++-4.7 was there since there is gcc-4.7. How does > clang fare? it has gcc 4.6.3. clang is not and

Re: [LyX/master] unique_ptr and make_unique

2016-06-12 Thread Kornel Benko
Am Sonntag, 12. Juni 2016 um 03:25:38, schrieb Guillaume Munch > Le 09/06/2016 15:23, Guillaume Munch a écrit : > > diff --git a/configure.ac b/configure.ac > > index 3353df4..52da6ce 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -130,6 +130,9 @@ AC_C_BIGENDIAN > > #

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

2016-06-12 Thread Kornel Benko
Am Samstag, 11. Juni 2016 um 20:50:43, schrieb Scott Kostyshak > On Sat, Jun 11, 2016 at 07:30:55PM -0400, Scott Kostyshak wrote: > > On Sun, Jun 12, 2016 at 12:23:18AM +0200, Kornel Benko wrote: > > > Am Samstag, 11. Juni 2016 um 18:12:20, schrieb Scott Kostyshak > > >

Re: "Reconfigure" gives an error

2016-06-12 Thread CarLaTeX
2016-06-12 9:41 GMT+02:00 Andrew Parsloe : > On 11/06/2016 8:53 p.m., Georg Baum wrote: > >> Andrew Parsloe wrote: >> >> On 11/06/2016 5:32 p.m., CarLaTeX wrote: >>> Hi LyX developers, I've installed LyX 2.2.0 on Windows 10 (distribution for LaTeX: MiKTeX

Re: "Reconfigure" gives an error

2016-06-12 Thread Andrew Parsloe
On 11/06/2016 8:53 p.m., Georg Baum wrote: Andrew Parsloe wrote: On 11/06/2016 5:32 p.m., CarLaTeX wrote: Hi LyX developers, I've installed LyX 2.2.0 on Windows 10 (distribution for LaTeX: MiKTeX 2.9). When I use "Tools > Reconfigure" I get this error: Immagine incorporata 2 I try to