Re: [patch] Experiment with c++11 unicode strings

2016-08-30 Thread Guillaume Munch
Le 30/08/2016 à 21:12, Georg Baum a écrit : Guillaume Munch wrote: * Why ascii_num_get_facet::do_get uses from_local8bit at some point. The encoding does not matter here: Our own numpunct_facet does not override truename() and falsename(), so std::numpunct::truename() and

Re: [patch] Experiment with c++11 unicode strings

2016-08-30 Thread Georg Baum
Guillaume Munch wrote: > I made it work with libc++ too, which was not straightforward. In this > case, the template is undefined and cannot be inherited from. > > Could you or somebody else please double-check the following, which I am > not sure to understand correctly: > > * Why

Re: [LyX/master] Add feedback in status bar when zooming

2016-08-30 Thread Scott Kostyshak
On Tue, Aug 30, 2016 at 05:03:11PM +0200, Jean-Marc Lasgouttes wrote: > Le 30/08/2016 à 16:55, Scott Kostyshak a écrit : > > OK I pushed at 03684ae0. I wonder if the misunderstanding comes back to > > what we agreed on before, which is that it is weird that both > > > > buffer-zoom-in 4 > >

Re: [LyX/master] Add feedback in status bar when zooming

2016-08-30 Thread Jean-Marc Lasgouttes
Le 30/08/2016 à 16:55, Scott Kostyshak a écrit : OK I pushed at 03684ae0. I wonder if the misunderstanding comes back to what we agreed on before, which is that it is weird that both buffer-zoom-in 4 buffer-zoom-out 4 have the same behavior. No, it probably come from my laziness about

Re: [LyX/master] Add feedback in status bar when zooming

2016-08-30 Thread Scott Kostyshak
On Tue, Aug 30, 2016 at 04:41:38PM +0200, Jean-Marc Lasgouttes wrote: > Le 30/08/2016 à 16:36, Scott Kostyshak a écrit : > > It would go down to 10%, both with my patch and without it. > > It is OK, then. > > Do what you think is best. OK I pushed at 03684ae0. I wonder if the misunderstanding

Re: [LyX/master] Add feedback in status bar when zooming

2016-08-30 Thread Scott Kostyshak
On Tue, Aug 30, 2016 at 10:51:13AM +0200, Jean-Marc Lasgouttes wrote: > Le 30/08/2016 à 03:52, Scott Kostyshak a écrit : > > On current master, if zoom is at 10% and you run > > > > buffer-zoom-in -1 > > > > then the LFUN is not disabled and status shows: > > > > Zoom level is now 10%

Re: Insert inset should not remove tracked changes

2016-08-30 Thread racoon
On 30.08.2016 14:58, Guillaume Munch wrote: Le 30/08/2016 à 12:52, racoon a écrit : Say you have a passage with a lot of tracked changes. Now, however, you would like to "comment it out" with a LyX note. Surely, you don't want to loose the changes made but keep them for later evaluation. +1

Re: Insert inset should not remove tracked changes

2016-08-30 Thread Guillaume Munch
Le 30/08/2016 à 12:52, racoon a écrit : Say you have a passage with a lot of tracked changes. Now, however, you would like to "comment it out" with a LyX note. Surely, you don't want to loose the changes made but keep them for later evaluation. +1 http://www.lyx.org/trac/ticket/10244

Re: Insert inset should not remove tracked changes

2016-08-30 Thread racoon
On 30.08.2016 11:06, Kornel Benko wrote: Am Dienstag, 30. August 2016 um 10:40:55, schrieb racoon Hi, I am wondering whether this is on purpose or not: 1. Enable Track Changes 2. Enter some text 3. Disable Track Changes 4. Select the text 5. Insert an inset, e.g. a LyX note

Re: [LyX/master] Add feedback in status bar when zooming

2016-08-30 Thread Jean-Marc Lasgouttes
Le 30/08/2016 à 03:52, Scott Kostyshak a écrit : On current master, if zoom is at 10% and you run buffer-zoom-in -1 then the LFUN is not disabled and status shows: Zoom level is now 10% (buffer-zoom-in -1) With my patch, I think the LFUN is disabled and status shows the same as

Re: Insert inset should not remove tracked changes

2016-08-30 Thread Kornel Benko
Am Dienstag, 30. August 2016 um 10:40:55, schrieb racoon > Hi, > > I am wondering whether this is on purpose or not: > > 1. Enable Track Changes > 2. Enter some text > 3. Disable Track Changes > 4. Select the text > 5. Insert an inset, e.g. a LyX note > > Result: > - The

Insert inset should not remove tracked changes

2016-08-30 Thread racoon
Hi, I am wondering whether this is on purpose or not: 1. Enable Track Changes 2. Enter some text 3. Disable Track Changes 4. Select the text 5. Insert an inset, e.g. a LyX note Result: - The tracked changes are removed Isn't it more intuitive to leave the changes as they are? After all I am