Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

[Kornel Benko]

Am Dienstag, 27. Dezember 2016 um 17:11:20, schrieb Scott Kostyshak 

> On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote:
> > commit 1cc14a31ca8320d881b674f93c34a09cf1666cca
> > Author: Guillaume Munch 
> > Date:   Mon May 30 21:42:08 2016 +0100
> > 
> > TocWidget: fix an erroneous collapse and optimise updates based on 
> > profiling
> > 
> > TocModels::reset() in GuiView::structureChanged() collapses the 
> > TocWidget, and
> > therefore requires an update right after, which was missing.
> > 
> > In fact, profiling TocWidget::updateView() shows that delaying the 
> > update is
> > good only for fast keypresses (essentially movement). It costs 5% of a
> > char-forward operation in a document with approx. 100 table of contents
> > items. The update optimisation has been rewritten to take this data into
> > account.
> 
> A git bisect suggests this causes a SIGSEGV. To reproduce:
> 
> 1. open the attached file
> 2. open the outline pane
> 3. put the cursor just to the left of "Hello" (but inside the caption inset)
> 4. "Save As" to a new filename.
> 
> Can you reproduce?

Yes.

> Backtrace is attached.
> 
> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

[Scott Kostyshak]

On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote:
> commit 1cc14a31ca8320d881b674f93c34a09cf1666cca
> Author: Guillaume Munch 
> Date:   Mon May 30 21:42:08 2016 +0100
> 
> TocWidget: fix an erroneous collapse and optimise updates based on 
> profiling
> 
> TocModels::reset() in GuiView::structureChanged() collapses the 
> TocWidget, and
> therefore requires an update right after, which was missing.
> 
> In fact, profiling TocWidget::updateView() shows that delaying the update 
> is
> good only for fast keypresses (essentially movement). It costs 5% of a
> char-forward operation in a document with approx. 100 table of contents
> items. The update optimisation has been rewritten to take this data into
> account.

A git bisect suggests this causes a SIGSEGV. To reproduce:

1. open the attached file
2. open the outline pane
3. put the cursor just to the left of "Hello" (but inside the caption inset)
4. "Save As" to a new filename.

Can you reproduce?

Backtrace is attached.

Scott
#0  0x00c95c56 in lyx::DocIterator::inTexted (this=0x7fff8d00) at 
/home/scott/lyxbuilds/master/repo/src/DocIterator.h:143
#1  0x00ed289f in lyx::DocIterator::getInnerText (this=0x2d84ac8) at 
/home/scott/lyxbuilds/master/repo/src/DocIterator.cpp:232
#2  0x00eb3423 in lyx::TocBackend::findItem (toc=std::vector of length 
1, capacity 1 = {...}, dit=...)
at /home/scott/lyxbuilds/master/repo/src/TocBackend.cpp:112
#3  0x01307b56 in lyx::frontend::TocModel::modelIndex (this=0x2eca980, 
dit=...)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/TocModel.cpp:129
#4  0x01308de9 in lyx::frontend::TocModels::currentIndex 
(this=0x2420c28, type=...)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/TocModel.cpp:304
#5  0x012fb498 in lyx::frontend::TocWidget::finishUpdateView 
(this=0x24fcf50)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/TocWidget.cpp:461
#6  0x012fb377 in lyx::frontend::TocWidget::updateView (this=0x24fcf50)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/TocWidget.cpp:437
#7  0x012fb3e5 in lyx::frontend::TocWidget::updateViewNow 
(this=0x24fcf50)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/TocWidget.cpp:446
#8  0x012fbe66 in lyx::frontend::TocWidget::init (this=0x24fcf50, 
str=...)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/TocWidget.cpp:535
#9  0x01204f1e in lyx::frontend::GuiToc::initialiseParams 
(this=0x253b880, data="")
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiToc.cpp:58
#10 0x011cc350 in lyx::frontend::GuiView::updateDialog (this=0x24bd7b0, 
name="toc", data="")
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiView.cpp:1675
#11 0x011cc1a6 in lyx::frontend::GuiView::structureChanged 
(this=0x24bd7b0)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiView.cpp:1660
#12 0x00e266bd in lyx::Buffer::structureChanged (this=0x2bd8f20) at 
/home/scott/lyxbuilds/master/repo/src/Buffer.cpp:3830
#13 0x00e2c885 in lyx::Buffer::updateBuffer (this=0x2bd8f20, 
scope=lyx::Buffer::UpdateMaster, utype=lyx::InternalUpdate)
at /home/scott/lyxbuilds/master/repo/src/Buffer.cpp:4625
#14 0x00c6c3fa in lyx::Buffer::updateBuffer (this=0x2bd8f20) at 
/home/scott/lyxbuilds/master/repo/src/Buffer.h:724
#15 0x00e2e5ff in lyx::Buffer::reload (this=0x2bd8f20) at 
/home/scott/lyxbuilds/master/repo/src/Buffer.cpp:5017
#16 0x011d3d12 in lyx::frontend::GuiView::renameBuffer (this=0x24bd7b0, 
b=..., newname=L"", kind=lyx::frontend::GuiView::LV_WRITE_AS)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiView.cpp:2565
#17 0x011dd5d4 in lyx::frontend::GuiView::dispatch (this=0x24bd7b0, 
cmd=..., dr=...)
at /home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiView.cpp:3745
#18 0x011afb30 in lyx::frontend::GuiApplication::dispatch 
(this=0x1fb84b0, cmd=..., dr=...)
at 
/home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiApplication.cpp:2078
#19 0x011ab953 in lyx::frontend::GuiApplication::dispatch 
(this=0x1fb84b0, cmd=...)
at 
/home/scott/lyxbuilds/master/repo/src/frontends/qt4/GuiApplication.cpp:1397
#20 0x00f0a99e in lyx::dispatch (action=...) at 
/home/scott/lyxbuilds/master/repo/src/LyX.cpp:1404
#21 0x0146246e in lyx::frontend::Action::action (this=0x2dc50c0) at 
/home/scott/lyxbuilds/master/repo/src/frontends/qt4/Action.cpp:87
#22 0x0146251c in lyx::frontend::Action::qt_static_metacall 
(_o=0x2dc50c0, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffbfa0)
at 
/home/scott/lyxbuilds/master/CMakeBuild/src/frontends/qt4/moc_Action.cpp:80
#23 0x7621d012 in QMetaObject::activate (sender=0x2dc50c0, 
signalOffset=3, local_signal_index=1, argv=0x7fffbfa0)
at /usr/src/qt/qt5/qtbase/src/corelib/kernel/qobject.cpp:3730
#24 0x7621c7f8 in QMetaO

doc/UserGuide systemF tests failing

[Scott Kostyshak]

The following tests on current master are failing:

  export/doc/UserGuide_dvi3_systemF (Failed)
  export/doc/UserGuide_pdf4_systemF (Failed)
  export/doc/UserGuide_pdf5_systemF (Failed)

Scott


signature.asc
Description: PGP signature

Fwd: X-Apps

[Paul A. Rubin]

This bounced for a few days (server down?), so I'm retrying it.


 Forwarded Message 

Apologies if this has already been brought up ...

With version 18 (Sarah), Linux Mint switched to a new set of tools 
called "X-Apps 
", at least 
for Cinnamon users. In particular, the new default PDF viewer is 
"xreader", and /Evince is no longer installed by default/. I discovered 
this the hard way today, after an OS upgrade. I tried to preview a 
document in LyX (pdflatex). The status line happily told me that the 
preview was successful, but no viewer opened.


Once I figured out what was going on, I switched all the PDF (whatever) 
file formats from evince to Custom/xreader, a mild PITA. My question to 
the group is whether we should include xreader in the list of viewers 
that the configuration script looks for. If so, should we also add xed 
(the new text editor) and xviewer (the new image viewer)?


Cheers,
Paul

Re: master fails to compile with Qt 5.8dev

[Scott Kostyshak]

On Tue, Dec 27, 2016 at 07:23:53PM +0100, Guillaume Munch wrote:
> Le 25/11/2016 à 05:20, Scott Kostyshak a écrit :
> > I occassionally build the Qt development version to test various things.
> > 
> > I currently get the following error when building LyX with Qt 5.8dev:
> > 
> > /home/vbox/lyxbuilds/master/repo/src/frontends/qt4/GuiViewSource.cpp:224:14:
> >  error: ambiguous overload for ‘operator!=’ (operand types are ‘const 
> > QChar’ and ‘char’)
> >while (*oc != '\0' && *nc != '\0' && *oc == *nc) {
> >   ^
> > Is this a problem with Qt's development version or is it indeed a valid 
> > error?
> > 
> 
> I am not sure, but it is fixed LyX-wise at 6d375dde.

Thanks. I'll try again in a couple of weeks (traveling now).

Scott


signature.asc
Description: PGP signature

Re: master fails to compile with Qt 5.8dev

[Guillaume Munch]

Le 25/11/2016 à 05:20, Scott Kostyshak a écrit :

I occassionally build the Qt development version to test various things.

I currently get the following error when building LyX with Qt 5.8dev:

/home/vbox/lyxbuilds/master/repo/src/frontends/qt4/GuiViewSource.cpp:224:14: 
error: ambiguous overload for ‘operator!=’ (operand types are ‘const QChar’ and 
‘char’)
   while (*oc != '\0' && *nc != '\0' && *oc == *nc) {
  ^
Is this a problem with Qt's development version or is it indeed a valid error?



I am not sure, but it is fixed LyX-wise at 6d375dde.

Re: GUI translation string for quotation marks

[Kornel Benko]

Am Dienstag, 27. Dezember 2016 um 07:38:32, schrieb Jürgen Spitzmüller 

> Am Dienstag, den 27.12.2016, 01:49 +0100 schrieb Kornel Benko:
> > Jürgen,
> > the relevant dialogs are in document language, but they should be in
> > gui language.
> 
> Not here. Can you give me an example, please?
> 
> Jürgen
> 

Yes, I try to make a snapshot.

Hm, it is working as expected. Sorry for the noise.

Kornel

signature.asc
Description: This is a digitally signed message part.