Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.02.2018, 20:19 +0100 schrieb Guillaume MM:
> I would not have proposed it for 2.3, 

Note that we had to act, since our old pseudo key compressor code broke
completely with Qt 5.10.

Jürgen

> 
> Guillaume
> 

signature.asc
Description: This is a digitally signed message part


Re: Binary regexes in configure.py

2018-02-01 Thread Scott Kostyshak
On Fri, Feb 02, 2018 at 03:12:39AM +, Richard Heck wrote:

> I finally figured out what's happening here, so I've pushed this fix to
> master. I'll wait for your OK for 2.3.x.

Thanks for figuring that out, Richard! Please go ahead for 2.3.x branch.

Scott


signature.asc
Description: PGP signature


Re: Binary regexes in configure.py

2018-02-01 Thread Richard Heck
On 02/01/2018 09:11 PM, Richard Heck wrote:
> On 02/01/2018 08:59 PM, Richard Heck wrote:
>> On 02/01/2018 01:59 PM, Scott Kostyshak wrote:
>>> On Tue, Jan 30, 2018 at 02:37:28AM +, Scott Kostyshak wrote:
>>>
> 
> +checking list of textclasses...
> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/svglobal3.layout has no
> \DeclareXXClass line.
> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/ectaart.layout has no
> \DeclareXXClass line.
> [...]
> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/bxjsbook.layout has no
> \DeclareXXClass line.
> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/letter.layout has no
> \DeclareXXClass line.
> 
 I see these also. We should figure this out, but it's good to know it
 doesn't cause any problem.
>> It very much would cause a problem in certain cases, namely, if you use
>> --without-latex-config, or if there's some later problem with
>> chkconfig.ltx. Then textclass.lst is empty.
>>
>>> git bisect suggests 731c9fb4 caused the change.
>> I put in some debugging code, and the regex simply isn't matching the
>> lines of the file the way it is supposed to. Ever.
>>
>> The attached patch fixes it for me. It looks like one of those weird
>> double-escaping problems. I'm not sure why the switch to binary strings
>> would cause this, but apparently it does.
> I think the reason is because we are no longer using the r'...' construct.
>
> There seems also to be a similar issue, though not one that is actually
> causing a problem, with some other regexes later. The updated patch also
> fixes those.
>
> I noticed that Enrico has things like "\\s" as well (search "declare =")
> rather than just "\s". The latter seems to work, but I'm curious what
> exactly is going on here.

I finally figured out what's happening here, so I've pushed this fix to
master. I'll wait for your OK for 2.3.x.

Richard



Build failed in Jenkins: Support and maintenance jobs » Check-author-email-in-commit-log #46

2018-02-01 Thread ci-lyx
https://ci.inria.fr/lyx/job/support/job/Check-author-email-in-commit-log/46/Changes:

[spitz] Account for custom encoding in DocIteratior::getEncoding

[spitz] Properly communicate forced encodings

[lasgouttes] Fix embarrassing thinko (fixup 1a969fa4a61)

[sanda] * layouttranslations - update ar, ru, el

[spitz] Make GUI string translatable

[spitz] Make another GUI string translatable

[spitz] de.po: update

[spitz] Use proper localization chain for Box special width/height

[lasgouttes] Make sure to add at least one element in row if possible

[spitz] Differentiate Buffer strings and GUI strings in citeengines

[spitz] Document B_ in cite style definitions

[sanda] * cs.po

[uwestoehr] ru.po: last minute changes for RC from Yuriy

[forenr] Update it.po

[uwestoehr] Additional.lyx: port recent changes

[rgheck] Whitespace.

[rgheck] Fix bug #11055.

[spitz] Whitespace

[spitz] Add Bibliography to the Outliner.

[lasgouttes] Catch exceptions to please coverity

[lasgouttes] Fixup 6b6fa94c: coverity says there are more possible exceptions.

[uwestoehr] French EmbeddedObjects.lyx: sync document settings with English 
version

[spitz] Once more, the libertine font package has been renamed.

[lasgouttes] Add support for enchant 2.x

[milde] Do not use "ligature dashes" with French documents.

[milde] Use LaTeX macros instead of Latin transcription for Greek characters.

[uwestoehr] French Additional.lyx: sync with branch

[uwestoehr] ru.po: more translations from Yuriy

[milde] Remove spurious no-break space.

[lasgouttes] Make CursorData::checkNewWordPosition() more robust

[jpc]   Remove unappropriate French style command from preamble

[milde] lyx2lyx refactoring.

[lasgouttes] Fix Cursor::sanitize

[uwestoehr] pt_BR.po: updates from Georger

[uwestoehr] French docs: remove a file that was accidentally committed

[spitz] Enable CompressorProxy for all Workareas (incl. EmbeddedWorkarea)

--
Started by timer
Building remotely on lyx-linux2 (linux) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository git://git.lyx.org/lyx.git
 > git init 
 > 
 >  # timeout=10
Fetching upstream changes from git://git.lyx.org/lyx.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.lyx.org/lyx.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://git.lyx.org/lyx.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://git.lyx.org/lyx.git # timeout=10
Fetching upstream changes from git://git.lyx.org/lyx.git
 > git fetch --tags --progress git://git.lyx.org/lyx.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 5ce36019e591fbdf4a0cb3e44f3f9e2dc662be89 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5ce36019e591fbdf4a0cb3e44f3f9e2dc662be89
 > git rev-list c7d7ac31a1379a957bab46273ca1fcf640f151e1 # timeout=10
[Check-author-email-in-commit-log] $ /bin/sh -xe 
/tmp/hudson5112980964346992829.sh
+ printf \n\nShow disk usage. Not needed, just for information\n


Show disk usage. Not needed, just for information
+ df -h / /builds /home /builds/workspace
Filesystem  Size  Used Avail Use% Mounted on
/dev/sda118G  9.3G  7.4G  56% /
/dev/sda118G  9.3G  7.4G  56% /
/dev/sda118G  9.3G  7.4G  56% /
/dev/vda 40G  8.8G   29G  24% /builds/workspace
+ git status
HEAD detached at 5ce3601
nothing to commit, working directory clean
+ SCRIPT=development/CI/bin/check_git_log_for_unrecognised_email_addresses.sh
+ 
EXPECTED_HASH=1330d9fca5e385e9de8933cbf6d39107b2f6af1cf7ca3175babfd4e5ab46b024ff2d98c7c8630b362be506da9376f9262a524755f9acf655d83dcce8a564
+ printf \n\nExecute script that checks commit log\n


Execute script that checks commit log
+ development/CI/bin/check_git_log_for_unrecognised_email_addresses.sh 
--check-hash 
1330d9fca5e385e9de8933cbf6d39107b2f6af1cf7ca3175babfd4e5ab46b024ff2d98c7c8630b362be506da9376f9262a524755f9acf655d83dcce8a564
Hash mismatch:
  Desired: 
1330d9fca5e385e9de8933cbf6d39107b2f6af1cf7ca3175babfd4e5ab46b024ff2d98c7c8630b362be506da9376f9262a524755f9acf655d83dcce8a564
  Current: 
73f7eb10b187d77a69526cb374742fdf40b7539aa95c42496ace4ee1de1ee4d6820885f850957718ed51210095b72632910a0c2529393ce2b1f41a5308b0a012
Latest log:
c070c2f1f8 2018-01-10 02:38:31 +0100 name=Uwe Stöhr email=uwesto...@web.de
bb650bf8c2 2018-01-10 02:12:40 +0100 name=Uwe Stöhr email=uwesto...@web.de
26acdd27c4 2017-07-30 00:54:12 +0200 name=Christian Ridderström 
email=christian.ridderst...@profoto.com
e30f3d76d2 2017-07-23 13:11:5

Binary regexes in configure.py

2018-02-01 Thread Richard Heck
On 02/01/2018 08:59 PM, Richard Heck wrote:
> On 02/01/2018 01:59 PM, Scott Kostyshak wrote:
>> On Tue, Jan 30, 2018 at 02:37:28AM +, Scott Kostyshak wrote:
>>
 
 +checking list of textclasses...
 Layout file /usr/local/share/lyx-2.3.0rc2/layouts/svglobal3.layout has no
 \DeclareXXClass line.
 Layout file /usr/local/share/lyx-2.3.0rc2/layouts/ectaart.layout has no
 \DeclareXXClass line.
 [...]
 Layout file /usr/local/share/lyx-2.3.0rc2/layouts/bxjsbook.layout has no
 \DeclareXXClass line.
 Layout file /usr/local/share/lyx-2.3.0rc2/layouts/letter.layout has no
 \DeclareXXClass line.
 
>>> I see these also. We should figure this out, but it's good to know it
>>> doesn't cause any problem.
> It very much would cause a problem in certain cases, namely, if you use
> --without-latex-config, or if there's some later problem with
> chkconfig.ltx. Then textclass.lst is empty.
>
>> git bisect suggests 731c9fb4 caused the change.
> I put in some debugging code, and the regex simply isn't matching the
> lines of the file the way it is supposed to. Ever.
>
> The attached patch fixes it for me. It looks like one of those weird
> double-escaping problems. I'm not sure why the switch to binary strings
> would cause this, but apparently it does.

I think the reason is because we are no longer using the r'...' construct.

There seems also to be a similar issue, though not one that is actually
causing a problem, with some other regexes later. The updated patch also
fixes those.

I noticed that Enrico has things like "\\s" as well (search "declare =")
rather than just "\s". The latter seems to work, but I'm curious what
exactly is going on here.

Richard

diff --git a/lib/configure.py b/lib/configure.py
index 95203fcb6e..5d91650a2f 100644
--- a/lib/configure.py
+++ b/lib/configure.py
@@ -1276,6 +1276,7 @@ def processLayoutFile(file, bool_docbook):
 "scrbook" "scrbook" "book (koma-script)" "false" "scrbook.cls" "Books"
 "svjog" "svjour" "article (Springer - svjour/jog)" "false" 
"svjour.cls,svjog.clo" ""
 '''
+
 def checkForClassExtension(x):
 '''if the extension for a latex class is not
provided, add .cls to the classname'''
@@ -1285,8 +1286,8 @@ def processLayoutFile(file, bool_docbook):
 return x.strip()
 classname = file.split(os.sep)[-1].split('.')[0]
 # return ('LaTeX', '[a,b]', 'a', ',b,c', 'article') for 
\DeclareLaTeXClass[a,b,c]{article}
-p = 
re.compile(b'^\s*#\s*\\Declare(LaTeX|DocBook)Class\s*(\[([^,]*)(,.*)*\])*\s*{(.*)}\s*$')
-q = re.compile(b'^\s*#\s*\\DeclareCategory{(.*)}\s*$')
+p = 
re.compile(b'^\s*#\s*Declare(LaTeX|DocBook)Class\s*(\[([^,]*)(,.*)*\])*\s*{(.*)}\s*$')
+q = re.compile(b'^\s*#\s*DeclareCategory{(.*)}\s*$')
 classdeclaration = b""
 categorydeclaration = b'""'
 for line in open(file, 'rb').readlines():
@@ -1311,9 +1312,9 @@ def processLayoutFile(file, bool_docbook):
 if qres != None:
  categorydeclaration = b'"%s"' % (qres.groups()[0])
  if classdeclaration != b"":
- return classdeclaration + b" " + categorydeclaration
+ return classdeclaration + b" " + categorydeclaration + b"\n"
 if classdeclaration != b"":
-return classdeclaration + b" " + categorydeclaration
+return classdeclaration + b" " + categorydeclaration + b"\n"
 logger.warning("Layout file " + file + " has no \DeclareXXClass line. ")
 return b""
 
@@ -1511,7 +1512,7 @@ def processModuleFile(file, filename, bool_docbook):
 We expect output:
   "ModuleName" "filename" "Description" "Packages" "Requires" 
"Excludes" "Category"
 '''
-remods = re.compile(b'\DeclareLyXModule\s*(?:\[([^]]*?)\])?{(.*)}')
+remods = re.compile(b'DeclareLyXModule\s*(?:\[([^]]*?)\])?{(.*)}')
 rereqs = re.compile(b'#+\s*Requires: (.*)')
 reexcs = re.compile(b'#+\s*Excludes: (.*)')
 recaty = re.compile(b'#+\s*Category: (.*)')
@@ -1635,7 +1636,7 @@ def processCiteEngineFile(file, filename, bool_docbook):
 We expect output:
   "CiteEngineName" "filename" "CiteEngineType" "CiteFramework" 
"DefaultBiblio" "Description" "Packages"
 '''
-remods = re.compile(b'\DeclareLyXCiteEngine\s*(?:\[([^]]*?)\])?{(.*)}')
+remods = re.compile(b'DeclareLyXCiteEngine\s*(?:\[([^]]*?)\])?{(.*)}')
 redbeg = re.compile(b'#+\s*DescriptionBegin\s*$')
 redend = re.compile(b'#+\s*DescriptionEnd\s*$')
 recet = re.compile(b'\s*CiteEngineType\s*(.*)')


Re: 2.3.0rc2 tar balls have been uploaded

2018-02-01 Thread Richard Heck
On 02/01/2018 01:59 PM, Scott Kostyshak wrote:
> On Tue, Jan 30, 2018 at 02:37:28AM +, Scott Kostyshak wrote:
>
>>> 
>>> +checking list of textclasses...
>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/svglobal3.layout has no
>>> \DeclareXXClass line.
>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/ectaart.layout has no
>>> \DeclareXXClass line.
>>> [...]
>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/bxjsbook.layout has no
>>> \DeclareXXClass line.
>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/letter.layout has no
>>> \DeclareXXClass line.
>>> 
>> I see these also. We should figure this out, but it's good to know it
>> doesn't cause any problem.

It very much would cause a problem in certain cases, namely, if you use
--without-latex-config, or if there's some later problem with
chkconfig.ltx. Then textclass.lst is empty.

> git bisect suggests 731c9fb4 caused the change.

I put in some debugging code, and the regex simply isn't matching the
lines of the file the way it is supposed to. Ever.

The attached patch fixes it for me. It looks like one of those weird
double-escaping problems. I'm not sure why the switch to binary strings
would cause this, but apparently it does.

Richard

diff --git a/lib/configure.py b/lib/configure.py
index 95203fcb6e..7a67a3ee5f 100644
--- a/lib/configure.py
+++ b/lib/configure.py
@@ -1276,6 +1276,7 @@ def processLayoutFile(file, bool_docbook):
 "scrbook" "scrbook" "book (koma-script)" "false" "scrbook.cls" "Books"
 "svjog" "svjour" "article (Springer - svjour/jog)" "false" 
"svjour.cls,svjog.clo" ""
 '''
+
 def checkForClassExtension(x):
 '''if the extension for a latex class is not
provided, add .cls to the classname'''
@@ -1285,8 +1286,8 @@ def processLayoutFile(file, bool_docbook):
 return x.strip()
 classname = file.split(os.sep)[-1].split('.')[0]
 # return ('LaTeX', '[a,b]', 'a', ',b,c', 'article') for 
\DeclareLaTeXClass[a,b,c]{article}
-p = 
re.compile(b'^\s*#\s*\\Declare(LaTeX|DocBook)Class\s*(\[([^,]*)(,.*)*\])*\s*{(.*)}\s*$')
-q = re.compile(b'^\s*#\s*\\DeclareCategory{(.*)}\s*$')
+p = 
re.compile(b'^\s*#\s*Declare(LaTeX|DocBook)Class\s*(\[([^,]*)(,.*)*\])*\s*{(.*)}\s*$')
+q = re.compile(b'^\s*#\s*DeclareCategory{(.*)}\s*$')
 classdeclaration = b""
 categorydeclaration = b'""'
 for line in open(file, 'rb').readlines():
@@ -1311,9 +1312,9 @@ def processLayoutFile(file, bool_docbook):
 if qres != None:
  categorydeclaration = b'"%s"' % (qres.groups()[0])
  if classdeclaration != b"":
- return classdeclaration + b" " + categorydeclaration
+ return classdeclaration + b" " + categorydeclaration + b"\n"
 if classdeclaration != b"":
-return classdeclaration + b" " + categorydeclaration
+return classdeclaration + b" " + categorydeclaration + b"\n"
 logger.warning("Layout file " + file + " has no \DeclareXXClass line. ")
 return b""
 


Re: [LyX/master] Install a new compressor

2018-02-01 Thread Scott Kostyshak
On Thu, Feb 01, 2018 at 07:19:03PM +, Guillaume MM wrote:
> Le 01/02/2018 à 18:21, Scott Kostyshak a écrit :
> > On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote:
> > > Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller:
> > > > Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc
> > > > Lasgouttes:
> > > > > This makes much sense. You could probably move the new line to the
> > > > > other
> > > > > GuiWorkArea constructor...
> > > > Yes, this seems to work as well.
> > > I have now pushed this fix to master.
> > Thanks for the fix, Jürgen. Let's double-check with Guillaume and port
> > to 2.3.x. Guillaume does this patch make sense to you?
> > 
> > Scott
> 
> 
> Dear Scott, this looks good to me.

Thanks for taking a look.

> I would not have proposed it for 2.3,

I'm pretty sure I know what you mean but I want to make 100% sure:

You mean the new compressor in the first place (i.e. commit 789617b8),
right? Conditional on us keeping that commit for 2.3.0, you do agree
that it makes sense to backport the follow-up 5ce36019, right?

The new compressor is in 2.3.0rc2. If we do not receive any other
reports that seem linked to it, do you agree that we should keep the
compressor for 2.3.0? Or do you have reason to think there is a
significant chance of a nasty bug that we might not encounter while
testing that could be serious?

Thanks,

Scott


signature.asc
Description: PGP signature


Re: [LyX/master] Install a new compressor

2018-02-01 Thread Guillaume MM

Le 01/02/2018 à 18:21, Scott Kostyshak a écrit :

On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote:

Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller:

Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc
Lasgouttes:

This makes much sense. You could probably move the new line to the
other
GuiWorkArea constructor...

Yes, this seems to work as well.

I have now pushed this fix to master.

Thanks for the fix, Jürgen. Let's double-check with Guillaume and port
to 2.3.x. Guillaume does this patch make sense to you?

Scott



Dear Scott, this looks good to me. I would not have proposed it for 2.3, 
but thank you for the live test, this is much appreciated.


Guillaume



configure.py: convert warnings to errors for pre-release?

2018-02-01 Thread Scott Kostyshak
Thanks to Jean-Pierre's hawk eyes, we found a potential issue in
configure.py [1]. I did not see this because I don't manually check the
configure log (although this would be a good thing to do from time to
time).

I'm wondering if it would be useful to add an option to configure.py
that would turn warnings into errors; and additionally whether it would
make sense to turn this option on by default when using
--enable-build-type=pre (autotools) and -DLYX_RELEASE=OFF (CMake).

Thoughts?

Scott


[1]
https://www.mail-archive.com/search?l=mid&q=c8e8f5aa-e4fa-4daa-dba2-a4d7435b39a6%40free.fr



signature.asc
Description: PGP signature


Re: 2.3.0rc2 tar balls have been uploaded

2018-02-01 Thread Scott Kostyshak
On Tue, Jan 30, 2018 at 02:37:28AM +, Scott Kostyshak wrote:

> > 
> > +checking list of textclasses...
> > Layout file /usr/local/share/lyx-2.3.0rc2/layouts/svglobal3.layout has no
> > \DeclareXXClass line.
> > Layout file /usr/local/share/lyx-2.3.0rc2/layouts/ectaart.layout has no
> > \DeclareXXClass line.
> > [...]
> > Layout file /usr/local/share/lyx-2.3.0rc2/layouts/bxjsbook.layout has no
> > \DeclareXXClass line.
> > Layout file /usr/local/share/lyx-2.3.0rc2/layouts/letter.layout has no
> > \DeclareXXClass line.
> > 
> 
> I see these also. We should figure this out, but it's good to know it
> doesn't cause any problem.

git bisect suggests 731c9fb4 caused the change.

Scott


signature.asc
Description: PGP signature


Re: LyX version 2.3.0rc2 available

2018-02-01 Thread Uwe Stöhr

Am 01.02.2018 um 18:21 schrieb Scott Kostyshak:


On Thu, Feb 01, 2018 at 02:14:34PM +, emile lunardon wrote:

LyX for Windows offers incomplete support for non-TeX fonts. This is the
case, for example, of the Gyre Schola font, which although proposed by
Miktex 2.9 , is unknown to LyX 2.3 RC2 (this is not the case of LyX 2.3
compiled under Linux Ubuntu 16.04).


I cannot reproduce this. After you installed the package "tex-gyre" 
using MiKTeX's package manager you have to reconfigure LyX (menu 
Tools->Reconfigure) and then you can select it as roman font.


By the way I see that TeX Gyre provides in the meantime also math fonts. 
Support for them cannot be added for LyX 2.3 because this will be a file 
format change.


regards Uwe


Re: [LyX/master] Install a new compressor

2018-02-01 Thread Scott Kostyshak
On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote:
> Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller:
> > Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc
> > Lasgouttes:
> > > This makes much sense. You could probably move the new line to the
> > > other 
> > > GuiWorkArea constructor...
> > 
> > Yes, this seems to work as well.
> 
> I have now pushed this fix to master.

Thanks for the fix, Jürgen. Let's double-check with Guillaume and port
to 2.3.x. Guillaume does this patch make sense to you?

Scott


signature.asc
Description: PGP signature


Re: LyX version 2.3.0rc2 available

2018-02-01 Thread Scott Kostyshak
On Thu, Feb 01, 2018 at 02:14:34PM +, emile lunardon wrote:
> LyX for Windows offers incomplete support for non-TeX fonts. This is the
> case, for example, of the Gyre Schola font, which although proposed by
> Miktex 2.9 , is unknown to LyX 2.3 RC2 (this is not the case of LyX 2.3
> compiled under Linux Ubuntu 16.04).

CC'ing our Windows packager. Uwe can you reproduce?

Scott


signature.asc
Description: PGP signature


Re: LyX version 2.3.0rc2 available

2018-02-01 Thread Richard Heck
On 02/01/2018 12:19 AM, Scott Kostyshak wrote:
> On Thu, Feb 01, 2018 at 05:06:52AM +, Joel Kulesza wrote:
>> On Tue, Jan 30, 2018 at 11:36 PM, Scott Kostyshak  wrote:
>>
>>> You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/.
>>>
>>>
>> Colleagues,
>>
>> Given my recent faulty assumption on how the download site and associated
>> mirrors work, what are your thoughts on the wording change:
>>
>> You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/ (based
>> in Paris) or a closer mirror listed at: http://www.lyx.org/Download#toc11.
> I'm fine with the change if others support it.

Fine with me.

Richard



Re: LyX version 2.3.0rc2 available

2018-02-01 Thread emile lunardon
LyX for Windows offers incomplete support for non-TeX fonts. This is the
case, for example, of the Gyre Schola font, which although proposed by
Miktex 2.9 , is unknown to LyX 2.3 RC2 (this is not the case of LyX 2.3
compiled under Linux Ubuntu 16.04).

2018-01-31 7:36 GMT+01:00 Scott Kostyshak :

> Public release of LyX version 2.3.0rc2
> 
>
> We are proud to announce the second public release candidate of the new
> LyX 2.3
> series. This pre-release is meant for testing and should not be used for
> serious work. For curious users who would like to test in order to help
> catch
> bugs before the 2.3.0 release, please back up all of your documents and be
> prepared for the worst to happen. Most users (who desire a stable LyX
> version)
> should not use this pre-release.
>
> The 2.3 series has a rich set of new features compared to the current
> stable
> series. An overview of the new features can be found here:
>
>   https://wiki.lyx.org/LyX/NewInLyX23
>
> You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/.
>
> We appreciate your help in testing this pre-release!
>
> If a file from an earlier version of LyX is opened *and saved* with
> any version of 2.3.x, then the original file will automatically be
> backed up. The backup file will be found in the backup directory, if one
> is set under Tools> Preferences> Paths, or else in the same folder as
> the original file, if no backup directory is set. The filename of the
> backup file will be:
> ORIGNAME-lyxformat-NUM.lyx~
> where NUM is the LyX format number of the original file. In the case of
> 2.2.x file, this will be 508, but in the case of older files it will be
> different.
>
> The file lib/RELEASE-NOTES lists some known issues and problems compared
> to the current stable releases (LyX 2.2.x). We strongly recommend that
> packagers of LyX on various platforms and distributions read this file.
>
> As with any major release, this one comes with a lot of new features but
> also some bugs. If you think you have found a bug in LyX 2.3.0rc2, either
> email the LyX developers' mailing list (lyx-devel at lists.lyx.org),
> or open a bug report at https://www.lyx.org/trac/wiki/BugTrackerHome.
> Please specify if the behavior you are reporting is different from behavior
> in a previous LyX version.
>
> If you have trouble using LyX or have a question, consult the
> documentation that comes with LyX (under Help) and the LyX wiki, which you
> will find at https://wiki.lyx.org/. You can also send email to the LyX
> users'
> list (lyx-users at lists.lyx.org).
>
> The LyX team.
> https://www.lyx.org
>
>


Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller:
> Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc
> Lasgouttes:
> > This makes much sense. You could probably move the new line to the
> > other 
> > GuiWorkArea constructor...
> 
> Yes, this seems to work as well.

I have now pushed this fix to master.

Jürgen

signature.asc
Description: This is a digitally signed message part


Re: LyX version 2.3.0rc2 available

2018-02-01 Thread Joel Kulesza
On Thu, Feb 1, 2018 at 6:34 AM, Pavel Sanda  wrote:

> Joel Kulesza wrote:
> > Given my recent faulty assumption on how the download site and associated
> > mirrors work, what are your thoughts on the wording change:
> >
> > You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/
> (based
> > in Paris) or a closer mirror listed at: http://www.lyx.org/Download#
> toc11.
>
> I'd say wording should be smt like:
>
> You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/ or
> you can use one of the mirrors listed on our web in case the link doesn't
> work or is too slow.
>

I would include the link to the mirror listing. Otherwise, I can imagine
frustration of having a slow/failed download causing me to then go hunt for
a better alternative on the website (for a new user, who may not be totally
familiar with it).


Re: LyX version 2.3.0rc2 available

2018-02-01 Thread Pavel Sanda
Joel Kulesza wrote:
> Given my recent faulty assumption on how the download site and associated
> mirrors work, what are your thoughts on the wording change:
> 
> You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/ (based
> in Paris) or a closer mirror listed at: http://www.lyx.org/Download#toc11.

I'd say wording should be smt like:

You can download LyX 2.3.0rc2 from ftp://ftp.lyx.org/pub/lyx/devel/ or
you can use one of the mirrors listed on our web in case the link doesn't
work or is too slow.


Pavel


Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc
Lasgouttes:
> This makes much sense. You could probably move the new line to the
> other 
> GuiWorkArea constructor...

Yes, this seems to work as well.

> Some more things seem weird in this code (like the w argument to the 
> EmbeddedWorkArea constructor), but it is not the right time to do 
> dangerous changes to this code :)

I agree.

Jürgen

> JMarc
> 

signature.asc
Description: This is a digitally signed message part


Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jean-Marc Lasgouttes

Le 01/02/2018 à 10:50, Jürgen Spitzmüller a écrit :

The attached patch fixes it for me. But since this is not my code, I am
not that confident it is the correct fix.


This makes much sense. You could probably move the new line to the other 
GuiWorkArea constructor...


Some more things seem weird in this code (like the w argument to the 
EmbeddedWorkArea constructor), but it is not the right time to do 
dangerous changes to this code :)


JMarc



Re: [LyX/master] Install a new compressor

2018-02-01 Thread Kornel Benko
Am Donnerstag, 1. Februar 2018 10:50:42 CET schrieb Jürgen Spitzmüller 
:
> Am Mittwoch, den 31.01.2018, 22:12 -0500 schrieb Scott Kostyshak:
> > git bisect suggests this caused the issue reported on lyx-users [1].
> > 
> > To reproduce:
> > 
> > 1. Open LyX
> > 2. Start a new document
> > 3. Go to Edit > Find & Replace (Advanced)
> > 4. Try to type something in the "Find" text area.
> > 
> > During step 4, I can't type anything.
> 
> The attached patch fixes it for me. But since this is not my code, I am
> not that confident it is the correct fix.
> 
> Jürgen

Cures it for me too.

Kornel



Re: [LyX/master] Install a new compressor

2018-02-01 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.01.2018, 22:12 -0500 schrieb Scott Kostyshak:
> git bisect suggests this caused the issue reported on lyx-users [1].
> 
> To reproduce:
> 
> 1. Open LyX
> 2. Start a new document
> 3. Go to Edit > Find & Replace (Advanced)
> 4. Try to type something in the "Find" text area.
> 
> During step 4, I can't type anything.

The attached patch fixes it for me. But since this is not my code, I am
not that confident it is the correct fix.

Jürgendiff --git a/src/frontends/qt4/GuiWorkArea.cpp b/src/frontends/qt4/GuiWorkArea.cpp
index ff6073e0db..3b7dc6c6b0 100644
--- a/src/frontends/qt4/GuiWorkArea.cpp
+++ b/src/frontends/qt4/GuiWorkArea.cpp
@@ -1404,6 +1404,7 @@ GuiView & GuiWorkArea::view()
 
 EmbeddedWorkArea::EmbeddedWorkArea(QWidget * w): GuiWorkArea(w)
 {
+	new CompressorProxy(this); // not a leak
 	support::TempFile tempfile("embedded.internal");
 	tempfile.setAutoRemove(false);
 	buffer_ = theBufferList().newInternalBuffer(tempfile.name().absFileName());


signature.asc
Description: This is a digitally signed message part


Re: [RFC][PATCH] native file dialogs

2018-02-01 Thread Guenter Milde
On 2018-01-31, Jürgen Spitzmüller wrote:
> Am Mittwoch, den 31.01.2018, 11:00 +0100 schrieb Jean-Marc Lasgouttes:
>> Le 31/01/2018 à 08:20, Jürgen Spitzmüller a écrit :

...

>> > The nice thing about the buttons is that they only occur when it
>> > makes
>> > sense. And remember we do not only have "Examples". We also show
>> > "Templates" (my favorite), "Documents", "Cliparts" (and maybe
>> > others).
>> > And if done correctly, it could be extended to other places
>> > depending
>> > on the context (e.g., "BibTeX databases" ($TEXMF/bib) in the BibTeX
>> > dialog).

>> Yes, I thought about that since writing this message. Note that "New 
>> from template" already starts from the template directory.

> Yes, I know.

OTOH, we do not have a "File>Save as template" (and I don't think we
should add it) while "File>Save as" offers the [templates] button for
easy creation of templates.

> The off thing is that it only includes the system
> directory, not the user directory (not that the buttons would solve
> that).

The examples and templates directories can be configured in
Tools>Preferences>Paths. However if changed to the user directory, the
system dir is "hidden". I worked around this with a symlink from my user
templates directory to the system one.

I expect the average user to gain from creation and use of custom
templates. Therefore I'd like to make this "dead easy".

* Set the default value for the templates to the user directory

* Either 
  - add a symlink USERDIR/templates/standard/ -> LYXDIR/templates/
when installing LyX
  or
  - merge the files in userdir and lyxdir in the "new from template"
dialogue.

I don't expect the average user to create custom examples in 
USERDIR/examples. OTOH, examples can be used as templates. Maybe we could
also add a symlink USERDIR/templates/examples/ -> LYXDIR/examples/
(Possibly in additon to a Help>Examples sub-menu.)

See also the discussion around
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg200102.html

Günter



Re: [RFC][PATCH] native file dialogs

2018-02-01 Thread Guenter Milde
On 2018-01-30, José Abílio Matos wrote:
> On Tuesday, 30 January 2018 14.53.45 WET Pavel Sanda wrote:

>> I use them sometimes, but can't say whether it's because of real usage or
>> devel activities... P

> Me too. :-)

So do I...

...

> One option that I thought about it sometimes is the removal of the
> native file dialogs and the placement in the Help menu of an entry that
> would allow to open the file picker for Examples. Because, at least to
> me, Examples conceptually belong to Help and not to File.

Agreed. See also https://www.lyx.org/trac/ticket/8715 and the discussion at
lyx-devel 10 months ago
https://www.mail-archive.com/search?l=mid&q=20170406034441.dxnerqeqj2civx3s%40steph

Günter