On 02/01/2018 09:11 PM, Richard Heck wrote: > On 02/01/2018 08:59 PM, Richard Heck wrote: >> On 02/01/2018 01:59 PM, Scott Kostyshak wrote: >>> On Tue, Jan 30, 2018 at 02:37:28AM +0000, Scott Kostyshak wrote: >>> >>>>> <cite> >>>>> +checking list of textclasses... >>>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/svglobal3.layout has no >>>>> \DeclareXXClass line. >>>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/ectaart.layout has no >>>>> \DeclareXXClass line. >>>>> [...] >>>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/bxjsbook.layout has no >>>>> \DeclareXXClass line. >>>>> Layout file /usr/local/share/lyx-2.3.0rc2/layouts/letter.layout has no >>>>> \DeclareXXClass line. >>>>> </cite> >>>> I see these also. We should figure this out, but it's good to know it >>>> doesn't cause any problem. >> It very much would cause a problem in certain cases, namely, if you use >> --without-latex-config, or if there's some later problem with >> chkconfig.ltx. Then textclass.lst is empty. >> >>> git bisect suggests 731c9fb4 caused the change. >> I put in some debugging code, and the regex simply isn't matching the >> lines of the file the way it is supposed to. Ever. >> >> The attached patch fixes it for me. It looks like one of those weird >> double-escaping problems. I'm not sure why the switch to binary strings >> would cause this, but apparently it does. > I think the reason is because we are no longer using the r'...' construct. > > There seems also to be a similar issue, though not one that is actually > causing a problem, with some other regexes later. The updated patch also > fixes those. > > I noticed that Enrico has things like "\\s" as well (search "declare =") > rather than just "\s". The latter seems to work, but I'm curious what > exactly is going on here.
I finally figured out what's happening here, so I've pushed this fix to master. I'll wait for your OK for 2.3.x. Richard
