2.3.x compilation error with -Werror

2018-10-07 Thread Scott Kostyshak
I get the following on current 2.3.x (e94ea46b) when compiling with
-Werror:

/home/scott/lyxbuilds/2.3.x/repo/src/insets/InsetBibtex.cpp:883:2: error: this 
‘if’ clause does not guard... [-Werror=misleading-indentation]
  if (buffer().masterParams().documentClass().hasLaTeXLayout("chapter"))
  ^~
/home/scott/lyxbuilds/2.3.x/repo/src/insets/InsetBibtex.cpp:885:3: note: 
...this statement, but the latter is misleadingly indented as if it were 
guarded by the ‘if’
   return buffer().B_("References");
   ^~

Scott


signature.asc
Description: PGP signature


Re: Messages on first use of mathed in a session

2018-10-07 Thread Andrew Parsloe

On 8/10/2018 12:43 a.m., Jean-Marc Lasgouttes wrote:

Le 06/10/2018 à 23:06, Andrew Parsloe a écrit :
The first time I use mathed in a session there can be a noticeable 
pause (a few seconds) before any character is displayed. When I look 
at the messages pane I get the attached list of messages. This is 
with 2.3.1-1 (built and compiled with Qt 5.10.1). Is this expected? 
Second and later uses of mathed aren't delayed and don't generate the 
messages.


Are you sure that the messages happen at the time of the delay? I know 
there used to be a delay related to font loading at first math use, 
but this is not related to resources. Here I do not see any delay.


As far as I can see, the messages you see happen when trying to create 
toolbar icons for math.


Did you build LyX yourself? If so, did you use configure or cmake?

JMarc
No, this is the LyX resulting from Riki's LyX-231-Installer-5.exe. The 
delay is of no importance since it happens only once and was what made 
me look at the messages pane. Just for interest I tested LyX 2.2.3 and 
none of the


frontends/qt4/GuiApplication.cpp (552): Directory :/images/math/ not 
found in resource!


frontends/qt4/GuiApplication.cpp (552): Directory :/images/ not found in 
resource!



 messages result from first use of mathed in it. I am completely 
ignorant of these matters but I wondered if the qt4 was significant, 
since 2.3.1-1 is built with Qt 5.10.1.


Andrew


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


sigsegv bug

2018-10-07 Thread Ludo Van Passel
Dear lyx devteam

following the details from a bug message  hat I receive every time I wan’t 
import a file in an other format. 

Sincerely

==
Lyx 2.3.1-1
SIGSEGV crach on MacOS High Sierra
When IMPORT files every format

Info:
(  1) 1   lyx 0x00010e135d7f 
_ZN3lyx8frontend5Alert7doErrorERKNSt3__112basic_stringIwNS2_11char_traitsIwEENS2_9allocatorIwSA_b
 : 1   lyx 0x00010e135d7f 
_ZN3lyx8frontend5Alert7doErrorERKNSt3__112basic_stringIwNS2_11char_traitsIwEENS2_9allocatorIwSA_b
 + 190
(  2) 2   lyx 0x00010e1362b5 
_ZN3lyx8frontend5Alert5errorERKNSt3__112basic_stringIwNS2_11char_traitsIwEENS2_9allocatorIwSA_b
 : 2   lyx 0x00010e1362b5 
_ZN3lyx8frontend5Alert5errorERKNSt3__112basic_stringIwNS2_11char_traitsIwEENS2_9allocatorIwSA_b
 + 149
(  3) 3   lyx 0x00010decce2b 
_ZN3lyx13error_handlerEi : 3   lyx 
0x00010decce2b _ZN3lyx13error_handlerEi + 506
(  4) 4   libsystem_platform.dylib0x7fff7d8d6f5a _sigtramp : 4  
 libsystem_platform.dylib0x7fff7d8d6f5a _sigtramp + 26
(  5) 5   lyx 0x00010e13d04e 
_ZThn16_NK3lyx8frontend14GuiApplication9getStatusERKNS_11FuncRequestE : 5   lyx 
0x00010e13d04e 
_ZThn16_NK3lyx8frontend14GuiApplication9getStatusERKNS_11FuncRequestE + 18
(  6) 6   lyx 0x00010e11a8e7 
_ZN3lyx8frontend6Action18qt_static_metacallEP7QObjectN11QMetaObject4CallEiPPv : 
6   lyx 0x00010e11a8e7 
_ZN3lyx8frontend6Action18qt_static_metacallEP7QObjectN11QMetaObject4CallEiPPv + 
157
(  7) 7   QtCore  0x00010f2e52e9 
_ZN11QMetaObject8activateEP7QObjectiiPPv : 7   QtCore   
   0x00010f2e52e9 _ZN11QMetaObject8activateEP7QObjectiiPPv + 3113
(  8) 8   QtWidgets   0x00010f726187 
_ZN7QAction8activateENS_11ActionEventE : 8   QtWidgets  
 0x00010f726187 _ZN7QAction8activateENS_11ActionEventE + 263
(  9) 9   QtCore  0x00010f2e52e9 
_ZN11QMetaObject8activateEP7QObjectiiPPv : 9   QtCore   
   0x00010f2e52e9 _ZN11QMetaObject8activateEP7QObjectiiPPv + 3113
( 10) 10  QtCore  0x00010f2dd2f1 
_ZN7QObject5eventEP6QEvent : 10  QtCore  
0x00010f2dd2f1 _ZN7QObject5eventEP6QEvent + 801
( 11) 11  QtWidgets   0x00010f72fb2d 
_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent : 11  QtWidgets   
0x00010f72fb2d 
_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent + 301
( 12) 12  QtWidgets   0x00010f730ea7 
_ZN12QApplication6notifyEP7QObjectP6QEvent : 12  QtWidgets  
 0x00010f730ea7 _ZN12QApplication6notifyEP7QObjectP6QEvent + 391
( 13) 13  lyx 0x00010e1463e0 
_ZN3lyx8frontend14GuiApplication6notifyEP7QObjectP6QEvent : 13  lyx 
0x00010e1463e0 
_ZN3lyx8frontend14GuiApplication6notifyEP7QObjectP6QEvent + 22
( 14) 14  QtCore  0x00010f2b3414 
_ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent : 14  QtCore   
   0x00010f2b3414 
_ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent + 164
( 15) 15  QtCore  0x00010f2b459b 
_ZN23QCoreApplicationPrivate16sendPostedEventsEP7QObjectiP11QThreadData : 15  
QtCore  0x00010f2b459b 
_ZN23QCoreApplicationPrivate16sendPostedEventsEP7QObjectiP11QThreadData + 891
( 16) 16  libqcocoa.dylib 0x000111d9512e 
_ZN28QCocoaEventDispatcherPrivate19processPostedEventsEv : 16  libqcocoa.dylib  
   0x000111d9512e 
_ZN28QCocoaEventDispatcherPrivate19processPostedEventsEv + 190
( 17) 17  libqcocoa.dylib 0x000111d959f1 
_ZN28QCocoaEventDispatcherPrivate26postedEventsSourceCallbackEPv : 17  
libqcocoa.dylib 0x000111d959f1 
_ZN28QCocoaEventDispatcherPrivate26postedEventsSourceCallbackEPv + 33
( 18) 18  CoreFoundation  0x7fff55706d31 
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ : 18  CoreFoundation 
 0x7fff55706d31 
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
( 19) 19  CoreFoundation  0x7fff557be60c 
__CFRunLoopDoSource0 : 19  CoreFoundation  
0x7fff557be60c __CFRunLoopDoSource0 + 108
( 20) 20  CoreFoundation  0x7fff556e9ce0 
__CFRunLoopDoSources0 : 20  CoreFoundation  
0x7fff556e9ce0 

Re: [LyX/2.3.x] Fix caret painting

2018-10-07 Thread Scott Kostyshak
On Sun, Oct 07, 2018 at 01:59:39PM +0200, Jean-Marc Lasgouttes wrote:
> Le 04/09/2018 à 03:55, Scott Kostyshak a écrit :
> > If I have an ERT in a preview inset, it previews when I open LyX. But if
> > I zoom in or out, the preview is not refreshed.
> > 
> > I did a bisect that lead me here. Note that I did the bisect on 2.3.x.
> > 
> > Can anyone reproduce?
> 
> I also have issues with preview working at times and then not. I do not see
> at this point how this could be related to this commit, though.

Good to know. Thanks for taking a look.

Scott


signature.asc
Description: PGP signature


Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

2018-10-07 Thread Scott Kostyshak
On Sun, Oct 07, 2018 at 05:18:23PM +0200, Jean-Marc Lasgouttes wrote:

> I have removed this feature in 2.4.0. The feature is already hidden in 2.3.

Sounds good. Thanks for doing that.

Scott


signature.asc
Description: PGP signature


Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

2018-10-07 Thread Jean-Marc Lasgouttes

Le 09/02/2018 à 19:19, Scott Kostyshak a écrit :

On Tue, Feb 06, 2018 at 10:15:30PM +, Scott Kostyshak wrote:

On Tue, Feb 06, 2018 at 08:35:56PM +, Jean-Marc Lasgouttes wrote:

Le 06/02/2018 à 18:17, Scott Kostyshak a écrit :

Absolutely. I think JMarc made a similar suggestion to hide it. I
proposed to silently ignore it because by nature of being a release
manager I tend to by default suggest the fewest changes possible now
that we are after rc2.


Note that we already do that on Linux, so it would not be an extraordinary
change.


Good point.


We can decide to disable it for now


That's fine with me.


Since no other opinions yet, let's move forward with disabling it for
2.3.0. JMarc do you have time to do this? Normally I think this is
something I could make a patch for, but I'm hesitant to provide a patch
for something I don't understand (pixmap cache) this close to a release.


I have removed this feature in 2.4.0. The feature is already hidden in 2.3.

JMarc


Re: GUI for setting Document->Colors not translatable

2018-10-07 Thread Kornel Benko
Am Sonntag, 7. Oktober 2018 14:02:28 CEST schrieb Jean-Marc Lasgouttes 
:
> Le 17/08/2018 à 11:33, Jürgen Spitzmüller a écrit :
> > Am Donnerstag, den 16.08.2018, 10:05 +0200 schrieb Kornel Benko:
> >> In my case, it _is_ translated, but only if using German
> >> LANG/LANGUAGE environment.
> >> In all other cases it is English.
> >>
> >> The attached shows the dialog while
> >>* editing English document
> >>* The GUI is set to French
> >>* Environment LANGUAGE=de_DE:sk_SK:en_US:en
> >>* Environment LANG=de_DE.UTF-8
> >>
> >> As can be seen, even the string 'Cancel' is not translated (which
> >> clearly exists in our po-file)
> >> and which works on other dialogs.
> > 
> > This is a qt dialog (QColorDialog). I suppose it takes the Environment
> > settings rather than what is set in LyX's prefs. This should be the
> > same in other native qt dialogs (such as the file dialog).
> 
> Is this fixed now that we translate Qt strings too?
> 
> JMarc
> 

Jürgen would say that is the intended feature. They will be translated into
the language of Environment LANGUAGE
(This may not be the GUI language if not selected default,
which applied in my case)

Kornel


signature.asc
Description: This is a digitally signed message part.


Re: LyX Version 2.3.1 not showing bold on screen

2018-10-07 Thread Paola Manzini



> On 7 Oct 2018, at 14:00, Jean-Marc Lasgouttes  wrote:
> 
> Le 07/10/2018 à 14:46, Paola Manzini a écrit :
>> Hi All,
>> using LyX 2.3.1 on a MacBook Pro, Mac OS version 10.14 Mojave: bold fonts do 
>> not show on screen when editing. The documents does compile correctly. I 
>> haven’t seen this bug reported, so here I go. I had the same problem on Mac 
>> OS High Sierra.
> 
> Hello,
> 
> This is tracked at https://www.lyx.org/trac/ticket/11271
> 
> Since it is a Qt issue, we are not sure of what we an do at our level.
> 
> JMarc


Oops, sorry I missed that tracked bug. Thanks for clarifying!
Paola



Re: LyX Version 2.3.1 not showing bold on screen

2018-10-07 Thread Jean-Marc Lasgouttes

Le 07/10/2018 à 14:46, Paola Manzini a écrit :

Hi All,

using LyX 2.3.1 on a MacBook Pro, Mac OS version 10.14 Mojave: bold fonts do 
not show on screen when editing. The documents does compile correctly. I 
haven’t seen this bug reported, so here I go. I had the same problem on Mac OS 
High Sierra.


Hello,

This is tracked at https://www.lyx.org/trac/ticket/11271

Since it is a Qt issue, we are not sure of what we an do at our level.

JMarc


LyX Version 2.3.1 not showing bold on screen

2018-10-07 Thread Paola Manzini
Hi All,

using LyX 2.3.1 on a MacBook Pro, Mac OS version 10.14 Mojave: bold fonts do 
not show on screen when editing. The documents does compile correctly. I 
haven’t seen this bug reported, so here I go. I had the same problem on Mac OS 
High Sierra.

Thanks,
Paola



Re: [LyX/2.3.x] Fix bug #9348

2018-10-07 Thread Guillaume MM

Hi,

The commit below introduces an incompatibility between lyx 2.3.1 and 
2.3.2 that can affect users of math macros.


This was reported a while ago at 
https://www.lyx.org/trac/ticket/9348#comment:17 with an example. The 
difference results in extra red braces being introduced. The example 
shows several cases where this changes the latex meaning and pdf output 
in some cases, and causes compilation errors in other cases.


This is the sort of difference that can cause repeated issues, say, for 
two people who use different stable versions to collaborate on the same 
document.


Guillaume



Le 06/10/2018 à 12:51, Enrico Forestieri a écrit :

commit e94ea46be7e6738ff7ebdaca995c076a6fe649ef
Author: Enrico Forestieri 
Date:   Tue Apr 10 22:40:02 2018 +0200

 Fix bug #9348
 
 (cherry picked from commit 503f7db224c7afaa82ce1f0aea538bd2af0cf31a)

---
  src/mathed/InsetMathBrace.h |2 --
  status.23x  |2 ++
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mathed/InsetMathBrace.h b/src/mathed/InsetMathBrace.h
index b28cd05..82393e9 100644
--- a/src/mathed/InsetMathBrace.h
+++ b/src/mathed/InsetMathBrace.h
@@ -29,8 +29,6 @@ public:
InsetMathBrace * asBraceInset() { return this; }
/// identifies brace insets
InsetMathBrace const * asBraceInset() const { return this; }
-   /// we write extra braces in any case...
-   bool extraBraces() const { return true; }
///
void metrics(MetricsInfo & mi, Dimension & dim) const;
///
diff --git a/status.23x b/status.23x
index 4874268..66ef597 100644
--- a/status.23x
+++ b/status.23x
@@ -127,6 +127,8 @@ What's new
  
  - Fix issue with erroneous qualified citations (bug 11308).
  
+- Do not remove brace insets when parsing from latex (bug 9348).

+
  
  
  * USER INTERFACE






Re: GUI for setting Document->Colors not translatable

2018-10-07 Thread Jean-Marc Lasgouttes

Le 17/08/2018 à 11:33, Jürgen Spitzmüller a écrit :

Am Donnerstag, den 16.08.2018, 10:05 +0200 schrieb Kornel Benko:

In my case, it _is_ translated, but only if using German
LANG/LANGUAGE environment.
In all other cases it is English.

The attached shows the dialog while
* editing English document
* The GUI is set to French
* Environment LANGUAGE=de_DE:sk_SK:en_US:en
* Environment LANG=de_DE.UTF-8

As can be seen, even the string 'Cancel' is not translated (which
clearly exists in our po-file)
and which works on other dialogs.


This is a qt dialog (QColorDialog). I suppose it takes the Environment
settings rather than what is set in LyX's prefs. This should be the
same in other native qt dialogs (such as the file dialog).


Is this fixed now that we translate Qt strings too?

JMarc


Re: Sharpness of lyx characters

2018-10-07 Thread Jean-Marc Lasgouttes

Le 23/08/2018 à 17:35, Pol a écrit :

screen characters in lyx on hp-elitebook x360, appear unclear, i would
say that 'ink density' is not uniform.
No change switching to different fonts.
All applications display clear characters, except LyX
Lyx runs on opensuse leap 15 / plasma


Hi Paolo,

Did you update to LyX 2.3.1? If yes, does this address your issue?

JMarc



Re: [LyX/2.3.x] Fix caret painting

2018-10-07 Thread Jean-Marc Lasgouttes

Le 04/09/2018 à 03:55, Scott Kostyshak a écrit :

If I have an ERT in a preview inset, it previews when I open LyX. But if
I zoom in or out, the preview is not refreshed.

I did a bisect that lead me here. Note that I did the bisect on 2.3.x.

Can anyone reproduce?


I also have issues with preview working at times and then not. I do not 
see at this point how this could be related to this commit, though.


JMarc



Re: [LyX/2.3.x] Skip paint event when in the middle of a buffer operation

2018-10-07 Thread Jean-Marc Lasgouttes

Le 04/10/2018 à 15:22, Jean-Marc Lasgouttes a écrit :

Actually, as can be seen in
   https://www.lyx.org/trac/ticket/11323
there is a case for rushing out 2.3.2 with a fix for this. I therefore 
backported for 2.3.2 so that it gets maximum testing.


BTW, I would be interested in testing on windows and macOS, so that we 
do not discover problems at release time :)


JMarc


Re: Messages on first use of mathed in a session

2018-10-07 Thread Jean-Marc Lasgouttes

Le 06/10/2018 à 23:06, Andrew Parsloe a écrit :
The first time I use mathed in a session there can be a noticeable pause 
(a few seconds) before any character is displayed. When I look at the 
messages pane I get the attached list of messages. This is with 2.3.1-1 
(built and compiled with Qt 5.10.1). Is this expected? Second and later 
uses of mathed aren't delayed and don't generate the messages.


Are you sure that the messages happen at the time of the delay? I know 
there used to be a delay related to font loading at first math use, but 
this is not related to resources. Here I do not see any delay.


As far as I can see, the messages you see happen when trying to create 
toolbar icons for math.


Did you build LyX yourself? If so, did you use configure or cmake?

JMarc