Re: dynamic quotes

2017-01-07 Thread Guillaume Munch
Le 05/01/2017 à 06:39, Jürgen Spitzmüller a écrit : Am Mittwoch, den 04.01.2017, 23:27 +0100 schrieb Guillaume Munch: There I do not follow anymore: if without the checkbox you would need 12 key bindings, how is the checkbox helping? Or do you mean that even the checkbox does not address your

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Guillaume Munch
Le 30/12/2016 à 21:02, Richard Heck a écrit : On 12/30/2016 12:15 PM, Guillaume Munch wrote: Thanks for the patch. It is the same as calling fixIfBroken in GuiView::structureChanged (as attached) which I agree becomes even simpler. But, provided one accepts the idea that DocIterators hold

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Guillaume Munch
Le 30/12/2016 à 22:48, Jean-Marc Lasgouttes a écrit : At some time where DEPM was causing issues, there was the idea of registering cursors with their buffer. This would allow to keep track of what is happening. Another possibility would be to register insets, so that one can know when

Re: Memory leak with WordList

2016-12-31 Thread Guillaume Munch
Le 31/12/2016 à 13:16, Jean-Marc Lasgouttes a écrit : WordList leaks all its contents on exit, which is very impolite (even though the memory will be reclaimed anyway). This hides real memory leaks that may happen elsewhere. Snippet of Valgrind output for stable below. The WordList object

Re: master fails to compile with Qt 5.8dev

2016-12-27 Thread Guillaume Munch
Le 25/11/2016 à 05:20, Scott Kostyshak a écrit : I occassionally build the Qt development version to test various things. I currently get the following error when building LyX with Qt 5.8dev: /home/vbox/lyxbuilds/master/repo/src/frontends/qt4/GuiViewSource.cpp:224:14: error: ambiguous

Re: [LyX/master] Nonsense for whoever insists on using gcc4.6 & qt4.8 in 2017

2017-03-19 Thread Guillaume Munch
Le 11/03/2017 à 20:16, Pavel Sanda a écrit : Guillaume Munch wrote: On the other hand, for graphics, the idea of the previous FileMonitor could be adapted to refresh graphics when they appear on the screen Perhaps. But it should do that when window gets active (we already catch that signal

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended-parameterised #1

2017-03-19 Thread Guillaume Munch
Le 19/03/2017 à 13:17, ci-...@inria.fr a écrit : Making distclean in . make[3]: Entering directory '/build/workspace/lyx-2.3.0dev/_build/sub/src' Makefile:2455: support/tests/.deps/check_ExternalTransforms-dummy_functions.Po: No such file or directory Makefile:2456:

Re: [PATCH] Output of en- and em-dashes

2017-03-18 Thread Guillaume Munch
Le 18/03/2017 à 14:59, Enrico Forestieri a écrit : On Wed, Mar 15, 2017 at 06:12:51PM +0100, Enrico Forestieri wrote: Apparently, nobody has a preference, so I am going to commit the second patch, i.e., the one using a zero-width space character. On second thoughts, I am not sure this is the

Re: cmake compilation error

2017-03-11 Thread Guillaume Munch
Le 11/03/2017 à 18:07, Jean-Pierre Chrétien a écrit : Le 11/03/2017 à 17:57, Kornel Benko a écrit : I see the same with installed QT5.2.1. But no problems with QT5.7. Seems that I've got 5.3.2 here, Debian Jessie (up to date stable). Indeed the function is introduced in qt5.4. It is now

Re: cmake compilation error

2017-03-12 Thread Guillaume Munch
Le 12/03/2017 à 16:51, Kornel Benko a écrit : Should we emit a warning (which probably will be ignored) or better refuse to build with "5.0" <= QT < "5.4" ? I don't think so, the indication INSTALL file should be enough in that case. From my POV, if user selects QT5, we should use it.

Re: [LyX/master] Nonsense for whoever insists on using gcc4.6 & qt4.8 in 2017

2017-03-11 Thread Guillaume Munch
Le 11/03/2017 à 08:34, Pavel Sanda a écrit : Guillaume Munch wrote: commit 24f68aff8d2ba9139017ca3927eda1f1aaf039af Author: Guillaume Munch <g...@lyx.org> Date: Sat Mar 11 00:11:02 2017 +0100 Nonsense for whoever insists on using gcc4.6 & qt4.8 in 2017 Does it mean it is no

Re: [LyX/master] buffer-export without argument exports the default format

2017-03-11 Thread Guillaume Munch
Le 11/03/2017 à 08:37, Scott Kostyshak a écrit : It looks like Guillaume made the change at 3dec5826. Yes, and thanks for the feedback.

Re: [LyX/master] buffer-export without argument exports the default format

2017-03-08 Thread Guillaume Munch
Le 08/03/2017 à 13:18, Kornel Benko a écrit : Am Mittwoch, 8. März 2017 um 11:48:12, schrieb Guenter Milde Would you be opposed to using a different symbol that is not interpreted by common shells? I thought about it. I prefer *, because * it is established as

Re: How far is 2.3.0?

2017-03-04 Thread Guillaume Munch
Le 24/02/2017 à 18:45, Jean-Marc Lasgouttes a écrit : Hi there, A good subject before the week-end: what do we need to do before declaring feature freeze for 2.3? Personally I have finished a cycle or breaking/fixing the math editor and would like to refrain from doing new big architectural

Re: Ending selection on item inside a table erroneously interpreted as a "click", brings up dialog

2017-03-04 Thread Guillaume Munch
Le 03/03/2017 à 17:42, Helge Hafting a écrit : I guess the same goes for anything that does something when clicked. If it is inside a table cell and a mouse selection ends on top of it, a (wrong) click action happens. Hi Helge, It's fixed at 354897f6. Guillaume

Re: Regular expression search

2017-03-04 Thread Guillaume Munch
Le 27/02/2017 à 22:08, Georg Baum a écrit : Guillaume Munch wrote: AFAIR, the ECMAScript regexes are a proper subset of PCRE whereas there are incompatibilities between POSIX and PCRE. Moreover ECMAScript is the default for , so maybe it is better supported across compilers. This makes

Re: Automatic configuration of forward search

2017-03-04 Thread Guillaume Munch
Le 25/02/2017 à 18:09, Scott Kostyshak a écrit : On Wed, Aug 03, 2016 at 10:11:38PM -0400, Scott Kostyshak wrote: It would be nice if users did not have to configure forward search (although they should have the option to do so if they prefer). I see two possibilities: (1) Can configure.py do

Re: [LyX/master] buffer-export without argument exports the default format

2017-03-04 Thread Guillaume Munch
Le 28/02/2017 à 04:50, Scott Kostyshak a écrit : On Tue, Feb 28, 2017 at 12:47:12AM +0100, Guillaume Munch wrote: commit a1faa41c839089a9f21323af6540926eae90ec6f Author: Guillaume Munch <g...@lyx.org> Date: Mon Feb 27 20:43:11 2017 +0100 buffer-export without argument exports the d

Re: today's compilation errors and warnings

2017-03-04 Thread Guillaume Munch
Le 05/03/2017 à 03:27, Uwe Stöhr a écrit : I compiled today's master and get an error: xgettext: error while opening "src/frontends/qt4/LyXToolBox.cpp" for reading: No such file or directory C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error

<    5   6   7   8   9   10