Re: Subject: [PATCH] Make text selectable in Help > About LyX > Version

2012-10-31 Thread Lars Gullik Bjønnes
Kornel Benko writes: | Am Mittwoch, 31. Oktober 2012 um 16:46:53, schrieb Jean-Marc | Lasgouttes >> Le 31/10/2012 16:41, Kornel Benko a écrit : >> > git log -1 --format="%H %ci" >> >> Or simply >>git log -1 --format="%h" >> >> What I do not know is where to put such code so that it is alwa

Re: Subject: [PATCH] Make text selectable in Help > About LyX > Version

2012-10-31 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Jean-Marc Lasgouttes wrote: >> What I do not know is where to put such code so that it is always up to >> date. This should replace the date for development releases. > | 1) linker time, something along the lines LDFLAGS += --defsym | __GITSHA=$$(git -1 log blablabla)) |

Re: Subject: [PATCH] Make text selectable in Help > About LyX > Version

2012-10-31 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 31/10/2012 16:41, Kornel Benko a écrit : >> git log -1 --format="%H %ci" > | Or simply | git log -1 --format="%h" > | What I do not know is where to put such code so that it is always up | to date. This should replace the date for development releases. Hmm...

Re: git in 2.1

2012-10-30 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | Alessandro Di Federico writes: > | | On Fri, 2012-10-26 at 18:03 +0200, Pavel Sanda wrote: >>> No, it is not. Adding some basic support (#0) like we have with other >>> RCS >>> is one weekend work and you'll spe

Re: git in 2.1

2012-10-30 Thread Lars Gullik Bjønnes
Alessandro Di Federico writes: | On Fri, 2012-10-26 at 18:03 +0200, Pavel Sanda wrote: >> No, it is not. Adding some basic support (#0) like we have with other >> RCS >> is one weekend work and you'll spend more time on testing than coding. >> >> Some folks spoke about more fancy git support - i

Re: Compilers used for compiling LyX?

2012-10-29 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj?nnes wrote: >> Would be fun to see how far off we are from being able to use C++11. > | Which minimum version of gcc/MSVC is needed for your fun? I think we have to wait a bit. I'd prefere c++11 to be out of experimental state in gcc. So gcc 4.8 earliest, alt

Re: Compilers used for compiling LyX?

2012-10-29 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 29/10/2012 06:36, Liviu Andronic a écrit : >> On Sun, Oct 28, 2012 at 11:58 AM, Jean-Marc Lasgouttes >> wrote: >>> I have 4.4 on my ubuntu 10.04 install. >>> >> Are you sure? Ubuntu Lucid ships Qt 4.6.2 [1]. >> [1] >> http://packages.ubuntu.com/search?keywords=l

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-28 Thread Lars Gullik Bjønnes
Stephan Witt writes: | Am 27.10.2012 um 22:21 schrieb Lars Gullik Bjønnes : > >> On 27 October 2012 21:31, Stephan Witt wrote: >>> Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : >>> >>>>> This invalidates all patches hanging around for cosmet

Retina support on Mac

2012-10-28 Thread Lars Gullik Bjønnes
What would having retina support on Mac entail for LyX? I just got a request for that (together with a donation). -- Lgb

Re: boost

2012-10-28 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 26/10/12 19:05, Pavel Sanda a écrit : >> BTW after some decade we still include boost in our tarballs and maintain >> its updates. What was the original reason and is it still needed? Some >> distributions disable internal boost and we do not see any flood of bug

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
On 27 October 2012 21:31, Stephan Witt wrote: > Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : > >>> This invalidates all patches hanging around for cosmetic reasons. >>> Is this really necessary? >> >> Why do you have patches hanging around? > > Be

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
Stephan Witt writes: | Am 27.10.2012 um 15:46 schrieb Lars Gullik Bjønnes : > >> --- >> src/AppleSpellChecker.cpp | 6 +- >> src/AspellChecker.cpp | 32 +++-- >> src/Author.cpp| 13 +- >> src/BiblioInfo.cpp| 233 +

Re: Compile problem with latest pull

2012-10-27 Thread Lars Gullik Bjønnes
Kayvan Sylvan writes: | On Fedora 16: > | CXXInsetListings.o | insets/InsetLine.cpp: In member function 'virtual void | lyx::InsetLine::metrics(lyx::MetricsInfo&, lyx::Dimension&) const': | insets/InsetLine.cpp:121:33: error: 'abs' was not declared in this scope On F16, that is actually surp

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
> This invalidates all patches hanging around for cosmetic reasons. > Is this really necessary? Why do you have patches hanging around? Are you saying that changes are hostage to undisclosed patches that someone might have? And if it takes you more than 5 minutes to fix the conflicts that you ge

Re: [PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj??nnes wrote: >>Change to use Modified Bernstein's hash function > | Doesn't this imply fileformat change/conversions so hashes generated | in 2.0 are correctly recognized in 2.1? Actually if I read the usage correctly we are free to change the hash function.

Re: [PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj??nnes wrote: >>Change to use Modified Bernstein's hash function > | Doesn't this imply fileformat change/conversions so hashes generated | in 2.0 are correctly recognized in 2.1? Right. The Author feature is really lacking in documentation. This really seem

[PATCH 2/2] Author.{h,cpp}: remove last_id

2012-10-27 Thread Lars Gullik Bjønnes
We can get the id from the size of the author container. --- src/Author.cpp | 3 +-- src/Author.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Author.cpp b/src/Author.cpp index b19e2be..5efa1fa 100644 --- a/src/Author.cpp +++ b/src/Author.cpp @@ -77,7 +77,6 @@ bool a

[PATCH 1/2] Author.cpp: Change to use Modified Bernstein's hash function

2012-10-27 Thread Lars Gullik Bjønnes
Also remove the manual "optimization": 33 * hash == (hash << 5) + hash, and just let the compiler handle that. The 33 really is important for the function so it is nicer to let it stand out more. --- src/Author.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Author.

Berntein's hash

2012-10-27 Thread Lars Gullik Bjønnes
static int computeHash(docstring const & name, docstring const & email) { string const full_author_string = to_utf8(name + email); // Bernstein's hash function unsigned int hash = 5381; for (unsigned int c: full_author_string) hash = ((hash <

Re: Compilers used for compiling LyX?

2012-10-27 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Sat, Oct 27, 2012 at 01:35:26AM +0200, Lars Gullik Bjønnes wrote: >> >> Do any of you have feeling what compilers are use to compile LyX >> now-a-days, that at what version they are? >> >> Would be fun to see how far off we are from bein

Re: boost

2012-10-27 Thread Lars Gullik Bjønnes
André Pönitz writes: | I thought I could simply shut up. Alas, it looks like I can't. > | On Sat, Oct 27, 2012 at 01:12:21AM +0200, Lars Gullik Bjønnes wrote: >> lar...@gullik.org (Lars Gullik Bjønnes) writes: >> >> | | BTW after some decade we still include boost in

Re: boost

2012-10-27 Thread Lars Gullik Bjønnes
André Pönitz writes: | I thought I could simply shut up. Alas, it looks like I can't. > | On Sat, Oct 27, 2012 at 01:12:21AM +0200, Lars Gullik Bjønnes wrote: >> lar...@gullik.org (Lars Gullik Bjønnes) writes: >> >> | | BTW after some decade we still include boost in

Re: boost

2012-10-26 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj?nnes wrote: >> My preferences are as follows: >> >> 0. Standard C++ >> 1. Something with the same apis/behaviour as standard C++ >> 2. Use something that is destined for standardization. >> 3. third party libraries. >> >> In a lot of cases 1 & 2 is solved by

Compilers used for compiling LyX?

2012-10-26 Thread Lars Gullik Bjønnes
Do any of you have feeling what compilers are use to compile LyX now-a-days, that at what version they are? Would be fun to see how far off we are from being able to use C++11. -- Lgb

Re: boost

2012-10-26 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | | BTW after some decade we still include boost in our tarballs and maintain | | its updates. What was the original reason and is it still needed? > | My preferences are as follows: > | 0. Standard C++ | 1. Something with the same apis/behavi

Re: boost

2012-10-26 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | Pavel Sanda writes: > | | Lars Gullik Bj?nnes wrote: >>> The problem is that somethings that I find highly non-controversial are >>> not thought so by others. >> | | If this is the problem, you can always go through the

Re: boost

2012-10-26 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj?nnes wrote: >> The problem is that somethings that I find highly non-controversial are >> not thought so by others. > | If this is the problem, you can always go through the usual route | "if no one objects I'll commit this later". > >> (Basically TR1 is dead

Re: git in 2.1

2012-10-26 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Alessandro Di Federico wrote: >> This year I'm planning to put up a SVN server > | Right and it must be <1.7 :-/ > >> (sigh, no git support yet, and it may be too late now) > | No, it is not. Adding some basic support (#0) like we have with other RCS | is one weekend work an

Re: [PATCH 1/3] Buffer.cpp: drop unused

2012-10-26 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | Jean-Marc Lasgouttes writes: > | | Lars, >> | | I propose that you commit the patches that you know are not | | controversial. This series of patches is a good example IMO. > | The problem is that somethings that I find highly non-c

Re: [PATCH 1/3] Buffer.cpp: drop unused

2012-10-26 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Lars, > | I propose that you commit the patches that you know are not | controversial. This series of patches is a good example IMO. The problem is that somethings that I find highly non-controversial are not thought so by others. | Pavel, Vincent, this is probabl

[PATCH 1/2] support/lyxalgo.h: introduce lyx::clamp

2012-10-26 Thread Lars Gullik Bjønnes
This returns a clamped value, requiring it to be between low and high. clamp(5, 0, 10) == min(max(5, 0), 10) == max(min(5, 10), 0) --- src/support/lyxalgo.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/support/lyxalgo.h b/src/support/lyxalgo.h index f747e27..6ffb59b 100644 --- a/

[PATCH 2/2] Use clamp

2012-10-26 Thread Lars Gullik Bjønnes
--- src/BufferView.cpp| 5 +++-- src/Text3.cpp | 3 ++- src/frontends/qt4/GuiWorkArea.cpp | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/BufferView.cpp b/src/BufferView.cpp index bb5ed50..079ee1c 100644 --- a/src/BufferView.cpp +++ b

[PATCH] insets/InsetLine.cpp: use std::abs

2012-10-26 Thread Lars Gullik Bjønnes
Use std::abs in stead of std::max(v, -v). --- src/insets/InsetLine.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/insets/InsetLine.cpp b/src/insets/InsetLine.cpp index 86a7e5c..f72fe64 100644 --- a/src/insets/InsetLine.cpp +++ b/src/insets/InsetLine.cpp @@ -118,7 +118,

[PATCH] Use new T not new T()

2012-10-25 Thread Lars Gullik Bjønnes
--- src/Buffer.cpp| 4 ++-- src/LyX.cpp | 8 src/WordList.cpp | 2 +- src/frontends/qt4/GuiApplication.cpp | 4 ++-- src/frontends/qt4/GuiClipboard.cpp| 2 +- src/frontends/qt4/GuiProgressView.cpp | 2 +- src/fron

[PATCH 3/3] Use empty() to check empty and non-empty'ness not size()

2012-10-25 Thread Lars Gullik Bjønnes
Also add FormatList::empty(). --- src/BiblioInfo.cpp | 8 +++--- src/Cursor.cpp | 4 +-- src/Format.h | 2 ++ src/KeySequence.cpp | 3 +- src/Paragraph.cpp| 4 +-- src/client/client.cpp| 10 +++ s

[PATCH 2/3] WS cleanup, remove extraeneous spaces

2012-10-25 Thread Lars Gullik Bjønnes
--- src/BufferParams.h | 2 +- src/CutAndPaste.cpp | 2 +- src/LyX.h | 3 +-- src/graphics/GraphicsLoader.cpp | 5 ++--- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/BufferParams.h b/src/BufferParams.h index 306e5bc..98f79a5 1006

[PATCH 1/3] Buffer.cpp: drop unused

2012-10-25 Thread Lars Gullik Bjønnes
--- src/Buffer.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Buffer.cpp b/src/Buffer.cpp index 8b052ad..ebc5d3a 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -113,7 +113,6 @@ #include #include #include -#include #include using namespace std; -- 1.8.0

Re: [PATCH 10/13] More idiomatic way of checking if a shared_ptr has an associated managed object

2012-10-25 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: Ok for me to commit this? | --- | src/KeyMap.cpp | 17 - | src/frontends/qt4/LayoutBox.cpp| 4 ++-- | src/graphics/GraphicsCacheItem.cpp | 2 +- | src/graphics/GraphicsLoader.cpp| 22

Re: [PATCH] config/lyxinclude.m4: add support for -flto

2012-10-24 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 24/10/12 22:18, Lars Gullik Bjønnes a écrit : >> Jean-Marc Lasgouttes writes: >> >> | Le 24/10/2012 13:13, Lars Gullik Bjønnes a écrit : >>>> Add feature --enable-lto, link-time optimization. >>> >> | Do you see a vi

Re: [PATCH 2/2] config/lyxinclude.m4: add support for --enable-cxx11

2012-10-24 Thread Lars Gullik Bjønnes
Richard Heck writes: | On 10/23/2012 09:07 PM, Lars Gullik Bjønnes wrote: >> Using --enable-cxx11 turns on C++11 mode in gcc. | Seems like a good idea. I will have to commit 1/2 in this series as well. Ok? -- Lgb

Re: [PATCH 5/5] src/lyxfind.cpp: use local typedef to simplify

2012-10-24 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Wed, Oct 24, 2012 at 01:27:40AM +0200, Lars Gullik Bjønnes wrote: >> André Pönitz writes: >> >> | On Tue, Oct 23, 2012 at 11:14:42PM +0200, lar...@gullik.org wrote: >> >> From: Lars Gullik Bjønnes >> >> >> >>

Re: [PATCH] config/lyxinclude.m4: add support for -flto

2012-10-24 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 24/10/2012 13:13, Lars Gullik Bjønnes a écrit : >> Add feature --enable-lto, link-time optimization. > | Do you see a visible gain, that would make it worth using on release builds? textdatabss dec hexfilename 8042443 28616 3962

[PATCH] config/lyxinclude.m4: add support for -flto

2012-10-24 Thread Lars Gullik Bjønnes
Add feature --enable-lto, link-time optimization. Enabling link-time optimization turns debug information off (-g), sine -flto and -g does not currently well work together. Also stdlib-debug is turned off, does also not work well with -flto. --- config/lyxinclude.m4 | 27

[PATCH 1/2] support/Messages.cpp: add space to not be taken as user defined literal

2012-10-23 Thread Lars Gullik Bjønnes
In C++11 you are not allowed to have non-literal specifiers right after a string literal. --- src/support/Messages.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/support/Messages.cpp b/src/support/Messages.cpp index ca5c110..fdcaf66 100644 --- a/src/support/Messages.cp

[PATCH 2/2] config/lyxinclude.m4: add support for --enable-cxx11

2012-10-23 Thread Lars Gullik Bjønnes
Using --enable-cxx11 turns on C++11 mode in gcc. --- config/lyxinclude.m4 | 16 1 file changed, 16 insertions(+) diff --git a/config/lyxinclude.m4 b/config/lyxinclude.m4 index e532c54..2e529ea 100644 --- a/config/lyxinclude.m4 +++ b/config/lyxinclude.m4 @@ -232,6 +232,10 @@ AC_AR

Re: FYI: compiling with gcc 4.8

2012-10-23 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | gcc 4.8.0 (4.8.0 20121023 (experimental)): > | time make -j6 | real3m9.445s | user11m53.000s | sys 0m51.485s > | size src/lyx | text databss dec hexfilename | 11348213 31352 44504 11424069 ae5145 s

Re: [PATCH 5/5] src/lyxfind.cpp: use local typedef to simplify

2012-10-23 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Tue, Oct 23, 2012 at 11:14:42PM +0200, lar...@gullik.org wrote: >> From: Lars Gullik Bjønnes >> >> Use a local typedef pair P to avoid having to repeat >> that multiple times. >>

FYI: compiling with gcc 4.8

2012-10-23 Thread Lars Gullik Bjønnes
(AMD Phenom(tm) II X6 1090T Processor) gcc 4.7.2 (4.7.2 20120921 (Red Hat 4.7.2-2)): time make CXX=/usr/bin/g++ -j6 real3m1.055s user10m31.367s sys 0m49.691s size src/lyx text data bss dec hexfilename 11339834 3133645416 11416586 ae340a src/lyx ls -

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/12 21:18, Lars Gullik Bjønnes a écrit : >> | Concerning auto, I am still not sure that I like it. >> >> Liking it took me some 5 seconds. >> >> Auto suddenly makes it nice to work with the complex types you get in >>

Re: [PATCH 13/13] boost: changes to make it compile cleanly with gcc 4.8

2012-10-23 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | --- | boost/boost/lexical_cast.hpp | 1 - | boost/boost/math/special_functions/fpclassify.hpp | 4 | boost/boost/math/special_functions/sign.hpp | 2 -- | boost/boost/regex/v4/regex_format.hpp | 2

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes writes: | On Tue, Oct 23, 2012 at 2:27 PM, Lars Gullik Bjønnes wrote: >> C++11 would make the code look a lot nicer, esp. thru the use of range >> based for, and auto: >> >> std::vector::iterator at = somevec.begin(); >> std::vect

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/2012 15:41, Abdelrazak Younes a écrit : >> I really don't understand the rationale, sorry. I'd consider very bad >> style to create our own lyx::vector or lyx::iostream, so what's the >> point? > | FWIW, we already define lyx::assert, lyx::shared_ptr, lyx::

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/2012 14:27, Lars Gullik Bjønnes a écrit : >> C++11 would make the code look a lot nicer, esp. thru the use of range >> based for, and auto: >> >> std::vector::iterator at = somevec.begin(); >> std::vect

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/12 01:21, Lars Gullik Bjønnes a écrit : >> Anyhow... I am going to ditch the hole series. Pick what you want from >> it if anything. >> >> I just cannot stand the hostility. > | Come on. André is bored and he feel happy to be

Re: Ad. "using namespace std" - ref prob in c9b9748c

2012-10-22 Thread Lars Gullik Bjønnes
Abdelrazak Younes writes: | On Mon, Oct 22, 2012 at 11:53 AM, Jean-Marc Lasgouttes | wrote: >> Le 22/10/2012 00:41, Lars Gullik Bjønnes a écrit : >> >>> >>> It is mentioned in c9b9748c that "using namespace std" on msvc10 also >>> drags in std:

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-22 Thread Lars Gullik Bjønnes
Richard Heck writes: | On 10/21/2012 03:11 PM, Lars Gullik Bjønnes wrote: >> Using std::make_shared (and in our case for the time being >> boost::make_shared) >> is the preferred way of creating a std::shared_ptr. >> | Can we get some kind if mini-tutorial here,

Re: Ad. "using namespace std" - ref prob in c9b9748c

2012-10-22 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 22/10/2012 00:41, Lars Gullik Bjønnes a écrit : >> >> It is mentioned in c9b9748c that "using namespace std" on msvc10 also >> drags in std::tr1 stuff. > >> IMHO a much better solution is to just use "std::" p

Re: Ad. "using namespace std" - ref prob in c9b9748c

2012-10-22 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Mon, Oct 22, 2012 at 12:41:08AM +0200, Lars Gullik Bjønnes wrote: >> >> It is mentioned in c9b9748c that "using namespace std" on msvc10 also >> drags in std::tr1 stuff. >> >> IMHO the soltion is not to use boost::shared_ptr et

Re: Ad. "using namespace std" - ref prob in c9b9748c

2012-10-22 Thread Lars Gullik Bjønnes
Abdelrazak Younes writes: | On Mon, Oct 22, 2012 at 12:41 AM, Lars Gullik Bjønnes wrote: >> >> It is mentioned in c9b9748c that "using namespace std" on msvc10 also >> drags in std::tr1 stuff. >> >> IMHO the soltion is not to use boost::shared_ptr etc. B

Re: [PATCH 08/13] support/shared_ptr.h: drop support of TR1 smart pointers

2012-10-22 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj?nnes wrote: >> diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h >> index 69e42da..792beb2 100644 >> --- a/src/support/shared_ptr.h >> +++ b/src/support/shared_ptr.h >> @@ -12,22 +12,6 @@ >> #ifndef LYX_SHARED_PTR_H >> #define LYX_SHARED_PTR_H

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-22 Thread Lars Gullik Bjønnes
Richard Heck writes: | On 10/21/2012 03:11 PM, Lars Gullik Bjønnes wrote: >> Using std::make_shared (and in our case for the time being >> boost::make_shared) >> is the preferred way of creating a std::shared_ptr. >> | Can we get some kind if mini-tutorial here,

Ad. "using namespace std" - ref prob in c9b9748c

2012-10-21 Thread Lars Gullik Bjønnes
It is mentioned in c9b9748c that "using namespace std" on msvc10 also drags in std::tr1 stuff. IMHO the soltion is not to use boost::shared_ptr etc. But to stop using "using namespace std". I look briefly as to what was discussed in 2007 when the "using namespace std" was introduced all over, and

Re: [PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Sun, Oct 21, 2012 at 08:49:06PM +0200, Lars Gullik Bjønnes wrote: >> diff --git a/src/LyX.h b/src/LyX.h >> index 70b8b7e..97c9b4a 100644 >> --- a/src/LyX.h >> +++ b/src/LyX.h >> @@ -16,6 +16,7 @@ >> >> #include "su

[PATCH 07/13] graphics/GraphicsLoader.cpp: use !empty() to check for non-emptyness not size()

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsLoader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/graphics/GraphicsLoader.cpp b/src/graphics/GraphicsLoader.cpp index 8f3a4cf..04dd7bd 100644 --- a/src/graphics/GraphicsLoader.cpp +++ b/src/graphics/GraphicsLoader.cpp @@ -89,7 +89,7 @@ voi

[PATCH 03/13] src/Lyx: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/LyX.cpp | 5 + src/LyX.h | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/LyX.cpp b/src/LyX.cpp index 722f040..03caff3 100644 --- a/src/LyX.cpp +++ b/src/LyX.cpp @@ -64,7 +64,6 @@ #include "support/Systemcall.h" #include "support/bind.h" -#include

[PATCH 10/13] More idiomatic way of checking if a shared_ptr has an associated managed object

2012-10-21 Thread Lars Gullik Bjønnes
--- src/KeyMap.cpp | 17 - src/frontends/qt4/LayoutBox.cpp| 4 ++-- src/graphics/GraphicsCacheItem.cpp | 2 +- src/graphics/GraphicsLoader.cpp| 22 +++--- src/support/ForkedCalls.cpp| 2 +- 5 files changed, 23 insertions(+), 2

[PATCH 09/13] support/shared_ptr.h: introduce boost::make_shared into ns lyx

2012-10-21 Thread Lars Gullik Bjønnes
--- src/support/shared_ptr.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h index 792beb2..3aa6492 100644 --- a/src/support/shared_ptr.h +++ b/src/support/shared_ptr.h @@ -12,12 +12,13 @@ #ifndef LYX_SHARED_PTR_H #define

[PATCH 05/13] src/graphics/GraphicsCacheItem: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsCacheItem.cpp | 1 - src/graphics/GraphicsCacheItem.h | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsCacheItem.cpp b/src/graphics/GraphicsCacheItem.cpp index fafa78b..60477cc 100644 --- a/src/graphics/GraphicsCacheItem.cpp

[PATCH 08/13] support/shared_ptr.h: drop support of TR1 smart pointers

2012-10-21 Thread Lars Gullik Bjønnes
--- src/support/shared_ptr.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/support/shared_ptr.h b/src/support/shared_ptr.h index 69e42da..792beb2 100644 --- a/src/support/shared_ptr.h +++ b/src/support/shared_ptr.h @@ -12,22 +12,6 @@ #ifndef LYX_SHARED_PTR_H #defin

[PATCH 13/13] boost: changes to make it compile cleanly with gcc 4.8

2012-10-21 Thread Lars Gullik Bjønnes
--- boost/boost/lexical_cast.hpp | 1 - boost/boost/math/special_functions/fpclassify.hpp | 4 boost/boost/math/special_functions/sign.hpp | 2 -- boost/boost/regex/v4/regex_format.hpp | 2 -- boost/boost/regex/v4/regex_split.hpp | 1 - boo

Re: [PATCH 01/13] Buffer.cpp: drop unused

2012-10-21 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | This patch, and the others I saw, make sense. However, I only see | numbers 1, 2, 4 and 6 (of supposedly 13 parts). For some reason the seem to be trickling in. I'll resend the missing once if they do no show up. -- Lgb

[PATCH 11/13] Use make_shared to create shared_ptr

2012-10-21 Thread Lars Gullik Bjønnes
Using std::make_shared (and in our case for the time being boost::make_shared) is the preferred way of creating a std::shared_ptr. This is mainly due to two aspects: - half the number of allocations required - potential of using less space, and better locality Also a failed creation of t

[PATCH 12/13] graphics/GraphicsImage.h: let newImage and Image::clone return a shared_ptr

2012-10-21 Thread Lars Gullik Bjønnes
--- src/frontends/qt4/GuiImage.cpp | 8 src/frontends/qt4/GuiImage.h | 2 +- src/graphics/GraphicsCacheItem.cpp | 2 +- src/graphics/GraphicsImage.h | 5 +++-- src/graphics/GraphicsLoader.cpp| 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/f

[PATCH 04/13] src/graphics/GraphicsCache: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsCache.cpp | 1 - src/graphics/GraphicsCache.h | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsCache.cpp b/src/graphics/GraphicsCache.cpp index d508563..f9eee10 100644 --- a/src/graphics/GraphicsCache.cpp +++ b/src/graphics/G

[PATCH 06/13] src/graphics/GraphicsLoader: use boost::scoped_ptr to hold the pimpl

2012-10-21 Thread Lars Gullik Bjønnes
--- src/graphics/GraphicsLoader.cpp | 1 - src/graphics/GraphicsLoader.h | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/graphics/GraphicsLoader.cpp b/src/graphics/GraphicsLoader.cpp index bd81a50..8f3a4cf 100644 --- a/src/graphics/GraphicsLoader.cpp +++ b/src/graphi

[PATCH 02/13] WS cleanup, remove extraeneous spaces

2012-10-21 Thread Lars Gullik Bjønnes
--- src/BufferParams.h | 2 +- src/CutAndPaste.cpp | 2 +- src/LyX.h | 3 +-- src/graphics/GraphicsLoader.cpp | 5 ++--- src/tex2lyx/tex2lyx.cpp | 4 ++-- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/BufferParams.h b/src

[PATCH 01/13] Buffer.cpp: drop unused

2012-10-21 Thread Lars Gullik Bjønnes
--- src/Buffer.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Buffer.cpp b/src/Buffer.cpp index 8b052ad..ebc5d3a 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -113,7 +113,6 @@ #include #include #include -#include #include using namespace std; -- 1.8.0.rc3.16.g8ead1b

Re: branch warnings

2012-10-21 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 09/10/2012 20:49, Lars Gullik Bjønnes a écrit : >> Jürgen Spitzmüller writes: >> >> | Jean-Marc Lasgouttes wrote: >>>>> ../boost/boost/config/stdlib/libstdcpp3.hpp:42:0: warning: >>>>> "BOOST_DISABLE_

Re: Press about LyX

2012-10-21 Thread Lars Gullik Bjønnes
Jürgen Spitzmüller writes: | Jerry wrote: >> Who among the LyX developers has the power to edit the press page, >> http://www.lyx.org/PressAboutLyX? Daniel has written an article about LyX >> for the HowToAnswer web site and would like to get it linked from the LyX >> press page. Surely this bene

Re: branch warnings

2012-10-10 Thread Lars Gullik Bjønnes
Jürgen Spitzmüller writes: | Lars Gullik Bjønnes wrote: >> Is branch the only place where you do --without-included-boost? > | I don't specify that explicitly. > | I compile trunk | --with-version-suffix=-svn --enable-maintainer-mode > | and branch with | --enable-build-t

Re: branch warnings

2012-10-09 Thread Lars Gullik Bjønnes
Jürgen Spitzmüller writes: | Jean-Marc Lasgouttes wrote: >> > ../boost/boost/config/stdlib/libstdcpp3.hpp:42:0: warning: >> > "BOOST_DISABLE_THREADS" redefined [enabled by default] >> > In file included from BiblioInfo.cpp:13:0: >> > ../config.h:628:0: note: this is the location of the previous d

Re: [patch] fix warning on branch

2012-10-01 Thread Lars Gullik Bjønnes
Scott Kostyshak writes: | On Thu, Sep 27, 2012 at 3:53 PM, Scott Kostyshak wrote: >> On Thu, Sep 27, 2012 at 1:51 PM, Julien Rioux >> wrote: >>> On 27/09/2012 7:17 AM, Scott Kostyshak wrote: - ::write(pipefd, cmd.c_str(), cmd.length()); +if (::write(

Re: [PATCH (?)] add -Werror to autotools and cmake ?

2012-10-01 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Sat, Sep 29, 2012 at 04:53:00AM -0400, Scott Kostyshak wrote: >> I have been thinking about compiler warnings because of the recent >> discussion here: >> http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg175099.html >> >> >From that thread, I have the understandin

Re: [LyX 2.0.x] Fix bug #8349: Cannot compile 2.0.x: unresolved external symbol

2012-09-25 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 24/09/12 19:33, Vincent van Ravesteijn a écrit : >> Op 24-9-2012 16:28, Jean-Marc Lasgouttes schreef: >>> That's amusing. This is a patch from Stephan that I backported, and it >>> looks like Stephan did the backport, which does not help communication. >> >> Just

Re: [patch] fix warning on branch

2012-09-21 Thread Lars Gullik Bjønnes
Scott Kostyshak writes: | On Thu, Sep 20, 2012 at 5:49 PM, Lars Gullik Bjønnes wrote: >> btw. std::string::c_str() should not be used here, >> use std::string::data() instead. > | Lars, can you confirm that I made the right corrections? I changed | c_str() to data() in two plac

Re: [patch] fix warning on branch

2012-09-20 Thread Lars Gullik Bjønnes
Scott Kostyshak writes: | On Thu, Sep 20, 2012 at 4:05 PM, Scott Kostyshak wrote: >>> This patch for branch fixes a warning that was fixed on master here: >>> ea50cd71f9d >>> >>> Is it OK? >>> >>> Scott >> >> This updated patch fixes another warning on branch, which was also >> fixed in master a

Re: [LyX master] Calibrate log file parser

2012-09-19 Thread Lars Gullik Bjønnes
Richard Heck writes: | On 09/17/2012 03:19 AM, Juergen Spitzmueller wrote: >> The branch, master, has been updated. >> >> - Log - >> >> commit e8a01d099a7ecbe5059cbdf0aa0aab16e9862cf6 >> Author: Juergen Spitzmueller >> Date: Mon S

Re: Problem with command-sequence

2012-09-19 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 19/09/2012 12:25, Lars Gullik Bjønnes a écrit : >> Perhaps async LFUNS are not a good idea? > | This was the big discussion about asynchronous export... Right... but why now have LFUNS de async by default (when done as a script thingie), and a separat

Re: Problem with command-sequence

2012-09-19 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 19/09/2012 01:07, Andrew Parsloe a écrit : >> It was only a "wistful" suggestion -- it would allow a tinkerer like me >> to tinker a little more. > | I would try to use "repeat 1000 " in order | to continue tinkering. > > >> The real problem (in the original post

Re: lyx.org is down

2012-09-18 Thread Lars Gullik Bjønnes
| From: Richard Heck | Subject: Re: lyx.org is down | Newsgroups: gmane.editors.lyx.devel | To: Scott Kostyshak | Cc: lyx-devel@lists.lyx.org | Date: Mon, 17 Sep 2012 11:40:38 -0400 (17 hours, 59 minutes, 25 seconds ago) | | On 09/16/2012 02:05 PM, Scott Kostyshak wrote: | > lyx.org is down. |

Re: LyX.org Down?

2012-08-08 Thread Lars Gullik Bjønnes
Richard Heck writes: | On 08/02/2012 09:49 AM, Kornel Benko wrote: >> >> Am Donnerstag, 2. August 2012 um 20:05:42, schrieb John >> McCabe-Dansted >> >> > I've been having trouble accessing the LyX website. At first I >> thought it >> >> > was just the SVN server, but now I can't even get to www

Re: Unable to Push New Tag

2012-07-04 Thread Lars Gullik Bjønnes
On 26 June 2012 20:32, Richard Heck wrote: > On 06/26/2012 12:20 PM, Vincent van Ravesteijn wrote: >> >> Op 26-6-2012 17:48, Richard Heck schreef: >>> >>> >>> Anyone know how to fix this? Or am I doing something wrong? >>> >>> Richard >>> >> >> You need to have permissions to "create a new branch"

[PATCH] comment out function to get rid of a compiler warning

2012-05-18 Thread Lars Gullik Bjønnes
--         Lgb 0001-TextMetrics.cpp-comment-out-addressBreakPoint-functi.patch Description: Binary data

Re: #8118: Unfinished transition to new server and git

2012-04-15 Thread Lars Gullik Bjønnes
On Sun, Apr 15, 2012 at 15:21, LyX Ticket Tracker wrote: > New description: > >  Tracking things which remain unfinished from transation to new server and >  git. > >  1. Trac browsing of source code does not point to master, so we browse >  some old >    state. That means that all links saved els

Re: [lyx/refs/heads/2.0.x] status.20x for last commit.

2012-03-25 Thread Lars Gullik Bjønnes
Enrico Forestieri writes: | On Sun, Mar 25, 2012 at 04:36:40PM +0200, Vincent van Ravesteijn wrote: > >> Op 25-3-2012 15:52, for...@lyx.org schreef: >> >Author: Enrico Forestieri >> >Date: Sun, 25 Mar 2012 15:49:10 +0200 >> >New Commit: ae068255137f111c598e93f9a54a891ffdb4dafc >> >URL: >> >http:

Re: [patch] full support for table rotations

2012-03-21 Thread Lars Gullik Bjønnes
Uwe Stöhr writes: | Am 20.03.2012 09:31, schrieb Vincent van Ravesteijn: > >>> + if (tabular.rotate != 0) >>> + rotateTabularAngleSB->setValue(tabular.rotate); >>> + else >>> + rotateTabularAngleSB->setValue(90); >> >> rotateTabularAngleSB->setValue(tabular.rotate == 0 ? 90 : tabular.rotate); > |

Re: Updates to gitolite progress

2012-03-21 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Jean-Marc Lasgouttes wrote: >> Le 21/03/2012 16:14, Vincent van Ravesteijn a écrit : >>> There is also a 2.0.x branch in your first clone, so you can just >>> cherry-pick the commit to master directly onto this 2.0.x branch, and >>> push from there. >> >> But If I want to co

Re: Updates to gitolite progress

2012-03-21 Thread Lars Gullik Bjønnes
Vincent van Ravesteijn writes: >>> There has to be a simple way to commit a patch to branch (please >>> tell me there is!). >> > | I forgot to mention: Ideally, if we do it the git-way completely, you | would only have to commit a patch to the 2.0.x branch. Later, the | 2.0.x will automatically b

Re: [PATCH] Setup .gitignore for generated files

2012-03-21 Thread Lars Gullik Bjønnes
Pavel Sanda writes: | Lars Gullik Bj?nnes wrote: >> >> Setting up .gitignore or .git/info/excludes is something that should >> be done. Not doing it makes it a lot harder to see actual new files >> that should be added. >> >> Signed-off-by: Lars Gullik Bj?¸nnes >> --- >> .gitignore

[PATCH] Setup .gitignore for generated files

2012-03-21 Thread Lars Gullik Bjønnes
Setting up .gitignore or .git/info/excludes is something that should be done. Not doing it makes it a lot harder to see actual new files that should be added. Signed-off-by: Lars Gullik Bjønnes --- .gitignore| 13 + boost/.gitignore |1 + conf

  1   2   3   4   5   6   7   8   9   10   >