Re: Pandora's box

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 10:31, Abdelrazak Younes a écrit : Hi Guillaume, Just my 2 cents about those recent commits: 1) Switching to C++11 thread is a good thing 2) All these #if (gcc 4.6) are uglyfying the code considerably, you should enter C++11 with 2 steps or just leave it. Thanks, Abdel Hi

Re: Pandora's box

2016-08-06 Thread Abdelrazak Younes
, By touching upon the problem of static variables and threading in LyX (see my patch at <http://mid.gmane.org/nltsru$pag$1...@ger.gmane.org>), I have the impression that I opened Pandora's box. I just committed a series of patches that fixes "FIXME thread" in cases where c++11 gives

Re: Pandora's box

2016-08-01 Thread Richard Heck
On 08/01/2016 06:50 PM, Guillaume Munch wrote: > Le 31/07/2016 à 19:52, Richard Heck a écrit : >>> +++ b/src/frontends/qt4/GuiCitation.cpp >> >> Is there some way we could store these per BufferView or something? I'd >> kind of like to save the last searched string for each document, >> rather

Re: Pandora's box

2016-08-01 Thread Richard Heck
On 08/01/2016 04:01 PM, Guillaume Munch wrote: > Le 31/07/2016 à 19:52, Richard Heck a écrit : >> On 07/31/2016 01:38 PM, Guillaume Munch wrote: >> >>> For other "FIXME thread" issues, either the solution is more >>> complex, or >>> using statics is inappropriate altogether (I think). Is there a

Re: Pandora's box

2016-08-01 Thread Guillaume Munch
Le 31/07/2016 à 19:52, Richard Heck a écrit : +++ b/src/frontends/qt4/GuiCitation.cpp Is there some way we could store these per BufferView or something? I'd kind of like to save the last searched string for each document, rather than globally. Yes, I think there must be a better solution.

Re: Pandora's box

2016-08-01 Thread Guillaume Munch
Le 31/07/2016 à 19:52, Richard Heck a écrit : On 07/31/2016 01:38 PM, Guillaume Munch wrote: For other "FIXME thread" issues, either the solution is more complex, or using statics is inappropriate altogether (I think). Is there a plan to get rid of these? It looks to me as if most of the

Re: Pandora's box

2016-07-31 Thread Richard Heck
Patch comments. > From 7fd53bc44bd278fd1f30400c030e350f2c0a6aa3 Mon Sep 17 00:00:00 2001 > From: Guillaume Munch > Date: Sun, 31 Jul 2016 00:42:51 +0100 > Subject: [PATCH] Replace static with thread_local when used for caching > > thread_local is a per-thread static variable, so

Re: Pandora's box

2016-07-31 Thread Richard Heck
On 07/31/2016 01:38 PM, Guillaume Munch wrote: > Hi list, > > By touching upon the problem of static variables and threading in LyX > (see my patch at <http://mid.gmane.org/nltsru$pag$1...@ger.gmane.org>), I > have the impression that I opened Pandora's box. I think the URL

Pandora's box

2016-07-31 Thread Guillaume Munch
Hi list, By touching upon the problem of static variables and threading in LyX (see my patch at <http://mid.gmane.org/nltsru$pag$1...@ger.gmane.org>), I have the impression that I opened Pandora's box. I just committed a series of patches that fixes "FIXME thread" in cases w