Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Stephan Witt]

Am 15.02.2020 um 09:28 schrieb Kornel Benko :
> 
> Am Sat, 15 Feb 2020 09:17:53 +0100
> schrieb Kornel Benko :
> 
>> Am Sat, 15 Feb 2020 09:02:45 +0100
>> schrieb Stephan Witt :
>> 
>>> Am 15.02.2020 um 08:32 schrieb Kornel Benko :  
 
 Am Fri, 14 Feb 2020 17:37:28 +0100
 schrieb Stephan Witt :
 
> Changes not staged for commit:
> (use "git add ..." to update what will be committed)
> (use "git checkout -- ..." to discard changes in working directory)
> 
>   modified:   development/cmake/modules/FindHUNSPELL.cmake
> 
> no changes added to commit (use "git add" and/or "git commit -a“)
> ==
> 
> No luck. I’d guess on Windows with case insensitive FS it’s the same.
> 
 
 Should it be not enough to say here:
   git checkout development/cmake/modules/FindHUNSPELL.cmake
   git checkout development/cmake/modules/FindENCHANT.cmake
 ?
>>> 
>>> No. I‘ve tried this already.
>>> 
>>> IMO you can’t have two files with different cases in name only. Didn’t you 
>>> add a
>>> second one instead of rename it? Actually there’s a problem because it’s 
>>> duplicated
>>> and changed.  
>> 
>> No, I did 'git mv'.
>> 
>> Possibly it is better to
>>  git rm; git commit
>>  git add; git commit;
>> 
>>> I can rename it on my end. But I don’t know what happens on your side when 
>>> I push the
>>> change.   
>> 
>> 
>>> I‘ll try to post the diffs later.
>>> 
>>> Another option is: you remove the misnamed duplicates from git if they’re 
>>> present on
>>> your side. 
>>> 
>>> Stephan
>>> 
>> 
>>  Kornel
>> 
> 
> 
> I see now, that the cherry-pick went probably wrong at 2.3.x, because I have 
> now two
> pairs. (With and without the case diff)

Yes, that’s the problem.

> I could remove the wrong one, but what would happen on your side?

And now it’s ok again. Although I had to drop my experimental clone.
But fortunately with a fresh one I can switch to 2,3,x branch again.

Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Kornel Benko]

Am Sat, 15 Feb 2020 09:17:53 +0100
schrieb Kornel Benko :

> Am Sat, 15 Feb 2020 09:02:45 +0100
> schrieb Stephan Witt :
> 
> > Am 15.02.2020 um 08:32 schrieb Kornel Benko :  
> > > 
> > > Am Fri, 14 Feb 2020 17:37:28 +0100
> > > schrieb Stephan Witt :
> > > 
> > >> Changes not staged for commit:
> > >>  (use "git add ..." to update what will be committed)
> > >>  (use "git checkout -- ..." to discard changes in working 
> > >> directory)
> > >> 
> > >>modified:   development/cmake/modules/FindHUNSPELL.cmake
> > >> 
> > >> no changes added to commit (use "git add" and/or "git commit -a“)
> > >> ==
> > >> 
> > >> No luck. I’d guess on Windows with case insensitive FS it’s the same.
> > >> 
> > > 
> > > Should it be not enough to say here:
> > >git checkout development/cmake/modules/FindHUNSPELL.cmake
> > >git checkout development/cmake/modules/FindENCHANT.cmake
> > > ?
> > 
> > No. I‘ve tried this already.
> > 
> > IMO you can’t have two files with different cases in name only. Didn’t you 
> > add a
> > second one instead of rename it? Actually there’s a problem because it’s 
> > duplicated
> > and changed.  
> 
> No, I did 'git mv'.
> 
> Possibly it is better to
>   git rm; git commit
>   git add; git commit;
> 
> > I can rename it on my end. But I don’t know what happens on your side when 
> > I push the
> > change.   
> 
> 
> > I‘ll try to post the diffs later.
> > 
> > Another option is: you remove the misnamed duplicates from git if they’re 
> > present on
> > your side. 
> > 
> > Stephan
> >   
> 
>   Kornel
> 


I see now, that the cherry-pick went probably wrong at 2.3.x, because I have 
now two
pairs. (With and without the case diff)

I could remove the wrong one, but what would happen on your side?

Kornel


pgpmuLjQi47aG.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Kornel Benko]

Am Sat, 15 Feb 2020 09:02:45 +0100
schrieb Stephan Witt :

> Am 15.02.2020 um 08:32 schrieb Kornel Benko :
> > 
> > Am Fri, 14 Feb 2020 17:37:28 +0100
> > schrieb Stephan Witt :
> >   
> >> Changes not staged for commit:
> >>  (use "git add ..." to update what will be committed)
> >>  (use "git checkout -- ..." to discard changes in working directory)
> >> 
> >>modified:   development/cmake/modules/FindHUNSPELL.cmake
> >> 
> >> no changes added to commit (use "git add" and/or "git commit -a“)
> >> ==
> >> 
> >> No luck. I’d guess on Windows with case insensitive FS it’s the same.
> >>   
> > 
> > Should it be not enough to say here:
> >git checkout development/cmake/modules/FindHUNSPELL.cmake
> >git checkout development/cmake/modules/FindENCHANT.cmake
> > ?  
> 
> No. I‘ve tried this already.
> 
> IMO you can’t have two files with different cases in name only. Didn’t you 
> add a second
> one instead of rename it? Actually there’s a problem because it’s duplicated 
> and
> changed.

No, I did 'git mv'.

Possibly it is better to
git rm; git commit
git add; git commit;

> I can rename it on my end. But I don’t know what happens on your side when I 
> push the
> change. 


> I‘ll try to post the diffs later.
> 
> Another option is: you remove the misnamed duplicates from git if they’re 
> present on
> your side. 
> 
> Stephan
> 

Kornel



pgpp2r3Mv5vuv.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Stephan Witt]

Am 15.02.2020 um 08:32 schrieb Kornel Benko :
> 
> Am Fri, 14 Feb 2020 17:37:28 +0100
> schrieb Stephan Witt :
> 
>> Changes not staged for commit:
>>  (use "git add ..." to update what will be committed)
>>  (use "git checkout -- ..." to discard changes in working directory)
>> 
>>modified:   development/cmake/modules/FindHUNSPELL.cmake
>> 
>> no changes added to commit (use "git add" and/or "git commit -a“)
>> ==
>> 
>> No luck. I’d guess on Windows with case insensitive FS it’s the same.
>> 
> 
> Should it be not enough to say here:
>git checkout development/cmake/modules/FindHUNSPELL.cmake
>git checkout development/cmake/modules/FindENCHANT.cmake
> ?

No. I‘ve tried this already.

IMO you can’t have two files with different cases in name only. Didn’t you add 
a second one instead of rename it? Actually there’s a problem because it’s 
duplicated and changed.

I can rename it on my end. But I don’t know what happens on your side when I 
push the change. 

I‘ll try to post the diffs later.

Another option is: you remove the misnamed duplicates from git if they’re 
present on your side. 

Stephan

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Kornel Benko]

Am Fri, 14 Feb 2020 17:37:28 +0100
schrieb Stephan Witt :

> Changes not staged for commit:
>   (use "git add ..." to update what will be committed)
>   (use "git checkout -- ..." to discard changes in working directory)
> 
>   modified:   development/cmake/modules/FindHUNSPELL.cmake
> 
> no changes added to commit (use "git add" and/or "git commit -a“)
> ==
> 
> No luck. I’d guess on Windows with case insensitive FS it’s the same.
> 

Should it be not enough to say here:
git checkout development/cmake/modules/FindHUNSPELL.cmake
git checkout development/cmake/modules/FindENCHANT.cmake
?

Kornel


pgp2m4rBT00Zd.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Stephan Witt]

Am 14.02.2020 um 17:22 schrieb Stephan Witt :
> 
> Am 14.02.2020 um 16:44 schrieb Kornel Benko :
>> 
>> Am Fri, 14 Feb 2020 15:57:45 +0100
>> schrieb Stephan Witt :
>> 
>>> Am 08.02.2020 um 21:55 schrieb Kornel Benko :
>>>> 
>>>> commit a47dec6b4a91ca59a8d9d4431ecedd77f8ffc7e7
>>>> Author: Kornel Benko 
>>>> Date:   Mon Jan 27 10:44:14 2020 +0100
>>>> 
>>>>  Cmake build: Remove cmake warnings about mismatched values of
>>>> FindPackageHandleStandardArgs()
>>>> 
>>>>  (cherry picked from commit 9fdc00fe2a2b2db752ca244eac3d14e708d5caba)
>>>> ---
>>>> CMakeLists.txt   |2 +-
>>>> development/cmake/modules/FindENCHANT.cmake  |   22 ++
>>>> development/cmake/modules/FindHUNSPELL.cmake |   21 +
>>>> 3 files changed, 44 insertions(+), 1 deletions(-)  
>>> 
>>> Hi Kornel,
>>> 
>>> I don’t know how this goes on Windows. But on Mac this breaks for checkouts
>>> in file systems with case insensitive file names. At least I have problems
>>> to switch between master and 2.3.x branch now.
>>> 
>>> I don’t know how to proceed. Do you have an idea?
>> 
>> I use a 'git clone'-dir for 2.3.x

That’s the protocol of a clean clone process:

==
$ git clone g...@git.lyx.org:lyx lyx-2.3.x
Cloning into 'lyx-2.3.x'...
remote: Counting objects: 459413, done.
remote: Compressing objects: 100% (73785/73785), done.
remote: Total 459413 (delta 386809), reused 456042 (delta 383995)
Receiving objects: 100% (459413/459413), 428.32 MiB | 3.66 MiB/s, done.
Resolving deltas: 100% (386809/386809), done.
Checking out files: 100% (7263/7263), done.
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'development/cmake/modules/FindENCHANT.cmake'
  'development/cmake/modules/FindEnchant.cmake'
  'development/cmake/modules/FindHUNSPELL.cmake'
  'development/cmake/modules/FindHunspell.cmake'
$ (cd lyx-2.3.x;git checkout 2.3.x)
Checking out files: 100% (3325/3325), done.
Branch '2.3.x' set up to track remote branch '2.3.x' from 'origin'.
Switched to a new branch '2.3.x'
$ (cd lyx-2.3.x;git status)
On branch 2.3.x
Your branch is up to date with 'origin/2.3.x'.

Changes not staged for commit:
  (use "git add ..." to update what will be committed)
  (use "git checkout -- ..." to discard changes in working directory)

modified:   development/cmake/modules/FindHUNSPELL.cmake

no changes added to commit (use "git add" and/or "git commit -a“)
==

No luck. I’d guess on Windows with case insensitive FS it’s the same.

Stephan

> 
> I have a separate checkout too. But there it is the same.
> 
>> Here I use normally
>>  git fetch
>>  git stash clear
>>  git stash save --include-untracked
>>  git pull --rebase
>>  git stash pop
> 
> Normally I don’t like to loose my stash.
> 
>> 
>>> error: cannot pull with rebase: You have unstaged changes.
>>> error: please commit or stash them.
>>> 
>>> $ (cd development/cmake/modules ;ls -l )
>>> total 288
>> 
>> Does this help?
> 
> No. Unfortunately not.
> 
> Stephan
> 
> -- 
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Stephan Witt]

Am 14.02.2020 um 16:44 schrieb Kornel Benko :
> 
> Am Fri, 14 Feb 2020 15:57:45 +0100
> schrieb Stephan Witt :
> 
>> Am 08.02.2020 um 21:55 schrieb Kornel Benko :
>>> 
>>> commit a47dec6b4a91ca59a8d9d4431ecedd77f8ffc7e7
>>> Author: Kornel Benko 
>>> Date:   Mon Jan 27 10:44:14 2020 +0100
>>> 
>>>   Cmake build: Remove cmake warnings about mismatched values of
>>> FindPackageHandleStandardArgs()
>>> 
>>>   (cherry picked from commit 9fdc00fe2a2b2db752ca244eac3d14e708d5caba)
>>> ---
>>> CMakeLists.txt   |2 +-
>>> development/cmake/modules/FindENCHANT.cmake  |   22 ++
>>> development/cmake/modules/FindHUNSPELL.cmake |   21 +
>>> 3 files changed, 44 insertions(+), 1 deletions(-)  
>> 
>> Hi Kornel,
>> 
>> I don’t know how this goes on Windows. But on Mac this breaks for checkouts
>> in file systems with case insensitive file names. At least I have problems
>> to switch between master and 2.3.x branch now.
>> 
>> I don’t know how to proceed. Do you have an idea?
> 
> I use a 'git clone'-dir for 2.3.x

I have a separate checkout too. But there it is the same.

> Here I use normally
>   git fetch
>   git stash clear
>   git stash save --include-untracked
>   git pull --rebase
>   git stash pop

Normally I don’t like to loose my stash.

> 
>> error: cannot pull with rebase: You have unstaged changes.
>> error: please commit or stash them.
>> 
>> $ (cd development/cmake/modules ;ls -l )
>> total 288
> 
> Does this help?

No. Unfortunately not.

Stephan

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Kornel Benko]

Am Fri, 14 Feb 2020 15:57:45 +0100
schrieb Stephan Witt :

> Am 08.02.2020 um 21:55 schrieb Kornel Benko :
> > 
> > commit a47dec6b4a91ca59a8d9d4431ecedd77f8ffc7e7
> > Author: Kornel Benko 
> > Date:   Mon Jan 27 10:44:14 2020 +0100
> > 
> >Cmake build: Remove cmake warnings about mismatched values of
> > FindPackageHandleStandardArgs()
> > 
> >(cherry picked from commit 9fdc00fe2a2b2db752ca244eac3d14e708d5caba)
> > ---
> > CMakeLists.txt   |2 +-
> > development/cmake/modules/FindENCHANT.cmake  |   22 ++
> > development/cmake/modules/FindHUNSPELL.cmake |   21 +
> > 3 files changed, 44 insertions(+), 1 deletions(-)  
> 
> Hi Kornel,
> 
> I don’t know how this goes on Windows. But on Mac this breaks for checkouts
> in file systems with case insensitive file names. At least I have problems
> to switch between master and 2.3.x branch now.
> 
> I don’t know how to proceed. Do you have an idea?

I use a 'git clone'-dir for 2.3.x

> Stephan
> 
> The protocol of my terminal session is as follows:
> 
> $ git checkout -f master
> Checking out files: 100% (3326/3326), done.
> Switched to branch 'master'
> Your branch is up to date with 'origin/master‘.
> $ git status
> On branch master
> Your branch is up to date with 'origin/master'.
> 
> nothing to commit, working tree clean
> 
> $ (cd development/cmake/modules ;ls -l)
> total 288
> -rw-r--r--  1 stephan  staff   3908 27 Dez  2018 FindASPELL.cmake
> -rw-r--r--  1 stephan  staff   1071 27 Dez  2018 FindAiksaurusLIB.cmake
> -rw-r--r--  1 stephan  staff   4233 27 Dez  2018 FindCXX11Compiler.cmake
> -rw-r--r--  1 stephan  staff682 10 Feb 11:30 FindENCHANT.cmake
> -rw-r--r--  1 stephan  staff   1322 27 Dez  2018 FindGNUWIN32.cmake
> -rw-r--r--  1 stephan  staff741 14 Feb 15:52 FindHunspell.cmake
> -rw-r--r--  1 stephan  staff   3891 14 Feb 15:52 FindICONV.cmake
> -rwxr-xr-x  1 stephan  staff   3239 27 Dez  2018 FindLyXGettext.cmake
> -rw-r--r--  1 stephan  staff   2516 27 Dez  2018 FindMagic.cmake
> -rw-r--r--  1 stephan  staff777 27 Dez  2018 FindMyThesLIB.cmake
> -rw-r--r--  1 stephan  staff   4775 27 Dez  2018 FindOpenSSL.cmake
> -rw-r--r--  1 stephan  staff  38254 27 Dez  2018 FindQt4.cmake
> -rw-r--r--  1 stephan  staff   1418 27 Dez  2018 FindZLIB.cmake
> -rw-r--r--  1 stephan  staff   2801 27 Dez  2018 LyXDestinations.cmake
> -rw-r--r--  1 stephan  staff  14119 14 Feb 15:52 LyXMacros.cmake
> -rw-r--r--  1 stephan  staff   3830 22 Aug 16:32 LyXPaths.cmake
> -rw-r--r--  1 stephan  staff   2067 27 Dez  2018 LyXuic.cmake
> -rw-r--r--  1 stephan  staff651 27 Dez  2018 MacroBoolTo01.cmake
> -rw-r--r--  1 stephan  staff  10691 27 Dez  2018 PCHSupport_26.cmake
> -rw-r--r--  1 stephan  staff   2144 27 Dez  2018 ProjectSourceGroup.cmake
> 
> 
> $ git checkout -f 2.3.x
> Checking out files: 100% (3325/3325), done.
> Switched to branch '2.3.x'
> Your branch is behind 'origin/2.3.x' by 3 commits, and can be fast-forwarded.
>   (use "git pull" to update your local branch)
> $ git status
> On branch 2.3.x
> Your branch is behind 'origin/2.3.x' by 3 commits, and can be fast-forwarded.
>   (use "git pull" to update your local branch)
> 
> Changes not staged for commit:
>   (use "git add ..." to update what will be committed)
>   (use "git checkout -- ..." to discard changes in working directory)
> 
>   modified:   development/cmake/modules/FindHUNSPELL.cmake
> 
> no changes added to commit (use "git add" and/or "git commit -a“)
> $ git pull --rebase
> Unstaged changes after reset:
> M development/cmake/modules/FindHunspell.cmake

Here I use normally
git fetch
git stash clear
git stash save --include-untracked
git pull --rebase
git stash pop

> error: cannot pull with rebase: You have unstaged changes.
> error: please commit or stash them.
> 
> $ (cd development/cmake/modules ;ls -l )
> total 288

Does this help?

Kornel



pgpmkbt1X_QUY.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/2.3.x] Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()

[Stephan Witt]

Am 08.02.2020 um 21:55 schrieb Kornel Benko :
> 
> commit a47dec6b4a91ca59a8d9d4431ecedd77f8ffc7e7
> Author: Kornel Benko 
> Date:   Mon Jan 27 10:44:14 2020 +0100
> 
>Cmake build: Remove cmake warnings about mismatched values of 
> FindPackageHandleStandardArgs()
> 
>(cherry picked from commit 9fdc00fe2a2b2db752ca244eac3d14e708d5caba)
> ---
> CMakeLists.txt   |2 +-
> development/cmake/modules/FindENCHANT.cmake  |   22 ++
> development/cmake/modules/FindHUNSPELL.cmake |   21 +
> 3 files changed, 44 insertions(+), 1 deletions(-)

Hi Kornel,

I don’t know how this goes on Windows. But on Mac this breaks for checkouts
in file systems with case insensitive file names. At least I have problems
to switch between master and 2.3.x branch now.

I don’t know how to proceed. Do you have an idea?

Stephan

The protocol of my terminal session is as follows:

$ git checkout -f master
Checking out files: 100% (3326/3326), done.
Switched to branch 'master'
Your branch is up to date with 'origin/master‘.
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

$ (cd development/cmake/modules ;ls -l)
total 288
-rw-r--r--  1 stephan  staff   3908 27 Dez  2018 FindASPELL.cmake
-rw-r--r--  1 stephan  staff   1071 27 Dez  2018 FindAiksaurusLIB.cmake
-rw-r--r--  1 stephan  staff   4233 27 Dez  2018 FindCXX11Compiler.cmake
-rw-r--r--  1 stephan  staff682 10 Feb 11:30 FindENCHANT.cmake
-rw-r--r--  1 stephan  staff   1322 27 Dez  2018 FindGNUWIN32.cmake
-rw-r--r--  1 stephan  staff741 14 Feb 15:52 FindHunspell.cmake
-rw-r--r--  1 stephan  staff   3891 14 Feb 15:52 FindICONV.cmake
-rwxr-xr-x  1 stephan  staff   3239 27 Dez  2018 FindLyXGettext.cmake
-rw-r--r--  1 stephan  staff   2516 27 Dez  2018 FindMagic.cmake
-rw-r--r--  1 stephan  staff777 27 Dez  2018 FindMyThesLIB.cmake
-rw-r--r--  1 stephan  staff   4775 27 Dez  2018 FindOpenSSL.cmake
-rw-r--r--  1 stephan  staff  38254 27 Dez  2018 FindQt4.cmake
-rw-r--r--  1 stephan  staff   1418 27 Dez  2018 FindZLIB.cmake
-rw-r--r--  1 stephan  staff   2801 27 Dez  2018 LyXDestinations.cmake
-rw-r--r--  1 stephan  staff  14119 14 Feb 15:52 LyXMacros.cmake
-rw-r--r--  1 stephan  staff   3830 22 Aug 16:32 LyXPaths.cmake
-rw-r--r--  1 stephan  staff   2067 27 Dez  2018 LyXuic.cmake
-rw-r--r--  1 stephan  staff651 27 Dez  2018 MacroBoolTo01.cmake
-rw-r--r--  1 stephan  staff  10691 27 Dez  2018 PCHSupport_26.cmake
-rw-r--r--  1 stephan  staff   2144 27 Dez  2018 ProjectSourceGroup.cmake


$ git checkout -f 2.3.x
Checking out files: 100% (3325/3325), done.
Switched to branch '2.3.x'
Your branch is behind 'origin/2.3.x' by 3 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
$ git status
On branch 2.3.x
Your branch is behind 'origin/2.3.x' by 3 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add ..." to update what will be committed)
  (use "git checkout -- ..." to discard changes in working directory)

modified:   development/cmake/modules/FindHUNSPELL.cmake

no changes added to commit (use "git add" and/or "git commit -a“)
$ git pull --rebase
Unstaged changes after reset:
M   development/cmake/modules/FindHunspell.cmake
error: cannot pull with rebase: You have unstaged changes.
error: please commit or stash them.

$ (cd development/cmake/modules ;ls -l )
total 288
-rw-r--r--  1 stephan  staff   3908 27 Dez  2018 FindASPELL.cmake
-rw-r--r--  1 stephan  staff   1071 27 Dez  2018 FindAiksaurusLIB.cmake
-rw-r--r--  1 stephan  staff   4233 27 Dez  2018 FindCXX11Compiler.cmake
-rw-r--r--  1 stephan  staff682 10 Feb 11:30 FindENCHANT.cmake
-rw-r--r--  1 stephan  staff   1322 27 Dez  2018 FindGNUWIN32.cmake
-rw-r--r--  1 stephan  staff551 14 Feb 15:54 FindHunspell.cmake
-rw-r--r--  1 stephan  staff   4036 14 Feb 15:54 FindICONV.cmake
-rwxr-xr-x  1 stephan  staff   3239 27 Dez  2018 FindLyXGettext.cmake
-rw-r--r--  1 stephan  staff   2516 27 Dez  2018 FindMagic.cmake
-rw-r--r--  1 stephan  staff777 27 Dez  2018 FindMyThesLIB.cmake
-rw-r--r--  1 stephan  staff   4775 27 Dez  2018 FindOpenSSL.cmake
-rw-r--r--  1 stephan  staff  38254 27 Dez  2018 FindQt4.cmake
-rw-r--r--  1 stephan  staff   1418 27 Dez  2018 FindZLIB.cmake
-rw-r--r--  1 stephan  staff   2801 27 Dez  2018 LyXDestinations.cmake
-rw-r--r--  1 stephan  staff  14115 14 Feb 15:54 LyXMacros.cmake
-rw-r--r--  1 stephan  staff   3830 22 Aug 16:32 LyXPaths.cmake
-rw-r--r--  1 stephan  staff   2067 27 Dez  2018 LyXuic.cmake
-rw-r--r--  1 stephan  staff651 27 Dez  2018 MacroBoolTo01.cmake
-rw-r--r--  1 stephan  staff  10691 27 Dez  2018 PCHSupport_26.cmake
-rw-r--r--  1 stephan  staff   2144 27 Dez  2018 ProjectSourceGroup.cmake


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: cmake warnings

[Kornel Benko]

Am Montag, 12. Mai 2014 um 07:35:36, schrieb Stephan Witt st.w...@gmx.net
  I'd like to terminate if there is no spell checker and it's not said to 
  ignore this.
  The LYX_ options aren't three state. So this is possible only with a check 
  for another
  option, right?
  
  Yes.
  
  Then I'd prefer to give the hint at a more prominent location.
  
  Alternative patch is attached.
  
  Stephan
  
  Yes, better place for the message. But the option is missing.
 
 Yes, I didn't insist to abort. What's your opinion?
 

I don't insist either. The behaviour until now was to do nothing.
Therefore the new option should start with default not to abort (if any option).

Proposing the name as LYX_REQUIRE_SPELLCHECK.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Kornel Benko]

Am Montag, 12. Mai 2014 um 07:35:36, schrieb Stephan Witt 
> >> I'd like to terminate if there is no spell checker and it's not said to 
> >> ignore this.
> >> The LYX_ options aren't three state. So this is possible only with a check 
> >> for another
> >> option, right?
> > 
> > Yes.
> > 
> >> Then I'd prefer to give the hint at a more prominent location.
> >> 
> >> Alternative patch is attached.
> >> 
> >> Stephan
> > 
> > Yes, better place for the message. But the option is missing.
> 
> Yes, I didn't insist to abort. What's your opinion?
> 

I don't insist either. The behaviour until now was to do nothing.
Therefore the new option should start with default not to abort (if any option).

Proposing the name as LYX_REQUIRE_SPELLCHECK.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Abdelrazak Younes]

On Sun, May 11, 2014 at 12:22 AM, Kornel Benko kor...@lyx.org wrote:

 Am Samstag, 10. Mai 2014 um 22:26:24, schrieb Abdelrazak Younes 
 you...@lyx.org
  On Sat, May 10, 2014 at 9:50 PM, Kornel Benko kor...@lyx.org wrote:
 
   Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes 
   you...@lyx.org
Hi guys,
   
Just checked out feature/str-metrics and I got  some warning when
 running
cmake:
   
CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
  Policy CMP0028 is not set: Double colon in target name means ALIAS
 or
  IMPORTED target.  Run cmake --help-policy CMP0028 for policy
 details.
  Use the cmake_policy command to set the policy and suppress this
   warning.
   
  Target lyx2.2 links to target Qt5::Concurrent but the target
 was
   not
  found.  Perhaps a find_package() call is missing for an IMPORTED
   target,
or
  an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.
  
   I don't see it. But I don't have Qt5 anyway.
  
 
  I use Qt4.8 but Qt5 is also installed I think but only the runtime not
 the
  devel package.

 Maybe this is the cause of the warning
 'Target lyx2.2 links to target Qt5::Concurrent',
 Could you install the Qt5 devel?


I can't at this point for other project reasons, sorry.



 Please notice that I am guessing only and cannot verify.

   Could you display the command arguments of add_executable on line 106?
  
   message(STATUS  ${_lyx}
   ${WIN32_CONSOLE}
   ${LYX_BUILD_BUNDLE}
   ${lyx_sources}
   ${lyx_headers}
   ${vld_files}
   ${FILE_RC}
   ${lyx_info_files}
   ${lyx_cmake_files}
   ${OSX_BUNDLE_FILES}
   )
  
   To see, where is the colon inserted?
  
 
  Here it is:
 

 Nothing special in it. Especially no colon ':'.
 Are you using new cmake ( = 3.0)?


Yes, I forgot I was using a development version, sorry about that:
  3.0.20140324-g4f419


   
By the way, I just run cmake .. without any argument, is this good
   enough
those days?
  
   No. But since some values will be used from cache, so it may fit.
  
 
  This was a fresh checkout, so no cache. My question was about make sure I
  don't miss important cmake definitions.

 You do miss some.
 LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.

 (If you don't use CPACK then at least use LYX_INSTALL option)


 Hunspell is installed on my system, why don't we pick that automatically?

Thanks,
Abdel.

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 09:57:17, schrieb Abdelrazak Younes you...@lyx.org
 On Sun, May 11, 2014 at 12:22 AM, Kornel Benko kor...@lyx.org wrote:
 
  Am Samstag, 10. Mai 2014 um 22:26:24, schrieb Abdelrazak Younes 
  you...@lyx.org
...

  
   I use Qt4.8 but Qt5 is also installed I think but only the runtime not
  the
   devel package.
 
  Maybe this is the cause of the warning
  'Target lyx2.2 links to target Qt5::Concurrent',
  Could you install the Qt5 devel?
 
 
 I can't at this point for other project reasons, sorry.
 

You could manually edit also the CMakeCache.txt.
Replace the used Qt5 libs with the Qt4 libs. They should be the same as
in CMakeCache.txtx for lyx2.1.

...
 
 Yes, I forgot I was using a development version, sorry about that:
   3.0.20140324-g4f419
 

That's OK. Good to know someone is using it.

...
  You do miss some.
  LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.
 
  (If you don't use CPACK then at least use LYX_INSTALL option)
 
 
  Hunspell is installed on my system, why don't we pick that automatically?

Good question. But which one to select, if also the other are installed?
There may be a reason why someone does not want a specific lib.

 Thanks,
 Abdel.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Abdelrazak Younes]

On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:

   You do miss some.
   LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.
  
   (If you don't use CPACK then at least use LYX_INSTALL option)
  
 
   Hunspell is installed on my system, why don't we pick that
 automatically?

 Good question. But which one to select, if also the other are installed?
 There may be a reason why someone does not want a specific lib.


I would say by order of preference check hunspell, then enchant, then
aspell.

Abdel.

Re: cmake warnings

[Scott Kostyshak]

On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org wrote:
 On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:

   Hunspell is installed on my system, why don't we pick that
  automatically?

 Good question. But which one to select, if also the other are installed?
 There may be a reason why someone does not want a specific lib.


 I would say by order of preference check hunspell, then enchant, then
 aspell.

Regardless of the order (e.g. even if Enchant is prioritized), it
would be nice to fill in the path in Preferences  Paths so that if
the user wants to use Hunspell all he has to do is change the
spellchecker.

Scott

Re: cmake warnings

[Abdelrazak Younes]

On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak skost...@lyx.org wrote:

 On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org wrote:
  On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:
 
Hunspell is installed on my system, why don't we pick that
   automatically?
 
  Good question. But which one to select, if also the other are installed?
  There may be a reason why someone does not want a specific lib.
 
 
  I would say by order of preference check hunspell, then enchant, then
  aspell.

 Regardless of the order (e.g. even if Enchant is prioritized), it
 would be nice to fill in the path in Preferences  Paths so that if
 the user wants to use Hunspell all he has to do is change the
 spellchecker.


Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
the development packages are found we should use them.

Abdel

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes you...@lyx.org
 On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak skost...@lyx.org wrote:
 
  On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org wrote:
   On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:
  
 Hunspell is installed on my system, why don't we pick that
automatically?
  
   Good question. But which one to select, if also the other are installed?
   There may be a reason why someone does not want a specific lib.
  
  
   I would say by order of preference check hunspell, then enchant, then
   aspell.
 
  Regardless of the order (e.g. even if Enchant is prioritized), it
  would be nice to fill in the path in Preferences  Paths so that if
  the user wants to use Hunspell all he has to do is change the
  spellchecker.
 
 
 Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
 the development packages are found we should use them.

If that is the consent, OK. But what to do, if no spellchecker is found?
* Abort
* Drop a message only
* Silently ignore

 Abdel

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Stephan Witt]

Am 11.05.2014 um 12:38 schrieb Kornel Benko kor...@lyx.org:

 Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
 you...@lyx.org
 On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak skost...@lyx.org wrote:
 
 On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org wrote:
 On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:
 
 Hunspell is installed on my system, why don't we pick that
 automatically?
 
 Good question. But which one to select, if also the other are installed?
 There may be a reason why someone does not want a specific lib.
 
 
 I would say by order of preference check hunspell, then enchant, then
 aspell.
 
 Regardless of the order (e.g. even if Enchant is prioritized), it
 would be nice to fill in the path in Preferences  Paths so that if
 the user wants to use Hunspell all he has to do is change the
 spellchecker.
 
 
 Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
 the development packages are found we should use them.
 
 If that is the consent, OK. But what to do, if no spellchecker is found?
 * Abort
 * Drop a message only
 * Silently ignore

Is it possible to abort if no command line switch is given to disable them?

Many users are asking for spell checker support but don't install any developer
package for spell checking and are baffled later about getting no spell checker.
It would be good to abort then with a helpful error message, IMHO.

Stephan

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt st.w...@gmx.net
 Am 11.05.2014 um 12:38 schrieb Kornel Benko kor...@lyx.org:
 
  Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
  you...@lyx.org
  On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak skost...@lyx.org wrote:
  
  On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org wrote:
  On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:
  
  Hunspell is installed on my system, why don't we pick that
  automatically?
  
  Good question. But which one to select, if also the other are installed?
  There may be a reason why someone does not want a specific lib.
  
  
  I would say by order of preference check hunspell, then enchant, then
  aspell.
  
  Regardless of the order (e.g. even if Enchant is prioritized), it
  would be nice to fill in the path in Preferences  Paths so that if
  the user wants to use Hunspell all he has to do is change the
  spellchecker.
  
  
  Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
  the development packages are found we should use them.
  
  If that is the consent, OK. But what to do, if no spellchecker is found?
  * Abort
  * Drop a message only
  * Silently ignore
 
 Is it possible to abort if no command line switch is given to disable them?

Sure. Like this
message(FATAL_ERROR You are leaving the moon atmosphere)

 Many users are asking for spell checker support but don't install any 
 developer
 package for spell checking and are baffled later about getting no spell 
 checker.
 It would be good to abort then with a helpful error message, IMHO.
 
 Stephan

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko kor...@lyx.org
 Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt st.w...@gmx.net
  Am 11.05.2014 um 12:38 schrieb Kornel Benko kor...@lyx.org:
  
   Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
   you...@lyx.org
   On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak skost...@lyx.org 
   wrote:
   
   On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org 
   wrote:
   On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:
   
   Hunspell is installed on my system, why don't we pick that
   automatically?
   
   Good question. But which one to select, if also the other are 
   installed?
   There may be a reason why someone does not want a specific lib.
   
   
   I would say by order of preference check hunspell, then enchant, then
   aspell.
   
   Regardless of the order (e.g. even if Enchant is prioritized), it
   would be nice to fill in the path in Preferences  Paths so that if
   the user wants to use Hunspell all he has to do is change the
   spellchecker.
   
   
   Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
   the development packages are found we should use them.
   
   If that is the consent, OK. But what to do, if no spellchecker is found?
   * Abort
   * Drop a message only
   * Silently ignore
  
  Is it possible to abort if no command line switch is given to disable them?
 
 Sure. Like this
   message(FATAL_ERROR You are leaving the moon atmosphere)
 
  Many users are asking for spell checker support but don't install any 
  developer
  package for spell checking and are baffled later about getting no spell 
  checker.
  It would be good to abort then with a helpful error message, IMHO.
  
  Stephan
 

What about the attached?

Korneldiff --git a/CMakeLists.txt b/CMakeLists.txt
index fe133eb..d68fa2b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -540,19 +540,22 @@ endif()
 
 include_directories(${TOP_BINARY_DIR} ${TOP_SRC_DIR}/src)
 
-if(LYX_ASPELL)
-	find_package(ASPELL REQUIRED)
-	include_directories(${ASPELL_INCLUDE_DIR})
-endif()
-
-if(LYX_ENCHANT)
-	find_package(Enchant REQUIRED)
-	include_directories(${ENCHANT_INCLUDE_DIR})
-endif()
+set(Spelling_FOUND OFF)
+foreach(_spell ASPELL Enchant Hunspell)
+  string(TOUPPER ${_spell} _upspell)
+  find_package(${_spell})
+  if (${_upspell}_FOUND)
+include_directories(${${_upspell}_INCLUDE_DIR})
+set(Spelling_FOUND ON)
+  else()
+if(LYX_${_upspell})
+  message(FATAL_ERROR Required ${_spell} devel package not found)
+endif()
+  endif()
+endforeach()
 
-if(LYX_HUNSPELL)
-	find_package(Hunspell REQUIRED)
-	include_directories(${HUNSPELL_INCLUDE_DIR})
+if(NOT Spelling_FOUND)
+  message(STATUS No spellcheck libraries found. Lyx will be unable use spellchecking)
 endif()
 
 if(LYX_NLS)


signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Stephan Witt]

Am 11.05.2014 um 18:43 schrieb Kornel Benko kor...@lyx.org:

 Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko kor...@lyx.org
 Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt st.w...@gmx.net
 Am 11.05.2014 um 12:38 schrieb Kornel Benko kor...@lyx.org:
 
 Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
 you...@lyx.org
 On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak skost...@lyx.org 
 wrote:
 
 On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes you...@lyx.org 
 wrote:
 On Sun, May 11, 2014 at 11:09 AM, Kornel Benko kor...@lyx.org wrote:
 
 Hunspell is installed on my system, why don't we pick that
 automatically?
 
 Good question. But which one to select, if also the other are 
 installed?
 There may be a reason why someone does not want a specific lib.
 
 
 I would say by order of preference check hunspell, then enchant, then
 aspell.
 
 Regardless of the order (e.g. even if Enchant is prioritized), it
 would be nice to fill in the path in Preferences  Paths so that if
 the user wants to use Hunspell all he has to do is change the
 spellchecker.
 
 
 Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
 the development packages are found we should use them.
 
 If that is the consent, OK. But what to do, if no spellchecker is found?
 * Abort
 * Drop a message only
 * Silently ignore
 
 Is it possible to abort if no command line switch is given to disable them?
 
 Sure. Like this
  message(FATAL_ERROR You are leaving the moon atmosphere)
 
 Many users are asking for spell checker support but don't install any 
 developer
 package for spell checking and are baffled later about getting no spell 
 checker.
 It would be good to abort then with a helpful error message, IMHO.
 
 Stephan
 
 
 What about the attached?
 
   KornelCMakeLists.txt.patch

I'd like to terminate if there is no spell checker and it's not said to ignore 
this.
The LYX_ options aren't three state. So this is possible only with a check for 
another
option, right? Then I'd prefer to give the hint at a more prominent location.

Alternative patch is attached.

Stephan


0001-CMakeLists.txt.patch
Description: Binary data

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 21:52:36, schrieb Stephan Witt st.w...@gmx.net
 Am 11.05.2014 um 18:43 schrieb Kornel Benko kor...@lyx.org:
 
  Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko kor...@lyx.org
  Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
  st.w...@gmx.net
  Am 11.05.2014 um 12:38 schrieb Kornel Benko kor...@lyx.org:

...

  Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
  the development packages are found we should use them.
  
  If that is the consent, OK. But what to do, if no spellchecker is found?
  * Abort
  * Drop a message only
  * Silently ignore
  
  Is it possible to abort if no command line switch is given to disable 
  them?
  
  Sure. Like this
 message(FATAL_ERROR You are leaving the moon atmosphere)
  
  Many users are asking for spell checker support but don't install any 
  developer
  package for spell checking and are baffled later about getting no spell 
  checker.
  It would be good to abort then with a helpful error message, IMHO.
  
  Stephan
  
  
  What about the attached?
  
  KornelCMakeLists.txt.patch
 
 I'd like to terminate if there is no spell checker and it's not said to 
 ignore this.
 The LYX_ options aren't three state. So this is possible only with a check 
 for another
 option, right?

Yes.

 Then I'd prefer to give the hint at a more prominent location.
 
 Alternative patch is attached.
 
 Stephan

Yes, better place for the message. But the option is missing.

Kornel



signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Stephan Witt]

Am 11.05.2014 um 22:34 schrieb Kornel Benko kor...@lyx.org:

 Am Sonntag, 11. Mai 2014 um 21:52:36, schrieb Stephan Witt st.w...@gmx.net
 Am 11.05.2014 um 18:43 schrieb Kornel Benko kor...@lyx.org:
 
 Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko kor...@lyx.org
 Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
 st.w...@gmx.net
 Am 11.05.2014 um 12:38 schrieb Kornel Benko kor...@lyx.org:
 
 ...
 
 Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
 the development packages are found we should use them.
 
 If that is the consent, OK. But what to do, if no spellchecker is found?
 * Abort
 * Drop a message only
 * Silently ignore
 
 Is it possible to abort if no command line switch is given to disable 
 them?
 
 Sure. Like this
message(FATAL_ERROR You are leaving the moon atmosphere)
 
 Many users are asking for spell checker support but don't install any 
 developer
 package for spell checking and are baffled later about getting no spell 
 checker.
 It would be good to abort then with a helpful error message, IMHO.
 
 Stephan
 
 
 What about the attached?
 
 KornelCMakeLists.txt.patch
 
 I'd like to terminate if there is no spell checker and it's not said to 
 ignore this.
 The LYX_ options aren't three state. So this is possible only with a check 
 for another
 option, right?
 
 Yes.
 
 Then I'd prefer to give the hint at a more prominent location.
 
 Alternative patch is attached.
 
 Stephan
 
 Yes, better place for the message. But the option is missing.

Yes, I didn't insist to abort. What's your opinion?

Stephan

Re: cmake warnings

[Abdelrazak Younes]

On Sun, May 11, 2014 at 12:22 AM, Kornel Benko  wrote:

> Am Samstag, 10. Mai 2014 um 22:26:24, schrieb Abdelrazak Younes <
> you...@lyx.org>
> > On Sat, May 10, 2014 at 9:50 PM, Kornel Benko  wrote:
> >
> > > Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes <
> > > you...@lyx.org>
> > > > Hi guys,
> > > >
> > > > Just checked out feature/str-metrics and I got  some warning when
> running
> > > > cmake:
> > > >
> > > > CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
> > > >   Policy CMP0028 is not set: Double colon in target name means ALIAS
> or
> > > >   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy
> details.
> > > >   Use the cmake_policy command to set the policy and suppress this
> > > warning.
> > > >
> > > >   Target "lyx2.2" links to target "Qt5::Concurrent" but the target
> was
> > > not
> > > >   found.  Perhaps a find_package() call is missing for an IMPORTED
> > > target,
> > > > or
> > > >   an ALIAS target is missing?
> > > > This warning is for project developers.  Use -Wno-dev to suppress it.
> > >
> > > I don't see it. But I don't have Qt5 anyway.
> > >
> >
> > I use Qt4.8 but Qt5 is also installed I think but only the runtime not
> the
> > devel package.
>
> Maybe this is the cause of the warning
> 'Target "lyx2.2" links to target "Qt5::Concurrent"',
> Could you install the Qt5 devel?
>

I can't at this point for other project reasons, sorry.



> Please notice that I am guessing only and cannot verify.
>
> > > Could you display the command arguments of add_executable on line 106?
> > >
> > > message(STATUS  ${_lyx}
> > > ${WIN32_CONSOLE}
> > > ${LYX_BUILD_BUNDLE}
> > > ${lyx_sources}
> > > ${lyx_headers}
> > > ${vld_files}
> > > ${FILE_RC}
> > > ${lyx_info_files}
> > > ${lyx_cmake_files}
> > > ${OSX_BUNDLE_FILES}
> > > )
> > >
> > > To see, where is the colon inserted?
> > >
> >
> > Here it is:
> >
>
> Nothing special in it. Especially no colon ':'.
> Are you using new cmake ( >= 3.0)?
>

Yes, I forgot I was using a development version, sorry about that:
  3.0.20140324-g4f419


> > > >
> > > > By the way, I just run "cmake .." without any argument, is this good
> > > enough
> > > > those days?
> > >
> > > No. But since some values will be used from cache, so it may fit.
> > >
> >
> > This was a fresh checkout, so no cache. My question was about make sure I
> > don't miss important cmake definitions.
>
> You do miss some.
> LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.
>
> (If you don't use CPACK then at least use LYX_INSTALL option)
>

 Hunspell is installed on my system, why don't we pick that automatically?

Thanks,
Abdel.

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 09:57:17, schrieb Abdelrazak Younes 
> On Sun, May 11, 2014 at 12:22 AM, Kornel Benko  wrote:
> 
> > Am Samstag, 10. Mai 2014 um 22:26:24, schrieb Abdelrazak Younes <
> > you...@lyx.org>
...

> > >
> > > I use Qt4.8 but Qt5 is also installed I think but only the runtime not
> > the
> > > devel package.
> >
> > Maybe this is the cause of the warning
> > 'Target "lyx2.2" links to target "Qt5::Concurrent"',
> > Could you install the Qt5 devel?
> >
> 
> I can't at this point for other project reasons, sorry.
> 

You could manually edit also the CMakeCache.txt.
Replace the used Qt5 libs with the Qt4 libs. They should be the same as
in CMakeCache.txtx for lyx2.1.

...
> 
> Yes, I forgot I was using a development version, sorry about that:
>   3.0.20140324-g4f419
> 

That's OK. Good to know someone is using it.

...
> > You do miss some.
> > LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.
> >
> > (If you don't use CPACK then at least use LYX_INSTALL option)
> >
> 
>  Hunspell is installed on my system, why don't we pick that automatically?

Good question. But which one to select, if also the other are installed?
There may be a reason why someone does not want a specific lib.

> Thanks,
> Abdel.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Abdelrazak Younes]

On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:

> > > You do miss some.
> > > LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.
> > >
> > > (If you don't use CPACK then at least use LYX_INSTALL option)
> > >
> >
> >  Hunspell is installed on my system, why don't we pick that
> automatically?
>
> Good question. But which one to select, if also the other are installed?
> There may be a reason why someone does not want a specific lib.
>

I would say by order of preference check hunspell, then enchant, then
aspell.

Abdel.

Re: cmake warnings

[Scott Kostyshak]

On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  wrote:
> On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
>>
>> >  Hunspell is installed on my system, why don't we pick that
>> > automatically?
>>
>> Good question. But which one to select, if also the other are installed?
>> There may be a reason why someone does not want a specific lib.
>
>
> I would say by order of preference check hunspell, then enchant, then
> aspell.

Regardless of the order (e.g. even if Enchant is prioritized), it
would be nice to fill in the path in Preferences > Paths so that if
the user wants to use Hunspell all he has to do is change the
spellchecker.

Scott

Re: cmake warnings

[Abdelrazak Younes]

On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak  wrote:

> On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  wrote:
> > On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
> >>
> >> >  Hunspell is installed on my system, why don't we pick that
> >> > automatically?
> >>
> >> Good question. But which one to select, if also the other are installed?
> >> There may be a reason why someone does not want a specific lib.
> >
> >
> > I would say by order of preference check hunspell, then enchant, then
> > aspell.
>
> Regardless of the order (e.g. even if Enchant is prioritized), it
> would be nice to fill in the path in Preferences > Paths so that if
> the user wants to use Hunspell all he has to do is change the
> spellchecker.
>

Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
the development packages are found we should use them.

Abdel

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
> On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak  wrote:
> 
> > On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  wrote:
> > > On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
> > >>
> > >> >  Hunspell is installed on my system, why don't we pick that
> > >> > automatically?
> > >>
> > >> Good question. But which one to select, if also the other are installed?
> > >> There may be a reason why someone does not want a specific lib.
> > >
> > >
> > > I would say by order of preference check hunspell, then enchant, then
> > > aspell.
> >
> > Regardless of the order (e.g. even if Enchant is prioritized), it
> > would be nice to fill in the path in Preferences > Paths so that if
> > the user wants to use Hunspell all he has to do is change the
> > spellchecker.
> >
> 
> Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
> the development packages are found we should use them.

If that is the consent, OK. But what to do, if no spellchecker is found?
* Abort
* Drop a message only
* Silently ignore

> Abdel

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Stephan Witt]

Am 11.05.2014 um 12:38 schrieb Kornel Benko :

> Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
> 
>> On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak  wrote:
>> 
>>> On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  wrote:
 On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
> 
>> Hunspell is installed on my system, why don't we pick that
>> automatically?
> 
> Good question. But which one to select, if also the other are installed?
> There may be a reason why someone does not want a specific lib.
 
 
 I would say by order of preference check hunspell, then enchant, then
 aspell.
>>> 
>>> Regardless of the order (e.g. even if Enchant is prioritized), it
>>> would be nice to fill in the path in Preferences > Paths so that if
>>> the user wants to use Hunspell all he has to do is change the
>>> spellchecker.
>>> 
>> 
>> Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
>> the development packages are found we should use them.
> 
> If that is the consent, OK. But what to do, if no spellchecker is found?
> * Abort
> * Drop a message only
> * Silently ignore

Is it possible to abort if no command line switch is given to disable them?

Many users are asking for spell checker support but don't install any developer
package for spell checking and are baffled later about getting no spell checker.
It would be good to abort then with a helpful error message, IMHO.

Stephan

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
> Am 11.05.2014 um 12:38 schrieb Kornel Benko :
> 
> > Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
> > 
> >> On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak  wrote:
> >> 
> >>> On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  wrote:
>  On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
> > 
> >> Hunspell is installed on my system, why don't we pick that
> >> automatically?
> > 
> > Good question. But which one to select, if also the other are installed?
> > There may be a reason why someone does not want a specific lib.
>  
>  
>  I would say by order of preference check hunspell, then enchant, then
>  aspell.
> >>> 
> >>> Regardless of the order (e.g. even if Enchant is prioritized), it
> >>> would be nice to fill in the path in Preferences > Paths so that if
> >>> the user wants to use Hunspell all he has to do is change the
> >>> spellchecker.
> >>> 
> >> 
> >> Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
> >> the development packages are found we should use them.
> > 
> > If that is the consent, OK. But what to do, if no spellchecker is found?
> > * Abort
> > * Drop a message only
> > * Silently ignore
> 
> Is it possible to abort if no command line switch is given to disable them?

Sure. Like this
message(FATAL_ERROR "You are leaving the moon atmosphere")

> Many users are asking for spell checker support but don't install any 
> developer
> package for spell checking and are baffled later about getting no spell 
> checker.
> It would be good to abort then with a helpful error message, IMHO.
> 
> Stephan

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko 
> Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
> > Am 11.05.2014 um 12:38 schrieb Kornel Benko :
> > 
> > > Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
> > > 
> > >> On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak  
> > >> wrote:
> > >> 
> > >>> On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  
> > >>> wrote:
> >  On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
> > > 
> > >> Hunspell is installed on my system, why don't we pick that
> > >> automatically?
> > > 
> > > Good question. But which one to select, if also the other are 
> > > installed?
> > > There may be a reason why someone does not want a specific lib.
> >  
> >  
> >  I would say by order of preference check hunspell, then enchant, then
> >  aspell.
> > >>> 
> > >>> Regardless of the order (e.g. even if Enchant is prioritized), it
> > >>> would be nice to fill in the path in Preferences > Paths so that if
> > >>> the user wants to use Hunspell all he has to do is change the
> > >>> spellchecker.
> > >>> 
> > >> 
> > >> Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
> > >> the development packages are found we should use them.
> > > 
> > > If that is the consent, OK. But what to do, if no spellchecker is found?
> > > * Abort
> > > * Drop a message only
> > > * Silently ignore
> > 
> > Is it possible to abort if no command line switch is given to disable them?
> 
> Sure. Like this
>   message(FATAL_ERROR "You are leaving the moon atmosphere")
> 
> > Many users are asking for spell checker support but don't install any 
> > developer
> > package for spell checking and are baffled later about getting no spell 
> > checker.
> > It would be good to abort then with a helpful error message, IMHO.
> > 
> > Stephan
> 

What about the attached?

Korneldiff --git a/CMakeLists.txt b/CMakeLists.txt
index fe133eb..d68fa2b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -540,19 +540,22 @@ endif()
 
 include_directories(${TOP_BINARY_DIR} ${TOP_SRC_DIR}/src)
 
-if(LYX_ASPELL)
-	find_package(ASPELL REQUIRED)
-	include_directories(${ASPELL_INCLUDE_DIR})
-endif()
-
-if(LYX_ENCHANT)
-	find_package(Enchant REQUIRED)
-	include_directories(${ENCHANT_INCLUDE_DIR})
-endif()
+set(Spelling_FOUND OFF)
+foreach(_spell "ASPELL" "Enchant" "Hunspell")
+  string(TOUPPER ${_spell} _upspell)
+  find_package(${_spell})
+  if (${_upspell}_FOUND)
+include_directories(${${_upspell}_INCLUDE_DIR})
+set(Spelling_FOUND ON)
+  else()
+if(LYX_${_upspell})
+  message(FATAL_ERROR "Required ${_spell} devel package not found")
+endif()
+  endif()
+endforeach()
 
-if(LYX_HUNSPELL)
-	find_package(Hunspell REQUIRED)
-	include_directories(${HUNSPELL_INCLUDE_DIR})
+if(NOT Spelling_FOUND)
+  message(STATUS "No spellcheck libraries found. Lyx will be unable use spellchecking")
 endif()
 
 if(LYX_NLS)


signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Stephan Witt]

Am 11.05.2014 um 18:43 schrieb Kornel Benko :

> Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko 
>> Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
>>> Am 11.05.2014 um 12:38 schrieb Kornel Benko :
>>> 
 Am Sonntag, 11. Mai 2014 um 11:55:38, schrieb Abdelrazak Younes 
 
> On Sun, May 11, 2014 at 11:23 AM, Scott Kostyshak  
> wrote:
> 
>> On Sun, May 11, 2014 at 5:16 AM, Abdelrazak Younes  
>> wrote:
>>> On Sun, May 11, 2014 at 11:09 AM, Kornel Benko  wrote:
 
> Hunspell is installed on my system, why don't we pick that
> automatically?
 
 Good question. But which one to select, if also the other are 
 installed?
 There may be a reason why someone does not want a specific lib.
>>> 
>>> 
>>> I would say by order of preference check hunspell, then enchant, then
>>> aspell.
>> 
>> Regardless of the order (e.g. even if Enchant is prioritized), it
>> would be nice to fill in the path in Preferences > Paths so that if
>> the user wants to use Hunspell all he has to do is change the
>> spellchecker.
>> 
> 
> Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
> the development packages are found we should use them.
 
 If that is the consent, OK. But what to do, if no spellchecker is found?
 * Abort
 * Drop a message only
 * Silently ignore
>>> 
>>> Is it possible to abort if no command line switch is given to disable them?
>> 
>> Sure. Like this
>>  message(FATAL_ERROR "You are leaving the moon atmosphere")
>> 
>>> Many users are asking for spell checker support but don't install any 
>>> developer
>>> package for spell checking and are baffled later about getting no spell 
>>> checker.
>>> It would be good to abort then with a helpful error message, IMHO.
>>> 
>>> Stephan
>> 
> 
> What about the attached?
> 
>   Kornel

I'd like to terminate if there is no spell checker and it's not said to ignore 
this.
The LYX_ options aren't three state. So this is possible only with a check for 
another
option, right? Then I'd prefer to give the hint at a more prominent location.

Alternative patch is attached.

Stephan


0001-CMakeLists.txt.patch
Description: Binary data

Re: cmake warnings

[Kornel Benko]

Am Sonntag, 11. Mai 2014 um 21:52:36, schrieb Stephan Witt 
> Am 11.05.2014 um 18:43 schrieb Kornel Benko :
> 
> > Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko 
> >> Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
> >> 
> >>> Am 11.05.2014 um 12:38 schrieb Kornel Benko :

...

> > Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
> > the development packages are found we should use them.
>  
>  If that is the consent, OK. But what to do, if no spellchecker is found?
>  * Abort
>  * Drop a message only
>  * Silently ignore
> >>> 
> >>> Is it possible to abort if no command line switch is given to disable 
> >>> them?
> >> 
> >> Sure. Like this
> >>message(FATAL_ERROR "You are leaving the moon atmosphere")
> >> 
> >>> Many users are asking for spell checker support but don't install any 
> >>> developer
> >>> package for spell checking and are baffled later about getting no spell 
> >>> checker.
> >>> It would be good to abort then with a helpful error message, IMHO.
> >>> 
> >>> Stephan
> >> 
> > 
> > What about the attached?
> > 
> > Kornel
> 
> I'd like to terminate if there is no spell checker and it's not said to 
> ignore this.
> The LYX_ options aren't three state. So this is possible only with a check 
> for another
> option, right?

Yes.

> Then I'd prefer to give the hint at a more prominent location.
> 
> Alternative patch is attached.
> 
> Stephan

Yes, better place for the message. But the option is missing.

Kornel



signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Stephan Witt]

Am 11.05.2014 um 22:34 schrieb Kornel Benko :

> Am Sonntag, 11. Mai 2014 um 21:52:36, schrieb Stephan Witt 
>> Am 11.05.2014 um 18:43 schrieb Kornel Benko :
>> 
>>> Am Sonntag, 11. Mai 2014 um 18:15:22, schrieb Kornel Benko 
 Am Sonntag, 11. Mai 2014 um 18:11:44, schrieb Stephan Witt 
 
> Am 11.05.2014 um 12:38 schrieb Kornel Benko :
> 
> ...
> 
>>> Indeed, AFAIR we can compile concurrent support for all 3 spellers so if
>>> the development packages are found we should use them.
>> 
>> If that is the consent, OK. But what to do, if no spellchecker is found?
>> * Abort
>> * Drop a message only
>> * Silently ignore
> 
> Is it possible to abort if no command line switch is given to disable 
> them?
 
 Sure. Like this
message(FATAL_ERROR "You are leaving the moon atmosphere")
 
> Many users are asking for spell checker support but don't install any 
> developer
> package for spell checking and are baffled later about getting no spell 
> checker.
> It would be good to abort then with a helpful error message, IMHO.
> 
> Stephan
 
>>> 
>>> What about the attached?
>>> 
>>> Kornel
>> 
>> I'd like to terminate if there is no spell checker and it's not said to 
>> ignore this.
>> The LYX_ options aren't three state. So this is possible only with a check 
>> for another
>> option, right?
> 
> Yes.
> 
>> Then I'd prefer to give the hint at a more prominent location.
>> 
>> Alternative patch is attached.
>> 
>> Stephan
> 
> Yes, better place for the message. But the option is missing.

Yes, I didn't insist to abort. What's your opinion?

Stephan

cmake warnings

[Abdelrazak Younes]

Hi guys,

Just checked out feature/str-metrics and I got  some warning when running
cmake:

CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run cmake --help-policy CMP0028 for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target lyx2.2 links to target Qt5::Concurrent but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target,
or
  an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run cmake --help-policy CMP0028 for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target lyx2.2 links to target Qt5::Concurrent but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target,
or
  an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.

By the way, I just run cmake .. without any argument, is this good enough
those days?

Abdel.

Re: cmake warnings

[Kornel Benko]

Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes you...@lyx.org
 Hi guys,
 
 Just checked out feature/str-metrics and I got  some warning when running
 cmake:
 
 CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
   Policy CMP0028 is not set: Double colon in target name means ALIAS or
   IMPORTED target.  Run cmake --help-policy CMP0028 for policy details.
   Use the cmake_policy command to set the policy and suppress this warning.
 
   Target lyx2.2 links to target Qt5::Concurrent but the target was not
   found.  Perhaps a find_package() call is missing for an IMPORTED target,
 or
   an ALIAS target is missing?
 This warning is for project developers.  Use -Wno-dev to suppress it.

I don't see it. But I don't have Qt5 anyway.
Could you display the command arguments of add_executable on line 106?

message(STATUS  ${_lyx}
${WIN32_CONSOLE}
${LYX_BUILD_BUNDLE}
${lyx_sources}
${lyx_headers}
${vld_files}
${FILE_RC}
${lyx_info_files}
${lyx_cmake_files}
${OSX_BUNDLE_FILES}
)

To see, where is the colon inserted?

 
 By the way, I just run cmake .. without any argument, is this good enough
 those days?

No. But since some values will be used from cache, so it may fit.

Rebuilding with saved values should be done by
# make rebuild_cache
in the build directory.

 Abdel.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Abdelrazak Younes]

On Sat, May 10, 2014 at 9:50 PM, Kornel Benko kor...@lyx.org wrote:

 Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes 
 you...@lyx.org
  Hi guys,
 
  Just checked out feature/str-metrics and I got  some warning when running
  cmake:
 
  CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target.  Run cmake --help-policy CMP0028 for policy details.
Use the cmake_policy command to set the policy and suppress this
 warning.
 
Target lyx2.2 links to target Qt5::Concurrent but the target was
 not
found.  Perhaps a find_package() call is missing for an IMPORTED
 target,
  or
an ALIAS target is missing?
  This warning is for project developers.  Use -Wno-dev to suppress it.

 I don't see it. But I don't have Qt5 anyway.


I use Qt4.8 but Qt5 is also installed I think but only the runtime not the
devel package.


 Could you display the command arguments of add_executable on line 106?

 message(STATUS  ${_lyx}
 ${WIN32_CONSOLE}
 ${LYX_BUILD_BUNDLE}
 ${lyx_sources}
 ${lyx_headers}
 ${vld_files}
 ${FILE_RC}
 ${lyx_info_files}
 ${lyx_cmake_files}
 ${OSX_BUNDLE_FILES}
 )

 To see, where is the colon inserted?


Here it is:

-- 

Re: cmake warnings

[Kornel Benko]

Am Samstag, 10. Mai 2014 um 22:26:24, schrieb Abdelrazak Younes you...@lyx.org
 On Sat, May 10, 2014 at 9:50 PM, Kornel Benko kor...@lyx.org wrote:
 
  Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes 
  you...@lyx.org
   Hi guys,
  
   Just checked out feature/str-metrics and I got  some warning when running
   cmake:
  
   CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
 Policy CMP0028 is not set: Double colon in target name means ALIAS or
 IMPORTED target.  Run cmake --help-policy CMP0028 for policy details.
 Use the cmake_policy command to set the policy and suppress this
  warning.
  
 Target lyx2.2 links to target Qt5::Concurrent but the target was
  not
 found.  Perhaps a find_package() call is missing for an IMPORTED
  target,
   or
 an ALIAS target is missing?
   This warning is for project developers.  Use -Wno-dev to suppress it.
 
  I don't see it. But I don't have Qt5 anyway.
 
 
 I use Qt4.8 but Qt5 is also installed I think but only the runtime not the
 devel package.

Maybe this is the cause of the warning
'Target lyx2.2 links to target Qt5::Concurrent',
Could you install the Qt5 devel?
Please notice that I am guessing only and cannot verify.

  Could you display the command arguments of add_executable on line 106?
 
  message(STATUS  ${_lyx}
  ${WIN32_CONSOLE}
  ${LYX_BUILD_BUNDLE}
  ${lyx_sources}
  ${lyx_headers}
  ${vld_files}
  ${FILE_RC}
  ${lyx_info_files}
  ${lyx_cmake_files}
  ${OSX_BUNDLE_FILES}
  )
 
  To see, where is the colon inserted?
 
 
 Here it is:
 

Nothing special in it. Especially no colon ':'.
Are you using new cmake ( = 3.0)?

  
   By the way, I just run cmake .. without any argument, is this good
  enough
   those days?
 
  No. But since some values will be used from cache, so it may fit.
 
 
 This was a fresh checkout, so no cache. My question was about make sure I
 don't miss important cmake definitions.

You do miss some.
LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.

(If you don't use CPACK then at least use LYX_INSTALL option)

 Thanks,
 Abdel.

Kornel

signature.asc
Description: This is a digitally signed message part.

cmake warnings

[Abdelrazak Younes]

Hi guys,

Just checked out feature/str-metrics and I got  some warning when running
cmake:

CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "lyx2.2" links to target "Qt5::Concurrent" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target,
or
  an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
  Policy CMP0028 is not set: Double colon in target name means ALIAS or
  IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "lyx2.2" links to target "Qt5::Concurrent" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target,
or
  an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.

By the way, I just run "cmake .." without any argument, is this good enough
those days?

Abdel.

Re: cmake warnings

[Kornel Benko]

Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes 
> Hi guys,
> 
> Just checked out feature/str-metrics and I got  some warning when running
> cmake:
> 
> CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
>   Policy CMP0028 is not set: Double colon in target name means ALIAS or
>   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
>   Use the cmake_policy command to set the policy and suppress this warning.
> 
>   Target "lyx2.2" links to target "Qt5::Concurrent" but the target was not
>   found.  Perhaps a find_package() call is missing for an IMPORTED target,
> or
>   an ALIAS target is missing?
> This warning is for project developers.  Use -Wno-dev to suppress it.

I don't see it. But I don't have Qt5 anyway.
Could you display the command arguments of add_executable on line 106?

message(STATUS  ${_lyx}
${WIN32_CONSOLE}
${LYX_BUILD_BUNDLE}
${lyx_sources}
${lyx_headers}
${vld_files}
${FILE_RC}
${lyx_info_files}
${lyx_cmake_files}
${OSX_BUNDLE_FILES}
)

To see, where is the colon inserted?

> 
> By the way, I just run "cmake .." without any argument, is this good enough
> those days?

No. But since some values will be used from cache, so it may fit.

Rebuilding with saved values should be done by
# make rebuild_cache
in the build directory.

> Abdel.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: cmake warnings

[Abdelrazak Younes]

On Sat, May 10, 2014 at 9:50 PM, Kornel Benko  wrote:

> Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes <
> you...@lyx.org>
> > Hi guys,
> >
> > Just checked out feature/str-metrics and I got  some warning when running
> > cmake:
> >
> > CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
> >   Policy CMP0028 is not set: Double colon in target name means ALIAS or
> >   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
> >   Use the cmake_policy command to set the policy and suppress this
> warning.
> >
> >   Target "lyx2.2" links to target "Qt5::Concurrent" but the target was
> not
> >   found.  Perhaps a find_package() call is missing for an IMPORTED
> target,
> > or
> >   an ALIAS target is missing?
> > This warning is for project developers.  Use -Wno-dev to suppress it.
>
> I don't see it. But I don't have Qt5 anyway.
>

I use Qt4.8 but Qt5 is also installed I think but only the runtime not the
devel package.


> Could you display the command arguments of add_executable on line 106?
>
> message(STATUS  ${_lyx}
> ${WIN32_CONSOLE}
> ${LYX_BUILD_BUNDLE}
> ${lyx_sources}
> ${lyx_headers}
> ${vld_files}
> ${FILE_RC}
> ${lyx_info_files}
> ${lyx_cmake_files}
> ${OSX_BUNDLE_FILES}
> )
>
> To see, where is the colon inserted?
>

Here it is:

-- 

Re: cmake warnings

[Kornel Benko]

Am Samstag, 10. Mai 2014 um 22:26:24, schrieb Abdelrazak Younes 
> On Sat, May 10, 2014 at 9:50 PM, Kornel Benko  wrote:
> 
> > Am Samstag, 10. Mai 2014 um 18:32:13, schrieb Abdelrazak Younes <
> > you...@lyx.org>
> > > Hi guys,
> > >
> > > Just checked out feature/str-metrics and I got  some warning when running
> > > cmake:
> > >
> > > CMake Warning (dev) at src/CMakeLists.txt:106 (add_executable):
> > >   Policy CMP0028 is not set: Double colon in target name means ALIAS or
> > >   IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
> > >   Use the cmake_policy command to set the policy and suppress this
> > warning.
> > >
> > >   Target "lyx2.2" links to target "Qt5::Concurrent" but the target was
> > not
> > >   found.  Perhaps a find_package() call is missing for an IMPORTED
> > target,
> > > or
> > >   an ALIAS target is missing?
> > > This warning is for project developers.  Use -Wno-dev to suppress it.
> >
> > I don't see it. But I don't have Qt5 anyway.
> >
> 
> I use Qt4.8 but Qt5 is also installed I think but only the runtime not the
> devel package.

Maybe this is the cause of the warning
'Target "lyx2.2" links to target "Qt5::Concurrent"',
Could you install the Qt5 devel?
Please notice that I am guessing only and cannot verify.

> > Could you display the command arguments of add_executable on line 106?
> >
> > message(STATUS  ${_lyx}
> > ${WIN32_CONSOLE}
> > ${LYX_BUILD_BUNDLE}
> > ${lyx_sources}
> > ${lyx_headers}
> > ${vld_files}
> > ${FILE_RC}
> > ${lyx_info_files}
> > ${lyx_cmake_files}
> > ${OSX_BUNDLE_FILES}
> > )
> >
> > To see, where is the colon inserted?
> >
> 
> Here it is:
> 

Nothing special in it. Especially no colon ':'.
Are you using new cmake ( >= 3.0)?

> > >
> > > By the way, I just run "cmake .." without any argument, is this good
> > enough
> > > those days?
> >
> > No. But since some values will be used from cache, so it may fit.
> >
> 
> This was a fresh checkout, so no cache. My question was about make sure I
> don't miss important cmake definitions.

You do miss some.
LYX_CPACK, LYX_ASPELL, LYX_ENCHANT, LYX_HUNSPELL.

(If you don't use CPACK then at least use LYX_INSTALL option)

> Thanks,
> Abdel.

Kornel

signature.asc
Description: This is a digitally signed message part.