Re: [patch] Specify the target format for local layout conversion

2016-07-29 Thread Guillaume Munch
Le 28/07/2016 à 17:49, José Abílio Matos a écrit : After a cursory look at your code I have no objection. :-) BTW, the usual rant at this type of code is that equally important would an option that allowed to express what is the stable version that you are interested (the equivalent -V option

Re: C++ "good practices" regarding constifying a function parameter?

2016-07-29 Thread Guillaume Munch
Le 27/07/2016 à 22:19, Scott Kostyshak a écrit : For the function definition, the difference is in terms of documentation. If you are adding const in the definition because you find it clearer this way, then it is a good reason to change it. Yes this was my intention. To me it has the same

Re: #10310: Session handling does not restore cursor position

2016-07-29 Thread Guillaume Munch
Le 28/07/2016 à 10:46, Jean-Marc Lasgouttes a écrit : I think the limit is useful. I am sure somebody somewhere has a makefile that creates thousand of files... It would be better to make it work IMO. Ok. Added to the bug report with a easyfix tag so that we don't forget.

Re: workaround to 'git reset --hard' not working because of .gitattributes

2016-07-29 Thread Guillaume Munch
Le 28/07/2016 à 23:19, Richard Heck a écrit : On 07/23/2016 06:30 PM, Guillaume Munch wrote: Since it looks so severe, I wonder whether there is a radical solution, such as rewriting the history of master, provided developers agree that the problem is that annoying. That sounds dangerous.

Re: #10310: Session handling does not restore cursor position

2016-07-29 Thread Guillaume Munch
Le 27/07/2016 à 23:01, Scott Kostyshak a écrit : I imagine it is there for performance reasons? A thousand lines in the file and a thousand entries in the map would be just as fine, probably ten thousands as well. LastFilePosSection::read() is called for every recent file when opening

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Jean-Marc Lasgouttes
Le 29/07/2016 à 19:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple patch (just a reordering), but since I don't understand

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Guillaume Munch
Le 29/07/2016 à 18:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple patch (just a reordering), but since I don't understand

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Guillaume Munch
Le 29/07/2016 à 23:32, Jean-Marc Lasgouttes a écrit : Le 29/07/2016 à 19:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple

Re: LabelFont in arguments of insets

2016-07-29 Thread Richard Heck
On 07/22/2016 11:18 PM, Andrew Parsloe wrote: > I downloaded and installed Uwe's windows 2.2.1 installer (which, I > gather, may not be exactly the official 2.2.1). > > I can confirm that the assertion is no longer there that arose when > using color in the LabelFont specification for an argument

Re: Annoying terminal messages: QXcbClipboard: SelectionRequest too old

2016-07-29 Thread Scott Kostyshak
On Fri, Jul 29, 2016 at 01:40:11AM +0200, Enrico Forestieri wrote: > On Wed, Jul 27, 2016 at 10:45:10PM -0400, Scott Kostyshak wrote: > > > > Enrico, have you seen the following? > > https://codereview.qt-project.org/#/c/32263/ > > > > In particular, note the patch set here: > >

Re: #10310: Session handling does not restore cursor position

2016-07-29 Thread Scott Kostyshak
On Fri, Jul 29, 2016 at 04:43:46PM +0100, Guillaume Munch wrote: > Le 27/07/2016 à 23:01, Scott Kostyshak a écrit : > > > > I imagine it is there for performance reasons? > > A thousand lines in the file and a thousand entries in the map would be just > as fine, probably ten thousands as well.

[PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Scott Kostyshak
I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple patch (just a reordering), but since I don't understand exactly why it works I would like to either commit

Re: C++ "good practices" regarding constifying a function parameter?

2016-07-29 Thread Scott Kostyshak
On Fri, Jul 29, 2016 at 03:43:45PM +0100, Guillaume Munch wrote: > All these are good reasons. OK it's in at 60e89213. Scott signature.asc Description: PGP signature

Re: default dir when save for first time is not cwd

2016-07-29 Thread Scott Kostyshak
On Tue, Jul 19, 2016 at 09:16:04PM -0400, Scott Kostyshak wrote: > Attached is an updated patch distinguishing TEXINPUTS. The patch is in at 9b64d7bd. If someone prefers for me to implement Guillaume's idea to reduce the size of the explanatory text, I am happy to do so. I plan to soon propose