Re: master crash (tocwidget code)

2021-11-03 Thread Jürgen Spitzmüller
Am Mi., 3. Nov. 2021 um 13:42 Uhr schrieb Pavel Sanda : > I can't reproduce this and do get the crash even when commenting the block > statements except return. > Right. Maybe it didn't crash for me by coincidence. Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: master crash (tocwidget code)

2021-11-03 Thread Kornel Benko
Am Wed, 3 Nov 2021 13:41:37 +0100 schrieb Pavel Sanda : > On Wed, Nov 03, 2021 at 08:28:59AM +0100, Jürgen Spitzmüller wrote: > > > Maybe this code (TocWidget::updateView()) is to blame? > > > > > > if (!gui_view_.documentBufferView()) { > > > > > > tocTV->setModel(nullptr); > > > > >

Re: master crash (tocwidget code)

2021-11-03 Thread Jürgen Spitzmüller
Am Mi., 3. Nov. 2021 um 15:17 Uhr schrieb Pavel Sanda : > I am afraid unless we want to revamp the whole toc update machinery we just > shouldn't by default that expect toc_ is nonempty. > This means that my patch which checks for toc_ emptiness should go in, right? Jürgen > > Pavel > -- >

Re: Latex run after toggling search pane

2021-11-03 Thread Jürgen Spitzmüller
Am Mi., 3. Nov. 2021 um 08:54 Uhr schrieb Yuriy Skalko < yuriy.ska...@gmail.com>: > Hello, > > In current master I'm getting automatic run of latex after toggling Find > and replace button on the toolbar. > > Bisect gives this commit: bca1b63d89e27b. Jürgen, can you check this? > Yes, this is

Re: master crash (tocwidget code)

2021-11-03 Thread Pavel Sanda
On Wed, Nov 03, 2021 at 08:28:59AM +0100, Jürgen Spitzmüller wrote: > > Maybe this code (TocWidget::updateView()) is to blame? > > > > if (!gui_view_.documentBufferView()) { > > > > tocTV->setModel(nullptr); > > > > depthSL->setMaximum(0); > > > >

Re: master crash (tocwidget code)

2021-11-03 Thread Pavel Sanda
On Tue, Nov 02, 2021 at 10:07:20PM +0100, Pavel Sanda wrote: > We call various reset() and clear() routines many many times, > and its unclear to me why we repeatedlt call the whole machinery. >From what I can see in the code the route to touching toc_ is: Guiview::structureChanged() ->

Re: master crash (tocwidget code)

2021-11-03 Thread Jürgen Spitzmüller
Am Mittwoch, dem 03.11.2021 um 16:43 +0100 schrieb Pavel Sanda: > Well, nothing against this particular patch, but the problem is that > if we accept that models_.find(type) might sucesfully return hashes > which are actually bogus, then all other models_.find occurences > might be in the same

Re: Footnote size is larger on master (\normalsize is prepended)

2021-11-03 Thread Scott Kostyshak
On Wed, Nov 03, 2021 at 08:12:55AM +0100, Jürgen Spitzmüller wrote: > Scott Kostyshak schrieb am Mi., 3. Nov. 2021, 02:44: > > > > > Thanks for taking a look. I see, so master behavior is correct. I think > > in most cases the intent is to not have it bold, i.e., I might look into > > removing

Re: Qt6 crash

2021-11-03 Thread Enrico Forestieri
On Wed, Nov 03, 2021 at 06:03:16PM +0100, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 03.11.2021 um 17:44 +0100 schrieb Jürgen Spitzmüller: > > Am Mittwoch, dem 03.11.2021 um 03:30 +0100 schrieb Stephan Witt: > > > I’ve built master with Qt 6.2.0 on Mac and it doesn’t crash. I’m > > > compiling

Re: master crash (tocwidget code)

2021-11-03 Thread Pavel Sanda
On Wed, Nov 03, 2021 at 03:59:25PM +0100, Jürgen Spitzmüller wrote: > Am Mi., 3. Nov. 2021 um 15:17 Uhr schrieb Pavel Sanda : > > > I am afraid unless we want to revamp the whole toc update machinery we just > > shouldn't by default that expect toc_ is nonempty. > > > > This means that my patch

Re: Qt6 crash

2021-11-03 Thread Jürgen Spitzmüller
Am Mittwoch, dem 03.11.2021 um 17:44 +0100 schrieb Jürgen Spitzmüller: > Am Mittwoch, dem 03.11.2021 um 03:30 +0100 schrieb Stephan Witt: > > I’ve built master with Qt 6.2.0 on Mac and it doesn’t crash. I’m > > compiling the UG with pdflatex. > > Thanks. Retried with a clean rebuild. Still

Re: Qt6 crash

2021-11-03 Thread Jürgen Spitzmüller
Am Mittwoch, dem 03.11.2021 um 03:30 +0100 schrieb Stephan Witt: > I’ve built master with Qt 6.2.0 on Mac and it doesn’t crash. I’m > compiling the UG with pdflatex. Thanks. Retried with a clean rebuild. Still crashing (after the PDF has been created): ( 1) src/lyx:

Re: master crash (tocwidget code)

2021-11-03 Thread Pavel Sanda
On Wed, Nov 03, 2021 at 05:18:44PM +0100, Jürgen Spitzmüller wrote: > Am Mittwoch, dem 03.11.2021 um 16:43 +0100 schrieb Pavel Sanda: > > Well, nothing against this particular patch, but the problem is that > > if we accept that models_.find(type) might sucesfully return hashes > > which are

Re: Footnote size is larger on master (\normalsize is prepended)

2021-11-03 Thread Jean-Marc Lasgouttes
Le 02/11/2021 à 15:52, Jürgen Spitzmüller a écrit : With inheritFont() == false, we end up in unnecessary font switches at footnote start, e.g. \footnote{\normalsize text ...} in section headings (see Scott's example), and I want to avoid that. Agreed. However it seems that the code 1/ looks

False spacing if a skip is emphasized

2021-11-03 Thread Andrew Parsloe
LyX 2.4 alpha 3 on windows 10. If a vertical skip between two standard paragraphs is emphasized (or bolded or nouned or ...) it produces a false linespace in the pdf within the second paragraph. The effect doesn't show in the LyX window. It's easy to emphasize a skip if the first word of the

Re: master crash (tocwidget code)

2021-11-03 Thread Jürgen Spitzmüller
Am Mi., 3. Nov. 2021 um 08:14 Uhr schrieb Jürgen Spitzmüller : > Maybe this code (TocWidget::updateView()) is to blame? > > if (!gui_view_.documentBufferView()) { > > tocTV->setModel(nullptr); > > depthSL->setMaximum(0); > > depthSL->setValue(0); >

Re: Footnote size is larger on master (\normalsize is prepended)

2021-11-03 Thread Jürgen Spitzmüller
Scott Kostyshak schrieb am Mi., 3. Nov. 2021, 02:44: > > Thanks for taking a look. I see, so master behavior is correct. I think > in most cases the intent is to not have it bold, i.e., I might look into > removing the bold in the .lyx files if I am motivated. > I think a non-bold footnote

Re: master crash (tocwidget code)

2021-11-03 Thread Jürgen Spitzmüller
Am Di., 2. Nov. 2021 um 22:08 Uhr schrieb Pavel Sanda : > I believe something else is going on. > > When you add something like > +++ b/src/frontends/qt/TocModel.cpp > @@ -327,6 +330,7 @@ TocItem const TocModels::currentItem(QString const & > type, > } > LASSERT(index.model() ==

Latex run after toggling search pane

2021-11-03 Thread Yuriy Skalko
Hello, In current master I'm getting automatic run of latex after toggling Find and replace button on the toolbar. Bisect gives this commit: bca1b63d89e27b. Jürgen, can you check this? Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel