Re: Failed tests for es/Additional.lyx
Am Sonntag, 17. September 2017 um 23:55:15, schrieb Scott Kostyshak > On Sat, Sep 16, 2017 at 09:37:55PM +0200, Kornel Benko wrote: > > > > Ah good to know. Should that change be ported to 2.3.x? > > > > From my POV, yes. > > OK go ahead (if you have time). > > Scott No problem, done at adfcd08 Kornel signature.asc Description: This is a digitally signed message part.
Re: Failed tests for es/Additional.lyx
On Sat, Sep 16, 2017 at 09:37:55PM +0200, Kornel Benko wrote: > > Ah good to know. Should that change be ported to 2.3.x? > > From my POV, yes. OK go ahead (if you have time). Scott signature.asc Description: PGP signature
Re: Failed tests for es/Additional.lyx
Am Samstag, 16. September 2017 um 14:15:24, schrieb Scott Kostyshak > On Sat, Sep 16, 2017 at 06:58:24PM +0200, Kornel Benko wrote: > > Am Samstag, 16. September 2017 um 12:28:42, schrieb Scott Kostyshak > > > > > On Sat, Aug 12, 2017 at 01:42:42PM +0200, Kornel Benko wrote: > > > > There are 2 issues here. > > > > > > > > 1.) The reference with non-ascii characters > > > > "sec:Insertar-Código-TeX" > > > > > > I personally think the change you propose here is fine (but the opinion > > > of a non-English speaker would be more valuable here). Could this issue > > > explain a lot of our systemF failures (that we've probably inverted long > > > ago and forgotten about)? I imagine it is quite common. > > > > It turned out, that the error vanished wit commit 1d0794e. Looks like a > > consequential error > > of language changes (which this commit addressed) > > Ah good to know. Should that change be ported to 2.3.x? From my POV, yes. > Scott Kornel signature.asc Description: This is a digitally signed message part.
Re: Failed tests for es/Additional.lyx
On Sat, Sep 16, 2017 at 06:58:24PM +0200, Kornel Benko wrote: > Am Samstag, 16. September 2017 um 12:28:42, schrieb Scott Kostyshak > > > On Sat, Aug 12, 2017 at 01:42:42PM +0200, Kornel Benko wrote: > > > There are 2 issues here. > > > > > > 1.) The reference with non-ascii characters > > > "sec:Insertar-Código-TeX" > > > > I personally think the change you propose here is fine (but the opinion > > of a non-English speaker would be more valuable here). Could this issue > > explain a lot of our systemF failures (that we've probably inverted long > > ago and forgotten about)? I imagine it is quite common. > > It turned out, that the error vanished wit commit 1d0794e. Looks like a > consequential error > of language changes (which this commit addressed) Ah good to know. Should that change be ported to 2.3.x? Scott signature.asc Description: PGP signature
Re: Failed tests for es/Additional.lyx
Am Samstag, 16. September 2017 um 12:28:42, schrieb Scott Kostyshak > On Sat, Aug 12, 2017 at 01:42:42PM +0200, Kornel Benko wrote: > > There are 2 issues here. > > > > 1.) The reference with non-ascii characters > > "sec:Insertar-Código-TeX" > > I personally think the change you propose here is fine (but the opinion > of a non-English speaker would be more valuable here). Could this issue > explain a lot of our systemF failures (that we've probably inverted long > ago and forgotten about)? I imagine it is quite common. It turned out, that the error vanished wit commit 1d0794e. Looks like a consequential error of language changes (which this commit addressed) > Do we know if there are any plans to allow non-ascii labels by whichever > part of the LaTeX machinery is responsible for this part of the code? > If not, I wonder if it would be a reasonable feature request to convert > such labels to ascii on export with system fonts. It seems we would want > to allow non-ascii labels for export to e.g. pdflatex, so we should not > e.g. only allow ascii characters in our label dialog. But I wonder if > converting them would make sense. I'm not sure if we would want to > convert the labels as accurately as possible (e.g. código to codigo), or > since an accurate conversion would be impossible for non-latin languages > just use e.g. "label1", "label2", etc. I'm guessing this might not be a > good idea, though, because aren't labels used in output in some cases? > For example, I think I remember labels of math equations being printed > if I set a certain LaTeX option (maybe draft?). > > > > 2.) Language specification in connection with ERT in argument to labelitem > > > > Annoyingly, it is not possible to remove the language setting unless one > > first removes the ERT. > > (See the section "3.5.3 Cómo se emplea" with the item '\(star\)' > > After this change, does the document appear any different? That is, do > we sacrifice anything just to make the tests pass? If not, I would say > go ahead. It looks the same, but as mentioned, not important anymore. > Scott Kornel signature.asc Description: This is a digitally signed message part.
Re: Failed tests for es/Additional.lyx
On Sat, Aug 12, 2017 at 01:42:42PM +0200, Kornel Benko wrote: > There are 2 issues here. > > 1.) The reference with non-ascii characters > "sec:Insertar-Código-TeX" I personally think the change you propose here is fine (but the opinion of a non-English speaker would be more valuable here). Could this issue explain a lot of our systemF failures (that we've probably inverted long ago and forgotten about)? I imagine it is quite common. Do we know if there are any plans to allow non-ascii labels by whichever part of the LaTeX machinery is responsible for this part of the code? If not, I wonder if it would be a reasonable feature request to convert such labels to ascii on export with system fonts. It seems we would want to allow non-ascii labels for export to e.g. pdflatex, so we should not e.g. only allow ascii characters in our label dialog. But I wonder if converting them would make sense. I'm not sure if we would want to convert the labels as accurately as possible (e.g. código to codigo), or since an accurate conversion would be impossible for non-latin languages just use e.g. "label1", "label2", etc. I'm guessing this might not be a good idea, though, because aren't labels used in output in some cases? For example, I think I remember labels of math equations being printed if I set a certain LaTeX option (maybe draft?). > 2.) Language specification in connection with ERT in argument to labelitem > > Annoyingly, it is not possible to remove the language setting unless one > first removes the ERT. > (See the section "3.5.3 Cómo se emplea" with the item '\(star\)' After this change, does the document appear any different? That is, do we sacrifice anything just to make the tests pass? If not, I would say go ahead. Scott signature.asc Description: PGP signature
Failed tests for es/Additional.lyx
There are 2 issues here. 1.) The reference with non-ascii characters "sec:Insertar-Código-TeX" 2.) Language specification in connection with ERT in argument to labelitem Annoyingly, it is not possible to remove the language setting unless one first removes the ERT. (See the section "3.5.3 Cómo se emplea" with the item '\(star\)' The attached patch makes following tests pass again: Test #2068: export/doc/es/Additional_dvi3_systemF Test #2073: export/doc/es/Additional_pdf4_systemF Test #2075: export/doc/es/Additional_pdf5_systemF Kornel signature.asc Description: This is a digitally signed message part. diff --git a/lib/doc/es/Additional.lyx b/lib/doc/es/Additional.lyx index 80f6af5..3f4da92 100644 --- a/lib/doc/es/Additional.lyx +++ b/lib/doc/es/Additional.lyx @@ -727,7 +727,7 @@ Insertar código \SpecialChar TeX \begin_inset CommandInset label LatexCommand label -name "sec:Insertar-Código-TeX" +name "sec:Insertar-Codigo-TeX" \end_inset @@ -5738,14 +5738,10 @@ labelitem \end_layout \begin_layout Itemize - -\lang english \begin_inset Argument item:1 status open \begin_layout Plain Layout - -\lang english \begin_inset ERT status open @@ -5767,12 +5763,8 @@ star \end_inset - -\lang spanish -Especifica cada entrada individual empezando cada ítem con el símbolo escogido - encerrado entre -\lang english -a + Especifica cada entrada individual empezando cada ítem con el símbolo escogido + encerrado entre a \begin_inset Quotes eld \end_inset @@ -5785,9 +5777,7 @@ Custom Item Insert\SpecialChar menuseparator Custom Item \family default -) -\lang spanish - y en +) y en \begin_inset Flex Code status collapsed @@ -16468,7 +16458,7 @@ Consulta la sección \begin_inset CommandInset ref LatexCommand ref -reference "sec:Insertar-Código-TeX" +reference "sec:Insertar-Codigo-TeX" \end_inset
