Re: [LyX/master] Docstringify getLongString in general and preamble snippets in particular

2016-10-20 Thread Jean-Marc Lasgouttes

Le 18/10/2016 à 19:59, Guillaume Munch a écrit :

From what I got from Georg's explanations, there's already a policy
which is quite clear: std::string must only contain ASCII. Therefore any
code using std::string in UTF-8 must be converted to use docstring instead.


That makes much sense, but I did not find it written this clearly in our 
docs.


JMarc



Re: [LyX/master] Docstringify getLongString in general and preamble snippets in particular

2016-10-18 Thread Guillaume Munch

Le 18/10/2016 à 09:44, Jean-Marc Lasgouttes a écrit :


I agree though that it is always annoying to have to guess what kind of
string is needed. I do not think that we implement a clear policy on
that. It would be nice to have one, so that we agree on what should be
what.



From what I got from Georg's explanations, there's already a policy
which is quite clear: std::string must only contain ASCII. Therefore any
code using std::string in UTF-8 must be converted to use docstring instead.




Re: [LyX/master] Docstringify getLongString in general and preamble snippets in particular

2016-10-18 Thread Jean-Marc Lasgouttes

Le 18/10/2016 à 01:08, Guillaume Munch a écrit :

Le 17/10/2016 à 00:35, Guillaume Munch a écrit :

commit 1f945177b9628b213c60872df88f2d155c3d6c54
Author: Guillaume Munch 
Date:   Sun Sep 25 12:37:40 2016 +0200

Docstringify getLongString in general and preamble snippets in
particular

Prepare ground for TexRow InPreamble



I can rename getLongString into getLongDocstring if people are more
comfortable with that.


We already have many 'docstring asString()' methods, so I am not sure we 
need that.


I agree though that it is always annoying to have to guess what kind of 
string is needed. I do not think that we implement a clear policy on 
that. It would be nice to have one, so that we agree on what should be what.


JMarc



Re: [LyX/master] Docstringify getLongString in general and preamble snippets in particular

2016-10-17 Thread Guillaume Munch

Le 17/10/2016 à 00:35, Guillaume Munch a écrit :

commit 1f945177b9628b213c60872df88f2d155c3d6c54
Author: Guillaume Munch 
Date:   Sun Sep 25 12:37:40 2016 +0200

Docstringify getLongString in general and preamble snippets in particular

Prepare ground for TexRow InPreamble



I can rename getLongString into getLongDocstring if people are more
comfortable with that.