Re: Make the math package loading automatic

[Jean-Pierre Chrétien]

Le 23/10/2017 à 08:28, Scott Kostyshak a écrit :

On Fri, Oct 20, 2017 at 09:01:02PM +, Scott Kostyshak wrote:


That way I can run the ctests just to double-check.


Thanks for sending me the patch. I checked and there are no changes in
ctests (with respect to 71a35ea) so I think we are good to go.


Done at 95f60915a7 (2.3.x) and 1720f54b41 (master).

--
Jean-Pierre

Re: Make the math package loading automatic

[Scott Kostyshak]

On Fri, Oct 20, 2017 at 09:01:02PM +, Scott Kostyshak wrote:

> That way I can run the ctests just to double-check.

Thanks for sending me the patch. I checked and there are no changes in
ctests (with respect to 71a35ea) so I think we are good to go.

Scott


signature.asc
Description: PGP signature

Re: Make the math package loading automatic

[Scott Kostyshak]

On Thu, Oct 19, 2017 at 01:07:29PM +, Jean-Pierre Chrétien wrote:
> Le 07/05/2017 à 21:58, Jean-Pierre Chrétien a écrit :
> 
> > 
> > What do you think? Should I parse the files to find \usepackage{xxx}
> > command in preambles, where xxx is one of the ten math packages managed
> > by math options
> 
> I did not find any occurrence.
> 
> > or is it sufficient to have no ctest failure?
> > 
> 
> I reran the test procedure of these changes in math options on recent master
> and documented it precisely in ticket #10661. The changes seem safe to me,
> and below is the beginning of a commit appropriate to perform them. Can it
> go to master ?
> It is also candidate to 2.3.x (and maybe to 2.2.x too).

Thanks for your work on this, Jean-Pierre, and for your detailed notes
on the ticket. Do you have a full patch for the 2.3.x branch? If you do
not want to send a large file to the list, you can send it to me
privately.

That way I can run the ctests just to double-check.

Scott


signature.asc
Description: PGP signature

Re: Make the math package loading automatic

[Jean-Pierre Chrétien]

Le 07/05/2017 à 21:58, Jean-Pierre Chrétien a écrit :



What do you think? Should I parse the files to find \usepackage{xxx} command in 
preambles, where xxx is one of the ten math packages managed by math options


I did not find any occurrence.


or is it sufficient to have no ctest failure?



I reran the test procedure of these changes in math options on recent master and 
documented it precisely in ticket #10661. The changes seem safe to me, and below 
is the beginning of a commit appropriate to perform them. Can it go to master ?

It is also candidate to 2.3.x (and maybe to 2.2.x too).


Jean-Pierre


commit ee85f40c1f7a2938515ff82853c3bf00130d862b
Author: jpc 
Date:   Thu Oct 19 14:47:51 2017 +0200

 Turn 'Do not load' math option to 'Automatic' (ticket 10661)

diff --git a/lib/doc/Additional.lyx b/lib/doc/Additional.lyx
index f3c23a515d..57f948fc45 100644
--- a/lib/doc/Additional.lyx
+++ b/lib/doc/Additional.lyx
@@ -86,14 +86,14 @@ shapepar
 \use_geometry false
 \use_package amsmath 1
 \use_package amssymb 1
-\use_package cancel 0
-\use_package esint 0
+\use_package cancel 1
+\use_package esint 1
 \use_package mathdots 1
-\use_package mathtools 0
+\use_package mathtools 1
 \use_package mhchem 1
-\use_package stackrel 0
-\use_package stmaryrd 0
-\use_package undertilde 0
+\use_package stackrel 1
+\use_package stmaryrd 1
+\use_package undertilde 1
 \cite_engine basic
 \cite_engine_type default
 \biblio_style plain
diff --git a/lib/doc/Customization.lyx b/lib/doc/Customization.lyx
index ed456e0619..cb81a847e8 100644
--- a/lib/doc/Customization.lyx
+++ b/lib/doc/Customization.lyx
@@ -82,16 +82,16 @@ logicalmkup
 \pdf_quoted_options "linkcolor=black, citecolor=black, urlcolor=blue, 
filecolor=blue,pdfpagelayout=OneColumn, pdfnewwindow=true, pdfstartview=XYZ, 
plainpages=false"

 \papersize default
 \use_geometry false
-\use_package amsmath 0
-\use_package amssymb 0
-\use_package cancel 0
-\use_package esint 0
+\use_package amsmath 1
+\use_package amssymb 1
+\use_package cancel 1
+\use_package esint 1
 \use_package mathdots 1
-\use_package mathtools 0
-\use_package mhchem 0
-\use_package stackrel 0
-\use_package stmaryrd 0
-\use_package undertilde 0
+\use_package mathtools 1
+\use_package mhchem 1
+\use_package stackrel 1
+\use_package stmaryrd 1
+\use_package undertilde 1
 \cite_engine basic
 \cite_engine_type default
 \biblio_style plain
diff --git a/lib/doc/Development.lyx b/lib/doc/Development.lyx
index 845f22aaa6..2998d0596f 100644
[snip]