Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Kornel Benko]

Am Mittwoch, 24. Januar 2018 um 16:38:30, schrieb Guenter Milde 

> Dear Kornel, dear LyX developers,
> 
> On 2018-01-24, Kornel Benko wrote:
> 
> > Total down to 31 fails:
> 
> Unfortunately, now we are left with some more complex ones:
> 
> > 1507 - export/doc/EmbeddedObjects_lyx16 (Failed)
> 
> Seems down to conversion of latex arguments (OptArg / Argument).
> 
> conversion emits “Warning: Lyx2lyx knows nothing about module
> 'graphicboxes'. Please check if short title insets have been converted
> correctly. “
> Unfortunatly, they have not.
> 
> > 3609 - export/examples/modernCV_lyx16 (Failed)
> 
> Also a problem with multiple LaTeX arguments. modernCV is a complex class
> with heavy use of optional arguments. Fails to compile afte the first
> round-trip with ! LaTeX Error: Missing \begin{document}.
> 
> Maybe we should just admit/document that this is too complex for LyX < 2.1.
> 
> > 3335 - export/examples/beamer_lyx16 (Failed)
> 
> Beamer is another example of a complex class with heavy changes...
> 
> > 4258 - export/examples/xyfigure_lyx16 (Failed)
> > 4259 - export/examples/xyfigure_lyx21 (Failed)
> > 4274 - export/examples/xypic_lyx16 (Failed)
> > 4275 - export/examples/xypic_lyx21 (Failed)
> 
> Fixed.
> 
> > 4482 - export/examples/de/MultilingualCaptions_lyx16 (Failed)
> 
> Also a module with multiple LaTeX arguments:
> 
>   Warning: Lyx2lyx knows nothing about module 'bicaption'. Please check
>   if short title insets have been converted correctly.
> 
> 
> Failures in translated documents are expected.
> 
> I compiled some dedicated minimal example files - maybe we need to invert
> them. Also, they can be ignored for all tests except lyx2lyx.

Thanks, this new 'export/lyx2lyx.*lyx[12][1236]' tests all pass.
Done.

> Günter

So, here the remaining 23 tests:
  Test #1571: export/doc/EmbeddedObjects_lyx16
  Test #2047: export/doc/de/EmbeddedObjects_lyx16
  Test #2239: export/doc/es/EmbeddedObjects_lyx16
  Test #2447: export/doc/fr/EmbeddedObjects_lyx16
  Test #2771: export/doc/ja/EmbeddedObjects_lyx16
  Test #3273: export/examples/MultilingualCaptions_lyx16
  Test #3399: export/examples/beamer_lyx16
  Test #3406: export/examples/beamerlyxexample1_lyx16
  Test #3673: export/examples/modernCV_lyx16
  Test #4546: export/examples/de/MultilingualCaptions_lyx16
  Test #4592: export/examples/de/beamer_lyx16
  Test #4837: export/examples/es/modernCV_lyx16
  Test #5027: export/examples/fr/MultilingualCaptions_lyx16
  Test #5066: export/examples/fr/beamer_lyx16
  Test #5421: export/examples/ja/MultilingualCaptions_lyx16
  Test #5430: export/examples/ja/beamer_lyx16
  Test #6174: export/templates/beamer-conference-ornate-20min_lyx16
  Test #6198: export/templates/de_beamer-conference-ornate-20min_lyx16
  Test #6262: export/templates/es_beamer-conference-ornate-20min_lyx16
  Test #6278: export/templates/fr_beamer-conference-ornate-20min_lyx16
  Test #6342: export/templates/ja_beamer-conference-ornate-20min_lyx16

The situation is much better than before. I am not sure, if we should 
disable/ignore these tests.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Guenter Milde]

Dear Kornel, dear LyX developers,

On 2018-01-24, Kornel Benko wrote:

> Total down to 31 fails:

Unfortunately, now we are left with some more complex ones:

>   1507 - export/doc/EmbeddedObjects_lyx16 (Failed)

Seems down to conversion of latex arguments (OptArg / Argument).

conversion emits “Warning: Lyx2lyx knows nothing about module
'graphicboxes'. Please check if short title insets have been converted
correctly. “
Unfortunatly, they have not.

>   3609 - export/examples/modernCV_lyx16 (Failed)

Also a problem with multiple LaTeX arguments. modernCV is a complex class
with heavy use of optional arguments. Fails to compile afte the first
round-trip with ! LaTeX Error: Missing \begin{document}.

Maybe we should just admit/document that this is too complex for LyX < 2.1.

>   3335 - export/examples/beamer_lyx16 (Failed)

Beamer is another example of a complex class with heavy changes...

>   4258 - export/examples/xyfigure_lyx16 (Failed)
>   4259 - export/examples/xyfigure_lyx21 (Failed)
>   4274 - export/examples/xypic_lyx16 (Failed)
>   4275 - export/examples/xypic_lyx21 (Failed)

Fixed.

>   4482 - export/examples/de/MultilingualCaptions_lyx16 (Failed)

Also a module with multiple LaTeX arguments:

  Warning: Lyx2lyx knows nothing about module 'bicaption'. Please check
  if short title insets have been converted correctly.


Failures in translated documents are expected.

I compiled some dedicated minimal example files - maybe we need to invert
them. Also, they can be ignored for all tests except lyx2lyx.


Günter

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Kornel Benko]

Am Dienstag, 23. Januar 2018 um 23:52:30, schrieb Guenter Milde 

> On 2018-01-23, Kornel Benko wrote:
> > Am Dienstag, 23. Januar 2018 um 13:07:53, schrieb Guenter Milde 
> > 
> >> On 2018-01-23, Kornel Benko wrote:
> 
> 
> > Yes, this reduced also the number of _lyx22 failed tests to 2:
> > 3699 - export/examples/seminar_lyx21 (Failed)
> > 5068 - export/examples/fr/seminar_lyx21 (Failed)
> 
> Actually _lyx21 tests. Fixed. (Also the corrupted seminar examples.)
> 
> >> >> > Now, for example, export/doc/nb/Tutorial_lyx16 adds at each run
> >> >> > following data to the created lyx-file.
> 
> 
> > and the number of _lyx16 failed tests to 38:
> > 1587 - export/doc/Math_lyx16 (Failed)
> 
> Fixed as well.
> Will commit soon.
> 
> Günter

Total down to 31 fails:
1507 - export/doc/EmbeddedObjects_lyx16 (Failed)
1983 - export/doc/de/EmbeddedObjects_lyx16 (Failed)
2175 - export/doc/es/EmbeddedObjects_lyx16 (Failed)
2383 - export/doc/fr/EmbeddedObjects_lyx16 (Failed)
2707 - export/doc/ja/EmbeddedObjects_lyx16 (Failed)
3209 - export/examples/MultilingualCaptions_lyx16 (Failed)
3335 - export/examples/beamer_lyx16 (Failed)
3342 - export/examples/beamerlyxexample1_lyx16 (Failed)
3609 - export/examples/modernCV_lyx16 (Failed)
4258 - export/examples/xyfigure_lyx16 (Failed)
4259 - export/examples/xyfigure_lyx21 (Failed)
4274 - export/examples/xypic_lyx16 (Failed)
4275 - export/examples/xypic_lyx21 (Failed)
4482 - export/examples/de/MultilingualCaptions_lyx16 (Failed)
4528 - export/examples/de/beamer_lyx16 (Failed)
4773 - export/examples/es/modernCV_lyx16 (Failed)
4963 - export/examples/fr/MultilingualCaptions_lyx16 (Failed)
5002 - export/examples/fr/beamer_lyx16 (Failed)
5115 - export/examples/fr/xyfigure_lyx16 (Failed)
5116 - export/examples/fr/xyfigure_lyx21 (Failed)
5131 - export/examples/fr/xypic_lyx16 (Failed)
5132 - export/examples/fr/xypic_lyx21 (Failed)
5357 - export/examples/ja/MultilingualCaptions_lyx16 (Failed)
5366 - export/examples/ja/beamer_lyx16 (Failed)
5416 - export/examples/ja/xypic_lyx16 (Failed)
5417 - export/examples/ja/xypic_lyx21 (Failed)
6110 - export/templates/beamer-conference-ornate-20min_lyx16 (Failed)
6134 - export/templates/de_beamer-conference-ornate-20min_lyx16 (Failed)
6198 - export/templates/es_beamer-conference-ornate-20min_lyx16 (Failed)
6214 - export/templates/fr_beamer-conference-ornate-20min_lyx16 (Failed)
6278 - export/templates/ja_beamer-conference-ornate-20min_lyx16 (Failed)

Good progress!

Kornel


signature.asc
Description: This is a digitally signed message part.

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Guenter Milde]

On 2018-01-23, Kornel Benko wrote:
> Am Dienstag, 23. Januar 2018 um 13:07:53, schrieb Guenter Milde 
> 
>> On 2018-01-23, Kornel Benko wrote:


> Yes, this reduced also the number of _lyx22 failed tests to 2:
>   3699 - export/examples/seminar_lyx21 (Failed)
>   5068 - export/examples/fr/seminar_lyx21 (Failed)

Actually _lyx21 tests. Fixed. (Also the corrupted seminar examples.)

>> >> > Now, for example, export/doc/nb/Tutorial_lyx16 adds at each run
>> >> > following data to the created lyx-file.


> and the number of _lyx16 failed tests to 38:
>   1587 - export/doc/Math_lyx16 (Failed)

Fixed as well.
Will commit soon.

Günter

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Kornel Benko]

Am Dienstag, 23. Januar 2018 um 13:07:53, schrieb Guenter Milde 

> > Yes. Should be maximal 3 IMHO.
> 
> Could you try something like:
> 
> * pull  8da6cdcf23d042cf431a
> * set max-round-trips to 3 and test for new failures.

This increased the count to 56.
Setting the value to 4: ==> 55
Setting the value to 5: ==> 55
Setting the value to 6: ==> 55
...

This is with the commit 67eca41.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Kornel Benko]

Am Dienstag, 23. Januar 2018 um 13:07:53, schrieb Guenter Milde 

> Dear Kornel,
> 
> On 2018-01-23, Kornel Benko wrote:
> > Am Montag, 22. Januar 2018 um 22:37:36, schrieb Guenter Milde 
> > 
> >> On 2018-01-22, Kornel Benko wrote:
> 
> ...
> 
> >> > I expanded the lyx2lyx test so, the an error is emitted at 10th
> >> > repeated run to export lyx16x.
> 
> >> > If two consecutive created lyx-files are identical, the test stops
> >> > without error. if a created lyx-file is not loadable, test stops with
> >> > error.
> 
> >> Could you post (or mail me, if it is too large) a list of the
> >> tests that fail with the 10th round-trip?
> 
> > Yes, I can. But there are too many.
> > 15 tests for _lyx22
> > 17 tests for _lyx21
> > 77 tests for _lyx16
> 
> > Better to start with _lyx22 tests, because they seem to accumulate.
> 
> ...
> 
> The _lyx22 tests should be fixed with 8da6cdcf23d042cf431a.

Yes, this reduced also the number of _lyx22 failed tests to 2:
3699 - export/examples/seminar_lyx21 (Failed)
5068 - export/examples/fr/seminar_lyx21 (Failed)

> >> > Now, for example, export/doc/nb/Tutorial_lyx16 adds at each run following
> >> > data to the created lyx-file.
> 
> >> >> % Added by lyx2lyx
> >> >> %  for proper underlining
> >> >> \PassOptionsToPackage{normalem}{ulem}
> >> >> \usepackage{ulem}
> >> >> \let\cite@rig\cite
> >> >> \newcommand{\b@xcite}[2][\%]{\def\def@pt{\%}\def\pas@pt{#1}
> >> >>   \mbox{\ifx\def@pt\pas@pt\cite@rig{#2}\else\cite@rig[#1]{#2}\fi}}
> >> >> \renewcommand{\underbar}[1]{{\let\cite\b@xcite\uline{#1}}}
> 
> >> > Though this creates loadable file, it is no longer compilable.
> >> > Pdf-exporting such a file.
> 
> This is fixed as well.

and the number of _lyx16 failed tests to 38:
1507 - export/doc/EmbeddedObjects_lyx16 (Failed)
1587 - export/doc/Math_lyx16 (Failed)
1919 - export/doc/de/Additional_lyx16 (Failed)
1935 - export/doc/de/Customization_lyx16 (Failed)
1983 - export/doc/de/EmbeddedObjects_lyx16 (Failed)
2031 - export/doc/de/Math_lyx16 (Failed)
2079 - export/doc/de/UserGuide_lyx16 (Failed)
2175 - export/doc/es/EmbeddedObjects_lyx16 (Failed)
2223 - export/doc/es/Math_lyx16 (Failed)
2383 - export/doc/fr/EmbeddedObjects_lyx16 (Failed)
2431 - export/doc/fr/Math_lyx16 (Failed)
2479 - export/doc/fr/UserGuide_lyx16 (Failed)
2707 - export/doc/ja/EmbeddedObjects_lyx16 (Failed)
2743 - export/doc/ja/Math_lyx16 (Failed)
2775 - export/doc/ja/UserGuide_lyx16 (Failed)
3101 - export/doc/zh_CN/Tutorial_lyx16 (Failed)
3209 - export/examples/MultilingualCaptions_lyx16 (Failed)
3225 - export/examples/PDF-comment_lyx16 (Failed)
3335 - export/examples/beamer_lyx16 (Failed)
3342 - export/examples/beamerlyxexample1_lyx16 (Failed)
3609 - export/examples/modernCV_lyx16 (Failed)
3698 - export/examples/seminar_lyx16 (Failed)
4482 - export/examples/de/MultilingualCaptions_lyx16 (Failed)
4498 - export/examples/de/PDF-comment_lyx16 (Failed)
4528 - export/examples/de/beamer_lyx16 (Failed)
4773 - export/examples/es/modernCV_lyx16 (Failed)
4931 - export/examples/fr/Foils_lyx16 (Failed)
4963 - export/examples/fr/MultilingualCaptions_lyx16 (Failed)
4979 - export/examples/fr/PDF-comment_lyx16 (Failed)
5002 - export/examples/fr/beamer_lyx16 (Failed)
5067 - export/examples/fr/seminar_lyx16 (Failed)
5357 - export/examples/ja/MultilingualCaptions_lyx16 (Failed)
5366 - export/examples/ja/beamer_lyx16 (Failed)
6110 - export/templates/beamer-conference-ornate-20min_lyx16 (Failed)
6134 - export/templates/de_beamer-conference-ornate-20min_lyx16 (Failed)
6198 - export/templates/es_beamer-conference-ornate-20min_lyx16 (Failed)
6214 - export/templates/fr_beamer-conference-ornate-20min_lyx16 (Failed)
6278 - export/templates/ja_beamer-conference-ornate-20min_lyx16 (Failed)

> ...
> 
> >> Hopefully, we can reduce the maximum number of round-trips for most
> >> documents.
> 
> > Yes. Should be maximal 3 IMHO.
> 
> Could you try something like:
> 
> * pull  8da6cdcf23d042cf431a
> * set max-round-trips to 3 and test for new failures.

OK. Will report.

> Thanks,
> 
> Günter

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Guenter Milde]

Dear Kornel,

On 2018-01-23, Kornel Benko wrote:
> Am Montag, 22. Januar 2018 um 22:37:36, schrieb Guenter Milde 
> 
>> On 2018-01-22, Kornel Benko wrote:

...

>> > I expanded the lyx2lyx test so, the an error is emitted at 10th
>> > repeated run to export lyx16x.

>> > If two consecutive created lyx-files are identical, the test stops
>> > without error. if a created lyx-file is not loadable, test stops with
>> > error.

>> Could you post (or mail me, if it is too large) a list of the
>> tests that fail with the 10th round-trip?

> Yes, I can. But there are too many.
> 15 tests for _lyx22
> 17 tests for _lyx21
> 77 tests for _lyx16

> Better to start with _lyx22 tests, because they seem to accumulate.

...

The _lyx22 tests should be fixed with 8da6cdcf23d042cf431a.

>> > Now, for example, export/doc/nb/Tutorial_lyx16 adds at each run following
>> > data to the created lyx-file.

>> >> % Added by lyx2lyx
>> >> %  for proper underlining
>> >> \PassOptionsToPackage{normalem}{ulem}
>> >> \usepackage{ulem}
>> >> \let\cite@rig\cite
>> >> \newcommand{\b@xcite}[2][\%]{\def\def@pt{\%}\def\pas@pt{#1}
>> >>   \mbox{\ifx\def@pt\pas@pt\cite@rig{#2}\else\cite@rig[#1]{#2}\fi}}
>> >> \renewcommand{\underbar}[1]{{\let\cite\b@xcite\uline{#1}}}

>> > Though this creates loadable file, it is no longer compilable.
>> > Pdf-exporting such a file.

This is fixed as well.

...

>> Hopefully, we can reduce the maximum number of round-trips for most
>> documents.

> Yes. Should be maximal 3 IMHO.

Could you try something like:

* pull  8da6cdcf23d042cf431a
* set max-round-trips to 3 and test for new failures.

Thanks,

Günter

Re: lyx2lyx round-trip (was: lyx2lyx problems ...)

[Kornel Benko]

Am Montag, 22. Januar 2018 um 22:37:36, schrieb Guenter Milde 

> On 2018-01-22, Kornel Benko wrote:
> 
> > Thanks to Günter, the ligature-problem is gone.
> 
> Unfortunately, the ligature-problem is not completely gone, just the
> tests pass.
> 
> > I expanded the lyx2lyx test so, the an error is emitted at 10th
> > repeated run to export lyx16x.
> 
> > If two consecutive created lyx-files are identical, the test stops
> > without error. if a created lyx-file is not loadable, test stops with
> > error.
> 
> Could you post (or mail me, if it is too large) a list of the
> tests that fail with the 10th round-trip?

Yes, I can. But there are too many.
15 tests for _lyx22
17 tests for _lyx21
77 tests for _lyx16

Better to start with _lyx22 tests, because they seem to accumulate.
  Test #277: export/export/MissingEndTagDiv_lyx22
  Test #1429: export/doc/Additional_lyx22
  Test #1445: export/doc/Customization_lyx22
  Test #1712: export/doc/attic/eu_Additional_lyx22
  Test #1776: export/doc/attic/it_Customization_lyx22
  Test #1817: export/doc/attic/pl_Additional_lyx22
  Test #1921: export/doc/de/Additional_lyx22
  Test #1937: export/doc/de/Customization_lyx22
  Test #2113: export/doc/es/Additional_lyx22
  Test #2129: export/doc/es/Customization_lyx22
  Test #2321: export/doc/fr/Additional_lyx22
  Test #2337: export/doc/fr/Customization_lyx22
  Test #2673: export/doc/ja/Additional_lyx22
  Test #2682: export/doc/ja/Customization_lyx22
  Test #4214: export/examples/thesis/thesis_lyx22

> > Now, for example, export/doc/nb/Tutorial_lyx16 adds at each run following
> > data to the created lyx-file.
> 
> >> % Added by lyx2lyx
> >> %  for proper underlining
> >> \PassOptionsToPackage{normalem}{ulem}
> >> \usepackage{ulem}
> >> \let\cite@rig\cite
> >> \newcommand{\b@xcite}[2][\%]{\def\def@pt{\%}\def\pas@pt{#1}
> >>   \mbox{\ifx\def@pt\pas@pt\cite@rig{#2}\else\cite@rig[#1]{#2}\fi}}
> >> \renewcommand{\underbar}[1]{{\let\cite\b@xcite\uline{#1}}}
> 
> > Though this creates loadable file, it is no longer compilable.
> > Pdf-exporting such a file.
> 
> 
> > ! LaTeX Error: Command \b@xcite already defined.
> >Or name \end... illegal, see p.192 of the manual.
> ...
> 
> Yes, I realized this when exploring the UserGuide_lyx16 error.
> I will have a look into this and similar round-trip issues.
> Hopefully, we can reduce the maximum number of round-trips for most documents.

Yes. Should be maximal 3 IMHO.

> Thanks,
> Günter
> 

Kornel

signature.asc
Description: This is a digitally signed message part.

lyx2lyx round-trip (was: lyx2lyx problems ...)

[Guenter Milde]

On 2018-01-22, Kornel Benko wrote:

> Thanks to Günter, the ligature-problem is gone.

Unfortunately, the ligature-problem is not completely gone, just the
tests pass.

> I expanded the lyx2lyx test so, the an error is emitted at 10th
> repeated run to export lyx16x.

> If two consecutive created lyx-files are identical, the test stops
> without error. if a created lyx-file is not loadable, test stops with
> error.

Could you post (or mail me, if it is too large) a list of the
tests that fail with the 10th round-trip?

> Now, for example, export/doc/nb/Tutorial_lyx16 adds at each run following
> data to the created lyx-file.

>> % Added by lyx2lyx
>> %  for proper underlining
>> \PassOptionsToPackage{normalem}{ulem}
>> \usepackage{ulem}
>> \let\cite@rig\cite
>> \newcommand{\b@xcite}[2][\%]{\def\def@pt{\%}\def\pas@pt{#1}
>>   \mbox{\ifx\def@pt\pas@pt\cite@rig{#2}\else\cite@rig[#1]{#2}\fi}}
>> \renewcommand{\underbar}[1]{{\let\cite\b@xcite\uline{#1}}}

> Though this creates loadable file, it is no longer compilable.
> Pdf-exporting such a file.


>   ! LaTeX Error: Command \b@xcite already defined.
>  Or name \end... illegal, see p.192 of the manual.
...

Yes, I realized this when exploring the UserGuide_lyx16 error.
I will have a look into this and similar round-trip issues.
Hopefully, we can reduce the maximum number of round-trips for most documents.

Thanks,
Günter