Re: New version 2.1.3

2015-03-12 Thread Jürgen Spitzmüller
2015-03-10 17:55 GMT+01:00 Jürgen Spitzmüller:

> 2015-03-09 18:36 GMT+01:00 Jürgen Spitzmüller:
>
>> Jean-Marc Lasgouttes  wrote:
>>
>>> I checked that the \protect bug is fixed, but now we have to deal with
>>> another one, seen above in the caption. I do not know what caused this
>>> actually, neither why LaTeX complains. Is it the \par?
>>>
>>
>> Yes. I have not tested (and unfortunately no time to do so), but I
>> suppose we need to adjust this commit:
>> http://www.lyx.org/trac/changeset/2eeed6cf/lyxgit
>>
>
>
> Looking more closely, I suspect the reason is that InsetLayout:Caption
> does not have MultiPar explicitly disabled. Rather than that,
> LFUN_PARAGRAPH_BREAK is explicitly disabled in InsetCaption::getStatus.
> This looks like a forgotten bit in the InsetLayout-ification of the caption
> inset.
>

I verified my hypothesis and committed the respective fix at
http://www.lyx.org/trac/changeset/9d824a04d11c3223db26d2fe146e86e90a432a6e/lyxgit

This should also go to branch IMHO.

Jürgen


Re: New version 2.1.3

2015-03-10 Thread Richard Heck

On 03/10/2015 01:36 PM, Jürgen Spitzmüller wrote:

2015-03-10 17:55 GMT+01:00 Jürgen Spitzmüller:

2015-03-09 18:36 GMT+01:00 Jürgen Spitzmüller:

Jean-Marc Lasgouttes mailto:lasgout...@lyx.org>> wrote:

I checked that the \protect bug is fixed, but now we have
to deal with another one, seen above in the caption. I do
not know what caused this actually, neither why LaTeX
complains. Is it the \par?


Yes. I have not tested (and unfortunately no time to do so),
but I suppose we need to adjust this commit:
http://www.lyx.org/trac/changeset/2eeed6cf/lyxgit



Looking more closely, I suspect the reason is that
InsetLayout:Caption does not have MultiPar explicitly disabled.
Rather than that, LFUN_PARAGRAPH_BREAK is explicitly disabled in
InsetCaption::getStatus. This looks like a forgotten bit in the
InsetLayout-ification of the caption inset.


I verified my hypothesis and committed the respective fix at
http://www.lyx.org/trac/changeset/9d824a04d11c3223db26d2fe146e86e90a432a6e/lyxgit

This should also go to branch IMHO.


OK.

rh



Re: New version 2.1.3

2015-03-10 Thread Jürgen Spitzmüller
2015-03-09 18:36 GMT+01:00 Jürgen Spitzmüller:

> Jean-Marc Lasgouttes  wrote:
>
>> I checked that the \protect bug is fixed, but now we have to deal with
>> another one, seen above in the caption. I do not know what caused this
>> actually, neither why LaTeX complains. Is it the \par?
>>
>
> Yes. I have not tested (and unfortunately no time to do so), but I suppose
> we need to adjust this commit:
> http://www.lyx.org/trac/changeset/2eeed6cf/lyxgit
>


Looking more closely, I suspect the reason is that InsetLayout:Caption does
not have MultiPar explicitly disabled. Rather than that,
LFUN_PARAGRAPH_BREAK is explicitly disabled in InsetCaption::getStatus.
This looks like a forgotten bit in the InsetLayout-ification of the caption
inset.

Jürgen


>
>
>>
>> JMarc
>>
>>
>


Re: New version 2.1.3

2015-03-09 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes  wrote:

> I checked that the \protect bug is fixed, but now we have to deal with
> another one, seen above in the caption. I do not know what caused this
> actually, neither why LaTeX complains. Is it the \par?
>

Yes. I have not tested (and unfortunately no time to do so), but I suppose
we need to adjust this commit:
http://www.lyx.org/trac/changeset/2eeed6cf/lyxgit


>
> JMarc
>
>


Re: New version 2.1.3

2015-03-09 Thread Jean-Marc Lasgouttes

Le 09/03/2015 14:33, Scott Kostyshak a écrit :

47c47
< \protect\caption{{\small{}Enlargemen}}
---

\protect\caption{{\small{}Enlargemen}{\small \par}}


This seems to be related to http://www.lyx.org/trac/ticket/9421.
However that bug is fixed in master but I still cannot compile the
file on current master.




Can you create a bug report for this on http://www.lyx.org/trac ?


I checked that the \protect bug is fixed, but now we have to deal with 
another one, seen above in the caption. I do not know what caused this 
actually, neither why LaTeX complains. Is it the \par?


JMarc




Re: New version 2.1.3

2015-03-09 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 5:41 PM, Scott Kostyshak  wrote:
> On Tue, Feb 24, 2015 at 5:27 PM, Patrick Dupre  wrote:
>> Actually, it is due to the sub figure.
>> In the previous version it was OK.
>
> Thanks for the MWE. I confirm that for LyX 2.1.0 the compilation
> succeeds on tmp.lyx, but for 2.1.3 the compilation fails.
>
> The diff between the LaTeX (pdflatex) produced by the two versions is below:
>
> 1c1
> < %% LyX 2.1.0 created this file.  For more info, see http://www.lyx.org/.
> ---
>> %% LyX 2.1.3 created this file.  For more info, see http://www.lyx.org/.
> 41,42c41,42
> < \subfloat[Upper]{\begin{centering}
> <
> ---
>> \subfloat[Upper]{\protect\begin{centering}
>> \protect
> 47c47
> < \protect\caption{{\small{}Enlargemen}}
> ---
>> \protect\caption{{\small{}Enlargemen}{\small \par}}
>
> This seems to be related to http://www.lyx.org/trac/ticket/9421.
> However that bug is fixed in master but I still cannot compile the
> file on current master.
>
> Scott

Hi Patrick,

Can you create a bug report for this on http://www.lyx.org/trac ?

Best,

Scott


Re: New version 2.1.3

2015-02-24 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 5:27 PM, Patrick Dupre  wrote:
> Actually, it is due to the sub figure.
> In the previous version it was OK.

Thanks for the MWE. I confirm that for LyX 2.1.0 the compilation
succeeds on tmp.lyx, but for 2.1.3 the compilation fails.

The diff between the LaTeX (pdflatex) produced by the two versions is below:

1c1
< %% LyX 2.1.0 created this file.  For more info, see http://www.lyx.org/.
---
> %% LyX 2.1.3 created this file.  For more info, see http://www.lyx.org/.
41,42c41,42
< \subfloat[Upper]{\begin{centering}
<
---
> \subfloat[Upper]{\protect\begin{centering}
> \protect
47c47
< \protect\caption{{\small{}Enlargemen}}
---
> \protect\caption{{\small{}Enlargemen}{\small \par}}

This seems to be related to http://www.lyx.org/trac/ticket/9421.
However that bug is fixed in master but I still cannot compile the
file on current master.

Scott


Re: New version 2.1.3

2015-02-24 Thread Patrick Dupre
Actually, it is due to the sub figure.
In the previous version it was OK.

===
 Patrick DUPRÉ | | email: pdu...@gmx.com
 Laboratoire de Physico-Chimie de l'Atmosphère | |
 Université du Littoral-Côte d'Opale   | |
 Tel.  (33)-(0)3 28 23 76 12   | | Fax: 03 28 65 82 44
 189A, avenue Maurice Schumann | | 59140 Dunkerque, France
===


> Sent: Tuesday, February 24, 2015 at 11:18 PM
> From: "Scott Kostyshak" 
> To: "Patrick Dupre" 
> Cc: lyx 
> Subject: Re: New version 2.1.3
>
> On Tue, Feb 24, 2015 at 5:07 PM, Patrick Dupre  wrote:
> > Hello
> >
> > With the new version of lyx I get a compilation error
> > when I try to change the font size (eg small) in the caption of
> > a figure:
> 
> Hi Patrick,
> 
> Could you please send a minimal example
> (http://wiki.lyx.org/FAQ/MinimalExample) ? Also, I know I'm picky but
> for next time I find it helpful if there is a more descriptive title
> (e.g. "File no longer compiles with 2.1.3").
> 
> Which LyX version were you using before? This can help us narrow down
> the issue. If you're coming from 2.0.x, this might be a lyx2lyx bug.
> 
> Best,
> 
> Scott
>

tmp.lyx
Description: application/lyx


Re: New version 2.1.3

2015-02-24 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 5:07 PM, Patrick Dupre  wrote:
> Hello
>
> With the new version of lyx I get a compilation error
> when I try to change the font size (eg small) in the caption of
> a figure:

Hi Patrick,

Could you please send a minimal example
(http://wiki.lyx.org/FAQ/MinimalExample) ? Also, I know I'm picky but
for next time I find it helpful if there is a more descriptive title
(e.g. "File no longer compiles with 2.1.3").

Which LyX version were you using before? This can help us narrow down
the issue. If you're coming from 2.0.x, this might be a lyx2lyx bug.

Best,

Scott