Re: AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-10-23 Thread Alexander Scherbatiy
tests that expect that the scaled image by certain algorithm is returned. This is fixed by invoking the super.getScaledImage(width, height, hints) method in ToolkitImage in case if a high resolution image is not set. Thanks, Alexandr. On 10/22/2013 1:31 PM, Alexander Scherbatiy

Re: AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-10-29 Thread Alexander Scherbatiy
/25/2013 5:18 PM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.02/ - Scaled image width and height are transformed according to the AffineTransform type. - ToolkitImage subclass is used to hold @2x image instance

[8] Review request for 8024926 [macosx] AquaIcon HiDPI support

2013-10-29 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8024926 webrev: http://cr.openjdk.java.net/~alexsch/8024926/webrev.00 The fix returns a high resolution system icon in the overridden getScaledInstance(width, height, hints) method. The fix relies on the fix

Re: AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-05 Thread Alexander Scherbatiy
, Alexander Scherbatiy wrote: 2. I'm not sure that the proposed getScaledImageName() implementation in ScalableToolkitImage works perfectly for URLs like this: http://www.exampmle.com/dir/image In this case it will try to find 2x image here: http://www.exam...@2x.com/dir/image which doesn't look

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-06 Thread Alexander Scherbatiy
to call it and possibly to be a provider for it in JDK9... ...jim On 10/31/13 9:19 AM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.04/ The reflection is used to skip the Image.getScaledInstance() method call

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-21 Thread Alexander Scherbatiy
On 11/20/2013 3:17 PM, Jim Graham wrote: In looking through the ToolkitImage code some more it occurs to me that it was already designed (moreso in a previous life) to hold onto multiple representations of the image anyway. In a prior life in 1.0 and 1.1 it held separate ImageRepresentation

Re: Drawing HiDPI component to BufferedImage

2014-01-24 Thread Alexander Scherbatiy
Hi Hendrik, The API that allows to create custom images for HiDPI displays is only under discussion now. It can be found in the thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-January/006775.html It also contains a link to the patch that allows SunGraphics2D class to

Re: Nimbus color differences between JDK versions

2014-01-30 Thread Alexander Scherbatiy
Hi Robert, Could you send a sample that draws a JTree and set necessary icons/colors in the Nimbus LF to investigate the issue? Thanks, Alexandr. On 1/30/2014 12:52 PM, Robert Krüger wrote: Hi, we are in the process of migrating an application from Apple JDK 6 to OpenJDK 8, which

[9] Review request for 8033534 Get MultiResolution image from native system

2014-02-04 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8033534 webrev: http://cr.openjdk.java.net/~alexsch/8033534/webrev.00 - The method that gets a sorted array of NSImage representaion pixel sizes for the given image size is added - A MultiResolution image is

Re: [9] Review request for 8031573 [macosx] Checkmarks of JCheckBoxMenuItems aren't rendered in high resolution on Retina

2014-02-17 Thread Alexander Scherbatiy
On 2/14/2014 3:16 PM, Sergey Bylokhov wrote: On 2/14/14 2:32 PM, Alexander Scherbatiy wrote: On 2/14/2014 2:12 AM, Sergey Bylokhov wrote: Hi, Alexander. Did you check option of loading of the picture on demand?Since most of the time x2 version is useless on non hdpi and vice versa. Yes

Re: AWT Dev [9] Review request for 8031573 [macosx] Checkmarks of JCheckBoxMenuItems aren't rendered in high resolution on Retina

2014-02-25 Thread Alexander Scherbatiy
regards. Petr. On 18.02.2014, at 16:20, Sergey Bylokhov sergey.bylok...@oracle.com wrote: Hi, Alexander. The fix looks good then. On 17.02.2014 18:38, Alexander Scherbatiy wrote: On 2/14/2014 3:16 PM, Sergey Bylokhov wrote: On 2/14/14 2:32 PM, Alexander Scherbatiy wrote: On 2/14/2014 2:12 AM

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-02-26 Thread Alexander Scherbatiy
. Now we need to draw the image to region [300x300]. The resolution variant with size [350x350] will be used from the MultiResolution image. Thanks, Alexandr. Thank you. With best regards. Petr. On 26.02.2014, at 16:08, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Alexander Scherbatiy
variants. The ExceptionDescribe is left just for debugging purposes. Thanks, Alexandr. With best regards. Petr. On 04.03.2014, at 15:04, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Alexander Scherbatiy
to nativeGetNSImageRepresentationSizes will fail, will mean that some error exists in our code and it will be better to fail fast in this case, just return and throw and exception on java side. With best regards. Petr. On 04.03.2014, at 15:39, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: On 3/4/2014 3:30 PM

[9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8036598 webrev: http://cr.openjdk.java.net/~alexsch/8036598/webrev.00 The fix creates an AquaIcon based on resolution variants. It becomes possible after the fix 8033534 where CImage returns a

[9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-25 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8032667 webrev: http://cr.openjdk.java.net/~alexsch/8032667/webrev.00 High resolution image width and height were calculated using only scale factor in the AquaPainter class. The fix calculates image width

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-26 Thread Alexander Scherbatiy
list in case if they are not passed to the constructor. Thanks, Alexandr. On 3/26/2014 4:30 PM, Sergey Bylokhov wrote: Hello, Alexander. I think it will not work if the user set scale=1.5? On 3/26/14 4:18 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

2014-04-02 Thread Alexander Scherbatiy
the properly scaled image. Thanks, Alexandr. On 3/26/2014 6:15 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8038113 webrev: http://cr.openjdk.java.net/~alexsch/8038113/webrev.00 MultiResolution image is used

[9] Review request for 8039001 [macosx] Textfields in dialogs are disabled after using F3 on Mac OS X to select a window

2014-04-08 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8039001 webrev: http://cr.openjdk.java.net/~alexsch/8039001/webrev.00 NSRunningApplication active property is false when windowDidBecomeKey notification is received after switching from the Mission Control

Re: Checkmark in JCheckBoxMenuItem not HiDPI/Retina capable

2014-04-11 Thread Alexander Scherbatiy
don't see oversized checkmarks in the main menus. The oversized checkmark is still present in the popup menu after I restart the IDE. -- Eirik On 3/21/14, 10:50 AM, Hendrik Schreiber h...@tagtraum.com wrote: On Mar 21, 2014, at 15:40, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote

Re: Checkmark in JCheckBoxMenuItem not HiDPI/Retina capable

2014-04-14 Thread Alexander Scherbatiy
-dev@openjdk.java.net mailto:macosx-port-dev@openjdk.java.net, Alexander Scherbatiy alexandr.scherba...@oracle.com mailto:alexandr.scherba...@oracle.com Cc: Eirik Bakke eba...@mit.edu mailto:eba...@mit.edu Subject: Re: Checkmark in JCheckBoxMenuItem not HiDPI/Retina capable On Apr 11, 2014, at 18

Re: [9] Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor

2014-04-21 Thread Alexander Scherbatiy
createBufferedImage method does not create a BufferredImage any more, so it worths renaming. With best regards. Petr. On 15.04.2014, at 18:36, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8040279

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-05-12 Thread Alexander Scherbatiy
/browse/JDK-7124410 Thanks, Alexandr. On 4/25/2014 6:45 PM, Alexander Scherbatiy wrote: On 4/25/2014 2:17 AM, Jim Graham wrote: Hi Alexandr, I asked for who was requesting these facilities and you responded with the solution you are planning to provide. I don't care what the solution looks

Re: AWT Dev [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-05-19 Thread Alexander Scherbatiy
or the low-resolution image faster. Thanks, Alexandr. -phil. On 5/16/2014 9:16 AM, Alexander Scherbatiy wrote: Hi Phil, I need a reviewer from the 2d group for the fix. Could you take a look at the fix and review it? Thanks, Alexandr. On 5/12/2014 6:35 PM, Alexander Scherbatiy

Re: AWT Dev [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

2014-05-20 Thread Alexander Scherbatiy
Hello, Could you look at the fix? Thanks, Alexandr. On 4/30/2014 6:34 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8040291 webrev: http://cr.openjdk.java.net/~alexsch/8040291/webrev.00

Re: Odd behavior with transparent window getting shadow after toggling visibility

2014-12-05 Thread Alexander Scherbatiy
On 11/25/2014 10:47 PM, AJ Gregory wrote: If you run the class below on a RETINA MacBook Pro (OSX 10.10) the first time you see the JWindow it's a white circle with NO shadow, but then later when it calls setVisible(false) and setVisible(true) the circle has a shadow when it's made visible again

Re: java.lang.NoSuchMethodError: createImageUsingNativeSize error in 1.8.0_45

2015-07-23 Thread Alexander Scherbatiy
Could you file an issue on it: http://bugreport.java.com/bugreport Thanks, Alexandr. On 7/23/2015 2:27 PM, Paul Taylor wrote: On 23/07/2015 11:19, Paul Taylor wrote: This code that was used in some circumstances for dealing with single images dragged and drop from certain webbrowsers

Re: RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application(macos)

2015-10-22 Thread Alexander Scherbatiy
I have pushed your fix to the JDK 9: http://hg.openjdk.java.net/jdk9/client/jdk/rev/deb544c19dec Thanks, Alexandr. On 10/21/2015 8:59 PM, Sebastian Sickelmann wrote: On 10/20/2015 12:23 PM, Alexander Scherbatiy wrote: On 10/13/2015 10:32 PM, Sebastian Sickelmann wrote: On 10/08/2015

Re: RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application(macos)

2015-10-20 Thread Alexander Scherbatiy
On 10/13/2015 10:32 PM, Sebastian Sickelmann wrote: On 10/08/2015 01:06 PM, Alexander Scherbatiy wrote: Are you going to push the fix as part of other fixes for different JDK areas or as a separate fix? In the second case you need to file a new bug for it. I think the patches

Re: Bug: SystemFlavorMap.addFlavorForUnencodedNative ineffective on MacOS

2015-10-09 Thread Alexander Scherbatiy
Hello Mike, The initial Clipboard support in CToolkit in Mac OS X [1] recognizes only NSPasteboard data types that have "JAVA_DATAFLAVOR:" prefix: - +jlong indexForFormat(NSString *format) { ... +// If we don't recognize the format, but it's a Java "custom" format

Re: RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application

2015-10-06 Thread Alexander Scherbatiy
On 10/3/2015 5:40 AM, Stuart Marks wrote: On 9/28/15 2:03 AM, Alexander Scherbatiy wrote: Is it possible to use autoboxing in the fix instead of Boolean.valueOf(someBooleanVariable)? Hi, These cases are all interesting because they end up requiring boxed Boolean values, whether