Re: [153943] trunk/dports/science

2016-10-18 Thread Thibaut Paumard
Thanks David,

I have compiled some test programs provided with LORENE that make use of pgplot.

One can compile them without -lX11 and run the test with any of the pgplot 
variant without need for recompiling.

I will therefore remove -lX11 in the next commit.

Regards, Thibaut.


Le 18 oct. 2016 à 01:57, David Strubbe  a écrit :

> I guess the question is: is x11 definitely what pgplot should be linked with? 
> +x11 is an optional (though default) variant for pgplot (as below). Is it 
> necessary to use x11 for these LORENE codes to be compiled? For example, what 
> if they were to use +aquaterm?
> 
> pgplot @5.2.2_10 (graphics, devel)
> Variants: aquaterm, docs, dragonegg33, dragonegg34, g95, gcc44, 
> gcc45, gcc46, gcc47, gcc48, gcc49, gcc5, [+]gcc6, gcc7, [+]x11
> 
> Description:  The PGPLOT Graphics Subroutine Library is a Fortran- or 
> C-callable, device-independent graphics package for making simple scientific 
> graphs. It is intended for making
>   graphical images of publication quality with minimum 
> effort on the part of the user. For most applications, the program can be 
> device-independent, and the output can be
>   directed to the appropriate device at run time.
> Homepage: http://www.astro.caltech.edu/~tjp/pgplot/
> 
> Build Dependencies:   perl5, pkgconfig, gcc6
> Library Dependencies: libpng, zlib, xorg-libX11, libgcc
> Conflicts with:   miriad
> Platforms:darwin
> License:  Noncommercial
> Maintainers:  mcalh...@macports.org, openmaintai...@macports.org
> 
> 
> On Mon, Oct 17, 2016 at 11:38 AM, Thibaut Paumard  
> wrote:
> This is correct. I will emote the dependency.
> 
> Should I also remove -lX11 from LIB_PGPLOT, since libpgplot itself is linked 
> with -lX11?
> 
> Kind regards, Thibaut.
> 
> 
> Le 17 oct. 2016 à 20:12, David Strubbe  a écrit :
> 
>> It appears libX11, in the LIB_PGPLOT variable, is used in principle to 
>> compile some codes that are not in fact compiled in this package. It looks 
>> like X11 is only in fact used via pgplot.
>> 
>> On Mon, Oct 17, 2016 at 10:46 AM, Ryan Schmidt  
>> wrote:
>> 
>> > On Oct 16, 2016, at 11:57 PM, David Strubbe  wrote:
>> >
>> > Additionally, the dependency port:xorg-libX11 does not seem necessary: I 
>> > don't see any evidence in the build log that it is used, and the build 
>> > succeeds without it being active.
>> 
>> Are you sure? libX11 is mentioned in local_settings:
>> 
>> 
>> > > --- trunk/dports/science/LORENE/files/local_settings 
>> > >  (rev 0)
>> > > +++ trunk/dports/science/LORENE/files/local_settings  2016-10-16 
>> > > 17:41:08 UTC (rev 153943)
>> 
>> > > +# Graphical libraries: PGPLOT, PNG and X11
>> > > +# 
>> > > +LIB_PGPLOT = -lcpgplot -lpgplot -lX11
>> 
>> 
>> 
>> 
> 
> 

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153943] trunk/dports/science

2016-10-17 Thread David Strubbe
I guess the question is: is x11 definitely what pgplot should be linked
with? +x11 is an optional (though default) variant for pgplot (as below).
Is it necessary to use x11 for these LORENE codes to be compiled? For
example, what if they were to use +aquaterm?

pgplot @5.2.2_10 (graphics, devel)
Variants: aquaterm, docs, dragonegg33, dragonegg34, g95, gcc44,
gcc45, gcc46, gcc47, gcc48, gcc49, gcc5, [+]gcc6, gcc7, [+]x11

Description:  The PGPLOT Graphics Subroutine Library is a Fortran-
or C-callable, device-independent graphics package for making simple
scientific graphs. It is intended for making
  graphical images of publication quality with minimum
effort on the part of the user. For most applications, the program can be
device-independent, and the output can be
  directed to the appropriate device at run time.
Homepage: http://www.astro.caltech.edu/~tjp/pgplot/

Build Dependencies:   perl5, pkgconfig, gcc6
Library Dependencies: libpng, zlib, xorg-libX11, libgcc
Conflicts with:   miriad
Platforms:darwin
License:  Noncommercial
Maintainers:  mcalh...@macports.org, openmaintai...@macports.org


On Mon, Oct 17, 2016 at 11:38 AM, Thibaut Paumard 
wrote:

> This is correct. I will emote the dependency.
>
> Should I also remove -lX11 from LIB_PGPLOT, since libpgplot itself is
> linked with -lX11?
>
> Kind regards, Thibaut.
>
>
> Le 17 oct. 2016 à 20:12, David Strubbe  a écrit :
>
> It appears libX11, in the LIB_PGPLOT variable, is used in principle to
> compile some codes that are not in fact compiled in this package. It looks
> like X11 is only in fact used via pgplot.
>
> On Mon, Oct 17, 2016 at 10:46 AM, Ryan Schmidt 
> wrote:
>
>>
>> > On Oct 16, 2016, at 11:57 PM, David Strubbe 
>> wrote:
>> >
>> > Additionally, the dependency port:xorg-libX11 does not seem necessary:
>> I don't see any evidence in the build log that it is used, and the build
>> succeeds without it being active.
>>
>> Are you sure? libX11 is mentioned in local_settings:
>>
>>
>> > > --- trunk/dports/science/LORENE/files/local_settings
>>   (rev 0)
>> > > +++ trunk/dports/science/LORENE/files/local_settings  2016-10-16
>> 17:41:08 UTC (rev 153943)
>>
>> > > +# Graphical libraries: PGPLOT, PNG and X11
>> > > +# 
>> > > +LIB_PGPLOT = -lcpgplot -lpgplot -lX11
>>
>>
>>
>>
>
>
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153943] trunk/dports/science

2016-10-17 Thread Thibaut Paumard
I think this didn’t go to the list.

Le 17 oct. 2016 à 19:40, Paumard Thibaut <thibaut.paum...@obspm.fr> a écrit :

> Many thanks David,
> 
> Let me answer some of your questions:
> 
> Le Lundi 17 Octobre 2016 02:23 CEST, David Strubbe <dstru...@macports.org> a 
> écrit:
> 
>> Hi,
>> 
>> Let me add a few comments.
>> - The dependency for BLAS is wrong: the port OpenBLAS provides a library
>> -lopenblas not -lblas. Apparently the "lapack" port includes BLAS anyway.
>> To be simpler and more flexible, I suggest use of the linear algebra port
>> group I created to handle all this and also provide choices of different
>> optimized implementations (ATLAS, Accelerate, or OpenBLAS -- the port has
>> lapack included). See patch below.
> 
> Thanks, I've applied your patch. Does this warrant a rev bump? I would think 
> so, since the library may not be linked with the same version of blas and 
> lapack.
> 
>> - You are installing a lot of Makefiles and C source files -- is this on
>> purpose? It is somewhat unusual.
> 
> Yes, this is on purpose. Those are codes that, unfortunately, need to be 
> recompiled for each use case. So the scenario for using those codes from the 
> macports-installed package is to copy the folder for a given code to a place 
> with write access, configure it by putting the right parameter file in the 
> right place, set HOME_LORENE (see below), and run make.
> 
>> - You are putting everything in the lib directory. This should be reserved
>> for libraries. Headers should go in include; documentation or miscellaneous
>> things should go in share; etc.
> 
> The code is meant to be used that way. I don't want to diverge from what 
> upstream is doing: I could install the headers in ${prefix}/include etc., but 
> I would have to symlink from the "main" lorene directory.
> 
> To use the library, users are expected (by upstream) to set an environment 
> variable to the place that contains the compiled source code for lorene and 
> include $(HOME_LORENE)/local_settings.
> 
>> - Since there are tests apparently available, you should create a test
>> phase rather than install their files, so that users can run "port test".
> 
> Right, I should try and see which tests are suitable for that.
> 
> Kind regards, Thibaut.
> 
>> David
>> 
>> Index: Portfile
>> ===
>> --- Portfile(revision 153958)
>> +++ Portfile(working copy)
>> @@ -3,6 +3,7 @@
>> 
>> PortSystem  1.0
>> PortGroup   compilers 1.0
>> +PortGroup   linear_algebra 1.0
>> 
>> cvs.date   20160908
>> 
>> @@ -29,9 +30,7 @@
>> sha256
>> ef797abc51ed8ae27c200f5b71fd0a3824d1fa310392dac57067de2e423222ed
>> worksrcdir ${distname}-${version}+dfsg
>> 
>> -depends_libport:OpenBLAS \
>> -port:lapack \
>> -port:gsl \
>> +depends_libport:gsl \
>> port:fftw-3 \
>> port:pgplot \
>> port:xorg-libX11
>> @@ -47,6 +46,7 @@
>> reinplace -W ${worksrcpath} "s|@FFLAGS@|${configure.fflags}|g"
>> local_settings
>> reinplace -W ${worksrcpath} "s|@LDFLAGS@|${configure.ldflags}|g"
>> local_settings
>> reinplace -W ${worksrcpath} "s|@LIB_FORTRAN@|${compilers.libfortran}|g"
>> local_settings
>> +reinplace -W ${worksrcpath} "s|@LIB_LAPACK@|${linalglib}|g"
>> local_settings
>> }
>> 
>> build.env-appendHOME_LORENE=${worksrcpath}
>> Index: files/local_settings
>> ===
>> --- files/local_settings(revision 153958)
>> +++ files/local_settings(working copy)
>> @@ -74,7 +74,7 @@
>> 
>> # Linear Algebra Package (LAPACK) library
>> # ---
>> -LIB_LAPACK = -llapack -lblas
>> +LIB_LAPACK = @LIB_LAPACK
>> 
>> # Graphical libraries: PGPLOT, PNG and X11
>> # 
>> 
>> 
>> On Sun, Oct 16, 2016 at 1:27 PM, Ryan Schmidt <ryandes...@macports.org>
>> wrote:
>> 
>>> 
>>>> On Oct 16, 2016, at 12:41 PM, thib...@macports.org wrote:
>>>> 
>>>> Revision
>>>> 153943
>>>> Author
>>>> thib...@macports.org
>>>> Date
>>>> 2016-10-16 10:41:08 -0700 (Sun, 16 Oct 2016)
>>>

Re: [153943] trunk/dports/science

2016-10-17 Thread Thibaut Paumard
This is correct. I will emote the dependency.

Should I also remove -lX11 from LIB_PGPLOT, since libpgplot itself is linked 
with -lX11?

Kind regards, Thibaut.


Le 17 oct. 2016 à 20:12, David Strubbe  a écrit :

> It appears libX11, in the LIB_PGPLOT variable, is used in principle to 
> compile some codes that are not in fact compiled in this package. It looks 
> like X11 is only in fact used via pgplot.
> 
> On Mon, Oct 17, 2016 at 10:46 AM, Ryan Schmidt  
> wrote:
> 
> > On Oct 16, 2016, at 11:57 PM, David Strubbe  wrote:
> >
> > Additionally, the dependency port:xorg-libX11 does not seem necessary: I 
> > don't see any evidence in the build log that it is used, and the build 
> > succeeds without it being active.
> 
> Are you sure? libX11 is mentioned in local_settings:
> 
> 
> > > --- trunk/dports/science/LORENE/files/local_settings  
> > > (rev 0)
> > > +++ trunk/dports/science/LORENE/files/local_settings  2016-10-16 17:41:08 
> > > UTC (rev 153943)
> 
> > > +# Graphical libraries: PGPLOT, PNG and X11
> > > +# 
> > > +LIB_PGPLOT = -lcpgplot -lpgplot -lX11
> 
> 
> 
> 

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153943] trunk/dports/science

2016-10-17 Thread David Strubbe
It appears libX11, in the LIB_PGPLOT variable, is used in principle to
compile some codes that are not in fact compiled in this package. It looks
like X11 is only in fact used via pgplot.

On Mon, Oct 17, 2016 at 10:46 AM, Ryan Schmidt 
wrote:

>
> > On Oct 16, 2016, at 11:57 PM, David Strubbe 
> wrote:
> >
> > Additionally, the dependency port:xorg-libX11 does not seem necessary: I
> don't see any evidence in the build log that it is used, and the build
> succeeds without it being active.
>
> Are you sure? libX11 is mentioned in local_settings:
>
>
> > > --- trunk/dports/science/LORENE/files/local_settings
> (rev 0)
> > > +++ trunk/dports/science/LORENE/files/local_settings  2016-10-16
> 17:41:08 UTC (rev 153943)
>
> > > +# Graphical libraries: PGPLOT, PNG and X11
> > > +# 
> > > +LIB_PGPLOT = -lcpgplot -lpgplot -lX11
>
>
>
>
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153943] trunk/dports/science

2016-10-17 Thread Ryan Schmidt

> On Oct 16, 2016, at 11:57 PM, David Strubbe  wrote:
> 
> Additionally, the dependency port:xorg-libX11 does not seem necessary: I 
> don't see any evidence in the build log that it is used, and the build 
> succeeds without it being active.

Are you sure? libX11 is mentioned in local_settings:


> > --- trunk/dports/science/LORENE/files/local_settings
> >   (rev 0)
> > +++ trunk/dports/science/LORENE/files/local_settings  2016-10-16 17:41:08 
> > UTC (rev 153943)

> > +# Graphical libraries: PGPLOT, PNG and X11
> > +# 
> > +LIB_PGPLOT = -lcpgplot -lpgplot -lX11



___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [153943] trunk/dports/science

2016-10-17 Thread Ryan Schmidt

> On Oct 17, 2016, at 12:23 PM, Paumard Thibaut <thibaut.paum...@obspm.fr> 
> wrote:
> 
> Thanks  Ryan,
> 
> I will commit an update tonight to fix those issues.
> 
> Does that warrant a rev bump?

Will it change any files that get installed by the port? If so, yes.


> Kind regards, Thibaut.
> 
> Le Dimanche 16 Octobre 2016 22:27 CEST, Ryan Schmidt 
> <ryandes...@macports.org> a écrit:
> 
>> 
>>> On Oct 16, 2016, at 12:41 PM, thib...@macports.org wrote:
>>> 
>>> Revision
>>> 153943
>>> Author
>>> thib...@macports.org
>>> Date
>>> 2016-10-16 10:41:08 -0700 (Sun, 16 Oct 2016)
>>> Log Message
>>> 
>>> New port: LORENE
>>> Added Paths
>>> 
>>> • trunk/dports/science/LORENE/
>>> • trunk/dports/science/LORENE/Portfile
>>>     • trunk/dports/science/LORENE/files/
>>> • trunk/dports/science/LORENE/files/local_settings
>>> Diff
>>> 
>>> Added: trunk/dports/science/LORENE/Portfile (0 => 153943)
>>> 
>>> --- trunk/dports/science/LORENE/Portfile(rev 0)
>>> +++ trunk/dports/science/LORENE/Portfile2016-10-16 17:41:08 UTC (rev 
>>> 153943)
>>> @@ -0,0 +1,67 @@
>>> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
>>> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>>> +# $Id$
>> 
>> The whitespace of this portfile does not conform to this modeline. Tabs 
>> should be replaced with spaces.
>> 
>> 
>>> +PortSystem  1.0
>>> +PortGroup   compilers 1.0
>>> +
>>> +cvs.date   20160908
>>> +
>>> +name   LORENE
>>> +version0.0.0~cvs${cvs.date}
>>> +
>>> +categories science
>>> +maintainersthibaut openmaintainer
>>> +descriptionLangage Objet pour la RElativité NumériquE
>>> +long_descriptionLORENE is a set of C++ classes to solve various 
>>> problems \
>>> +arising in numerical relativity, and more generally in 
>>> \
>>> +computational astrophysics. It provides tools to solve 
>>> \
>>> +partial differential equations by means of 
>>> multi-domain \
>>> +spectral methods.
>>> +
>>> +license gpl-2+
>>> +platforms  darwin
>>> +
>>> +homepage   http://www.lorene.obspm.fr/
>>> +master_sites   
>>> https://people.debian.org/~thibaut/debian/pool/main/l/lorene/
>>> +distname   lorene
>>> +distfiles  ${distname}_${version}+dfsg.orig.tar.xz
>> 
>> Because this is not a tar.gz file but a tar.xz file, you must use "use_xz 
>> yes" to tell MacPorts how to decompress it. (Mavericks (?) and later can 
>> figure it out automatically, but our policy is not to rely on that, and to 
>> specify it correctly in the Portfile.)
>> 
>> 
>>> +checksums   rmd160  36346f8d7a50acee20a5b81051af2e7fe5f188c1 \
>>> +sha256  
>>> ef797abc51ed8ae27c200f5b71fd0a3824d1fa310392dac57067de2e423222ed
>>> +worksrcdir ${distname}-${version}+dfsg
>>> +
>>> +depends_libport:OpenBLAS \
>>> +port:lapack \
>>> +port:gsl \
>>> +port:fftw-3 \
>>> +port:pgplot \
>>> +port:xorg-libX11
>>> +
>>> +compilers.choosecxx f77
>>> +compilers.setup require_fortran
>>> +
>>> +configure  {
>>> +file copy ${filespath}/local_settings ${worksrcpath}/
>>> +reinplace -W ${worksrcpath} "s|@CXX@|${configure.cxx}|g" local_settings
>>> +reinplace -W ${worksrcpath} "s|@F77@| ${configure.f77} |g" 
>>> local_settings
>>> +reinplace -W ${worksrcpath} "s|@CXXFLAGS@|${configure.cxxflags}|g" 
>>> local_settings
>>> +reinplace -W ${worksrcpath} "s|@FFLAGS@|${configure.fflags}|g" 
>>> local_settings
>>> +reinplace -W ${worksrcpath} "s|@LDFLAGS@|${configure.ldflags}|g" 
>>> local_settings
>>> +reinplace -W ${worksrcpath} 
>>> "s|@LIB_FORTRAN@|${compilers.libfortran}|g" local_settings
>>> +}
>> 
>> I don't see anywhere in this Portfile that ar

Re: [153943] trunk/dports/science

2016-10-16 Thread David Strubbe
Additionally, the dependency port:xorg-libX11 does not seem necessary: I
don't see any evidence in the build log that it is used, and the build
succeeds without it being active.

On Sun, Oct 16, 2016 at 5:23 PM, David Strubbe <dstru...@macports.org>
wrote:

> Hi,
>
> Let me add a few comments.
> - The dependency for BLAS is wrong: the port OpenBLAS provides a library
> -lopenblas not -lblas. Apparently the "lapack" port includes BLAS anyway.
> To be simpler and more flexible, I suggest use of the linear algebra port
> group I created to handle all this and also provide choices of different
> optimized implementations (ATLAS, Accelerate, or OpenBLAS -- the port has
> lapack included). See patch below.
> - You are installing a lot of Makefiles and C source files -- is this on
> purpose? It is somewhat unusual.
> - You are putting everything in the lib directory. This should be reserved
> for libraries. Headers should go in include; documentation or miscellaneous
> things should go in share; etc.
> - Since there are tests apparently available, you should create a test
> phase rather than install their files, so that users can run "port test".
>
> David
>
> Index: Portfile
> ===
> --- Portfile(revision 153958)
> +++ Portfile(working copy)
> @@ -3,6 +3,7 @@
>
>  PortSystem  1.0
>  PortGroup   compilers 1.0
> +PortGroup   linear_algebra 1.0
>
>  cvs.date   20160908
>
> @@ -29,9 +30,7 @@
>  sha256  ef797abc51ed8ae27c200f5b71fd0a
> 3824d1fa310392dac57067de2e423222ed
>  worksrcdir ${distname}-${version}+dfsg
>
> -depends_libport:OpenBLAS \
> -port:lapack \
> -port:gsl \
> +depends_libport:gsl \
>  port:fftw-3 \
>  port:pgplot \
>  port:xorg-libX11
> @@ -47,6 +46,7 @@
>  reinplace -W ${worksrcpath} "s|@FFLAGS@|${configure.fflags}|g"
> local_settings
>  reinplace -W ${worksrcpath} "s|@LDFLAGS@|${configure.ldflags}|g"
> local_settings
>  reinplace -W ${worksrcpath} "s|@LIB_FORTRAN@|${compilers.libfortran}|g"
> local_settings
> +reinplace -W ${worksrcpath} "s|@LIB_LAPACK@|${linalglib}|g"
> local_settings
>  }
>
>  build.env-appendHOME_LORENE=${worksrcpath}
> Index: files/local_settings
> ===
> --- files/local_settings(revision 153958)
> +++ files/local_settings(working copy)
> @@ -74,7 +74,7 @@
>
>  # Linear Algebra Package (LAPACK) library
>  # ---
> -LIB_LAPACK = -llapack -lblas
> +LIB_LAPACK = @LIB_LAPACK
>
>  # Graphical libraries: PGPLOT, PNG and X11
>  # 
>
>
> On Sun, Oct 16, 2016 at 1:27 PM, Ryan Schmidt <ryandes...@macports.org>
> wrote:
>
>>
>> > On Oct 16, 2016, at 12:41 PM, thib...@macports.org wrote:
>> >
>> > Revision
>> > 153943
>> > Author
>> > thib...@macports.org
>> > Date
>> > 2016-10-16 10:41:08 -0700 (Sun, 16 Oct 2016)
>> > Log Message
>> >
>> > New port: LORENE
>> > Added Paths
>> >
>> >   • trunk/dports/science/LORENE/
>> >   • trunk/dports/science/LORENE/Portfile
>> >   • trunk/dports/science/LORENE/files/
>> >   • trunk/dports/science/LORENE/files/local_settings
>> > Diff
>> >
>> > Added: trunk/dports/science/LORENE/Portfile (0 => 153943)
>> >
>> > --- trunk/dports/science/LORENE/Portfile
>> (rev 0)
>> > +++ trunk/dports/science/LORENE/Portfile  2016-10-16 17:41:08 UTC
>> (rev 153943)
>> > @@ -0,0 +1,67 @@
>> > +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil;
>> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>> > +# $Id$
>>
>> The whitespace of this portfile does not conform to this modeline. Tabs
>> should be replaced with spaces.
>>
>>
>> > +PortSystem  1.0
>> > +PortGroup   compilers 1.0
>> > +
>> > +cvs.date 20160908
>> > +
>> > +name LORENE
>> > +version  0.0.0~cvs${cvs.date}
>> > +
>> > +categories   science
>> > +maintainers  thibaut openmaintainer
>> > +description  Langage Objet pour la RElativité NumériquE
>> > +long_descriptionLORENE is a se

Re: [153943] trunk/dports/science

2016-10-16 Thread Ryan Schmidt

> On Oct 16, 2016, at 12:41 PM, thib...@macports.org wrote:
> 
> Revision
> 153943
> Author
> thib...@macports.org
> Date
> 2016-10-16 10:41:08 -0700 (Sun, 16 Oct 2016)
> Log Message
> 
> New port: LORENE
> Added Paths
> 
>   • trunk/dports/science/LORENE/
>   • trunk/dports/science/LORENE/Portfile
>   • trunk/dports/science/LORENE/files/
>   • trunk/dports/science/LORENE/files/local_settings
> Diff
> 
> Added: trunk/dports/science/LORENE/Portfile (0 => 153943)
> 
> --- trunk/dports/science/LORENE/Portfile  (rev 0)
> +++ trunk/dports/science/LORENE/Portfile  2016-10-16 17:41:08 UTC (rev 
> 153943)
> @@ -0,0 +1,67 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# $Id$

The whitespace of this portfile does not conform to this modeline. Tabs should 
be replaced with spaces.


> +PortSystem  1.0
> +PortGroup   compilers 1.0
> +
> +cvs.date 20160908
> +
> +name LORENE
> +version  0.0.0~cvs${cvs.date}
> +
> +categories   science
> +maintainers  thibaut openmaintainer
> +description  Langage Objet pour la RElativité NumériquE
> +long_descriptionLORENE is a set of C++ classes to solve various problems 
> \
> +arising in numerical relativity, and more generally in \
> +computational astrophysics. It provides tools to solve \
> +partial differential equations by means of multi-domain \
> +spectral methods.
> +
> +license gpl-2+
> +platformsdarwin
> +
> +homepage http://www.lorene.obspm.fr/
> +master_sites 
> https://people.debian.org/~thibaut/debian/pool/main/l/lorene/
> +distname lorene
> +distfiles${distname}_${version}+dfsg.orig.tar.xz

Because this is not a tar.gz file but a tar.xz file, you must use "use_xz yes" 
to tell MacPorts how to decompress it. (Mavericks (?) and later can figure it 
out automatically, but our policy is not to rely on that, and to specify it 
correctly in the Portfile.)


> +checksums   rmd160  36346f8d7a50acee20a5b81051af2e7fe5f188c1 \
> +sha256  
> ef797abc51ed8ae27c200f5b71fd0a3824d1fa310392dac57067de2e423222ed
> +worksrcdir   ${distname}-${version}+dfsg
> +
> +depends_lib  port:OpenBLAS \
> +port:lapack \
> +port:gsl \
> +port:fftw-3 \
> +port:pgplot \
> +port:xorg-libX11
> +
> +compilers.choosecxx f77
> +compilers.setup require_fortran
> +
> +configure{
> +file copy ${filespath}/local_settings ${worksrcpath}/
> +reinplace -W ${worksrcpath} "s|@CXX@|${configure.cxx}|g" local_settings
> +reinplace -W ${worksrcpath} "s|@F77@| ${configure.f77} |g" local_settings
> +reinplace -W ${worksrcpath} "s|@CXXFLAGS@|${configure.cxxflags}|g" 
> local_settings
> +reinplace -W ${worksrcpath} "s|@FFLAGS@|${configure.fflags}|g" 
> local_settings
> +reinplace -W ${worksrcpath} "s|@LDFLAGS@|${configure.ldflags}|g" 
> local_settings
> +reinplace -W ${worksrcpath} "s|@LIB_FORTRAN@|${compilers.libfortran}|g" 
> local_settings
> +}

I don't see anywhere in this Portfile that arranges for the correct -arch (or, 
in the case of fortran, -m32/-m64) flags to be used. ([get_canonical_archflags 
...])

The universal variant fails and should probably be disabled because:

Error: Cannot install LORENE for the archs 'i386 x86_64' because
Error: its dependency pgplot does not build for the required archs by default
Error: and does not have a universal variant.


> +build.env-appendHOME_LORENE=${worksrcpath}
> +build.targetcpp fortran export
> +use_parallel_build  no
> +
> +destroot{
> +xinstall -d ${destroot}${prefix}/lib/lorene/Lib
> +xinstall {*}[glob ${worksrcpath}/Lib/*.a] 
> ${destroot}${prefix}/lib/lorene/Lib/
> +xinstall -d ${destroot}${prefix}/lib/lorene/C++/Include
> +xinstall {*}[glob ${worksrcpath}/C++/Include/*.h] 
> ${destroot}${prefix}/lib/lorene/C++/Include/
> +xinstall -d ${destroot}${prefix}/lib/lorene/C++/Include/Template
> +xinstall {*}[glob ${worksrcpath}/C++/Include/Template/*] 
> ${destroot}${prefix}/lib/lorene/C++/Include/Template/
> +xinstall ${worksrcpath}/local_settings ${destroot}${prefix}/lib/lorene/
> +xinstall -d ${destroot}${prefix}/lib/lorene/Devel
> +xinstall {*}[glob ${worksrcpath}