Re: Best practice for port contributors in github world

2016-12-13 Thread Lawrence Velázquez
> On Dec 13, 2016, at 7:56 AM, Luc Bourhis wrote: > > file://path/to/my/clone/of/macports-ports [default] Note that you have to use three slashes at the beginning of this line because the "/" that begins the absolute path is distinct from the "://" that separates the

Re: [macports-ports] branch master updated: phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

2016-12-12 Thread Lawrence Velázquez
> On Dec 12, 2016, at 11:46 PM, Marko Käning wrote: > > Yet, the git metadata is - also to my surprise - still valid, which can be > verified by clicking all the links on the commit’s page: > > >

Re: [macports-ports] branch master updated: phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

2016-12-12 Thread Lawrence Velázquez
Please clean up the commit message when you perform squash merges. Most of the text here is outdated Git metadata (old SHA-1 hashes, repeated author name, irrelevant authorship dates). vq > On Dec 12, 2016, at 10:54 PM, Marko Käning wrote: > > Marko Käning (mkae) pushed a

Re: PR final steps (to squash or not to squash)

2016-12-05 Thread Lawrence Velázquez
> On Dec 5, 2016, at 7:37 AM, René J.V. Bertin wrote: > > I guess we all have better things to do than this kind of task. Our commit history is essentially communication with future committers about what we did and why. Like any other communication, it should be clear and

Re: PR final steps (to squash or not to squash)

2016-12-05 Thread Lawrence Velázquez
> On Dec 5, 2016, at 10:38 AM, René J.V. Bertin wrote: > >> On Monday December 05 2016 14:58:08 Rainer Müller wrote: >> >> What would be easier than just checking out the updated Portfile? You >> can also just download the patch and apply it. Open for suggestions. > > In

Re: PR final steps (to squash or not to squash)

2016-12-05 Thread Lawrence Velázquez
> On Dec 5, 2016, at 8:57 PM, Zero King wrote: > >> From what I understand, what we'd really like for that case is >> a "squash, rebase and merge" option. Unless we've misunderstood what >> "squash and merge" does and it doesn't actually create a merge >> commit? > > No, it

Re: PR final steps (to squash or not to squash)

2016-12-05 Thread Lawrence Velázquez
> On Dec 5, 2016, at 5:14 AM, Mojca Miklavec wrote: > > Usually "larryv" is the one who takes most care to split commits Hey now, why the scare quotes? :) vq

Re: How should ports refer to the 2-clause BSD license?

2016-12-04 Thread Lawrence Velázquez
> On Dec 4, 2016, at 12:11 PM, Ryan Schmidt <ryandes...@macports.org> wrote: > >> On Dec 4, 2016, at 10:49, Lawrence Velázquez <lar...@macports.org> wrote: >> >> The checking script only mentions BSD (3-clause) and BSD-old >> (4-clause). > > As fa

Re: Tcl list-related 2.3.4 -> 2.3.5 changes?

2016-12-02 Thread Lawrence Velázquez
> On Dec 2, 2016, at 8:47 PM, Joshua Root wrote: > >> On 2016-12-3 02:45, René J.V. Bertin wrote: >> >> Hi, >> >> I'm trying to understand a regression that seems coupled to the >> 2.3.4 -> 2.3.5 upgrade (or more exactly, "master just after 2.3.4" >> -> "master 25 commits

Re: [macports-ports] branch master updated: databases/percona: Fixed percona download URL to use version_branch again. Removed $Id$ tag. Closes; #62 Closes: https://trac.macports.org/ticket/52664 Clos

2016-11-28 Thread Lawrence Velázquez
> On Nov 28, 2016, at 7:42 PM, Bradley Giesbrecht wrote: > > In IRC I wasn’t sure how to read Clemens comment: "Yes, Closes: > $ticketlink, due to the length on their own lines, preferably” > > I thought maybe a single long line commit message was not preferable. That's

Re: [macports-ports] branch master updated: databases/percona: Fixed percona download URL to use version_branch again. Removed $Id$ tag. Closes; #62 Closes: https://trac.macports.org/ticket/52664 Clos

2016-11-28 Thread Lawrence Velázquez
Hi, > On Nov 28, 2016, at 7:13 PM, Roger Ward wrote: > > Bradley Giesbrecht (pixilla) pushed a commit to branch master > in repository macports-ports. > > https://github.com/macports/macports-ports/commit/2f43f23a572b62018bd0e4c0182df99f1a9bcd34 > >

Re: `git describe`

2016-11-28 Thread Lawrence Velázquez
> On Nov 28, 2016, at 7:41 AM, René J.V. Bertin wrote: > > This is moot if master is exclusively a testing area for experiments > that may never make it to a release. If it has a more usual role and > is used by those who live on the bleeding edge, then my point stands All

Re: How best to submit new port to maintainer, in a world of Github?

2016-11-26 Thread Lawrence Velázquez
> On Nov 26, 2016, at 6:25 PM, A. Karl Kornel wrote: > > I have a question about how best to deal with submitting a port update > to an existing maintainer, in the new Git setup. > > The port in question is "libvirt", which has Ryan as maintainer, but > also has openmaintainer

Stop "replacing" existing Trac tickets with GitHub pull requests

2016-11-17 Thread Lawrence Velázquez
I know you all think GitHub pull requests are the bee's knees, but please DO NOT open pull requests to "replace" existing Trac tickets. It doesn't actually help committers evaluate submissions, and it splits the discussion across Trac and GitHub. vq

Re: [macports-ports] 02/02: py-geopy: delete py26 and py33 subports. See also https://trac.macports.org/ticket/52881

2016-11-16 Thread Lawrence Velázquez
> On Nov 16, 2016, at 4:40 PM, Mark Moll wrote: > > Mark Moll (mamoll) pushed a commit to branch master > in repository macports-ports. > > https://github.com/macports/macports-ports/commit/feb1081ffcbf1d0b06250a9f20c1095f8c4cbb67 > >

Re: Another workflow (pull requests) question.

2016-11-14 Thread Lawrence Velázquez
> On Nov 14, 2016, at 2:44 PM, Eric A. Borisch wrote: > >> On Mon, Nov 14, 2016 at 1:17 PM, Rainer Müller wrote: >> >> I am not opposed to enabling "Squash and merge", but we have no >> guide for maintainers explaining the pull request workflow. If

Re: GitHub migration complete

2016-11-07 Thread Lawrence Velázquez
> On Nov 7, 2016, at 12:39 PM, Lawrence Velázquez <lar...@macports.org> wrote: > >> On Nov 7, 2016, at 12:29 PM, René J.V. Bertin <rjvber...@gmail.com> wrote: >> >> As long as it doesn't cause problems elsewhere I think there >> shouldn't be any hard

Re: GitHub migration complete

2016-11-07 Thread Lawrence Velázquez
> On Nov 7, 2016, at 12:29 PM, René J.V. Bertin <rjvber...@gmail.com> wrote: > >> On Monday November 07 2016 11:52:17 Lawrence Velázquez wrote: >> >> Any sort of Git keyword expansion must happen client-side, which means >> such keywords/markers would onl

Re: PR usage by people with commit access

2016-11-07 Thread Lawrence Velázquez
> On Nov 5, 2016, at 1:03 PM, Marko Käning <mk-macpo...@posteo.net> wrote: > >> On 04 Nov 2016, at 19:00 , Lawrence Velázquez <lar...@macports.org> wrote: >> >> Sure. I would encourage committers who want feedback to open as many PRs >> as they want. >

Re: [macports-ports] branch master updated: misc: follow up on base changes and mass-unbreak ports in trace mode.

2016-11-07 Thread Lawrence Velázquez
> On Nov 7, 2016, at 10:37 AM, Rainer Müller wrote: > > Multiple of the affected ports just change the '.cmd' to 'autogen.sh'. > Would it make sense to have an additional use_autogensh that defaults to > this and adds dependencies on autoconf, automake, libtool? This is a