Now that the empty() function from PHP 5.5+ can handle a non-variable we
don't need to make a minaccept check!
** Changed in: mahara
Milestone: 17.10.0 => None
** Changed in: mahara
Status: Confirmed => Won't Fix
--
You received this bug notification because you are a member of Mahar
** Changed in: mahara
Milestone: 16.04.7 => 17.10.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
** Changed in: mahara
Milestone: 16.04.6 => 16.04.7
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
** Changed in: mahara
Milestone: 16.04.5 => 16.04.6
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
The fix for the 2 results for the /collection/ section are being handled
by https://bugs.launchpad.net/mahara/+bug/1638687
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Cont
I tried this command on the codebase
find . -type f -name "*.php" -exec grep -EHn '\bempty\(([^)]+)\(' {} \;
and I see there are places where the empty() command could cause
problems
./testing/classes/generator/TestingDataGenerator.php:783:$subject =
!empty(trim($record['subject'])) ? t
Also we should add a check to make sure there isn't any calls to empty()
in the php files that contain calls to functions within it to be safe.
eg things like this can cause problems:
empty(array_merge($one, $two));
empty($view->get('artefacts'));
We could grep for them with something like:
\b
** Changed in: mahara
Milestone: 16.04.4 => 16.04.5
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
** Changed in: mahara
Milestone: 16.04.3 => 16.04.4
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
** Changed in: mahara
Milestone: 16.04.2 => 16.04.3
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
** Changed in: mahara
Milestone: 16.04.1 => 16.04.2
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
** Changed in: mahara
Milestone: 16.04.0 => 16.04.1
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before e
12 matches
Mail list logo
