[Mahara-contributors] [Bug 1828331] A change has been merged
Reviewed: https://reviews.mahara.org/10030 Committed: https://git.mahara.org/mahara/mahara/commit/412b73280c4a4ef86b518134374a9af1839bb5a6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 412b73280c4a4ef86b518134374a9af1839bb5a6 Author: Ghada El-Zoghbi Date: Mon May 20 15:40:15 2019 +1000 Bug 1828331: Standarise date display to 24 hour format Sponsored by The Australian National University behatnotneeded Change-Id: Ibcfc43c787ad359e6dd778670eb213f671e70c6a -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828331 Title: Inconsistent time formats across Mahara Status in Mahara: Fix Committed Bug description: Mahara: 17.10.9+ OS: Linux DB: Postgres Browser: FF, Chrome, Others as well The time display has inconsistent display format at different areas. Please see the attached screenshot. Some of the areas include: - Shared with Me (24 hr format) - Group Forum (24 hr format) - Group Journal (12 hr format) - Group About (12 hr format) It would be useful to align the whole site to display only 1 format (e.g 24 hours) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828331/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1828331] Re: Inconsistent time formats across Mahara
Will not backport this one to core 19.04 as I feel it is a functionality change rather than a bug fix ** Changed in: mahara Status: Confirmed => Fix Committed ** Changed in: mahara Milestone: None => 19.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1828331 Title: Inconsistent time formats across Mahara Status in Mahara: Fix Committed Bug description: Mahara: 17.10.9+ OS: Linux DB: Postgres Browser: FF, Chrome, Others as well The time display has inconsistent display format at different areas. Please see the attached screenshot. Some of the areas include: - Shared with Me (24 hr format) - Group Forum (24 hr format) - Group Journal (12 hr format) - Group About (12 hr format) It would be useful to align the whole site to display only 1 format (e.g 24 hours) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1828331/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] Re: Notification when Importing Leap2A
** Changed in: mahara
Milestone: None => 19.10.0
** Changed in: mahara
Status: New => Fix Committed
** Changed in: mahara
Importance: Undecided => High
** Also affects: mahara/18.10
Importance: Undecided
Status: New
** Also affects: mahara/19.10
Importance: High
Status: Fix Committed
** Also affects: mahara/18.04
Importance: Undecided
Status: New
** Also affects: mahara/19.04
Importance: Undecided
Status: New
** Changed in: mahara/18.04
Status: New => Fix Committed
** Changed in: mahara/18.10
Status: New => Fix Committed
** Changed in: mahara/19.04
Status: New => Fix Committed
** Changed in: mahara/18.04
Milestone: None => 18.04.5
** Changed in: mahara/18.10
Milestone: None => 18.10.2
** Changed in: mahara/19.04
Milestone: None => 19.04.1
** Changed in: mahara/18.04
Importance: Undecided => High
** Changed in: mahara/18.10
Importance: Undecided => High
** Changed in: mahara/19.04
Importance: Undecided => High
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A change has been merged
Reviewed: https://reviews.mahara.org/10088
Committed:
https://git.mahara.org/mahara/mahara/commit/60bbf50e8eebea2db532584575ec95626b23df98
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE
commit 60bbf50e8eebea2db532584575ec95626b23df98
Author: Ghada El-Zoghbi
Date: Mon Jun 3 19:43:58 2019 +1000
Bug 1831419: validate insertion of event log for comment
When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.
Sponsored by The Australian National University
behatnotneeded
Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A change has been merged
Reviewed: https://reviews.mahara.org/10064
Committed:
https://git.mahara.org/mahara/mahara/commit/7040639d50ac68759656d50feb79f0edd4b40f68
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit 7040639d50ac68759656d50feb79f0edd4b40f68
Author: Ghada El-Zoghbi
Date: Mon Jun 3 19:43:58 2019 +1000
Bug 1831419: validate insertion of event log for comment
When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.
Sponsored by The Australian National University
behatnotneeded
Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10088
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10087
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A change has been merged
Reviewed: https://reviews.mahara.org/10087
Committed:
https://git.mahara.org/mahara/mahara/commit/467f1b0815f9cf72451ba02e18ac358e63e415e0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.10_STABLE
commit 467f1b0815f9cf72451ba02e18ac358e63e415e0
Author: Ghada El-Zoghbi
Date: Mon Jun 3 19:43:58 2019 +1000
Bug 1831419: validate insertion of event log for comment
When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.
Sponsored by The Australian National University
behatnotneeded
Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10086
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831419] A change has been merged
Reviewed: https://reviews.mahara.org/10086
Committed:
https://git.mahara.org/mahara/mahara/commit/0ac5ce6daf08c28fbc884a98c17f3781851fef4b
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:19.04_STABLE
commit 0ac5ce6daf08c28fbc884a98c17f3781851fef4b
Author: Ghada El-Zoghbi
Date: Mon Jun 3 19:43:58 2019 +1000
Bug 1831419: validate insertion of event log for comment
When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.
Sponsored by The Australian National University
behatnotneeded
Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419
Title:
Notification when Importing Leap2A
Status in Mahara:
Fix Committed
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
Fix Committed
Bug description:
Mahara: 19.04.04
DB: Postgres
OS: Linux
Browser: FF
When importing a view with a comment block, the following warning is
generated:
[WAR] ed (lib/mahara.php:2056) Undefined index: onview
Call stack (most recent first):
log_message("Undefined index: onview", 8, true, true,
"/var/www/mahara/htdocs/lib/mahara.php", 2056) at
/var/www/mahara/htdocs/lib/errors.php:520
error(8, "Undefined index: onview",
"/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at
/var/www/mahara/htdocs/lib/mahara.php:2056
handle_event("blockinstancecommit", object(BlockInstance)) at
/var/www/mahara/htdocs/blocktype/lib.php:1480
BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
View->addblockinstance(object(BlockInstance)) at
/var/www/mahara/htdocs/lib/view.php:3400
View::import_from_config(array(size 12), "2", "leap") at
/var/www/mahara/htdocs/import/leap/lib.php:1036
PluginImportLeap->import_view_from_request(object(stdClass)) at
/var/www/mahara/htdocs/import/leap/lib.php:1005
PluginImportLeap->import_from_requests() at
/var/www/mahara/htdocs/import/leap/lib.php:348
PluginImportLeap->do_import_from_requests() at
/var/www/mahara/htdocs/import/index.php:314
do_import() at /var/www/mahara/htdocs/import/index.php:71
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10084
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] A change has been merged
Reviewed: https://reviews.mahara.org/10084
Committed:
https://git.mahara.org/mahara/mahara/commit/3dc610416ce06b76c8b4e6d11d27eeba6a7ed0ee
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.10_STABLE
commit 3dc610416ce06b76c8b4e6d11d27eeba6a7ed0ee
Author: Ghada El-Zoghbi
Date: Fri Jun 14 14:53:11 2019 +1000
Bug 1832803: Check for empty string before passing it to DOMDocument
If an empty string is passed to the DOMDocument, a warning is
generated. Avoid the warning by checking for an empty string.
Sponsored by The Australian National University
behatnotneeded
Change-Id: I4bd3982de81f6db97601a1dbe5232d344e87ca81
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10081 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10082 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A change has been merged
Reviewed: https://reviews.mahara.org/10080 Committed: https://git.mahara.org/mahara/mahara/commit/c40945d82fb907ebea53264c0863d3e97c120b87 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit c40945d82fb907ebea53264c0863d3e97c120b87 Author: Ghada El-Zoghbi Date: Fri Jun 14 14:10:05 2019 +1000 Bug 1832796: Group journals - display add link only if user has permission For a regular member who does not have permission to add a journal to a group, the display message should not include the 'Add one' link. Sponsored by The Australian National University behatnotneeded Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72 (cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] A change has been merged
Reviewed: https://reviews.mahara.org/10085
Committed:
https://git.mahara.org/mahara/mahara/commit/251b026fb7751bb84446cefbce3a0f94cc389253
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:19.04_STABLE
commit 251b026fb7751bb84446cefbce3a0f94cc389253
Author: Ghada El-Zoghbi
Date: Fri Jun 14 14:53:11 2019 +1000
Bug 1832803: Check for empty string before passing it to DOMDocument
If an empty string is passed to the DOMDocument, a warning is
generated. Avoid the warning by checking for an empty string.
Sponsored by The Australian National University
behatnotneeded
Change-Id: I4bd3982de81f6db97601a1dbe5232d344e87ca81
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10085
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A change has been merged
Reviewed: https://reviews.mahara.org/10082 Committed: https://git.mahara.org/mahara/mahara/commit/81a820d9c7cdcb940376648e06e98457391fc9f4 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.04_STABLE commit 81a820d9c7cdcb940376648e06e98457391fc9f4 Author: Ghada El-Zoghbi Date: Fri Jun 14 14:10:05 2019 +1000 Bug 1832796: Group journals - display add link only if user has permission For a regular member who does not have permission to add a journal to a group, the display message should not include the 'Add one' link. Sponsored by The Australian National University behatnotneeded Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72 (cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd) (cherry picked from commit c40945d82fb907ebea53264c0863d3e97c120b87) (cherry picked from commit f6930a7468a46e13c3109d89c449c1a3db5b170a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10080 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A change has been merged
Reviewed: https://reviews.mahara.org/10081 Committed: https://git.mahara.org/mahara/mahara/commit/f6930a7468a46e13c3109d89c449c1a3db5b170a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit f6930a7468a46e13c3109d89c449c1a3db5b170a Author: Ghada El-Zoghbi Date: Fri Jun 14 14:10:05 2019 +1000 Bug 1832796: Group journals - display add link only if user has permission For a regular member who does not have permission to add a journal to a group, the display message should not include the 'Add one' link. Sponsored by The Australian National University behatnotneeded Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72 (cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd) (cherry picked from commit c40945d82fb907ebea53264c0863d3e97c120b87) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] Re: Adding Journal - message displayed to user is misleading
** Changed in: mahara/19.04 Status: New => Fix Committed ** Changed in: mahara/18.10 Status: New => Fix Committed ** Changed in: mahara/18.04 Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] A change has been merged
Reviewed: https://reviews.mahara.org/10083
Committed:
https://git.mahara.org/mahara/mahara/commit/0283745692d9e23991fda19f52ecb410226f7603
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE
commit 0283745692d9e23991fda19f52ecb410226f7603
Author: Ghada El-Zoghbi
Date: Fri Jun 14 14:53:11 2019 +1000
Bug 1832803: Check for empty string before passing it to DOMDocument
If an empty string is passed to the DOMDocument, a warning is
generated. Avoid the warning by checking for an empty string.
Sponsored by The Australian National University
behatnotneeded
Change-Id: I4bd3982de81f6db97601a1dbe5232d344e87ca81
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] Re: Adding Journal - message displayed to user is misleading
** Changed in: mahara Importance: Undecided => Medium ** Also affects: mahara/18.04 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: Medium Assignee: Ghada El-Zoghbi (ghada-z) Status: New ** Also affects: mahara/18.10 Importance: Undecided Status: New ** Also affects: mahara/19.04 Importance: Undecided Status: New ** Changed in: mahara/19.04 Importance: Undecided => Medium ** Changed in: mahara/18.10 Importance: Undecided => Medium ** Changed in: mahara/18.04 Importance: Undecided => Medium ** Changed in: mahara/19.10 Status: New => Fix Committed ** Changed in: mahara/19.10 Milestone: None => 19.10.0 ** Changed in: mahara/19.04 Milestone: None => 19.04.1 ** Changed in: mahara/18.10 Milestone: None => 18.10.2 ** Changed in: mahara/18.04 Milestone: None => 18.04.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] Re: Adding an empty string as a comment generates a warning
** Also affects: mahara/18.04
Importance: Undecided
Status: New
** Also affects: mahara/19.04
Importance: Undecided
Status: New
** Also affects: mahara/19.10
Importance: Undecided
Assignee: Ghada El-Zoghbi (ghada-z)
Status: New
** Also affects: mahara/18.10
Importance: Undecided
Status: New
** Changed in: mahara/18.04
Status: New => Fix Committed
** Changed in: mahara/18.10
Status: New => Fix Committed
** Changed in: mahara/19.04
Status: New => Fix Committed
** Changed in: mahara/19.10
Status: New => In Progress
** Changed in: mahara/18.04
Importance: Undecided => Medium
** Changed in: mahara/18.10
Importance: Undecided => Medium
** Changed in: mahara/19.04
Importance: Undecided => Medium
** Changed in: mahara/19.10
Importance: Undecided => Medium
** Changed in: mahara/18.04
Milestone: None => 18.04.5
** Changed in: mahara/18.10
Milestone: None => 18.10.2
** Changed in: mahara/19.04
Milestone: None => 19.04.1
** Changed in: mahara/19.10
Milestone: None => 19.10.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832803] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10083
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803
Title:
Adding an empty string as a comment generates a warning
Status in Mahara:
In Progress
Status in Mahara 18.04 series:
Fix Committed
Status in Mahara 18.10 series:
Fix Committed
Status in Mahara 19.04 series:
Fix Committed
Status in Mahara 19.10 series:
In Progress
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF
When entering a comment which does not have any text but includes an uploaded
file, the following warning is generated:
[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty
string supplied as input
Call stack (most recent first):
log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8,
true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at
/var/www/mahara/htdocs/lib/errors.php:520
error(2, "DOMDocument::loadHTML(): Empty string supplied as ...",
"/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
DOMDocument->loadHTML("", 8196) at
/var/www/mahara/htdocs/artefact/comment/lib.php:1184
ArtefactTypeComment::remove_comments_classes("") at
/var/www/mahara/htdocs/artefact/comment/lib.php:1637
add_feedback_form_submit(object(Pieform), array(size 8)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:544
Pieform->__construct(array(size 9)) at
/var/www/mahara/htdocs/lib/pieforms/pieform.php:166
Pieform::process(array(size 9)) at
/var/www/mahara/htdocs/lib/mahara.php:5400
pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266
To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears
Expected: no warning should appear.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832796] A change has been merged
Reviewed: https://reviews.mahara.org/10078 Committed: https://git.mahara.org/mahara/mahara/commit/9188fc20704de7ff238da2963276f7b84c9aa6fd Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 9188fc20704de7ff238da2963276f7b84c9aa6fd Author: Ghada El-Zoghbi Date: Fri Jun 14 14:10:05 2019 +1000 Bug 1832796: Group journals - display add link only if user has permission For a regular member who does not have permission to add a journal to a group, the display message should not include the 'Add one' link. Sponsored by The Australian National University behatnotneeded Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1832805] Re: Missing lang string when saving to timeline
Please let me know what the message should say and I can upload a patch. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832805 Title: Missing lang string when saving to timeline Status in Mahara: New Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF After a portfolio assignment has been unlocked (i.e. after grading) and was submitted via MNET, a student tries to save the page/collection in timeline, it display an error message. Which is the correct behaviour. The issues is a missing language string: [[cantversionview/view]] in the error message that is displayed to the user. Please see attached image. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832805/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
