[Mahara-contributors] [Bug 2016982] Re: Custom header logo not shown while using the "Configurable Theme"
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2016982 Title: Custom header logo not shown while using the "Configurable Theme" Status in Mahara: In Progress Bug description: When the "Configurable Theme" has been activated for an institution of an installation, the custom header logo of that institution is replaced by the standard Mahara logo. Tested on Mahara version 22.10.0 on Linux, PHP version 7.4, DB Postgres. Mahara installation with multiple institutions. -- Precondition: Activate the "Configurable Theme" for an institution and save the changes. Steps to reproduce: 1. Head to the institution's settings. 2. Upload a custom logo and save the changes. 3. Open any page of the application while being logged in to the institution which you have just set the custom logo up for. Expected result: You will see your chosen custom header logo AND the theme colors of the "Configurable Theme" you have set up. Actual result: You will see the Mahara site in your chosen "Configurable Theme" colors. When reloading any page you will shortly see your chosen custom logo flash up in the header bar and then be quickly replaced by the standard Mahara logo. -- Possible fix: By experimenting around in the theme files for the custom theme I was able to find a temporary fix by commenting out two functions in the /htdocs/theme/custom/js/theme.js file (around line 300) responsible for adapting the Mahara logo to the custom theme header bar colors: //displayCorrectSmallLogo(); //displayCorrectLogo(); I suspect these functions are at fault for replacing the chosen custom logo with the standard Mahara logo once the page has loaded. Sadly, I will not be able to apply this same fix to our production system since we abstain from any theme changes. Therefore, it would be great to get in a fix for this issue with one of the upcoming releases! :) Please feel free to contact me should you have any further questions! To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2016982/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006637] Re: Issue with upgrade and setting the blocktype_installed_viewtypes values correctly
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006637 Title: Issue with upgrade and setting the blocktype_installed_viewtypes values correctly Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When we add a new view type we update the blocktype_installed_viewtype table to know what blocks can be used on this new view type. But if we have an upgrade path where we add two new view types in one upgrade session then the information is not correct from Blocktype::get_viewtypes() because it is set to be static. We need it to ignore this static-ness on upgrade. To test: Install a 20.04_STABLE site Upgrade to main Run the following command in database: select * from blocktype_installed_viewtype where viewtype = 'activity' order by blocktype; Should see: 29 (or 30) rows including 'placeholder' and 'image' blocktypes Actually see: 21 (or 22) rows and 'placeholder' and 'image' blocktypes are missing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006637/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004509] Re: bulk export not working correctly for leap2A
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004509 Title: bulk export not working correctly for leap2A Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When doing an export from bulk export page (admin/users/bulkexport.php) there is a problem when doing a Leap2A export where it tries to do a pdf export instead To test: go to the page via link admin/users/bulkexport.php and do a Leap2A export for a person by putting their username into the 'Usernames to export' field If you don't have pdf export installed then on export you should see an error in the error log : Class 'PluginExportPdfLite' not found To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004509/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012419] Re: Error releasing submissions
** Changed in: mahara
Status: Fix Committed => Fix Released
** Changed in: mahara/22.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419
Title:
Error releasing submissions
Status in Mahara:
Fix Released
Status in Mahara 22.10 series:
Fix Released
Status in Mahara 23.04 series:
Fix Released
Bug description:
To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
* Create 2 users Student and Teacher
* Create an institution
* Add the two users in the institution
* Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
* Add Student as Member of Group 1 and Teacher as Tutor in Group 1
* As Student create a page and submit it for review in Group 1
* As Teacher release the Page
From this point an error will be displayed and the page will never be
released and will be marked as "Pending release after archiving."
The Error displayed is:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near '? LIMIT 1' at line
1] in EXECUTE("SELECT * FROM "lti_assessment" WHERE "group" = ?
LIMIT 1")Command was: SELECT * FROM "lti_assessment" WHERE "group" =
?
...
When examining the issue with a debugger it seems that
group_external_group($group) is called with an integer instead of a
string, so it means that record_exists('lti_assessment', 'group',
$group->id) is called with the wrong value (as $group->id does not
exist).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] Re: Releasing submissions: error message on failure
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995533] Re: Unable to see skin artefacts owned by another person
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995533 Title: Unable to see skin artefacts owned by another person Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Now that we are using accesscontrol.php for checking if we can see the artefact we need to have a check when the artefact is part of a skin To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995533/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1993079] Re: MNet not saving expiry date correctly on insert of new instance
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1993079 Title: MNet not saving expiry date correctly on insert of new instance Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Also not saving on update of MNet instance in some cases. To test have a moodle to connect to and then in mahara make a MNet connection in an institution by adding an xmlrpc auth method. On saving the form it should set an expiry for the certificate. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995813] Re: Deprecated Sass warning: $weight without unit
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995813 Title: Deprecated Sass warning: $weight without unit Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated. To preserve current behavior: $weight * 1% More info: https://sass-lang.com/d/function-units ╷ 151 │ @return mix(rgba($foreground, 1), $background, opacity($foreground) * 100); │ ^^ ╵ htdocs/theme/raw/sass/lib/bootstrap5/_functions.scss 151:11 opaque() htdocs/theme/raw/sass/lib/bootstrap5/mixins/_table-variants.scss 4:28 table-variant() htdocs/theme/raw/sass/lib/bootstrap5/_tables.scss 134:3 @import htdocs/theme/raw/sass/lib/bootstrap5/bootstrap.scss 22:9 @import htdocs/theme/raw/sass/style.scss 14:9 @import htdocs/theme/subthemestarter/sass/style.scss 26:9 root stylesheet Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996956] Re: RSS icon too tiny next to H1 for forums
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996956 Title: RSS icon too tiny next to H1 for forums Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: The RSS icon that is float right to the H1 in a forum is very small and very easy to miss. Need to remove the class text-small, and increase size and vertical align with padding to the H1. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996954] Re: Disabled delete button has red icon still
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996954 Title: Disabled delete button has red icon still Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Disabled unsubscribe button in Group Forum has a red icon when it should be grayed out like the text for all disabled buttons. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999347] Re: Update SimpleSamlPhp in Mahara to 1.19.7
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1999347 Title: Update SimpleSamlPhp in Mahara to 1.19.7 Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Update includes a security fix To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1999347/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998860] Re: Problems with deleting a page / person when page is on a watchlist
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998860 Title: Problems with deleting a page / person when page is on a watchlist Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: There are couple of issues around watchlists and queued items To test - problem one: 1) Create a site and add some people to it 2) Create a group and add some people as members 3) As group creator add a page to the group and add a block to the page 4) Masquerade as another group member and view the page - add page to watchlist 5) As this group member edit the page and add a block 6) Then straight away delete the block and go to the group portfolios page and delete the page (do this quickly to beat cron) You get an error: ERROR: update or delete on table "view" violates foreign key constraint "watcqueu_vie_fk" on table "watchlist_queue" This is because when you edit a page that is being watched the watchlist_queue table gets populated with changes and when you delete the block the line isn't removed from the watchlist_queue just the block ID (as it is still a valid view change - the block deletion) so when you try and delete the page it's still referenced. We need to remove the reference on page deletion To test - problem two: 1-5) The same steps as above 6) Stop masquerading as other person and delete person Person deletes successfully but they are still referenced in the watchlist_queue table - we need to remove those references on person deletion so we don't try and send a notification to a deleted person To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998860/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1993361] Re: "Site registration" lang string ID in admin/index.tpl needs to be modified.
** Changed in: mahara/21.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1993361
Title:
"Site registration" lang string ID in admin/index.tpl needs to be
modified.
Status in Mahara 21.10 series:
Fix Released
Status in Mahara 22.04 series:
Fix Released
Status in Mahara 22.10 series:
Fix Released
Bug description:
I think we should modify the "Site registration" lang string ID in
admin/index.tpl as below.
File to modify:
theme/raw/templates/admin/index.tpl
Line:
81
[ Before ]
{if $newregisterpolicy}
{str tag=newregistrationpolicyinfo section=admin}
{/if}
[ After ]
{if $newregisterpolicy}
{str tag=newregistrationpolicyinfo1 section=admin}
{/if}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/21.10/+bug/1993361/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995527] Re: Unable to delete a group
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995527 Title: Unable to delete a group Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When I try to delete a group when the submissions plugin is not installed I get the following message: ERROR: relation "module_submissions" does not exist This module may not be installed if upgrading from older system. Need to add an if_plugin_installed() check similar to is_plugin_active() so we can check if a plugin has been installed at some point even if it's not active currently - because when deleting a group we want to delete the info for the plugin even if it's not active. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995527/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996472] Re: Respect the 'do not send stats' when not in production mode
** Changed in: mahara Milestone: 23.04.0 => None ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996472 Title: Respect the 'do not send stats' when not in production mode Status in Mahara: Fix Released Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When you create a site when " $cfg->productionmode = false; " you can't register the site with Mahara.org (which is correct). And if you change the site to " $cfg->productionmode = true; " you can register with Mahara.org (again this correct). But if you then set the site back to " $cfg->productionmode = false; " it will continue to send registration data (this is not correct). We need a check to see what mode the site is in before sending the data and only do it if the site is currently in production mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996472/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997280] Re: LTI/LTI_Advantage and webservice check
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997280 Title: LTI/LTI_Advantage and webservice check Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Now that we pair up webservice auth instances to the thing that required them it means we can have more than one auth instance where the institution and authmethod are the same. But in LTI / LTI_Advantage we do a get_field() check that expects only one record to be returned. We need to adjust this check to make sure at least one record exists. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997280/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997298] Re: Copying a collection with SmartEvidence throws errors
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997298 Title: Copying a collection with SmartEvidence throws errors Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When copying a Collection with SmartEvidence the attached errors show up. This appears to be from the foreach ($evidences as $evidence) loop when $newartefact does not appear as a key in $newblocks. To replicate: * Create a Collection * Add SmarteEvidence * Add an Annotation block * Copy the Collection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997298/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997308] Re: SAML affiliated emails can cause email drift
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997308 Title: SAML affiliated emails can cause email drift Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Where the primary email in artefact_internal_profile_email is different to the email listed in usr.email field This is because the $user->email value is updated with the 'email' field from SAML and is not overridden by the affiliate email value when logging in and updating a user record To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997308/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997906] Re: LDAP not working in correctly in 22.10
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997906 Title: LDAP not working in correctly in 22.10 Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: We now get a: PHP Fatal error: Cannot redeclare group_user_access() (previously declared in /var/www/html/lib/group.php:38) in /var/www/html/lib/group.php on line 38 This is because we are already including the lib/group.php file earlier in the chain of loading things in some instances. We need to adjust the require() calls to require_once() To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997906/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004137] Re: PHP 8 compatibility causing error with PHP 7.4 for XML-RPC
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004137 Title: PHP 8 compatibility causing error with PHP 7.4 for XML-RPC Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Mahara: 22.10.0 DB: Postgres 14.3 OS: Linux 20.04 Browser: n/a The use of "mixed" type is supported in PHP 8.0+. It was introduced in this file: https://reviews.mahara.org/c/mahara/+/12921/28/htdocs/lib/applicationset.php with 2 functions: 1. current() : mixed 2. key() : mixed With PHP 7.4, when configuring institutions with Moodle integration (XML-RPC for example), the following error is received: "PHP message: [WAR] 40 (lib/errors.php:529) [TypeError]: Return value of ApplicationSet::current() must be an instance of mixed, instance of Application returned at /var/www/site/lib/applicationset.php:45 A type should not be set for these functions until it's fully implemented for PHP 8.0+. I only found those 2 instances in Mahara 22.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004137/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997918] Re: Message "send message" page has broken layout due to nested tags
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997918 Title: Message "send message" page has broken layout due to nested tags Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Currently under certain conditions the previous message display looks broken in the collapsible area part. This is due to a tag being nested within another tag. Coding standards say "Nested links are illegal - The a element can be wrapped around entire paragraphs, lists, tables, and so forth, even entire sections, so long as there is no interactive content within (e.g., buttons or other links)." We need to fix this up so that it follows html guidelines and also keeps the info we want To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997918/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004511] Re: Profile image used in image block gives errors
** Changed in: mahara Status: Fix Committed => Fix Released ** Changed in: mahara/22.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004511 Title: Profile image used in image block gives errors Status in Mahara: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When I do the following: 1) add a profile image to a person's account 2) create a page 3) add an image block to the page and pick the profile image See the following errors: Undefined variable: isdecorative Undefined variable: alttext Undefined variable: altiscaption To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004511/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004852] Re: LTI 1.1 grading not working for some locales
** Changed in: mahara
Status: Fix Committed => Fix Released
** Changed in: mahara/22.10
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2004852
Title:
LTI 1.1 grading not working for some locales
Status in Mahara:
Fix Released
Status in Mahara 21.10 series:
Fix Released
Status in Mahara 22.04 series:
Fix Released
Status in Mahara 22.10 series:
Fix Released
Status in Mahara 23.04 series:
Fix Released
Bug description:
With a LTI to a Moodle instance, when the teachers grades a
submission, the grade is not sent to Moodle in some cases. I think it
has to do with my server's locale set to french. The grade of 94%, for
example, si translated to 0,94 instead of 0.94.
I printed some debug and was able to see the error "Score must be
numeric". I also printed the xml from the $body variable (see
attachment).
I made a few changes in function publish_lti_outcome of
htdocs/module/lti/lib.php around line 1001 and it now works correctly.
$grade = $this->grade / 100;
$grade = str_replace(',', '.', $grade);
$smarty->assign('score', $grade);
This was tested with Mahara 22.10 and Moodle 3.11.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2004852/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1971914] Re: Make the Elasticsearch 7 individual type reindexing functionality more accessible
** Changed in: mahara/22.10 Status: Confirmed => Fix Released ** Changed in: mahara Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1971914 Title: Make the Elasticsearch 7 individual type reindexing functionality more accessible Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: On the settings page for Elasticsearch 7 /admin/extensions/pluginconfig.php?plugintype=search&pluginname=elasticsearch7 the section 'Index reset' needs a bit of an accessibility review and update as elements are not fully accessible: - Use the 'standard btn-secondary' class to make buttons visible as they are not disabled, but clickable. - Identify which button goes with which type. - Turn 'Requeue' button label and the new version of 'Requeue all items' into proper lang strings. - The 'Requeue all items' label should be changed as it doesn't indicate that you can actually requeue individual items. Individual labels are needed, one for each item type. - A help icon is needed - The 'Reset ALL indexes' button should move to the bottom of the page as it also saves the form. We would then have two buttons: 'Save settings' (primary) and 'Save settings and requeue all indexes' (secondary) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1971914/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1972912] Re: The reference link to a collection on submission.php on a revoke submission form goes to the wrong page with LTI 1.1
** Changed in: mahara/22.10 Status: Confirmed => Fix Released ** Changed in: mahara Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1972912 Title: The reference link to a collection on submission.php on a revoke submission form goes to the wrong page with LTI 1.1 Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: Replicate: With a moodle site set up with LTI, e.g.https://webservices- moodle.catalystdemo.co.nz/course/view.php?id=154 : - go to a course with an 'External tool' activity set up by an admin - log in as a student - submit a collection - on the same, click on the link that is the title of the submitted collection Expected: we land on the first page of the collection Actual: we land on the 'Manage collection' page. Note: might want to check if we can submit collections with no pages To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1972912/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1990981] Re: Unable to copy pages or collections into group
** Changed in: mahara/22.10 Status: Fix Committed => Fix Released ** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1990981 Title: Unable to copy pages or collections into group Status in Mahara: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Released Status in Mahara 23.04 series: Fix Released Bug description: When trying to copy a page or collection into a group, the group information gets lost when moving away from the first page of candidates. Collections will be copied, but into the personal area, not into the desired group. Debugging shows line 6504 in lib/view.php to be the culprit. Adding params only when there are none makes no sense. Removing the negation seems to solve the problem. Please find patch included. First part of patch solves a type mismatch error related to copying pages with certain artefacts. Second part solves this actual bug. Mahara version 22.04.2 Ubuntu 20.04 MariaDB 10.3 Reproducible on current demo.mahara.org To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995527] Re: Unable to delete a group
** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995527 Title: Unable to delete a group Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When I try to delete a group when the submissions plugin is not installed I get the following message: ERROR: relation "module_submissions" does not exist This module may not be installed if upgrading from older system. Need to add an if_plugin_installed() check similar to is_plugin_active() so we can check if a plugin has been installed at some point even if it's not active currently - because when deleting a group we want to delete the info for the plugin even if it's not active. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995527/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1973249] Re: Releasing submissions: error message on failure
** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1973249 Title: Releasing submissions: error message on failure Status in Mahara: Fix Committed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Linux/Ubuntu/Postgres When releasing a submission, if it fails, it's not evident that it needs to be re-queued in order for the cron to try releasing it again. We need an error message that tells people to go to the Admin > People > Export queue page, where you can requeue the submission. Or at least a message that says requeue. Currently, you can replicate a failed submission release by enabling the experimental PDF Export Plugin, as this causes an error when releasing a submission. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1973249/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995533] Re: Unable to see skin artefacts owned by another person
** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995533 Title: Unable to see skin artefacts owned by another person Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Released Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Now that we are using accesscontrol.php for checking if we can see the artefact we need to have a check when the artefact is part of a skin To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995533/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1990981] Re: Unable to copy pages or collections into group
** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1990981 Title: Unable to copy pages or collections into group Status in Mahara: Fix Committed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When trying to copy a page or collection into a group, the group information gets lost when moving away from the first page of candidates. Collections will be copied, but into the personal area, not into the desired group. Debugging shows line 6504 in lib/view.php to be the culprit. Adding params only when there are none makes no sense. Removing the negation seems to solve the problem. Please find patch included. First part of patch solves a type mismatch error related to copying pages with certain artefacts. Second part solves this actual bug. Mahara version 22.04.2 Ubuntu 20.04 MariaDB 10.3 Reproducible on current demo.mahara.org To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1972912] Re: The reference link to a collection on submission.php on a revoke submission form goes to the wrong page with LTI 1.1
** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1972912 Title: The reference link to a collection on submission.php on a revoke submission form goes to the wrong page with LTI 1.1 Status in Mahara: Confirmed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Confirmed Status in Mahara 23.04 series: Fix Released Bug description: Replicate: With a moodle site set up with LTI, e.g.https://webservices- moodle.catalystdemo.co.nz/course/view.php?id=154 : - go to a course with an 'External tool' activity set up by an admin - log in as a student - submit a collection - on the same, click on the link that is the title of the submitted collection Expected: we land on the first page of the collection Actual: we land on the 'Manage collection' page. Note: might want to check if we can submit collections with no pages To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1972912/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1997291] Re: DOMDocument::loadHTML() expecting '; '
** Changed in: mahara/22.10 Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1997291 Title: DOMDocument::loadHTML() expecting ';' Status in Mahara: In Progress Status in Mahara 22.10 series: Confirmed Status in Mahara 23.04 series: In Progress Bug description: While running /lib/cron.php I noticed a lot of PHP Warnings on the next page load. These are also in the error log. My current suspicion is that these are triggered when trying to send e-mail about forum activity. The actual error: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity. While this is a PHP Warning it isn't causing crashes. However, it will be filling up error logs and may be causing unexpected behaviour in other places. This error is occurring whenever html2text() is called. This is calling HtmltoText which calls DOMDocument and this is where the error happens. When DOMDocument::loadHTML() is called the errors are thrown whenever a non-encoded ampersand is found in the document. i.e. & rather than & Showing the error in an interactive shell: php > # Example 1: php > $s = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > # Example 2 is to demonstrate a working version of the string: php > $t = 'Forum topichttps://dev.mahara.local/artefact/file/download.php?file=193&embedded=1&group=1&topic=1&post=1";>'; php > php > $doc = new DOMDocument; php > $doc->loadHTML($s); PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 PHP Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity, line: 2 in php shell code on line 1 php > $doc->loadHTML($t); php > The examples I've been finding are in interaction_forum_post's with images in them. The specific code that causes this to come about looks to be in in prepare_post_body() in htdocs/interaction/forum/lib.php. This is explicitly stripping out & and leaving just the & character in any tags that have a call to download.php when a post is saved. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1997291/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1971914] Re: Make the Elasticsearch 7 individual type reindexing functionality more accessible
** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1971914 Title: Make the Elasticsearch 7 individual type reindexing functionality more accessible Status in Mahara: Confirmed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Confirmed Status in Mahara 23.04 series: Fix Released Bug description: On the settings page for Elasticsearch 7 /admin/extensions/pluginconfig.php?plugintype=search&pluginname=elasticsearch7 the section 'Index reset' needs a bit of an accessibility review and update as elements are not fully accessible: - Use the 'standard btn-secondary' class to make buttons visible as they are not disabled, but clickable. - Identify which button goes with which type. - Turn 'Requeue' button label and the new version of 'Requeue all items' into proper lang strings. - The 'Requeue all items' label should be changed as it doesn't indicate that you can actually requeue individual items. Individual labels are needed, one for each item type. - A help icon is needed - The 'Reset ALL indexes' button should move to the bottom of the page as it also saves the form. We would then have two buttons: 'Save settings' (primary) and 'Save settings and requeue all indexes' (secondary) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1971914/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996475] Re: Allow submissions to create a duplicate page/collection and submit that leaving the original still editable
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996475 Title: Allow submissions to create a duplicate page/collection and submit that leaving the original still editable Status in Mahara: Fix Released Bug description: ## High level functionality summary When a student submits a portfolio for assessment, a **copy** is made in their Mahara account, which is submitted rather than the original portfolio. That copy is available through Mahara. If the student accidentally deletes the submission link from an external LTI submission, e.g. Brightspace assignment, before they submit the assignment, they can return to the Brightspace 'Quicklink 'option and select their portfolio again for submission and a new copy is made. The previous copy is still available in Mahara, but not shown to the student in the 'Quicklink' option. All changes are made on the Mahara side to which parts LTI will 'call' and how we deal with submissions to ensure that no changes are needed on the LMS that wouldn't be LTI calls. ## Workflow 1. The student selects portfolio via the Brightspace 'Quicklink' menu. 2. The student confirms that they want to submit the portfolio. The submission confirmation screen message changes from 'If you submit "Title of the portfolio" for assessment, you will not be able to edit its content until marking has finished. Are you sure you want to submit this portfolio now?' to 'If you submit “Title of the portfolio” for assessment, a copy of that portfolio will be made and submitted. Do not remove the link that is inserted into the 'Text Submission' box. If you do, select your portfolio again via the 'Quicklink' and submit it again. You can continue working on the portfolio itself, but changes you make to it will not be reflected in your submitted portfolio.' 3. Student must click the 'Confirm' button to continue or the 'Cancel' button to select another portfolio. The following assumes that the student confirmed the submission. 4. A copy of the portfolio that is being submitted is made without adding a 'Copy of' at the start of the portfolio or a version number at the end to any page or collection title. Instead, the portfolio title (either title of the collection if the portfolio is a collection or title of the page if the portfolio is a single page; pages within a collection do not change their page title) is appended with '; submitted at DDMMYY, HH:MM', e.g. 'Assessment portfolio; submitted at 09/09/2022, 11:59'. The short date version is used so as not to make the title longer than necessary. A suffix is chosen so if portfolios are all listed in one area, all related portfolios are grouped together alphabetically. 5. A link to the original portfolio is added to the collection and page settings to find the original more easily later on. This is similar to the link added when a template is copied. The same logic will apply, i.e. if the original still exists, it is linked, if it was deleted, no link will be provided. 6. The submission copy is flagged as 'Submission' so it can be filtered from the list of portfolios a student sees on their 'Pages and collections' overview page and also wherever portfolios are selected for submission so they are not displayed when viewing portfolios available for submission. 7. On the 'Pages and collections' overview page an option is added to include submitted portfolios in the display. Per default, they are excluded. 8. Submitted copies behave like submitted portfolios right now: They are marked in yellow on the 'Pages and collections' overview page and an icon added to the left of the 'More options' menu to indicate that it's a submission. The submission time is mentioned in the 'More options' menu. The portfolio cannot be deleted and artefacts are locked. Page comments are added to this copy and stay with it. They are not added to the original portfolio. Artefact comments are visible on other pages when the artefact is added there. 9. When the instructor finished grading and the portfolio is unlocked, it is still flagged as 'Submission' but is not marked in yellow any more and the student can remove the 'Submission' flag from the page settings or collection settings if they want to 'promote' this portfolio to a regular portfolio so they can continue working on it and maybe even re-submit that copy if the original already diverged. 10. Submissions that have been returned to the student can be deleted through the normal deletion process and students can change anything else in them, including portfolio title, artefacts, etc. 11. Students cannot revoke a submission on their own. However, a site administrator can do so in Admin menu → Groups → Submissions through the
[Mahara-contributors] [Bug 2003990] Re: GrumPHP Mahara for linting on commits
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003990 Title: GrumPHP Mahara for linting on commits Status in Mahara: Fix Released Bug description: Currently pulls in our phpstan.neon file and runs phpstan on `git commit` related commands. Refer to https://github.com/phpro/grumphp Quick start: - composer require --dev phpro/grumphp - composer require --dev phpstan/phpstan In case SimpleSAMLPHP throws phpstan errors: run `make ssphp` To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008034] Re: Allow certain password fields to be toggled to display plain text
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008034 Title: Allow certain password fields to be toggled to display plain text Status in Mahara: Fix Released Bug description: We don't want this for all fields but just certain fields where we'd want to copy/paste the password text, for example the forgot password form or the reset password field in admin section This feature was sponsored by Pharmacy Council of New Zealand To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008034/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006523] Re: Do not list group homepage in group views block that can only appear on group homepage
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006523 Title: Do not list group homepage in group views block that can only appear on group homepage Status in Mahara: Fix Released Bug description: It makes little sense to list and have a link to group homepage when on the group homepage (circular reference) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006523/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007897] Re: Different icons on 'Portfolios' overview page when portfolio is submitted
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007897 Title: Different icons on 'Portfolios' overview page when portfolio is submitted Status in Mahara: Fix Released Bug description: In bug #1996475 we are changing the submission workflow so that copies of portfolios are submitted. Currently, the only differentiator between submitted portfolios and those that are ready to be turned into regular portfolios is colour: muted yellow (fully submitted) and muted green (not submitted any more, but still marked as submission so it doesn't clutter the regular portfolios screen). We should have another visual indicator for those that can't perceive colour. The idea is to use different icons in place of the 'More options' icon instead of having an information icon that is not clickable. That means, to tie in with the three different states that we have: 1. Regular portfolio: 'More options' icon of the ellipses 2. Submitted portfolio: Instead of the ellipses have icon check-to-slot that we already use for 'Submissions' in the admin area https://fontawesome.com/icons/check-to-slot?s=solid&f=classic ; tooltip / screenreader text: 'Submission information for "Title of the portfolio"' 3. Released portfolio but still flagged as submission: Instead of the ellipses have icon square-check https://fontawesome.com/icons/square-check?s=regular&f=classic ; tooltip / screenreader text: 'Portfolio "Title of the portfolio" released' Once we have the icons, check with Evonne if we should / could colorise them to match the muted colour states, but we'd need to check the contrast. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013001] Re: Change email header in 'logged in' contact us from 'From' to 'Reply-to'
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013001 Title: Change email header in 'logged in' contact us from 'From' to 'Reply- to' Status in Mahara: Fix Released Bug description: When you send a 'Contact us' message while you are not logged in, Mahara sends it correctly: From: [Site name] Reply-to: [Sender name] However, when you are logged in, it puts the sender's details in the 'From' field and thus the 'Reply-to' field is ignored. We need to follow the logged out sender format so that email providers don't put our mails into spam because they think we are pretending to send from a domain we don't control. So instead of having a customisation to do things differently for 'Contact us', we should have one rule that follows what we currently do for emails when people are not logged in. How to differentiate the notifications when logged in and when not? - The notification when someone is logged in includes a link to their profile URL via 'See...' after the main body of the message. The scenario that should be covered: 1. You are not logged into Mahara. 2. Send a message via 'Contact us'. 3. Existing behaviour:The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. 4. Log into Mahara as a regular account holder. 5. Send a message via 'Contact us'. 6. The email sent to the site admin has the no-reply email address for the site in 'From' and the sender's email in 'Reply-to'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013001/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991602] Re: Outcomes portfolio (2): Group changes
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991602 Title: Outcomes portfolio (2): Group changes Status in Mahara: Fix Released Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Group_changes # Group changes ## High level overview A new group type is created that defines the editing permissions on a portfolio and access to certain other pages within a portfolio. ## Details These are the changes in groups that can't be done via configuration. Create the group type 'Outcomes' that becomes available when an institution uses 'Outcomes portfolio'. The following rules apply when that group type is selected: * Based on the 'Controlled' group type, i.e. members can be added and aren't allowed to leave * Only group admin can see the 'Add' button on the 'Portfolios' overview page. However, everybody will be able to edit regular portfolio pages. * Nobody sees the 'Copy' button on the 'Portfolios' overview page. * Nobody can use the 'Copy' button in the 'More options' menu to make a copy of the portfolio in their personal account at this stage because that functionality is out of scope. * Only group admins can access the collection's 'Edit' and 'Manage outcomes' screens, but everybody can edit regular portfolio pages. * Only group admins and group tutors can change the sharing permissions for a portfolio either directly on a page or via the 'Portfolios' overview page. * Only allow group admins and group tutors to edit the group homepage. * Per default, all collections created in a group with the type 'Outcomes' have 'Outcome portfolio' selected automatically in the collection settings. * Group admins and group tutors can delete an entire portfolio or individual pages within it, but regular group members can't. * Group members cannot change the activity information or remove the associated block from the page. * Group tutors and admins can change the activity information but cannot remove the block itself from the page as it is placed there automatically. * Group members cannot remove a checkpoint block from their page once it has been placed there, but they can remove evidence from the checkpoint. Group tutors and admins can remove checkpoints. * 'Prevent removing of blocks' is automatically turned on to prevent group members from accidentally removing content blocks from the page. This setting can be changed though by anybody either temporarily or for longer. Out of scope: Tie the switch in with a particular set of roles that should be allowed to change the setting. * The outcomes portfolio is not to be locked as it is more or less a rolling document. → Nothing to develop here as that is the default. * Hide 'Group homepage' in the block 'Group portfolios'. * Hide forums (via group_menu_items() function in interaction/forum/lib.php) * Hide plans (via group_tabs() function in artefact/plans/lib.php) > Defaults for group settings on the group creation screen are defined in the *Administration menu → Groups → Default group settings* instead of hard-coding them so that the group type can be used more flexibly if needed. > 'Hide' means that the functionality is also not available when you know the URL. Why is a group used? * Both learners and staff can edit portfolios collaboratively. Permissions don't need to be changed as they would if we were to create portfolios in the personal portfolio area. * Site admin can create groups in bulk via CSV and add group members via CSV, including their roles in bulk, which makes the creation of the groups and updating the group membership efficient without needing to enter every single group. * Groups can have three roles: member, tutor, and administrator, which we can use to allow certain functionalities for the three different groups of people that need access to an outcome portfolio. * Basic group settings can be predefined and group homepage set up as a template. * All outcome portfolios for a group member can be held in the same group to easily see what the group member had been working on before, i.e. there is one group per learner and their support staff. > What is displayed on the group homepage can be set in the template in the site administration. > Defaults for group settings on the group creation screen are defined in the *Administration menu → Groups → Default group settings* instead of hard-coding them so that the group type can be used more flexibly if needed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991602/+subscriptions ___
[Mahara-contributors] [Bug 1991603] Re: Outcomes portfolio (3): 'Outcomes' infrastructure in the group collection
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1991603
Title:
Outcomes portfolio (3): 'Outcomes' infrastructure in the group
collection
Status in Mahara:
Fix Released
Bug description:
Part of the outcomes portfolio blueprint:
https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio
Better formatting:
https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Outcomes_infrastructure_in_a_group_collection
## High level overview
* Create the 'Manage outcomes' page infrastructure ('Manage outcomes – group
admin only' mock-up)
* Create the outcomes overview page and infrastructure
* Allow for the direct editing of fields
* Allow for the clicking of icons to complete outcomes and activities
* Create new pages (activities) from this page and set them up
* Pull in activity information from the individual pages
* Respect permissions for the different types of group members and who can
edit or only see what
## Details
### Mock-up reference: 'Set up the outcomes collection - group admin
only'
**Who?** As a group admin...
**What?** I want to be able to set up an outcomes collection...
**Why?** So that group tutors or I can add activities and prepare
everything for the group member to get started.
The collection is set up in a group for a particular group member by a
group admin. The numbered list refers to the bullets in the mock-up
'Set up the outcomes collection - group admin only'.
1. [no change] Collection name: Title of the outcomes portfolio. You can
choose that freely, but might want to establish a convention to differentiate
between the different plans that a group member may have.
2. Per default, the option 'Outcomes portfolio' is set to 'Yes'. This is done
automatically when the institution selected to work with outcomes portfolios
(see section 'Outcomes portfolio setting and database tables').
3. You can select the outcomes category from which all outcomes within the
collection shall take their outcome type. If there is only one category, the
category is displayed without the drop-down menu.
4. Clicking the 'Continue' button takes you to a new page where you can
manage the outcomes.
Additional changes (not pictured):
5. Option 'Manage outcomes' is accessible from the collection settings screen
and also on the 'Portfolios' overview page when clicking the 'More options'
icon on a collection for group admins only.
6. Option 'Manage pages' is not available from the collection settings screen
or via the 'More options' icon on a collection on the 'Portfolios' overview
page to avoid pages from being added to or removed from the collection outside
of the outcomes framework. It can also not be reached by URL.
> Out of scope: Be able to add regular portfolio pages to the
collection and not only activity pages.
### Mock-up reference: 'Manage outcomes - group admin only'
**Who?** As a group admin...
**What?** I want to enter the outcomes for a group member's outcomes
portfolio...
**Why?** To prepare the collaboration space for group tutors and group
members.
* The Mahara collection creation process will be used.
* Outcomes are set up and modified, but interactions primarily performed by
group tutors are done in 'Display' mode.
* In phase 1, we don't anticipate being able to move outcomes around but
would expect that they are set up in order.
* Outcomes can be deleted.
The numbered list refers to the bullets in the mock-up 'Manage
outcomes - group admin only'. Group tutors and group members do not
have access to this page.
> Notes:
> * One outcome field set is set up per default as that is the minimum that
is required.
> * collection_outcome table: ID, collection ID, short title, full title,
outcome type ID, support (boolean), progress (text), completed (boolean),
section that shows the ID from the 'collection_view' table of the 'section'
there. This 'section' is needed in here in case we delete an outcome or in
future want to re-order outcomes.
> * Collection_view table: create new column 'section' that in this case
states the outcome ID to which the page belongs (section ID is the ID of the ID
from the collection_outcome table.
> * Each outcome is its own Pieform and has its own 'Save' button that is not
displayed though.
1. Outcomes are auto numbered to distinguish them. When an outcome is
deleted, the number is automatically updated (on page load).
2. Short title: Short title for the outcome as that becomes the page title.
Suggested: 70 character limit. This field is mandatory.
3. Full title: The full name of the outcome text. Suggested: 255 character
limit.
4. Outcome type: Select list with the abbreviation of the outcome and the
colou
[Mahara-contributors] [Bug 1991604] Re: Outcomes portfolio (4): Activity page infrastructure
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991604 Title: Outcomes portfolio (4): Activity page infrastructure Status in Mahara: Fix Released Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Activity_page_infrastructure # Activity page infrastructure ## High level overview * Add activity information to the page settings → Create a new portfolio page type * Pull in information from tables and people to auto-populate information * Display activity information set up on the page settings page * Update certain information directly while editing or viewing the activity page * Dealing with 'signing off' / completing activities ## Details ### Mock-up reference: 'Set up activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to set up activites for the group member... **Why?** So that all admin work is collected in one place and then available when I work with the group member on a particular activity. The numbered list refers to the bullets in the mock-up 'Set up activity page – group tutors and group admin'. This page is only accessible to group tutors and group admins. Students cannot get to it. 1. [no change] Page title: It's a short title of the activity to avoid that the heading of a page is longer than one line and therefore fits better into a navigation menu. This title is pulled into the outcomes overview page automatically. Mandatory field. 2. Activity information panel: automatically uncollapsed as information needs to be entered. 3. Activity description: Long title of the activity. Mandatory field. 4. Subject: Select list with hard-coded items (phase 1). 5. Responsible staff: Select list comprised of all group tutors and group admins from this group. The person filling in the form is automatically displayed as default choice. 6. Start date: Date picker. 7. End date: Date picker. Check that the end date is greater or equal to the start date. 8. Levels of achievement: Three single-line text entry fields. The fourth level is predefined. * Icons are assigned automatically. * Level 1 is the highest achievement and level 4 the lowest. * Suggested icons: Font Awesome number corresponding to the level with a circle around it in primary theme link colour but with a new variable set up if a different colour should be used. This will need to be achieved with stacked icons, e.g. icon-1 and icon-circle. * New table 'view_activity_achievement_levels' with ID, view_activity_ID (i.e. the view ID), priority column (1-4), value and level 4 always being the same (via hidden value). 9. Clicking 'Save' takes you to the 'Edit' screen of the activity page. > Notes: > > * The page buttons have changed slightly in Mahara 22.10 and thus will be used instead of the ones pictured on the mock-up. > * This settings page is only available to group tutors and group admins. > * The rest of the page settings stay as they are in the 'Advanced' panel. > * 'Prevent removing of blocks' in the 'Advanced' panel is automatically set to 'Yes' (see section 'Group changes') but can be changed to 'No'. ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. 1. 'Settings' button: Available to group tutor and group admins to change information about the activity. It's not accessible to regular group members. 2. Activity information: * is displayed at the top of the page and cannot be moved. * is displayed collapsed so that you only see the long-form activity, outcomes, outcome type, and whether the outcome has been achieved or not in the panel header. * is a full-page width block. → Change the default width of blocks in Mahara when they are put on a page into full-page width blocks 3. Activity description: Long 'title' of the activity. 4. Outcome: Short title of the outcome to which this activity belongs. 5. Outcome type: Pulled from the outcome, i.e. short name with the predefined background colour. 6. Achieved: Switch to decide whether an outcome has been achieved or not. This can always be changed. A modal is displayed to
[Mahara-contributors] [Bug 1991605] Re: Outcomes portfolio (5): Checkpoint block infrastructure
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991605 Title: Outcomes portfolio (5): Checkpoint block infrastructure Status in Mahara: Fix Released Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio This is especially closely linked to bug #1991604 Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Checkpoint_block_infrastructure # Checkpoint block infrastructure ## High level overview * Create a new block type * Pull information through from the activity page setup for levels of achievement * Deal with achievements and rules of what shall happen once a checkpoint has been achieved * Resembles the peer assessment block * No restriction though who can add comments * No draft option * No instructions * Page comments are still kept separate and could still be used. ## Details ### Mock-up reference: 'Edit activity page – group tutor and group admin' **Who?** As group tutor or group admin... **What?** I want to add content to the activity page... **Why?** To assist the learner with their evidence collection and mark checkpoints as completed to illustrate progress. The numbered list refers to the bullets in the mock-up 'Edit activity page – group tutor and group admin'. This page is accessible to group tutors, group admins, and learners. Items 1-13 are part of the 'Activity page infrastructure' (see section there for details). Here are only the items listed that pertain to the 'Checkpoint' block, which is a new block type. 14. Checkpoint block is added in full width. When a checkpoint block is deleted by a group tutor or group admin, there is logic that renames all subsequent blocks. 15. Click 'Add comment' to add a comment to the checkpoint. Comments are displayed in reverse chronological order. 16. When a comment was made, the profile picture, the name, the time the comment was made and the comment itself are displayed. Comments can be saved as draft and then published, similarly to the 'Peer assessment'. Comments can be added no matter whether a checkpoint has been achieved or not. 17. [no change] Additional blocks can be pulled onto the page. 18. Set the achievement level with the drop-down menu. The help icon displays the long-form text for the levels. The menu itself only displays 'Level 1', 'Level 2', 'Level 3', and 'Level 4'. 19. Once the level has been set, a number icon represents the achievement level and below it is a help icon that contains the name of the person who set the level and when they did it. It also contains the long description of the achieved level. 20. Group tutors and group admins can delete comments. Editing of comments is possible for 10 minutes after posting or until somebody adds a new comment, whichever comes first. Group members cannot delete comments. > Note: It is possible to add new comments no matter whether an achievement level has been set or not. * New block type but block config is just the normal things that we record for blocks: block type, view, config data, dimensions * new table: ID, blockID, achievement level ID, userID, ctime * New table to record checkpoint results for future proofing in case things do need to be reported over it * Fetches achievement levels from the view_activity_achievement_level table * Levels: Lang string 'Level' added automatically to the priority number of the level * Actual name of the levels is in the help icon * New artefact table similar to peer assessment table To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991605/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996114] Re: Move sign-off/verify functionality out of the sign-off block
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996114 Title: Move sign-off/verify functionality out of the sign-off block Status in Mahara: Fix Released Bug description: Move the configuration for signing-off and verifying a page into the page settings. Move the action of signing-off and verifying a page out of a block and display it at the top of a page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996114/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995437] Re: Allow SAML auth to be named
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995437 Title: Allow SAML auth to be named Status in Mahara: Fix Released Bug description: The SAML auth method has a hard coded 'SAML' label, which is fine when only one Saml instance is on an institution. But if the institution allows connection via multiple SAML Identity providers then it gets confusing which is which. We should allow the instance 'name' field be filled in (altered from the default) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995437/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2002700] Re: installing not possible mysqli error
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2002700 Title: installing not possible mysqli error Status in Mahara: Fix Released Bug description: OS Informations: Apache2 PHP8.1 MariaDB 10.5.18 OS: Raspbian (Debian 11) I attached a picture with all infos i got so far. Bug: When i try to install the newest Mahara build 22.10.0 (2022090903) i cannot install it. In the webbrowser i get a failed to upgrade error. The database gets created and filled with the config data. But then i get the message, that the multirecipientnotifications is missing. When i try to install it over the cli i get a mysqli_stmt::bind_params() Argument #1 ($types) cannot be empty error caused by adodb-ymsqli.inc.php Line 1241 (directly after the Enabled 3 HTML filters part) I tried php8.0 and now 8.1 same error build. when i try to install mahara 22.4. i get the http 500 status code error. I made the Dataroot /var/mahara and get the www-data group read/write and owner rights the same for the html documentroot of mahara. i tried it on my google chrome (109.0.) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2002700/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2013246] Re: Disable copy page link when link is an tag
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2013246 Title: Disable copy page link when link is an tag Status in Mahara: Fix Released Bug description: Normally the 'copy' option is a button set by pieforms and so has a built in disable/processing system so we can only click it once. But if we have an link tag that hits the copying page directly with the view/collection id there is no disable mechanism on the link once it is clicked. This can cause people to click the link multiple times when the portfolio being copied is large because there is a delay after the clicking and before the finishing of process/redirection to new copy. We need some javascript to disable the link after the first click / show a processing icon so that people can only click it once before the process finishes/redirects To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2013246/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998971] Re: Add ctime and mtime to block_instance table
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998971 Title: Add ctime and mtime to block_instance table Status in Mahara: Fix Released Bug description: Currently, we send notifications out on any change on a page. However, not all changes on a block require letting others know, such as block title changes. With these new columns, we can look at each blocktype independently to decide if a notification needs to be sent out. This will help limit the notification on page updates. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969869] Re: Monitor plugin handle queue not clearing
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969869 Title: Monitor plugin handle queue not clearing Status in Mahara: Fix Released Bug description: After a cron run Eg of the cron limit is 500 but there are more than 500 queued up items then not all will be processed in the run. If that continues then the queue will keep filling up and slow down the system https://reviews.mahara.org/c/mahara/+/12314 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969869/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1966154] Re: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1966154 Title: TinyMCE on mobile doesn't allow for the adding of table rows / editing table properties Status in Mahara: Fix Released Bug description: It is not possible to add more rows to a table when you want to edit text via tinyMCE on a mobile device, e.g. phone. The current mobile interface of tinyMCE prevents the editing of table properties. I checked the online demo of tinyMCE and there it is possible to edit tables in both the basic and fully featured examples https://www.tiny.cloud/docs/demo/ but it doesn't look like those examples are using the mobile tinyMCE interface. We'd need to investigate: - Is the mobile interface we use still supported? There were some deprecations? - Do we still need a special mobile interface or can tinyMCE 5 be used on mobile as is? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1966154/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1969539] Re: Behat test for the portfolio completion page
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1969539 Title: Behat test for the portfolio completion page Status in Mahara: Fix Released Bug description: Related to this bug here: https://bugs.launchpad.net/mahara/+bug/1857933 Test steps (from Release Testing spreadsheet) 1. Admin turns Portfolio completion on in the institution settings 2. Log in as institution member. 3. Create a collection with Portfolio completion turned on. Add 3 pages with the following blocks: P1. Sign-off block P2. Sign-off block with verification enabled P3. No sign-off block 4. Page owner ticks off the pages on the front page of the collection. Portfolio completion shows 67% 5. Owner shares collection with a specific person who they assign the manager role to. 6. Log in as the manager. They should see the following on the collection front page: P1. Sign off block ticked, nothing to do for verifier P2. Sign off block ticked; red dot for verification P3. No sign-off or verification. 7. Manager ticks off the Verification. It becomes a tick and the completion becomes 100% To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1969539/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979274] Re: Clean up doubled up value fields in viewacl.tpl
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1979274
Title:
Clean up doubled up value fields in viewacl.tpl
Status in Mahara:
Fix Released
Bug description:
Doubled up value fields in viewacl.tpl
Removing one of the two
value="{%=o.presets.stopdate%}" value="{%=o.presets.stopdate%}"
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1979274/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1987709] Re: Authentication via SAML looks to cause improper setting of 'lastlastlogin'
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1987709 Title: Authentication via SAML looks to cause improper setting of 'lastlastlogin' Status in Mahara: Fix Released Bug description: It looks like we set it in the auth/saml/lib.php file but also call the $USER->reanimate() function that then calls $USER->authenticate() that also look to set it. We need to check if we actually need to set it in the saml file or just leave it to the reanimate function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1987709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1971898] Re: Pull ReCaptcha library via Composer
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1971898 Title: Pull ReCaptcha library via Composer Status in Mahara: Fix Released Bug description: A wishlist item for tracking the modernisation of how we manage third party libraries. We need to remove third party libraries from our codebase and have them included via composer. The 'make initcomposer' target will need to install the new libraries as well. https://wiki.mahara.org/wiki/Proposals/Management_of_third_party_libraries To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1971898/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991601] Re: Outcomes portfolio (1): Settings and database tables
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991601 Title: Outcomes portfolio (1): Settings and database tables Status in Mahara: Fix Released Bug description: Part of the outcomes portfolio blueprint: https://blueprints.launchpad.net/mahara/+spec/outcomes-portfolio Better formatting: https://wiki.mahara.org/wiki/Proposals/Outcomes_portfolio/Settings_and_database_tables # Outcomes portfolio setting and database tables ## High level overview * Create the 'Outcomes portfolio' option as institution setting so that it can be available for groups created in that institution * Create database tables for outcome types and subjects to record necessary details such as short names and colour code classes where appropriate. > The colours are defined via classes in the stylesheet in the code, not on the interface. ## Details 1. Create the 'Outcomes portfolio' option in the institution settings with rules as for portfolio completion and SmartEvidence, i.e. if somebody is in multiple institutions, they see it if at least one of their institutions has it turned on. * It can be used in conjunction with portfolio completion and SmartEvidence. * It has characteristics of the portfolio completion page (rather than SmartEvidence), i.e. it should be possible in the future to add further blocks to that special first page. * It will be the very first page if portfolio completion and / or SmartEvidence are selected as well. * Initially, it is only available on the group level (group owned collections), but be open to future plans to have it available on personal, institution, and site level as well * Add a new field 'outcomes' into the collection table 2. New database tables for 'Outcome category' (lang string 'Outcome category') and 'Outcome subject' (lang string 'Subject'). These are hard-coded / inserted into the DB for each institution. It is not possible (at this stage) to add or change them via the admin interface. The key value should be a number. The category is created to future proof the functionality for when different outcome portfolios are created that require different outcome types either within one institution or across different institutions. * 1 table for outcome categories (outcome_category): ID, outcome category title [up to 100 characters], institution ID; e.g. here the category would be 'Foundation' (in the future, this could be displayed in the admin interface, but currently is out of scope) * 1 table for outcome types (outcome_type): ID, outcome category ID as foreign key, title of the outcome type [up to 100 characters], abbreviation of the outcome type [up to 10 characters], outcome type background colour which refers to a class that is saved in here and defined in SCSS as a colour (background and border) in ``theme/raw/sass/components/_outcomes.scss`` where we will keep all the outcomes classes. * 1 table for subject categories: ID, subject category name [up to 100 characters], institution ID, e.g. here the category would be 'Subject' (in the future, this could be displayed in the admin interface, but currently is out of scope) * 1 table for subjects: ID, subject category ID as foreign key, title of the subject [up to 100 characters], abbreviation of the subject [up to 10 characters] To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991601/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1991339] Re: Displaying folder block subfolder in modal doesn't respect "Sort order of files " option
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1991339 Title: Displaying folder block subfolder in modal doesn't respect "Sort order of files " option Status in Mahara: Fix Released Bug description: We used to update the block's content with the render_instance() function but now that we open it in a modal we only call it by artefact id - so lose the block settings for ordering we need to open it via the render_details_in_modal() function so we can find/use the sort order setting To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1991339/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995532] Re: Adjust the new View() construct by integer for ID call
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995532 Title: Adjust the new View() construct by integer for ID call Status in Mahara: Fix Released Bug description: We can make the sql query more efficient by doing the filter on the join rather after the join results. Current way SQL explain output: explain analyze select v.id from view v left join "group" g on v.group = g.id where v.id =12 and (v.group is null or g.deleted = 0); QUERY PLAN -- Nested Loop Left Join (cost=0.71..16.75 rows=1 width=8) (actual time=0.015..0.015 rows=0 loops=1) Filter: ((v."group" IS NULL) OR (g.deleted = 0)) -> Index Scan using view_id_pk on view v (cost=0.42..8.44 rows=1 width=16) (actual time=0.014..0.014 rows=0 loops=1) Index Cond: (id = 12) -> Index Scan using grou_id_pk on "group" g (cost=0.29..8.30 rows=1 width=10) (never executed) Index Cond: (v."group" = id) Planning time: 0.652 ms Execution time: 0.107 ms New way SQL explain output: explain analyze select v.id from view v left join "group" g on v.group = g.id and (v.group is null or g.deleted = 0) where v.id = 12; QUERY PLAN Index Scan using view_id_pk on view v (cost=0.42..8.44 rows=1 width=16) (actual time=0.019..0.019 rows=0 loops=1) Index Cond: (id = 12) Planning time: 0.272 ms Execution time: 0.048 ms (4 rows) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995532/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1987717] Re: call_static_method() has been deprecated
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1987717 Title: call_static_method() has been deprecated Status in Mahara: Fix Released Bug description: This is an umbrella bug to catch patchsets that remove call_static_method(). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1987717/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1993079] Re: MNet not saving expiry date correctly on insert of new instance
** Changed in: mahara/23.04 Status: Fix Committed => Fix Released ** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1993079 Title: MNet not saving expiry date correctly on insert of new instance Status in Mahara: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Also not saving on update of MNet instance in some cases. To test have a moodle to connect to and then in mahara make a MNet connection in an institution by adding an xmlrpc auth method. On saving the form it should set an expiry for the certificate. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1993079/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995811] Re: Mark XML-RPC as deprecated
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995811 Title: Mark XML-RPC as deprecated Status in Mahara: Fix Released Bug description: As we are now wanting people to use LTI / LTI_Advantage and don't want to support legacy XML-RPC anymore we should begin by marking the plugin as deprecated so site owners can see that it will soon be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995811/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996956] Re: RSS icon too tiny next to H1 for forums
** Changed in: mahara Milestone: 23.04.0 => None ** Changed in: mahara/23.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996956 Title: RSS icon too tiny next to H1 for forums Status in Mahara: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: The RSS icon that is float right to the H1 in a forum is very small and very easy to miss. Need to remove the class text-small, and increase size and vertical align with padding to the H1. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1995813] Re: Deprecated Sass warning: $weight without unit
** Changed in: mahara/23.04 Status: Fix Committed => Fix Released ** Changed in: mahara Milestone: 22.10.1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1995813 Title: Deprecated Sass warning: $weight without unit Status in Mahara: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated. To preserve current behavior: $weight * 1% More info: https://sass-lang.com/d/function-units ╷ 151 │ @return mix(rgba($foreground, 1), $background, opacity($foreground) * 100); │ ^^ ╵ htdocs/theme/raw/sass/lib/bootstrap5/_functions.scss 151:11 opaque() htdocs/theme/raw/sass/lib/bootstrap5/mixins/_table-variants.scss 4:28 table-variant() htdocs/theme/raw/sass/lib/bootstrap5/_tables.scss 134:3 @import htdocs/theme/raw/sass/lib/bootstrap5/bootstrap.scss 22:9 @import htdocs/theme/raw/sass/style.scss 14:9 @import htdocs/theme/subthemestarter/sass/style.scss 26:9 root stylesheet Deprecation Warning: $weight: Passing a number without unit % (100) is deprecated. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1995813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999137] Re: add members to group if "owngroupsonly" is active does not show potential group members to institution staff
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1999137
Title:
add members to group if "owngroupsonly" is active does not show
potential group members to institution staff
Status in Mahara:
Fix Released
Bug description:
Settings:
- Mahara 22.04 (and also found in mahara 22.10)
- Only administrators and staff are allowed to create groups.
- "owngroupsonly" is activ
- isolated institutions is activ
Problem: add members to group if "owngroupsonly" is activ does not show users
to institution staff
To reproduce try the following steps:
1. Log in as an institutional staff (who is allowed to greate groups).
2. Be sure that the user is NO member of any group espacaly has no other
users in a group he is member.
3. Create a group A.
4. Go to the add user page for the group A.
5. The User can now see a list containing ALL users of the instititution in
the potential members list.
6. Select one or more users and add them to the group A.
7. Now the list of potenial members is empty and no more users can be added
to the group.
8. Create a new group B
9. Go to the add user page for the group B.
10. Now the list of potential members does NOT contain all users of the
institution but only the users from group A.
11. Remove the users added in 6. Now the lists of potential members again in
group A and group B contain all users of the institution.
Solution (line numbers belong to mahara 22.10 code and are different in
22.04):
In line 904 in search/internal/lib.php
$is_admin = $USER->get('admin') || $USER->get('staff');
does not check for institutional staff.
So always line 922
$searchsql .= '
AND u.id IN (' . implode(',', $membergroups) . ')';
creates an sql statment that only shows group members to the staff.
So it might should be added in line 914 just before if
(get_config('owngroupsonly') && !$is_admin)
the folowing code line:
$is_admin = $USER->get('admin') || $USER->is_institutional_admin() ||
$USER->get('staff') || $USER->is_institutional_staff();
So the complete code might be:
$is_admin_or_staff = $USER->get('admin') || $USER->is_institutional_admin()
|| $USER->get('staff') || $USER->is_institutional_staff();
if (get_config('owngroupsonly') && !$is_admin_or_staff) {
// in search results only include users that are members of the
same groups
// site admin and site staff users are excluded
$usergroups = get_column('group_member', 'group', 'member',
$USER->get('id'));
$membergroups = get_column_sql('SELECT member FROM {group_member}
WHERE "group" IN (' . implode(',', $usergroups) . ') AND member != ?',
array($USER->get('id')));
if ($membergroups) {
$membergroups = array_unique($membergroups);
$searchsql .= '
AND u.id IN (' . implode(',', $membergroups) . ')';
}
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1999137/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2000027] Re: Export of resume doesn't always work
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/227 Title: Export of resume doesn't always work Status in Mahara: Fix Released Bug description: Under certain circumstances that are not yet fully explored, a page that has resume fields can't be exported. Someone with a full resume didn't have issues exporting it, but someone with an empty resume and later only an education history did. For Catalyst testing: Petra's page didn't exhibit any issues whereas Percy's did. The error message is attached and more test information will need to be provided. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/227/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1996954] Re: Disabled delete button has red icon still
** Changed in: mahara Milestone: 23.04.0 => None ** Changed in: mahara/23.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1996954 Title: Disabled delete button has red icon still Status in Mahara: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Disabled unsubscribe button in Group Forum has a red icon when it should be grayed out like the text for all disabled buttons. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1996954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2000334] Re: Minor fixes for inbox/messages
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2000334 Title: Minor fixes for inbox/messages Status in Mahara: Fix Released Bug description: Making sure that comparisons work correctly in modern php and that both reply and reply all appear in the inbox if more than one potential recipient This fixes the missing reply buttons problem mentioned in https://mahara.org/interaction/forum/topic.php?id=9202 The issue of not populating the recipients for the form I can't replicate To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2000334/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2000183] Re: Icons missing on pages in a group
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2000183 Title: Icons missing on pages in a group Status in Mahara: Fix Released Bug description: Often, we have an icon as part of a section in Mahara, e.g. on the 'Portfolios' overview page. However, some of these pages in a group don't have one: - Members - Share - Files - Forums - Archive (needs to be activated in group settings) They should have an icon though for consistency. :-) If possible, also add the icon used for the 'Archive' to the 'Archived submissions' tab in Admin area -> Groups -> Submissions. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2000183/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2002924] Re: Problem with divide by zero when setting pagination limit
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2002924
Title:
Problem with divide by zero when setting pagination limit
Status in Mahara:
Fix Released
Bug description:
For certain blocks there is the ability to set the 'count' (pagination
limit) and if one sets it to a non integer value it causes the error:
[DivisionByZeroError]: Modulo by zero
We need to set a rule for the field so that it can only be an integer, eg
'rules'=> array('integer' => true, 'minvalue' => 1, 'maxvalue' =>
100),
To test:
1) Create a plan
2) create some tasks
3) Edit a page and add plan block to page
view page - all is fine
4) Edit the plan block and set 'count' to 'none'
On save - things hang
On page reload - see error
Can't edit page to fix problem so will mark this bug as high
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2002924/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999350] Re: Submissions not showing if wwwroot is not set
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1999350 Title: Submissions not showing if wwwroot is not set Status in Mahara: Fix Released Bug description: If $cfg->wwwroot is not set and wwwroot in the config table is also not set then the path to piertables.js is prefixed with a "/". When this is added to $js in htdocs/module/submissions/src/Controller.php it ultimately ends up with an extra "/" after it is rendered in the template. This results in the browser seeing this as a protocoless URL and failing to resolve the host. To test: Stand up a site without $cfg->wwwroot set. Ensure 'wwwroot' is empty in the config table in the database. Create a Group such that submissions can be made to it. As an account that can submit to that Group create a page or collection and submit it to the Group. As an account that can view Group submissions click through to the Submissions page for the Group. You will note that the submission is not visible. If you view the page source and search for piertables.js you will see the path prefixed with "//". If you open your browser devtools, on the network tab you will see the file does not report as succeeding to load. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1999350/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2000337] Re: Need to remove local language file from core
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2000337 Title: Need to remove local language file from core Status in Mahara: Fix Released Bug description: We somehow committed local/lang/en.utf8/module.lti_advantage.php to core The good thing is the strings in the local version are also in the htdocs/module/lti_advantage/lang/en.utf8/module.lti_advantage.php also so all we need to do is delete the local version. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2000337/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2002364] Re: Copying a group throws error
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2002364
Title:
Copying a group throws error
Status in Mahara:
Fix Released
Bug description:
When you want to copy a group, the following error message is
displayed and the copying aborted:
[WAR] 0b (lib/errors.php:852) Failed to get a recordset: postgres9 error:
[-1: ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
log_message("Failed to get a recordset: postgres9 error: [-1: E...", 8,
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:89
log_warn("Failed to get a recordset: postgres9 error: [-1: E...") at
/home/kristina/code/mahara/htdocs/lib/errors.php:852
SQLException->__construct("Failed to get a recordset: postgres9 error:
[-1: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:1236
insert_record("block_instance", object(stdClass), "id", true) at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kristina/code/mahara/htdocs/lib/group.php:3354
group_copy(3, "mygroups") at
/home/kristina/code/mahara/htdocs/group/copy.php:44
[WAR] 0b (lib/dml.php:1236) Failed to get a recordset: postgres9 error: [-1:
ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
insert_record() at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kristina/code/mahara/htdocs/lib/group.php:3354
group_copy() at /home/kristina/code/mahara/htdocs/group/copy.php:44
[WAR] 0b (lib/errors.php:852) Failed to get a recordset: postgres9 error:
[-1: ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
log_message("Failed to get a recordset: postgres9 error: [-1: E...", 8,
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:89
log_warn("Failed to get a recordset: postgres9 error: [-1: E...") at
/home/kristina/code/mahara/htdocs/lib/errors.php:852
SQLException->__construct("Failed to get a recordset: postgres9 error:
[-1: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:1236
insert_record("block_instance", object(stdClass), "id", true) at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kristina/code/mahara/htdocs/lib/group.php:3354
group_copy(3, "mygroups") at
/home/kristina/code/mahara/htdocs/group/copy.php:44
[WAR] 0b (lib/dml.php:1236) Failed to get a recordset: postgres9 error: [-1:
ERROR: null value in column "ctime" violates not-null constraint
DETAIL: Failing row contains (48, groupmembers, , b:0;, 12, 1, null, null,
null, 2023-01-10 01:43:22).] in EXECUTE("INSERT INTO "block_instance" ("id",
"blocktype", "title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?,
?, ?, ?)")Command was: INSERT INTO "block_instance" ("id", "blocktype",
"title", "configdata", "view", "row", "mtime") VALUES (?, ?, ?, ?, ?, ?, ?) and
values was
(id:48,blocktype:groupmembers,title:,configdata:b:0;,view:12,row:1,mtime:2023-01-1001:43:22)
Call stack (most recent first):
insert_record() at
/home/kristina/code/mahara/htdocs/blocktype/lib.php:2320
BlockInstance->commit() at
/home/kris
[Mahara-contributors] [Bug 2002446] Re: Fix for CurlFactory.php and PHP
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2002446 Title: Fix for CurlFactory.php and PHP Status in Mahara: Fix Released Bug description: The syntax for continue in a switch within a loop is incorrect see https://github.com/guzzle/RingPHP/commit/80d4890f0770a67ab27d839df9db7f04268d0eb7 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2002446/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006632] Re: PHP port in use for behat
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006632 Title: PHP port in use for behat Status in Mahara: Fix Released Bug description: I had an issue running mahara_behat.sh and tracked it down to port 8000 already being used. We should check for the port being in use and incrementing if so. The attached patch resolved this for me. This uses nc (netcat) to test the port. From what I've seen, netcat is installed on more distros than not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006632/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006516] Re: bulk export causing errors for comment / annotation block exports
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006516 Title: bulk export causing errors for comment / annotation block exports Status in Mahara: Fix Released Bug description: The comment block problem is when you are doing a bulk export via CLI as the $exporter object is not in a global scope and so can't be 'seen' by the comment block renderer. The annotation problem is we are trying to create a pieform during export and it can't resolve the get_ip() function. But we shouldn't need the pieform as the exported information wouldn't be able to use it anyway. The following 2 problems can best be seen when doing an export via the CLI, eg: for 'Person One' Create a person called 'Person One' and log in as them (not masquerade so as to se lastlogin value) Create a page and add a comment block and an annotation block to the page - add a comment to the page and the annotation block. Export the person via the CLI sudo -u www-data php htdocs/admin/cli/portfolio_bulkexport.php -fk=lastname -fv=One -e=leap -d=false Expected result - export goes smoothly Actual result - get two errors To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006516/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006512] Re: 'Manage access' or 'Sharing' - which is it?
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006512 Title: 'Manage access' or 'Sharing' - which is it? Status in Mahara: Fix Released Bug description: The page which displays management of sharing pages is currently called 'Share'. However, on the 'Portfolios' page, the card dropdown says '🔒 Manage access' http://mahara/view/accessurl.php?collection=1 goes to a page called '🔒 Edit access' See images for more. Titles, buttons, and links that go to the same functionality should be called the same otherwise it creates complexity in people learning to use Mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006512/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004509] Re: bulk export not working correctly for leap2A
** Changed in: mahara Milestone: 23.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004509 Title: bulk export not working correctly for leap2A Status in Mahara: Fix Committed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When doing an export from bulk export page (admin/users/bulkexport.php) there is a problem when doing a Leap2A export where it tries to do a pdf export instead To test: go to the page via link admin/users/bulkexport.php and do a Leap2A export for a person by putting their username into the 'Usernames to export' field If you don't have pdf export installed then on export you should see an error in the error log : Class 'PluginExportPdfLite' not found To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004509/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2007431] Re: Annotation blocks are not added in full width via matrix page
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2007431 Title: Annotation blocks are not added in full width via matrix page Status in Mahara: Fix Released Bug description: For Mahara 23.04 we changed the default width of blocks to full width. However, an annotation block is still only 1/3 of that width. To replicate: 1. Enable SmartEvidence for the institution. 2. Create a collection with one page and select a SmartEvidence framework. 3. Place an annotation via the SmartEvidence matrix page. 4. Go to the page for which the annotation was added. Results: - Expected: The annotation block is added in full width. - Actual: It's not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2007431/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006788] Re: Remove OTF font files
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006788 Title: Remove OTF font files Status in Mahara: Fix Released Bug description: .OTF font files are an older format that is not required by browsers any more. We should be removing the files referenced in the themes so they are not accidentally referenced but not uploaded as the Google webfonts helper doesn't include that file format any more. At the same time, we should update the link on the font installation page /admin/site/font/install.php to use https://gwfh.mranftl.com as that is now the link for the Google webfonts helper. This should be a lang string change. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006788/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008729] Re: recaptcha for php7.4
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008729 Title: recaptcha for php7.4 Status in Mahara: Fix Released Bug description: The new management of recaptcha downloads 1.3.0 by default. This requires PHP 8.x. Jenkins currently runs PHP 7.4 so this is rejected on automated testing. It will also be rejected on client sites running PHP 7.x. We need to nail the version to Recaptcha 1.2.x as this has a PHP requirement of >=5.5. While we are here, we could remove the patch that tries to clean up files we don't want as this isn't a concern any more. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008729/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008972] Re: Confusing error message when an artefact file is missing from dataroot
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008972 Title: Confusing error message when an artefact file is missing from dataroot Status in Mahara: Fix Released Bug description: Currently gives an error: Access denied You do not have access to view this page. But really the issue is the file is missing so we should give an error message conveying that. To test: 1) Upload an image file for a person in the files area and copy the URL link from the 'Name' column 2) Open this URL in a new window/tab - see the file get downloaded 3) Delete the file from the dataroot and reload the window See the error message To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008972/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2011530] Re: Adding license and copyright notices at the top of the "Show submitted portfolios" help file
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2011530 Title: Adding license and copyright notices at the top of the "Show submitted portfolios" help file Status in Mahara: Fix Released Bug description: I think we need to add a license and copyright notice message to the top of the "Show submitted portfolios" help file as below. Help file to modify: lang/en.utf8/help/forms/searchviews.showsubmissions.html Line: 1 [ Before ] Show submitted portfolios When you select this option, portfolios that you submitted for assessment are displayed. This includes portfolios that are currently under review that you can't edit and portfolios that have been released recently. You can turn the latter into regular portfolios in the page or collection settings so you can edit them and continue working on them instead of the original portfolio. [ After ] Show submitted portfolios When you select this option, portfolios that you submitted for assessment are displayed. This includes portfolios that are currently under review that you can't edit and portfolios that have been released recently. You can turn the latter into regular portfolios in the page or collection settings so you can edit them and continue working on them instead of the original portfolio. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2011530/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012419] Re: Error releasing submissions
** Changed in: mahara
Milestone: 23.04.0 => None
** Changed in: mahara/23.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419
Title:
Error releasing submissions
Status in Mahara:
Fix Committed
Status in Mahara 22.10 series:
Fix Committed
Status in Mahara 23.04 series:
Fix Released
Bug description:
To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
* Create 2 users Student and Teacher
* Create an institution
* Add the two users in the institution
* Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
* Add Student as Member of Group 1 and Teacher as Tutor in Group 1
* As Student create a page and submit it for review in Group 1
* As Teacher release the Page
From this point an error will be displayed and the page will never be
released and will be marked as "Pending release after archiving."
The Error displayed is:
Failed to get a recordset: mysqli error: [1064: You have an error in
your SQL syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near '? LIMIT 1' at line
1] in EXECUTE("SELECT * FROM "lti_assessment" WHERE "group" = ?
LIMIT 1")Command was: SELECT * FROM "lti_assessment" WHERE "group" =
?
...
When examining the issue with a debugger it seems that
group_external_group($group) is called with an integer instead of a
string, so it means that record_exists('lti_assessment', 'group',
$group->id) is called with the wrong value (as $group->id does not
exist).
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2012988] Re: Small fix for a typo on lang/en.utf8/mahara.php.
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2012988 Title: Small fix for a typo on lang/en.utf8/mahara.php. Status in Mahara: Fix Released Bug description: I think it's better to fix a typo (capitalisation and lowercase) on lang/en.utf8/mahara.php as below. Langfile: lang/en.utf8/mahara.php String: releasedinfofor [Before] RElease options for "%s" [After] Release options for "%s" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2012988/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2015016] Re: Small fix for 'Submitted status' help file.
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2015016 Title: Small fix for 'Submitted status' help file. Status in Mahara: Fix Released Bug description: I think the period after the colon may not be necessary. Langfile to modify: lang/en.utf8/help/forms/ANY.submittedstatus.html [Before] Submitted status The submission status of the page can be one of the following:. [After] Submitted status The submission status of the page can be one of the following: To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2015016/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1875149] Re: Outdated packages during PDF export install
** Changed in: mahara Milestone: 23.04.0 => 24.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1875149 Title: Outdated packages during PDF export install Status in Mahara: In Progress Bug description: When I run 'makepdfexport', I got the following messages: 1. Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead. 2. 'Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.' This should be checked. Tagging it against 20.04RC2 but could make a change only in 20.10 if it is not possible at this stage. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1875149/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1998874] Re: Fix up showcomments for non page comments causing JS error 'author_link'
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998874 Title: Fix up showcomments for non page comments causing JS error 'author_link' Status in Mahara: Fix Released Bug description: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save 5. Go to the notification sent to the owner of the page with the showcomment url 6. Navigate to the url Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment Reality: the page comments dropdown opens, and nothing is focused. Also broken page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998874/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1945537] Re: Problem with saving web service log message event when float is in another language
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1945537
Title:
Problem with saving web service log message event when float is in
another language
Status in Mahara:
Fix Released
Bug description:
Initially reported at
https://mahara.org/interaction/forum/topic.php?id=8930
So for example we try to save number as 1,2345 instead of 1.2345
We probably need to cast it via flotval somehow
Error looks like this
PHP Fatal error: Uncaught SQLException: Failed to get a recordset: postgres8
error: [-1: ERROR: invalid input syntax for type numeric: "0,12291693687439"]
in EXECUTE("INSERT INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "protocol", "auth", "functionname", "timetaken", "uri",
"info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)")Command was: INSERT
INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "protocol", "auth", "functionname", "timetaken", "uri",
"info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and values was
(id:109,timelogged:1632941361,userid:23,externalserviceid:3,protocol:REST,auth:OTHER,functionname:module_mobileapi_upload_blog_post,timetaken:0,12291693687439,uri:/webservice/rest/server.php?alt=json,info:exception:SQLExceptionmessage:Failedtogetarecordset:postgres8error:[-1:ERROR:invalidinputsyntaxfortypenumeric:"0,11438679695129"]inEXECUTE("INSERTINTO"external_services_logs"("id","timelogged","userid","externalserviceid","protocol","auth"
The problem looks to be related to:
The variable "time_taken" in file:
htdocs/webservice/lib.php
$time_taken = $time_end - $WEBSERVICE_START;
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1945537/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1952143] Re: Default width for blocks to be full-width
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1952143 Title: Default width for blocks to be full-width Status in Mahara: Fix Released Bug description: This item follows the design and usability considerations discussed in the analysis of this related Wishlist item: https://bugs.launchpad.net/mahara/+bug/1860600 The recommendation is that the default width for blocks on all pages is to be full-width, with the ability to adjust this as desired. This option already exists for those creating pages in accessible mode. To be applied to individual, group, institution, site and template pages, i.e. all pages, in 'normal' mode. In summary, this is an improvement on aesthetics, equity and usability. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1952143/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999347] Re: Update SimpleSamlPhp in Mahara to 1.19.7
** Changed in: mahara Milestone: 23.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1999347 Title: Update SimpleSamlPhp in Mahara to 1.19.7 Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Committed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Update includes a security fix To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1999347/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1979373] Re: Deprecate SOAP support
** Changed in: mahara Status: In Progress => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1979373 Title: Deprecate SOAP support Status in Mahara: Fix Released Bug description: While working through PHPStan issues I found that the SOAP implementation should have been reliably throwing errors. The lack of issues in this area suggests that this is not being used at all. Rather than supporting what is now quite old code we should just deprecate it and remove it from the codebase. The area that drew this to my attention is here: https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/mahara.php#L2640 $wsseSoapClient = new webservice_soap_client_wsse( array($client, '_doRequest'), $client->wsdlfile, $client->getOptions() ); The first parameter, which should declare our request, is unused in webservice_soap_client_wsse() The third parameter is unused also. In the webservice_soap_client_wsse() class there is a private $options, but this is never set. Also, webservice_soap_client(), which gives us $client, has no getOptions() method so this should also be erroring out loudly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1979373/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999594] Re: Create a hard point upgrade so we can remove code relating to db triggers after that point
** Changed in: mahara Status: In Progress => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1999594 Title: Create a hard point upgrade so we can remove code relating to db triggers after that point Status in Mahara: Fix Released Bug description: We removed a bunch of db triggers in Mahara and made them pseudo triggers (handled by PHP rather than the database) but we didn't remove the trigger check / db_*_trigger() functions. We should make the next Mahara be a hard upgrade point so that we can then safely remove the checks/functions in a patch after this point as sites will not be able to jump past this point to upgrade to a later version and find the trigger stuff missing. They will have to step to this point before upgrading further. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1999594/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1999608] Re: Leap2A import errors
** Changed in: mahara
Milestone: 23.04.0 => None
** Changed in: mahara/23.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1999608
Title:
Leap2A import errors
Status in Mahara:
Fix Committed
Status in Mahara 22.10 series:
Fix Released
Status in Mahara 23.04 series:
Fix Released
Bug description:
Regression: Exported portfolios when imported into 22.10 or main
produce the following error message (also attached with syntax
highlighting):
[WAR] b1 (artefact/internal/import/leap/lib.php:451) Undefined index:
http://terms.leapspecs.org
Call stack (most recent first):
log_message("Undefined index: http://terms.leapspecs.org";, 8, true, true,
"/home/kristina/code/mahara/htdocs/artefact/interna...", 451) at
/home/kristina/code/mahara/htdocs/lib/errors.php:514
error(8, "Undefined index: http://terms.leapspecs.org";,
"/home/kristina/code/mahara/htdocs/artefact/interna...", 451, array(size 3)) at
/home/kristina/code/mahara/htdocs/artefact/internal/import/leap/lib.php:451
LeapImportInternal::import_author_data(object(PluginImportLeap),
"portfolio:artefactinternal") at
/home/kristina/code/mahara/htdocs/lib/mahara.php:1943
call_static_method("LeapImportInternal", "import_author_data",
object(PluginImportLeap), "portfolio:artefactinternal") at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:892
PluginImportLeap->import_from_load_mapping() at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:368
PluginImportLeap->process() at
/home/kristina/code/mahara/htdocs/admin/users/add.php:345
adduser_submit(object(Pieform), array(size 26)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:563
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:159
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:5787
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/admin/users/add.php:154
[WAR] b1 (artefact/internal/import/leap/lib.php:464)
SimpleXMLElement::xpath(): Invalid expression
Call stack (most recent first):
log_message("SimpleXMLElement::xpath(): Invalid expression", 8, true,
true, "/home/kristina/code/mahara/htdocs/artefact/interna...", 464) at
/home/kristina/code/mahara/htdocs/lib/errors.php:514
error(2, "SimpleXMLElement::xpath(): Invalid expression",
"/home/kristina/code/mahara/htdocs/artefact/interna...", 464, array(size 5)) at
Unknown:0
SimpleXMLElement->xpath(":persondata") at
/home/kristina/code/mahara/htdocs/artefact/internal/import/leap/lib.php:464
LeapImportInternal::import_author_data(object(PluginImportLeap),
"portfolio:artefactinternal") at
/home/kristina/code/mahara/htdocs/lib/mahara.php:1943
call_static_method("LeapImportInternal", "import_author_data",
object(PluginImportLeap), "portfolio:artefactinternal") at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:892
PluginImportLeap->import_from_load_mapping() at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:368
PluginImportLeap->process() at
/home/kristina/code/mahara/htdocs/admin/users/add.php:345
adduser_submit(object(Pieform), array(size 26)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:563
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:159
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:5787
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/admin/users/add.php:154
[WAR] b1 (artefact/internal/import/leap/lib.php:465) Invalid argument
supplied for foreach()
Call stack (most recent first):
log_message("Invalid argument supplied for foreach()", 8, true, true,
"/home/kristina/code/mahara/htdocs/artefact/interna...", 465) at
/home/kristina/code/mahara/htdocs/lib/errors.php:514
error(2, "Invalid argument supplied for foreach()",
"/home/kristina/code/mahara/htdocs/artefact/interna...", 465, array(size 6)) at
/home/kristina/code/mahara/htdocs/artefact/internal/import/leap/lib.php:465
LeapImportInternal::import_author_data(object(PluginImportLeap),
"portfolio:artefactinternal") at
/home/kristina/code/mahara/htdocs/lib/mahara.php:1943
call_static_method("LeapImportInternal", "import_author_data",
object(PluginImportLeap), "portfolio:artefactinternal") at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:892
PluginImportLeap->import_from_load_mapping() at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:368
PluginImportLeap->process() at
/home/kristina/code/mahara/htdocs/admin/users/add.php:345
adduser_submit(object(Pieform), array(size 26)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.ph
[Mahara-contributors] [Bug 2000277] Re: Images added to portfolio review block are not copied when template is copied
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2000277 Title: Images added to portfolio review block are not copied when template is copied Status in Mahara: Fix Released Bug description: When you add an image into the review statement in the 'Portfolio review' block and then copy the portfolio into another account, the reference stays to the original image even though the image is transferred as far as I can tell. The fix should be similar to what was done for bug #1957725 To replicate: 1. Allow 'Portfolio completion' in the institution. 2. Set up a portfolio with at least one page and the portfolio completion page. 3. Add the block 'Portfolio review' to the portfolio completion page and add an image into the statement field. Note down the image ID. 4. Give others access and allow copying. 5. Log in as somebody else and copy the portfolio. Check the image ID referenced in the portfolio review block and check if the file was copied to your personal portfolio area. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2000277/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2003378] Re: PHP 8 Compatibility: phpcs
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2003378 Title: PHP 8 Compatibility: phpcs Status in Mahara: Fix Released Bug description: We're getting close to finishing this. We are currently working through the output of PHP CodeSniffer. This bug is a catchall bug to cover this work. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004137] Re: PHP 8 compatibility causing error with PHP 7.4 for XML-RPC
** Changed in: mahara/23.04 Status: Fix Committed => Fix Released ** Changed in: mahara Milestone: 23.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004137 Title: PHP 8 compatibility causing error with PHP 7.4 for XML-RPC Status in Mahara: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: Mahara: 22.10.0 DB: Postgres 14.3 OS: Linux 20.04 Browser: n/a The use of "mixed" type is supported in PHP 8.0+. It was introduced in this file: https://reviews.mahara.org/c/mahara/+/12921/28/htdocs/lib/applicationset.php with 2 functions: 1. current() : mixed 2. key() : mixed With PHP 7.4, when configuring institutions with Moodle integration (XML-RPC for example), the following error is received: "PHP message: [WAR] 40 (lib/errors.php:529) [TypeError]: Return value of ApplicationSet::current() must be an instance of mixed, instance of Application returned at /var/www/site/lib/applicationset.php:45 A type should not be set for these functions until it's fully implemented for PHP 8.0+. I only found those 2 instances in Mahara 22.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004137/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004511] Re: Profile image used in image block gives errors
** Changed in: mahara/23.04 Status: Fix Committed => Fix Released ** Changed in: mahara Milestone: 23.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004511 Title: Profile image used in image block gives errors Status in Mahara: Fix Committed Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When I do the following: 1) add a profile image to a person's account 2) create a page 3) add an image block to the page and pick the profile image See the following errors: Undefined variable: isdecorative Undefined variable: alttext Undefined variable: altiscaption To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004511/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2004852] Re: LTI 1.1 grading not working for some locales
** Changed in: mahara
Milestone: 23.04.0 => None
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2004852
Title:
LTI 1.1 grading not working for some locales
Status in Mahara:
Fix Committed
Status in Mahara 21.10 series:
Fix Committed
Status in Mahara 22.04 series:
Fix Released
Status in Mahara 22.10 series:
Fix Committed
Status in Mahara 23.04 series:
Fix Released
Bug description:
With a LTI to a Moodle instance, when the teachers grades a
submission, the grade is not sent to Moodle in some cases. I think it
has to do with my server's locale set to french. The grade of 94%, for
example, si translated to 0,94 instead of 0.94.
I printed some debug and was able to see the error "Score must be
numeric". I also printed the xml from the $body variable (see
attachment).
I made a few changes in function publish_lti_outcome of
htdocs/module/lti/lib.php around line 1001 and it now works correctly.
$grade = $this->grade / 100;
$grade = str_replace(',', '.', $grade);
$smarty->assign('score', $grade);
This was tested with Mahara 22.10 and Moodle 3.11.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2004852/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006637] Re: Issue with upgrade and setting the blocktype_installed_viewtypes values correctly
** Changed in: mahara Milestone: 23.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006637 Title: Issue with upgrade and setting the blocktype_installed_viewtypes values correctly Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Committed Status in Mahara 22.04 series: Fix Released Status in Mahara 22.10 series: Fix Committed Status in Mahara 23.04 series: Fix Released Bug description: When we add a new view type we update the blocktype_installed_viewtype table to know what blocks can be used on this new view type. But if we have an upgrade path where we add two new view types in one upgrade session then the information is not correct from Blocktype::get_viewtypes() because it is set to be static. We need it to ignore this static-ness on upgrade. To test: Install a 20.04_STABLE site Upgrade to main Run the following command in database: select * from blocktype_installed_viewtype where viewtype = 'activity' order by blocktype; Should see: 29 (or 30) rows including 'placeholder' and 'image' blocktypes Actually see: 21 (or 22) rows and 'placeholder' and 'image' blocktypes are missing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006637/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2006514] Re: Inconsistent Sign-off blocks after upgrade
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2006514 Title: Inconsistent Sign-off blocks after upgrade Status in Mahara: Fix Released Bug description: When rebasing a patchset on main I noticed a Page had lost the Sign- off block. This Page **was not** in a signed off state. The other Page in the Collection also had the block, **was** in a Signed off state, and did still have the new form of the block. I think the upgrade step here needs to be updated. It's working for block instances that are signed off, but not for those that aren't. https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975 Testing: Checkout 22.10_RELEASE and install the site Create an account As that account, create 2 Pages and add them to a Collection Add Progress Completion to the Collection Sign-off blocks to both pages Mark the first Page as Signed off. Back up the DB for handy restoring during development. Checkout main Run the upgrade Look at the Collection and pages. Expected result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator * The first Page to have the new form of the Sign-off block in a signed off state * The second Page to have the new form of the Sign-off block in a not signed off state The current result: * A Collection with a Progress Completion page * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator * The Progress Completion page to shows the second Page **with no** Sign-off state indicator * The first Page has the new form of the Sign-off block in a signed off state * The second Page **does not have have** the new form of the Sign-off block in a not signed off state To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 2008956] Re: PHP 8 deprecations to fix behat tests
** Changed in: mahara Status: In Progress => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2008956 Title: PHP 8 deprecations to fix behat tests Status in Mahara: Fix Released Bug description: Fixes to get tests running on PHP 8 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2008956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
