[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-12-12 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789721#action_12789721 ] Sean Owen commented on MAHOUT-165: -- So this is done now right? SparseVector uses OpenIntDo

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-23 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781467#action_12781467 ] Grant Ingersoll commented on MAHOUT-165: OK, I committed Shashi's patch and fixed t

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-23 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781451#action_12781451 ] Ted Dunning commented on MAHOUT-165: bq. From there, refactoring Vector to not have a W

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-23 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781438#action_12781438 ] Grant Ingersoll commented on MAHOUT-165: d'oh, missed the correct package names. >

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-23 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781436#action_12781436 ] Grant Ingersoll commented on MAHOUT-165: OK, I moved over the matrix module, but th

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-23 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781427#action_12781427 ] Grant Ingersoll commented on MAHOUT-165: OK, I am committing the Matrix module. On

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-22 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781171#action_12781171 ] Jake Mannix commented on MAHOUT-165: Ok, I agree with this - I'm just wrapping my head

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-22 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781169#action_12781169 ] Sean Owen commented on MAHOUT-165: -- I may not have a very informed perspective on this, bu

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-22 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781165#action_12781165 ] Jake Mannix commented on MAHOUT-165: bq. +1 yes the order of dependency makes the most

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-22 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781153#action_12781153 ] Drew Farris commented on MAHOUT-165: bq. The Colt stuff looks good, my only concern, le

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779651#action_12779651 ] Jake Mannix commented on MAHOUT-165: bq. Then my comment is just that the hash code can

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779650#action_12779650 ] Ted Dunning commented on MAHOUT-165: bq. Then my comment is just that the hash code ca

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779642#action_12779642 ] Sean Owen commented on MAHOUT-165: -- Fair enough. Then my comment is just that the hash cod

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779591#action_12779591 ] Jake Mannix commented on MAHOUT-165: bq. I think this deserves a bit more thought. I wa

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779496#action_12779496 ] Sean Owen commented on MAHOUT-165: -- I think this deserves a bit more thought. I was actual

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779456#action_12779456 ] Grant Ingersoll commented on MAHOUT-165: All sounding pretty good. If you don't mi

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779451#action_12779451 ] Drew Farris commented on MAHOUT-165: {quote} Awesome, thanks Drew. I noticed you didn't

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779411#action_12779411 ] Sean Owen commented on MAHOUT-165: -- +1 to making this a Mahout module. There's not much di

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779406#action_12779406 ] Shashikant Kore commented on MAHOUT-165: My patch is only for the changes to Sparse

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-18 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779398#action_12779398 ] Jake Mannix commented on MAHOUT-165: Shashi, is this patch just an update of the one wh

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779335#action_12779335 ] Jake Mannix commented on MAHOUT-165: Awesome, thanks Drew. I noticed you didn't add a

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779139#action_12779139 ] Ted Dunning commented on MAHOUT-165: bq. Well, I'm not sure how much of the "making a w

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779134#action_12779134 ] Ted Dunning commented on MAHOUT-165: bq. +1 sounds like a good idea to me. It's just a

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779132#action_12779132 ] Jake Mannix commented on MAHOUT-165: bq. I also like the idea of getting it donated to

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779127#action_12779127 ] Sean Owen commented on MAHOUT-165: -- Regarding @deprecated: sounds a little aggressive to m

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779121#action_12779121 ] Jake Mannix commented on MAHOUT-165: bq. Perhaps he would be willing to donate Colt to

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779116#action_12779116 ] Otis Gospodnetic commented on MAHOUT-165: - Yes, Wolfgang contributed MemoryIndex.

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779111#action_12779111 ] Grant Ingersoll commented on MAHOUT-165: bq. So I found Wolfgang Hoschek, the autho

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779082#action_12779082 ] Drew Farris commented on MAHOUT-165: {quote} Is it ok if I post a patch which has the o

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779068#action_12779068 ] Jake Mannix commented on MAHOUT-165: bq. Should all code be marked deprecated until it

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779058#action_12779058 ] Ted Dunning commented on MAHOUT-165: bq.The colt tree could also be put into a sepa

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779050#action_12779050 ] Jake Mannix commented on MAHOUT-165: bq. The colt tree could also be put into a separat

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779046#action_12779046 ] Sean Owen commented on MAHOUT-165: -- +1 to a transplant, and rename to org.apache.mahout.co

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779039#action_12779039 ] Drew Farris commented on MAHOUT-165: The colt tree could also be put into a separate mo

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779036#action_12779036 ] Jake Mannix commented on MAHOUT-165: And continuing on the topic of code adoption: Colt

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779033#action_12779033 ] Jake Mannix commented on MAHOUT-165: So I found Wolfgang Hoschek, the author of Colt, a

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778973#action_12778973 ] Sean Owen commented on MAHOUT-165: -- Oh I see. Well then, sounds like a compelling reason t

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778971#action_12778971 ] Jake Mannix commented on MAHOUT-165: Isn't colt abandoned? I'm not in favor of crackin

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778944#action_12778944 ] Sean Owen commented on MAHOUT-165: -- I generally favor including stuff as an intact library

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778937#action_12778937 ] Jake Mannix commented on MAHOUT-165: If we're going to try out a patch which includes C

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778831#action_12778831 ] Grant Ingersoll commented on MAHOUT-165: Yep, I think we are all agreed on Colt. I

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778832#action_12778832 ] Grant Ingersoll commented on MAHOUT-165: Shashi, can you make sure the patch is up

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-17 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778822#action_12778822 ] Shashikant Kore commented on MAHOUT-165: Not sure if voting for my own patch qualif

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-12 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777089#action_12777089 ] Ted Dunning commented on MAHOUT-165: bq. pulling Writable off of the interface, so tha

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-12 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777082#action_12777082 ] Jake Mannix commented on MAHOUT-165: Ok then, let's try out Colt, unless we have a more

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-12 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777050#action_12777050 ] Ted Dunning commented on MAHOUT-165: My issues (which I used for quite some time) were

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-12 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776999#action_12776999 ] Grant Ingersoll commented on MAHOUT-165: Sorry, have been heads down on trying to g

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-12 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776945#action_12776945 ] Jake Mannix commented on MAHOUT-165: Well, I've always had good luck with Colt, but at

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-12 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776924#action_12776924 ] Sean Owen commented on MAHOUT-165: -- IntDoubleHash right? We could look at that, but I thou

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-11-11 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776748#action_12776748 ] Jake Mannix commented on MAHOUT-165: *bump* So what is the collective vision on this n

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-15 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766231#action_12766231 ] Grant Ingersoll commented on MAHOUT-165: Shashi's vectors are at: http://people.a

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-14 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765554#action_12765554 ] Grant Ingersoll commented on MAHOUT-165: Shashi, can you share your test vectors?

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-05 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762167#action_12762167 ] Shashikant Kore commented on MAHOUT-165: I am trying out this patch. Somehow, I fin

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Ted Dunning
Colt did a nice job of this. Basically, their idea was to take various general functional patterns and allow the functions to be plugged in. Common patterns that are reasonable to include in such a framework include: a) dot product as the aggregration of a pairwise function application (normal d

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Jake Mannix
On Thu, Oct 1, 2009 at 10:10 AM, Ted Dunning wrote: > Btw... the other think that the HashVector does better is inserts. The > sorted vector could do much better on average if it deferred sorting until > an access or iteration was done. Even iteration doesn't necessarily need > sorting, but it

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Ted Dunning
Btw... the other think that the HashVector does better is inserts. The sorted vector could do much better on average if it deferred sorting until an access or iteration was done. Even iteration doesn't necessarily need sorting, but it could by seen as part of the contract. On Thu, Oct 1, 2009 at

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Jake Mannix
Yeah, I added the "trying to find..." part of the debug output because I couldn't figure out what IntDoubleHash was "impossibly confused" about. Unfortunately, seeing what it was confused about only confused *me* about why it was impossible. On Thu, Oct 1, 2009 at 9:12 AM, Ted Dunning wrote: >

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Ted Dunning
It indicates a bug in the code or in the writer's head. You are correct about the intent. The default value (which should probably just be 0) should be returned if the value is missing. On Thu, Oct 1, 2009 at 5:41 AM, Grant Ingersoll (JIRA) wrote: > I don't think this is "impossible confusion",

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761201#action_12761201 ] Grant Ingersoll commented on MAHOUT-165: The exception in the test is: {quote} java

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Sean Owen
(PS yeah that was my fault for misreading the original message.) On Thu, Oct 1, 2009 at 11:39 AM, Grant Ingersoll wrote: > > On Sep 30, 2009, at 4:34 PM, Jake Mannix wrote: > >> I didn't say that equals() should ignore name, I said the opposite - >> equals >> and >> hashCode() should *only* take

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-10-01 Thread Grant Ingersoll
On Sep 30, 2009, at 4:34 PM, Jake Mannix wrote: I didn't say that equals() should ignore name, I said the opposite - equals and hashCode() should *only* take into account the contents and the name, and not implementation (which means that hashCode() needs to stay in one place and not ge

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761021#action_12761021 ] Ted Dunning commented on MAHOUT-165: THanks Jake, that could be very helpful. The thr

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761018#action_12761018 ] Jake Mannix commented on MAHOUT-165: Ted, some notes on your patch: * with the two

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761000#action_12761000 ] Ted Dunning commented on MAHOUT-165: I will take a quick look this evening at the patc

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761002#action_12761002 ] Jake Mannix commented on MAHOUT-165: Good luck with the "quick" part - there seem to be

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix
I didn't say that equals() should ignore name, I said the opposite - equals and hashCode() should *only* take into account the contents and the name, and not implementation (which means that hashCode() needs to stay in one place and not get monkeyed with in subclasses. On Wed, Sep 30, 2009 at 1:18

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix
On Wed, Sep 30, 2009 at 1:16 PM, Grant Ingersoll wrote: > > On Sep 30, 2009, at 4:03 PM, Jake Mannix wrote: > > Regarding having equals() effectively delegate to >> getName().equals(other.getName()) && equivalent(other) means that we need >> to >> be extra special careful about implementations of

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Sean Owen
No I don't hear anyone wanting to make equals() ignore the name. (Otherwise, hashCode() would have to ignore it as well.) JIRA also seems pretty laggy to me. On Wed, Sep 30, 2009 at 9:03 PM, Jake Mannix wrote: > If we are not going to break the contract between equals() and hashCode(), > and we'

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Grant Ingersoll
On Sep 30, 2009, at 4:03 PM, Jake Mannix wrote: Regarding having equals() effectively delegate to getName().equals(other.getName()) && equivalent(other) means that we need to be extra special careful about implementations of hashCode() : If we are not going to break the contract between equ

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix
Regarding having equals() effectively delegate to getName().equals(other.getName()) && equivalent(other) means that we need to be extra special careful about implementations of hashCode() : If we are not going to break the contract between equals() and hashCode(), and we're having equals() *only*

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760956#action_12760956 ] Sean Owen commented on MAHOUT-165: -- Are my conclusions sound then: We agree that equals()

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760902#action_12760902 ] Grant Ingersoll commented on MAHOUT-165: There are some thoughts on equals, etc. in

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760898#action_12760898 ] Grant Ingersoll commented on MAHOUT-165: There are some thoughts on equals, etc. in

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760893#action_12760893 ] Sean Owen commented on MAHOUT-165: -- It's a good, important question and one I think needs

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760886#action_12760886 ] Jake Mannix commented on MAHOUT-165: One test which is failing is the basic VectorTest

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-30 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760879#action_12760879 ] Jake Mannix commented on MAHOUT-165: Hey Ted, I tried bringing your patch up to current

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-18 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757022#action_12757022 ] Sean Owen commented on MAHOUT-165: -- FWIW this is just what the FastIDSet and FastMap thing

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-18 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757017#action_12757017 ] Shashikant Kore commented on MAHOUT-165: Colt handles the removal by explicitly kee

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-17 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756790#action_12756790 ] Ted Dunning commented on MAHOUT-165: bq. 3. We don't need right now, but there is no re

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-17 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756526#action_12756526 ] Shashikant Kore commented on MAHOUT-165: Since, I couldn't apply Ted's patch to tru

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-12 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754585#action_12754585 ] Grant Ingersoll commented on MAHOUT-165: Shashi, did you try Ted's patch? If that

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-12 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754586#action_12754586 ] Grant Ingersoll commented on MAHOUT-165: Ted, can you bring your patch up to date w

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-11 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754154#action_12754154 ] Ted Dunning commented on MAHOUT-165: If we need something more than small integers, it

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-11 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754147#action_12754147 ] Grant Ingersoll commented on MAHOUT-165: I think we will want doubles, but perhaps

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-10 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753583#action_12753583 ] Shashikant Kore commented on MAHOUT-165: The attached patch uses integer to double

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751534#action_12751534 ] Sean Owen commented on MAHOUT-165: -- I suggest we distribute in binary form. Just unpack th

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751520#action_12751520 ] Shashikant Kore commented on MAHOUT-165: OK. Should I copy relevant classes source

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751519#action_12751519 ] Ted Dunning commented on MAHOUT-165: To amplify on Grant's reply: Sean is correct. T

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751484#action_12751484 ] Grant Ingersoll commented on MAHOUT-165: Yes, Sean is correct. _IF_ the part of Co

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751423#action_12751423 ] Sean Owen commented on MAHOUT-165: -- While I'm not a lawyer, I am all but certain there is

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751398#action_12751398 ] Shashikant Kore commented on MAHOUT-165: My interpretation was Trove (and Colt) can

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-09-04 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751385#action_12751385 ] Sean Owen commented on MAHOUT-165: -- Wait a sec, I thought we had concluded that we *cannot

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-29 Thread Ted Dunning
I have just written a replacement. I will post a patch as soon as I get some solid testing done. On Sat, Aug 29, 2009 at 2:29 PM, Grant Ingersoll wrote: > Right, Colt likely could be used depending on the package it comes from and > as long as it doesn't have deps on the other packages. > > -Gra

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-29 Thread Grant Ingersoll
Right, Colt likely could be used depending on the package it comes from and as long as it doesn't have deps on the other packages. -Grant On Aug 29, 2009, at 2:22 PM, Ted Dunning wrote: Trove is LGPL so we can't lift code. Even linking can be tricky. On Fri, Aug 28, 2009 at 10:06 AM, Shash

Re: [jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-29 Thread Ted Dunning
Trove is LGPL so we can't lift code. Even linking can be tricky. On Fri, Aug 28, 2009 at 10:06 AM, Shashikant Kore (JIRA) wrote: > >[ > https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748904#action_1274

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-28 Thread Shashikant Kore (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748904#action_12748904 ] Shashikant Kore commented on MAHOUT-165: I'm fine with copying relevant classes fro

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-28 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748870#action_12748870 ] Grant Ingersoll commented on MAHOUT-165: Shashi, Any thoughts on whether we can ju

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-20 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745422#action_12745422 ] Sean Owen commented on MAHOUT-165: -- Yes, surely we can simply repackage the .jar to not ev

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-20 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745417#action_12745417 ] Grant Ingersoll commented on MAHOUT-165: Also, perhaps there is a snapshot availabl

[jira] Commented: (MAHOUT-165) Using better primitives hash for sparse vector for performance gains

2009-08-20 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745415#action_12745415 ] Grant Ingersoll commented on MAHOUT-165: http://acs.lbl.gov/~hoschek/colt-download/

  1   2   >