Re: [Mailman-Developers] Getting approval to go ahead

2015-03-24 Thread Barry Warsaw
On Mar 24, 2015, at 02:38 PM, Andrew Stuart wrote: I haven’t really worked on an open source project before. You're fitting right in though! :) It wouldn’t make sense to come up with an idea, write some code, submit it and have it rejected because it’s not OK with the project owners and doesn’t

Re: [Mailman-Developers] Getting approval to go ahead

2015-03-24 Thread Stephen J. Turnbull
Barry Warsaw writes: Keep feature and bug branches small if possible, and concise, such that they only implement the feature your working on or fix the reported bug. A little bit of extraneous stuff might be okay if it improves readability, but don't go overboard. I'd like to gloss this

Re: [Mailman-Developers] Getting approval to go ahead

2015-03-24 Thread Barry Warsaw
On Mar 25, 2015, at 01:02 PM, Stephen J. Turnbull wrote: (1) Suppose you change a small function whose formatting is not PEP 8 conformant (or otherwise so ugly you can't help fixing it -- of course, check blame first, if Barry committed those lines, have your eyes checked instead :-).

Re: [Mailman-Developers] Getting approval to go ahead

2015-03-23 Thread Terri Oda
On 2015-03-23 8:38 PM, Andrew Stuart wrote: I haven’t really worked on an open source project before. It wouldn’t make sense to come up with an idea, write some code, submit it and have it rejected because it’s not OK with the project owners and doesn’t fit with project goals. So at what

Re: [Mailman-Developers] Getting approval to go ahead

2015-03-23 Thread Andrew Stuart
Thanks Terri, Unfortunately, it is true that the lack of process has led people to put a lot of work into stuff that never got merged. I’m mainly just trying to avoid this - writing stuff that doesn’t get merged. I figure step one is to get a quick nod from one of the architects/project

Re: [Mailman-Developers] Getting approval to go ahead

2015-03-23 Thread Terri Oda
On 2015-03-23 10:38 PM, Andrew Stuart wrote: The question is, who do I ask for confirmation that the idea is solid and will be merged assuming all requirements are met for code quality/testing/documentation? For core stuff you particularly want Barry's blessing, for Hyperkitty it's Aurelian,

[Mailman-Developers] Getting approval to go ahead

2015-03-23 Thread Andrew Stuart
I haven’t really worked on an open source project before. It wouldn’t make sense to come up with an idea, write some code, submit it and have it rejected because it’s not OK with the project owners and doesn’t fit with project goals. So at what point do I know that if I write some code that

Re: [Mailman-Developers] Getting approval to go ahead

2015-03-23 Thread Ana Badescu
Hi Andrew, For starters, make sure you check https://pythonhosted.org/mailman/src/mailman/docs/STYLEGUIDE.html and https://google-styleguide.googlecode.com/svn/trunk/pyguide.html. Cheers, Ana On Tue, Mar 24, 2015 at 5:38 AM, Andrew Stuart andrew.stu...@supercoders.com.au wrote: I haven’t