Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Mark Sapiro]

On 01/05/2018 11:56 AM, Chris PUCHALSKI wrote:
> Here is the entire end of the IncomingRunner.py file as it stands now:
> 
> except Errors.HoldMessage:
> # Let the approval process take it from here.  The message no
> # longer needs to be queued.
> return 0
> except Errors.RejectMessage, e:
> #mlist.BounceMessage(msg, msgdata, e)
> #return 0
> # Log this.
> syslog('vette', """Message rejected, msgid: %s
> list: %s, handler: %s, reason: %s""",
>msg.get('message-id', 'n/a'),
>mlist.real_name, handler, e.notice())
> mlist.BounceMessage(msg, msgdata, e)
> except:
> # Push this pipeline module back on the stack, then re-raise
> # the exception.
> pipeline.insert(0, handler)
> raise
> # We've successfully completed handling of this message
> return 0
> 
> Is that the "return 0" you speak of or does it need to appear higher rather 
> than the end of the file?


It should be OK. The upstream code has return 0 following

mlist.BounceMessage(msg, msgdata, e)

but without that, control will fall through the try: to the return 0
after the

# We've successfully completed handling of this message

comment so it should be the same.

-- 
Mark Sapiro The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Chris PUCHALSKI]

Here is the entire end of the IncomingRunner.py file as it stands now:

except Errors.HoldMessage:
# Let the approval process take it from here.  The message no
# longer needs to be queued.
return 0
except Errors.RejectMessage, e:
#mlist.BounceMessage(msg, msgdata, e)
#return 0
# Log this.
syslog('vette', """Message rejected, msgid: %s
list: %s, handler: %s, reason: %s""",
   msg.get('message-id', 'n/a'),
   mlist.real_name, handler, e.notice())
mlist.BounceMessage(msg, msgdata, e)
except:
# Push this pipeline module back on the stack, then re-raise
# the exception.
pipeline.insert(0, handler)
raise
# We've successfully completed handling of this message
return 0

Is that the "return 0" you speak of or does it need to appear higher rather 
than the end of the file?


Christopher Puchalski
Corporate IT Security
chris.puchal...@raytheon.com


-Original Message-
From: Mailman-Users 
[mailto:mailman-users-bounces+chris.puchalski=raytheon@python.org] On 
Behalf Of Mark Sapiro
Sent: Friday, January 05, 2018 12:22 PM
To: mailman-users@python.org
Subject: [External] Re: [Mailman-Users] Privacy Filter Unusual Behavior

On 01/05/2018 10:50 AM, Chris PUCHALSKI wrote:
> 
> IncomingRunner.py (portion containing Errors.RejectMessage):
> 
> except Errors.RejectMessage, e:
> #mlist.BounceMessage(msg, msgdata, e)
> #return 0
> # Log this.
> syslog('vette', """Message rejected, msgid: %s
> list: %s, handler: %s, reason: %s""",
>msg.get('message-id', 'n/a'),
>mlist.real_name, handler, e.notice())
> mlist.BounceMessage(msg, msgdata, e)


The next line should be

return 0

The commented bit

#mlist.BounceMessage(msg, msgdata, e)
#return 0

Is all there was in the 2.1.12 base. In 2.1 16 it was changed to

except Errors.RejectMessage, e:
# Log this.
syslog('vette', """Message rejected, msgid: %s
list: %s,
handler: %s,
reason: %s""",
   msg.get('message-id', 'n/a'),
   mlist.real_name, handler, e.notice())
mlist.BounceMessage(msg, msgdata, e)
return 0

It appears that someone has backported this and possibly dropped the return 
which may be the issue. I'm not certain. Without the return 0, the try: should 
fall through to the following return 0 anyway, so it really shouldn't matter. 
Also, if this is a RedHat change and it is the reason, I'm sure there would 
have been more complaints by now.

I'm pretty much out of ideas at this point. If you want to tar up the entire 
/var/lib/mailman/Mailman directory and send it to me off list, I'll try to 
duplicate the issue. Other than that, I don't know what more to try.

-- 
Mark Sapiro <m...@msapiro.net>The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org 
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3 Security Policy: 
http://wiki.list.org/x/QIA9 Searchable Archives: 
http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/chris.puchalski%40raytheon.com
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Mark Sapiro]

On 01/05/2018 10:50 AM, Chris PUCHALSKI wrote:
> 
> IncomingRunner.py (portion containing Errors.RejectMessage):
> 
> except Errors.RejectMessage, e:
> #mlist.BounceMessage(msg, msgdata, e)
> #return 0
> # Log this.
> syslog('vette', """Message rejected, msgid: %s
> list: %s, handler: %s, reason: %s""",
>msg.get('message-id', 'n/a'),
>mlist.real_name, handler, e.notice())
> mlist.BounceMessage(msg, msgdata, e)


The next line should be

return 0

The commented bit

#mlist.BounceMessage(msg, msgdata, e)
#return 0

Is all there was in the 2.1.12 base. In 2.1 16 it was changed to

except Errors.RejectMessage, e:
# Log this.
syslog('vette', """Message rejected, msgid: %s
list: %s,
handler: %s,
reason: %s""",
   msg.get('message-id', 'n/a'),
   mlist.real_name, handler, e.notice())
mlist.BounceMessage(msg, msgdata, e)
return 0

It appears that someone has backported this and possibly dropped the
return which may be the issue. I'm not certain. Without the return 0,
the try: should fall through to the following return 0 anyway, so it
really shouldn't matter. Also, if this is a RedHat change and it is the
reason, I'm sure there would have been more complaints by now.

I'm pretty much out of ideas at this point. If you want to tar up the
entire /var/lib/mailman/Mailman directory and send it to me off list,
I'll try to duplicate the issue. Other than that, I don't know what more
to try.

-- 
Mark Sapiro The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Chris PUCHALSKI]

  #return 0
# Log this.
syslog('vette', """Message rejected, msgid: %s
list: %s, handler: %s, reason: %s""",
   msg.get('message-id', 'n/a'),
   mlist.real_name, handler, e.notice())
mlist.BounceMessage(msg, msgdata, e)



Christopher Puchalski
Corporate IT Security
chris.puchal...@raytheon.com

-Original Message-
From: Mailman-Users 
[mailto:mailman-users-bounces+chris.puchalski=raytheon@python.org] On 
Behalf Of Mark Sapiro
Sent: Thursday, January 04, 2018 1:24 PM
To: mailman-users@python.org
Subject: [External] Re: [Mailman-Users] Privacy Filter Unusual Behavior

On 01/04/2018 08:34 AM, Chris PUCHALSKI wrote:
> It is a Redhat package (mailman-2.1.12-25.el6.x86_64) so not from source. I 
> have the version locked because I found updates over wrote the customizations 
> made to the look/feel. Most of the modifications are related to hiding 
> options from users (to protect themselves) and cosmetic (so it fits company 
> look/feel). It was working up to some point a few months ago, I know because 
> I was doing some testing to help a list owner make a private list. I have the 
> version locked because I found updates over wrote the customizations made to 
> the look/feel.


So I assume from the fact that you are not contradicting any of this:

> OK. My understanding is a non-member posts to the list. The non-member gets a 
> rejection notice. The vette log has an entry like "Message rejected, msgid: 
>  ...". The message is also sent to the list member(s). The post 
> log has an entry like "post to  from , size=..., 
> message-id=, success".
> 
>  is the list in question;  is the non-member address and 
> the  in the vette log and post log are the same.
> 
> Is all this correct?

that my understanding is correct.

In that case, I think the issue must be due to your local changes. I can't say 
any more without seeing your code. Most likely, the issue is in 
/var/lib/mailman/Mailman/Handlers/Moderate.py. I would like to see a copy of 
that and also the setting for GLOBAL_PIPELINE in 
/var/lib/mailman/Mailman/Defaults.py and anything that references 
GLOBAL_PIPELINE in /var/lib/mailman/Mailman/mm_cfg.py (aka 
/etc/mailman/mm_cfg.py).

Also, I'd like to see the entire "except Errors.RejectMessage" clause in the 
_dopipeline method of the IncomingRunner class in 
/var/lib/mailman/Mailman/Queue/IncomingRunner.py.

-- 
Mark Sapiro <m...@msapiro.net>The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org 
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3 Security Policy: 
http://wiki.list.org/x/QIA9 Searchable Archives: 
http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/chris.puchalski%40raytheon.com
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Mark Sapiro]

On 01/04/2018 08:34 AM, Chris PUCHALSKI wrote:
> It is a Redhat package (mailman-2.1.12-25.el6.x86_64) so not from source. I 
> have the version locked because I found updates over wrote the customizations 
> made to the look/feel. Most of the modifications are related to hiding 
> options from users (to protect themselves) and cosmetic (so it fits company 
> look/feel). It was working up to some point a few months ago, I know because 
> I was doing some testing to help a list owner make a private list. I have the 
> version locked because I found updates over wrote the customizations made to 
> the look/feel.


So I assume from the fact that you are not contradicting any of this:

> OK. My understanding is a non-member posts to the list. The non-member gets a 
> rejection notice. The vette log has an entry like "Message rejected, msgid: 
>  ...". The message is also sent to the list member(s). The post 
> log has an entry like "post to  from , size=..., 
> message-id=, success".
> 
>  is the list in question;  is the non-member address and 
> the  in the vette log and post log are the same.
> 
> Is all this correct?

that my understanding is correct.

In that case, I think the issue must be due to your local changes. I
can't say any more without seeing your code. Most likely, the issue is
in /var/lib/mailman/Mailman/Handlers/Moderate.py. I would like to see a
copy of that and also the setting for GLOBAL_PIPELINE in
/var/lib/mailman/Mailman/Defaults.py and anything that references
GLOBAL_PIPELINE in /var/lib/mailman/Mailman/mm_cfg.py (aka
/etc/mailman/mm_cfg.py).

Also, I'd like to see the entire "except Errors.RejectMessage" clause in
the _dopipeline method of the IncomingRunner class in
/var/lib/mailman/Mailman/Queue/IncomingRunner.py.

-- 
Mark Sapiro The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Chris PUCHALSKI]

It is a Redhat package (mailman-2.1.12-25.el6.x86_64) so not from source. I 
have the version locked because I found updates over wrote the customizations 
made to the look/feel. Most of the modifications are related to hiding options 
from users (to protect themselves) and cosmetic (so it fits company look/feel). 
It was working up to some point a few months ago, I know because I was doing 
some testing to help a list owner make a private list. I have the version 
locked because I found updates over wrote the customizations made to the 
look/feel.


Christopher Puchalski
Corporate IT Security
chris.puchal...@raytheon.com

-Original Message-
From: Mailman-Users 
[mailto:mailman-users-bounces+chris.puchalski=raytheon@python.org] On 
Behalf Of Mark Sapiro
Sent: Wednesday, January 03, 2018 10:48 AM
To: mailman-users@python.org
Subject: [External] Re: [Mailman-Users] Privacy Filter Unusual Behavior

On 01/03/2018 06:57 AM, Chris PUCHALSKI wrote:
> It seems to happen in every case across a few lists tested.


OK.


> In this particular list I am testing with there is just a single member, but 
> I can add more to prove it impacts all if needed. We don't use archives, I 
> was forced to break that feature some time back. Digests also not used. 
> Basically we made an attempt to not retain any data after a message is 
> delivered to members.


One member should be enough.


> There is a reference to the message in post log and it does have the same 
> message ID.


OK. My understanding is a non-member posts to the list. The non-member gets a 
rejection notice. The vette log has an entry like "Message rejected, msgid: 
 ...". The message is also sent to the list member(s). The post log 
has an entry like "post to  from , size=..., 
message-id=, success".

 is the list in question;  is the non-member address and the 
 in the vette log and post log are the same.

Is all this correct?

What Mailman version is this? If not installed from source, what package? Any 
local modifications?

-- 
Mark Sapiro <m...@msapiro.net>The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org 
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3 Security Policy: 
http://wiki.list.org/x/QIA9 Searchable Archives: 
http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/chris.puchalski%40raytheon.com
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Mark Sapiro]

On 01/03/2018 06:57 AM, Chris PUCHALSKI wrote:
> It seems to happen in every case across a few lists tested.


OK.


> In this particular list I am testing with there is just a single member, but 
> I can add more to prove it impacts all if needed. We don't use archives, I 
> was forced to break that feature some time back. Digests also not used. 
> Basically we made an attempt to not retain any data after a message is 
> delivered to members.


One member should be enough.


> There is a reference to the message in post log and it does have the same 
> message ID.


OK. My understanding is a non-member posts to the list. The non-member
gets a rejection notice. The vette log has an entry like "Message
rejected, msgid:  ...". The message is also sent to the list
member(s). The post log has an entry like "post to  from
, size=..., message-id=, success".

 is the list in question;  is the non-member address
and the  in the vette log and post log are the same.

Is all this correct?

What Mailman version is this? If not installed from source, what
package? Any local modifications?

-- 
Mark Sapiro The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Chris PUCHALSKI]

It seems to happen in every case across a few lists tested.

In this particular list I am testing with there is just a single member, but I 
can add more to prove it impacts all if needed. We don't use archives, I was 
forced to break that feature some time back. Digests also not used. Basically 
we made an attempt to not retain any data after a message is delivered to 
members.

There is a reference to the message in post log and it does have the same 
message ID.


Chris P

-Original Message-
From: Mailman-Users 
[mailto:mailman-users-bounces+chris.puchalski=raytheon@python.org] On 
Behalf Of Mark Sapiro
Sent: Tuesday, January 02, 2018 3:55 PM
To: mailman-users@python.org
Subject: [External] Re: [Mailman-Users] Privacy Filter Unusual Behavior

On 01/02/2018 12:26 PM, Chris PUCHALSKI wrote:
> The privacy settings with concern to the moderation of nonmembers we have 
> been seeing something odd happening. We have nonmembers set to reject on a 
> list but it appears messages still get through to the list recipients. But 
> the sender also get the rejection notification. That is both confirmed in the 
> vette logs as well as in actual practice with test emails.


Does this occur with all non-member posts or just occasionally?

Do all list members receive the message? Is it in the archives? If your list 
supports digests is the message added to the lists/LISTNAME/digest.mbox file 
and sent in the digest? Is the message logged in the 'post' log? If so, is the 
Message-ID: in the post log the same as the one in the vette log?

-- 
Mark Sapiro <m...@msapiro.net>The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org 
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3 Security Policy: 
http://wiki.list.org/x/QIA9 Searchable Archives: 
http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/chris.puchalski%40raytheon.com
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Re: [Mailman-Users] Privacy Filter Unusual Behavior

[Mark Sapiro]

On 01/02/2018 12:26 PM, Chris PUCHALSKI wrote:
> The privacy settings with concern to the moderation of nonmembers we have 
> been seeing something odd happening. We have nonmembers set to reject on a 
> list but it appears messages still get through to the list recipients. But 
> the sender also get the rejection notification. That is both confirmed in the 
> vette logs as well as in actual practice with test emails.


Does this occur with all non-member posts or just occasionally?

Do all list members receive the message? Is it in the archives? If your
list supports digests is the message added to the
lists/LISTNAME/digest.mbox file and sent in the digest? Is the message
logged in the 'post' log? If so, is the Message-ID: in the post log the
same as the one in the vette log?

-- 
Mark Sapiro The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan
--
Mailman-Users mailing list Mailman-Users@python.org
https://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://wiki.list.org/x/AgA3
Security Policy: http://wiki.list.org/x/QIA9
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
https://mail.python.org/mailman/options/mailman-users/archive%40jab.org