[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573376#comment-13573376 ] Hudson commented on MAPREDUCE-4822: --- Integrated in Hadoop-Yarn-trunk #120 (See

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573432#comment-13573432 ] Hudson commented on MAPREDUCE-4822: --- Integrated in Hadoop-Hdfs-0.23-Build #518 (See

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573452#comment-13573452 ] Hudson commented on MAPREDUCE-4822: --- Integrated in Hadoop-Hdfs-trunk #1309 (See

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573504#comment-13573504 ] Hudson commented on MAPREDUCE-4822: --- Integrated in Hadoop-Mapreduce-trunk #1337 (See

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572622#comment-13572622 ] Chu Tong commented on MAPREDUCE-4822: - When I look at the code the

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572624#comment-13572624 ] Chu Tong commented on MAPREDUCE-4822: - Sorry, I did not put the code in codeblock

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572645#comment-13572645 ] Jason Lowe commented on MAPREDUCE-4822: --- That code simply parses a string into a

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572749#comment-13572749 ] Chu Tong commented on MAPREDUCE-4822: - My primary concern is the error checking to

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572801#comment-13572801 ] Jason Lowe commented on MAPREDUCE-4822: --- The intent of TaskAttemptID.forName()

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572867#comment-13572867 ] Chu Tong commented on MAPREDUCE-4822: - Ok, I think your point is more solid. I

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572894#comment-13572894 ] Hadoop QA commented on MAPREDUCE-4822: -- {color:red}-1 overall{color}. Here are

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572934#comment-13572934 ] Jason Lowe commented on MAPREDUCE-4822: --- +1, lgtm. There's one minor nit where

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572953#comment-13572953 ] Chu Tong commented on MAPREDUCE-4822: - right ..., Thanks Jason!

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572965#comment-13572965 ] Hudson commented on MAPREDUCE-4822: --- Integrated in Hadoop-trunk-Commit #3335 (See

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571841#comment-13571841 ] Hadoop QA commented on MAPREDUCE-4822: -- {color:red}-1 overall{color}. Here are

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571912#comment-13571912 ] Chu Tong commented on MAPREDUCE-4822: - No testcase is included as the change is

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570840#comment-13570840 ] Hadoop QA commented on MAPREDUCE-4822: -- {color:red}-1 overall{color}. Here are

[jira] [Commented] (MAPREDUCE-4822) Unnecessary conversions in History Events

[ https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571122#comment-13571122 ] Hadoop QA commented on MAPREDUCE-4822: -- {color:red}-1 overall{color}. Here are